<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Mohamed plans to send in a PR fixing this. </div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Thanks,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Sandhya</div>
<div id="appendonsend"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div dir="ltr" id="divRplyFwdMsg"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> hotspot-compiler-dev <hotspot-compiler-dev-retn@openjdk.org> on behalf of Viswanathan, Sandhya <sandhya.viswanathan@intel.com><br>
<b>Sent:</b> Thursday, January 23, 2025 4:55 PM<br>
<b>To:</b> dean.long@oracle.com <dean.long@oracle.com>; Julian Waters <tanksherman27@gmail.com>; hotspot-compiler-dev@openjdk.org <hotspot-compiler-dev@openjdk.org><br>
<b>Subject:</b> Re: [External] : Re: Is the section name _RDATA in jsvml.dll intended?</span>
<div> </div>
</div>
<div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Hi Julian,</div>
<div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Thanks for catching this. You are correct, it should have been:</div>
<div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
_RDATA SEGMENT READONLY PAGE 'DATA'</div>
<div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Best Regards,</div>
<div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Sandhya</div>
<hr style="direction: ltr; display: inline-block; width: 98%;">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> dean.long@oracle.com <dean.long@oracle.com><br>
<b>Sent:</b> Wednesday, January 22, 2025 5:44 PM<br>
<b>To:</b> Julian Waters <tanksherman27@gmail.com>; hotspot-compiler-dev@openjdk.org <hotspot-compiler-dev@openjdk.org>; Viswanathan, Sandhya <sandhya.viswanathan@intel.com><br>
<b>Subject:</b> Re: [External] : Re: Is the section name _RDATA in jsvml.dll intended?</span>
<div> </div>
</div>
<p style="direction: ltr; margin-top: 0px; margin-bottom: 0px;">Hi Sandhya. Can you answer this question?</p>
<div style="direction: ltr;">On 1/18/25 10:50 PM, Julian Waters wrote:</div>
<blockquote>
<div style="direction: ltr;">I briefly checked the _RDATA SEGMENT directive in some of the jsvml.dll source files and it does seem like the READ attribute is not in the right place, in some places it comes before the "align" attribute instead of after. I'm
not sure whether the Intel compiler meant READONLY before align, or if it meant to set READ after, as mentioned by the MASM documentation:
<a href="https://urldefense.com/v3/__https://learn.microsoft.com/en-us/cpp/assembler/masm/segment?view=msvc-170__;!!ACWV5N9M2RV99hQ!PpK1i1x6SNT-4xG2FQ2nuaQ6KQ_ODUE_s8rfd85w0Fo9-s6diy2Vb54W8t0upi7W6F-18BfUmNYDAOT927itQjQ$" id="OWA6884f160-040f-32ed-d1ad-4c6b8c6c9785" class="x_OWAAutoLink" data-auth="NotApplicable">
https://learn.microsoft.com/en-us/cpp/assembler/masm/segment?view=msvc-170</a></div>
<div style="direction: ltr;"><br>
</div>
<div style="direction: ltr;">An example of what I mean is this:</div>
<div style="direction: ltr;">_RDATA SEGMENT READ PAGE 'DATA'</div>
<div style="direction: ltr;"><br>
</div>
<div style="direction: ltr;">best regards,</div>
<div style="direction: ltr;">Julian</div>
</blockquote>
</body>
</html>