review request for 6781583

Xiaobin Lu Xiaobin.Lu at Sun.COM
Fri Dec 5 11:28:31 PST 2008


Webrev: http://webrev.invokedynamic.info/xiaobin.lu/6781583/webrev/

Details:

Due to more restrictions on implicit type conversion put to the latest 
GCC compiler such as GCC 4.3.2, the hotspot build fails on 64 bit 
platforms. I've fixed part of the problem on 32 bit platform with 
6718830 & 6681796, however, I just noticed that we need to do more on 64 
bit platforms as well.

One of the thing you might notice with the fix is that I explicitly use 
"%lld" to print jlong instead of using PTR_FORMAT. The reason of doing 
this is that jlong is defined as "long long int", and PTR_FORMAT is 
actually used to print "long int" on 64 bit platforms. GCC 4.3.2 doesn't 
even allow conversions between "long long" and "long" even though they 
have the same size on most of today's 64 bit platforms. Other part of 
the fix is pretty straightforward.

Reviewed by:

Verified by:
JPRT
Built on 32 bit GCC 4.3.2 and it succeeded

Thanks,
-Xiaobin





More information about the hotspot-dev mailing list