review request for 6781583

[Christian Thalinger]

On Fri, 2008-12-05 at 18:40 -0800, Xiaobin Lu wrote:
> 1. I modified "jlong" definition to make it conform with the definition 
> on JDK side. This change will make the complaint about using 
> INT64_FORMAT to print data types with "long long". So now, it is perfect 
> ok to use INT64_FORMAT to print jlong.

Yes, I think that's what a jlong should be on 64-bit architectures.

> 
> 2. There is some weird change in javaClasses.cpp which casts "nmethod* 
> nm" to "intptr_t". This has to be done since otherwise, gcc will 
> complain about using PTR_FORMAT (which isn't defined as "%p", but as 
> "0x%016x") to print nmethod*. We could change PTR_FORMAT to use %p, but 
> "%p" has its own issue since it does not prepend "0x" to the data on 
> Windows & Solaris. So I would rather leave that as is for now.
> 
> 3. I added a few return values on some system/library calls to avoid 
> compiler error. I believe it is better to fix these places rather than 
> just removing "-Werror" from gcc.make. Luckily, we don't have many of those.

Using an assert on the return values looks like the best thing to do
here.

- Christian