Review request again -- 6655385 Disable frame pointer omission in jvm.dll on Windows

[Steve Bohne]

Comments welcome.

Fixed 6655385: Disable frame pointer omission in jvm.dll on Windows for 
better crash logs

http://j2se.east/~sbohne/webrev/6655385

The C++ compiler option /Oy- is now used when building jvm.dll on 
Windows.  This has the effect of better quality crash logs involving
jvm.dll.  Previously, only the youngest jvm.dll frame could be
displayed, now we'll get a full stack trace.  The idea is that this
should help quite a bit in diagnosing Windows crashes where only
the crash log (and no crash dump) is available, as is frequently
the case with Windows bug reports.

Although Alacrity and other performance testing results were reasonable,
there is a small performance risk associated with this change.  Since
ebp is no longer used as a general register by the C++ compiler, there
is an effect on generated (C++) code.

As mentioned above, Alacrity results were unremarkable (see bug comments
for links to results).  Reference workload server testing on Intel and
AMD machines showed a few intermittent blips on jvm98, although these
were not consistently reproducible.  PrintGCStats showed <5% increase in
total GC time in a few cases, although in these cases the overall
benchmark score was not affected.  More detail can be found in the bug
report comments.  In summary, the performance results aren't perfect,
but they are acceptable.


Reviewed by:

Fix verified (y/n): y

Verification testing:
   Crashing testcase generated full stack trace in hs_err_pid.log

Other testing:
   JPRT
   Alacrity
   refWorkload jvm98/jbb2000/jbb2005 on Win32/64


Thanks,
Steve
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 6655385.diff.txt
Url: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20080131/ec1ae1a2/attachment.txt