hotspot/make/solaris/makefiles/sparcWorks.make misses 64-bit flags with Sun Studio 5.10

[Vladimir Kozlov]

I agree with Xiaobin.

Christian, thank you for looking on this.
But you should understand that we are not supporting 5.10
compilers yet. We just switched to 5.9 for HS14(jdk7) and jdk6
uses 5.8 (I don't know what OpenJDK6 is using).
So it will be few years before we move to 5.10, I think.

I would suggest to use 5.9 for your work if you have
access to it.

Thanks,
Vladimir

Xiaobin Lu wrote:
> I think the right fix is to compare COMPILER_REV_MAJOR and 
> COMPILER_REV_MINOR one by one just like what we do to Linux kernel 
> version somewhere in the make directory.
> 
> -Xiaobin
> 
> Christian Thalinger wrote:
>> Hi!
>>
>> I'm having some linking problems when building HotSpot for i386 with Sun
>> Studio 5.10 (but that will be the subject of another mail), so I tried
>> to build the 64-bit version.  I noticed that the -m64 switch is missing
>> and 32-bit object are generated.  A little digging into the Makefiles
>> revealed this line in hotspot/make/solaris/makefiles/sparcWorks.make:
>>
>> # Select the ARCHFLAGs and other SS12 (5.9) options
>> ifeq ($(shell expr $(COMPILER_REV) \>= 5.9), 1)
>>
>> Executing this line with 5.10 gives:
>>
>> $ expr "5.10" \>= "5.9"
>> 0
>>
>> Very true, as 5.1 is obviously less than 5.9.  I don't have a patch for
>> this one ready as I'm not sure what the appropriate fix is (fixing only
>> this check or doing something like COMPILER_REV_MAJOR,
>> COMPILER_REV_MINOR).  What would be the appropriate fix?
>>
>> - Christian
>>
>>   
>