HotSpot build problems on Windows

[Y Srinivas Ramakrishna]

Apologies! (mea culpa I am guessing.)

Yes, the version(s) under concurrentMarkSweep should go away.
I don't believe there's any CMS-specific
code in there, so no need to split (at the moment at least).

As Christian pointed out there's a .cpp as well as a .hpp that have
to go. Then you may want to scan the includeDB's and shuffle include's
around if/as needed.

-- ramki

----- Original Message -----
From: Jon Masamitsu <Jon.Masamitsu at Sun.COM>
Date: Friday, November 14, 2008 8:35 am
Subject: Re: HotSpot build problems on Windows
To: Christian Wimmer <wimmer at ssw.jku.at>
Cc: hotspot-dev at openjdk.java.net


> As Christian has found we have in a repository
> 
> ./share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.cpp
> ./share/vm/gc_implementation/shared/concurrentGCThread.cpp
> 
> The files are the same now.   I'm guessing that we
> should delete
> 
> ./share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.cpp
> 
> I'll see if I can tell mercurial to do that.  Any concerns?  Were 
> there any
> thoughts that concurrentGCThread.cpp should be split between
> CMS and shared (i.e., that there is some code in concurrentGCThread.cpp
> specialized for CMS)?
> 
> 
> 
> Christian Wimmer wrote On 11/13/08 21:06,:
> 
> >...
> >2) duplicate files: the files "concurrentGCThread.cpp" and  
> >"concurrentGCThread.hpp" are present in two directories:  
> >"gc_implementation\concurrentMarkSweep" and "gc_implementation 
> >\shared". The content of the files is equal, so just deleting one 
> pair  
> >of files works.
> >
> >
> >  
> >
>