Request for review (M): 6778669: Patch from Red Hat -- fixes compilation errors

Andrew John Hughes gnu_andrew at member.fsf.org
Sun Feb 22 12:35:37 PST 2009


2009/2/22 Christian Thalinger <Christian.Thalinger at sun.com>:
> On Sun, 2009-02-22 at 12:18 -0800, Vladimir Kozlov wrote:
>> Christian,
>>
>> Your changes looks good.
>> Could you also look on and possibly include fixes for hsdis build on linux.
>
> Ahh, right!  There was an issue on Linux.  I will include the attached
> patches.
>
> Andrew tested the patch and there seem to be a ton of warnings... sigh.
> We try to fix them.
>
> -- Christian
>
>

Even with this patch, there seem to be major issues in the ADLC parser
with GCC 4.3.3 on x86_64.  I assume IcedTea gets round them with the
patch to turn off -Werror.

Attached is an extended version of twisti's patch which starts to fix
some of the issues in adlc.  I've also included the build log with
this applied.

-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
-------------- next part --------------
A non-text attachment was scrubbed...
Name: warnings.patch
Type: application/octet-stream
Size: 15203 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20090222/b3cd79ae/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 75802 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20090222/b3cd79ae/attachment-0001.obj 


More information about the hotspot-dev mailing list