merge vm_version_x86_{32,64}.hpp

[David Holmes - Sun Microsystems]

Vladimir Kozlov said the following on 02/23/09 09:38:
> Actually we are merging x86 source as much as possible
> to avoid duplicated changes for 32- and 64-bits.
> Steve Goldman started this work and Tom did additional changes.
> So Christian's suggestion is in the line with this work.
> 
> It is better to have 2 files with few #ifdef then 4 separate file
> which have 80% (or more) of the same duplicated code.

But what Christian is doing is factoring out that 80% into 1 file and 
then we have two files with the 20% that is different. I'd rather see 
that than a single file with 20% of the code ifdef'd.

Just my 2c.

David

> Thanks,
> Vladimir
> 
> David Holmes - Sun Microsystems wrote:
>> Looking at the HS sources the tendency has been to separate files 
>> rather #ifdefs. I know it's not 100% consistent but I'd rather not 
>> help swing the pendulum back the other way unless there's a really 
>> good reason for doing so.
>>
>> David Holmes
>>
>> Vladimir Kozlov said the following on 02/23/09 06:21:
>>> Common vm_version_x86.{cpp,hpp} with #ifdef as we did for 
>>> assembler_x86.?pp
>>>
>>> Vladimir
>>>
>>> Christian Thalinger wrote:
>>>> On Fri, 2009-02-20 at 11:35 -0500, Paul Hohensee wrote:
>>>>> Feel free. :)  In general, if you're changing things somewhere, 
>>>>> feel free to refactor.
>>>>
>>>> Great :-)  Should I merge them into a common vm_version_x86.{cpp,hpp}
>>>> plus specific vm_version_x86_{32,64}.{cpp,hpp} files or just a single
>>>> vm_version_x86.{cpp,hpp} with #ifdef's?
>>>>
>>>> There would be very few #ifdef's but I would prefer the former 
>>>> approach.
>>>>
>>>> -- Christian
>>>>