merge vm_version_x86_{32,64}.hpp

Christian Thalinger Christian.Thalinger at Sun.COM
Sun Feb 22 23:49:31 PST 2009


On Mon, 2009-02-23 at 10:10 +1000, David Holmes - Sun Microsystems
wrote:
> Hi Vladimir,
> 
> Christian's proposal was to take the existing four files:
> 
>  > vm_version_x86_32.cpp, vm_version_x86_32.hpp,
>  > vm_version_x86_64.cpp, vm_version_x86_64.hpp
> 
> and to factor out the common code into:
> 
>  > vm_version_x86.cpp and vm_version_x86.hpp
> 
> the question asked was then whether to deal with the platform specific 
> code by:
> 
> a) keeping the existing 4 files in addition to the 2 new ones (assuming 
> all four are still needed); or
> 
> b) use ifdef's in the new files and discard the 4 old ones

Right, that is what I was trying to ask.  Sorry if that wasn't clear
enough.

-- Christian




More information about the hotspot-dev mailing list