Request for review (M): 6778669: Patch from Red Hat -- fixes compilation errors

[Christian Thalinger]

On Mon, 2009-02-23 at 09:42 +1000, David Holmes - Sun Microsystems
wrote:
> Andrew,
> 
> I think some of these need to be looked at more closely:
> 
>   // Print out the dictionary contents as key-value pairs
> -static void dumpekey(const void* key)  { fprintf(stdout, "%s", key); }
> +static void dumpekey(const void* key)  { fprintf(stdout, "%p", key); }
> 
> As far as I can see an ExprDict key is always a char*, hence %s is what 
> we want not %p. So the right fix would be to cast key to char* .

Right, I also saw that one and fill fix that before the second review
round.

-- Christian