Request for review (M): 6778669: Patch from Red Hat -- fixes compilation errors
Tom Rodriguez
Thomas.Rodriguez at Sun.COM
Mon Feb 23 11:43:38 PST 2009
Given the way that NameList is being abused in the code, I think (int)
(intptr_t) preserves the intent of storing ints so I think I prefer
your patch below.
tom
On Feb 23, 2009, at 9:30 AM, Christian Thalinger wrote:
> On Mon, 2009-02-23 at 17:47 +0100, Christian Thalinger wrote:
>> void PeepMatch::next_instruction(intptr_t &parent, intptr_t
>> &position, const char* &name, intptr_t &input) {
>> parent = (intptr_t) _parent.iter();
>> position = (intptr_t) _position.iter();
>>
>> Would it be possible to use std::vector<int> or std::list<int>
>> instead
>> of a NameList for these integers?
>
> Ohh, right, and the hackish solution would be:
>
> +void PeepMatch::next_instruction(int &parent, int &position, const
> char* &name, int &input) {
> + parent = (int) (intptr_t) _parent.iter();
> + position = (int) (intptr_t) _position.iter();
>
> -- Christian
>
More information about the hotspot-dev
mailing list