Request for review (M): 6808589: Merge vm_version_x86_{32, 64}.{cpp, hpp}

[Vladimir Kozlov]

About 6808665.

There is (still) other company besides Intel and AMD who produce x86 cpus.
I surprise we don't hear anything from it since our current implementation
looks for the features of Intel and AMD cpus only.
The code was added for 4395702 bug.

Anyway, I think, you can avoid the assert if you set std_cpuid1_rax.bits.family value:

void VM_Version::get_processor_features() {

   _cpu = 4; // 486 by default
+ _cpuid_info.std_cpuid1_rax.bits.family = 4;
   _model = 0;
   _stepping = 0;
   _cpuFeatures = 0;
   _logical_processors_per_package = 1;
   if (!Use486InstrsOnly) {

Vladimir

Christian Thalinger wrote:
> On Mon, 2009-02-23 at 10:36 -0800, Tom Rodriguez wrote:
>> Looks good.  Thanks for doing this.  Steve had merged all the  
>> important files but there are still a few left like this one.
> 
> No problem.  I will fix the missing ones too if you have some specific
> pointers.
> 
> Btw. can someone look at CR 6808665 and tell me if that's still
> used/supported?
> 
> -- Christian
>