Request for review (M): 6778669: Patch from Red Hat -- fixes compilation errors

[Andrew John Hughes]

2009/2/24 Christian Thalinger <Christian.Thalinger at sun.com>:
> On Mon, 2009-02-23 at 11:43 -0800, Tom Rodriguez wrote:
>> Given the way that NameList is being abused in the code, I think (int)
>> (intptr_t) preserves the intent of storing ints so I think I prefer
>> your patch below.
>
> Here is the second version of the patch:
>
> http://cr.openjdk.java.net/~twisti/6778669/webrev.01/
>
> I added +w to the SunCC compiler flags to find all bugs that GCC could
> probably complain about.  I will remove that flag before commit unless I
> can fix the remaining warnings like these:
>
> "/export/home/twisti/hotspot-comp/6778669/src/share/vm/adlc/formssel.hpp", line 1017: Warning: MatchRule::append_components hides the function MatchNode::append_components(FormDict&, ComponentList&, bool) const.
> "/export/home/twisti/hotspot-comp/6778669/src/share/vm/adlc/formssel.hpp", line 1017: Warning: MatchRule::cisc_spill_match hides the function MatchNode::cisc_spill_match(FormDict&, RegisterForm*, MatchNode*, const char*&, const char*&).
> "/export/home/twisti/hotspot-comp/6778669/src/share/vm/adlc/formssel.hpp", line 1017: Warning: MatchRule::equivalent hides the function MatchNode::equivalent(FormDict&, MatchNode*).
> "/export/home/twisti/hotspot-comp/6778669/src/share/vm/adlc/formssel.hpp", line 1017: Warning: MatchRule::swap_commutative_op hides the function MatchNode::swap_commutative_op(bool, int).
>
> Unfortunately I don't know how to fix them properly.  But it would be
> nice to have the +w flag in there as it found a lot of "bugs", like the
> printf ones.
>
> -- Christian
>
>

Works for me with GCC 4.3.3 on GNU/Linux x86_64.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8