Request for review (M): 6810672: Comment typos
Vladimir Kozlov
Vladimir.Kozlov at Sun.COM
Thu Feb 26 14:35:23 PST 2009
You forgot Peter's suggestion to fix examples in node.cpp:
Peter B. Kessler wrote:
> - 980 // Example: reshape "X*4" into "X<<1"
> - 981 // return new (C,3) LShiftINode( in(1), phase->intcon(1) );
> + 980 // Example: reshape "X*4" into "X<<2"
> + 981 // return new (C,3) LShiftINode( in(1), phase->intcon(2) );
> 982 //
> 983 // You must call 'phase->transform(X)' on any new Nodes X you make, except
> - 984 // for the returned root node. Example: reshape "X*31" with "(X<<5)-1".
> - 985 // Node *shift=phase->transform(new(C,3)LShiftINode(in(1),phase->intcon(5)));
> - 986 // return new (C,3) AddINode(shift, phase->intcon(-1));
> + 984 // for the returned root node. Example: reshape "X*31" with "(X<<5)-X".
> + 985 // Node *shift=phase->transform(new(C,3)LShiftINode(in(1),phase->intcon(5)));
> + 986 // return new (C,3) SubINode(shift, in(1));
Vladimir
Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/6810672/webrev.00/
>
More information about the hotspot-dev
mailing list