Request for review (XXL): 6810672: Comment typos

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Fri Feb 27 08:08:34 PST 2009


Looks OK.

Vladimir

Christian Thalinger wrote:
> On Thu, 2009-02-26 at 22:56 +0100, Christian Thalinger wrote:
>> http://cr.openjdk.java.net/~twisti/6810672/webrev.00/
> 
> Tom sent me a list of typos he grep'ed from the sources and I wrote a
> small script that replaced all of them, hopefully correctly.  Almost all
> are comment changes only, except two code snippets:
> 
> @@ -2672,9 +2672,9 @@ void PhaseIdealLoop::build_loop_late_pos
>        pinned = false;
>      }
>      if( pinned ) {
> -      IdealLoopTree *choosen_loop = get_loop(n->is_CFG() ? n : get_ctrl(n));
> -      if( !choosen_loop->_child )       // Inner loop?
> -        choosen_loop->_body.push(n); // Collect inner loops
> +      IdealLoopTree *chosen_loop = get_loop(n->is_CFG() ? n : get_ctrl(n));
> +      if( !chosen_loop->_child )       // Inner loop?
> +        chosen_loop->_body.push(n); // Collect inner loops
>        return;
>      }
>    } else {                      // No slot zero
> @@ -2746,9 +2746,9 @@ void PhaseIdealLoop::build_loop_late_pos
>    set_ctrl(n, least);
>  
>    // Collect inner loop bodies
> -  IdealLoopTree *choosen_loop = get_loop(least);
> -  if( !choosen_loop->_child )   // Inner loop?
> -    choosen_loop->_body.push(n);// Collect inner loops
> +  IdealLoopTree *chosen_loop = get_loop(least);
> +  if( !chosen_loop->_child )   // Inner loop?
> +    chosen_loop->_body.push(n);// Collect inner loops
>  }
>  
>  #ifndef PRODUCT
> 
> But I think these should be okay.  Here is the updated and (now) huge
> webrev:
> 
> http://cr.openjdk.java.net/~twisti/6810672/webrev.01/
> 
> -- Christian
> 



More information about the hotspot-dev mailing list