A question on the stack alignment on 64 bit arch

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Tue Jan 13 16:28:06 PST 2009


I think the intent of the code was probably to align to 16 but it  
didn't properly account for the wordSize.  Having it align to  
StackAlignmentInBytes seems to be the right thing to me.

tom

On Jan 13, 2009, at 4:17 PM, Xiaobin Lu wrote:

> Hi folks,
>
> While I am fixing the stack alignment bug (6792301), I noticed that  
> on 64 bit implementation of generate_native_wrapper, currently we  
> actually align the stack frame with 32 bytes (line 1289 & 1290 in  
> sharedRuntime_x86_64.cpp). If we want to consider  
> StackAlignmentInBytes, we probably want to align the frame with 16  
> bytes. Will this have any bad effects? I have run a few tests with  
> 16 bytes aligned stack frame and it seemed running fine.
>
> Thanks,
> -Xiaobin




More information about the hotspot-dev mailing list