[patch] missing include file in hotspot 14.0b08

[Kurt Miller]

Hmm. I spoke a bit too soon. The amd64 build found one more missing include:

g++ ...
openjdk/hotspot/src/share/vm/memory/cardTableModRefBS.cpp
openjdk/hotspot/src/share/vm/memory/space.hpp:852: warning: inline
   function `void
   ContiguousSpace::set_concurrent_iteration_safe_limit(HeapWord*)' used but
   never defined

Adding the following change to the existing set of changes fixed it for me.

--- hotspot/src/share/vm/includeDB_core.orig    Fri Dec 19 03:42:10 2008
+++ hotspot/src/share/vm/includeDB_core Fri Jan 16 09:38:20 2009
@@ -473,7 +473,7 @@ cardTableModRefBS.cpp                   cardTableRS.hp
 cardTableModRefBS.cpp                   java.hpp
 cardTableModRefBS.cpp                   mutexLocker.hpp
 cardTableModRefBS.cpp                   sharedHeap.hpp
-cardTableModRefBS.cpp                   space.hpp
+cardTableModRefBS.cpp                   space.inline.hpp
 cardTableModRefBS.cpp                   universe.hpp
 cardTableModRefBS.cpp                   virtualspace.hpp

On Wednesday 14 January 2009 2:28:21 pm Coleen Phillimore - Sun Microsystems wrote:
> 
> Okay, I'll add in the missing define that Matthias had and push it up.
> Coleen
> 
> On 01/14/09 14:26, Kurt Miller wrote:
> > Hi Coleen,
> >
> > On Sunday 11 January 2009 8:27:36 pm Coleen Phillimore wrote:
> >   
> >> What version of gcc were you using?  I had a lot more missing undefines
> >> and different ones (message about inline function not defined) with gcc
> >> version:
> >> gcc (Ubuntu 4.3.2-1ubuntu11) 4.3.2
> >> patchfile attached.  Can you try this out?
> >>     
> >
> > Your patch works well with gcc 3.3.5 on OpenBSD (gcc 3.3 doesn't
> > support precompiled headers). It would be great if your diff made
> > it into the tree.
> >
> > Regards,
> > -Kurt
> >   
>