From vladimir.kozlov at sun.com Wed Jul 1 18:40:02 2009 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Thu, 02 Jul 2009 01:40:02 +0000 Subject: hg: jdk7/hotspot/hotspot: 11 new changesets Message-ID: <20090702014027.7DC0DE888@hg.openjdk.java.net> Changeset: b109e761e927 Author: kvn Date: 2009-06-09 16:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/b109e761e927 6837472: com/sun/jdi/MonitorFrameInfo.java fails with AggressiveOpts in 6u14 Summary: Disable escape analysis when jvmti/debugger is used. Add support for EA ibto SA. Reviewed-by: never ! agent/src/share/classes/sun/jvm/hotspot/code/DebugInfoReadStream.java ! agent/src/share/classes/sun/jvm/hotspot/code/MonitorValue.java + agent/src/share/classes/sun/jvm/hotspot/code/ObjectValue.java ! agent/src/share/classes/sun/jvm/hotspot/code/ScopeDesc.java ! agent/src/share/classes/sun/jvm/hotspot/code/ScopeValue.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/ObjectReferenceImpl.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/ThreadReferenceImpl.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/CompiledVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/InterpretedVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/MonitorInfo.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/StackValue.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaThread.java ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/stackValue.cpp ! src/share/vm/runtime/stackValue.hpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/runtime/vframe.hpp ! src/share/vm/runtime/vframeArray.cpp ! src/share/vm/runtime/vframe_hp.cpp Changeset: c6386080541b Author: never Date: 2009-06-10 12:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c6386080541b 6849574: VM crash using NonBlockingHashMap (high_scale_lib) Reviewed-by: kvn ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp + test/compiler/6849574/Test.java Changeset: 915cc9c5ebc6 Author: kvn Date: 2009-06-23 17:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/915cc9c5ebc6 6837094: False positive for "meet not symmetric" failure Summary: Have the meet not symmetric check recursively do the interface-vs-oop check on array subtypes. Reviewed-by: jrose Contributed-by: rasbold at google.com ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp + test/compiler/6837094/Test.java Changeset: d1fe2c2fbdac Author: twisti Date: 2009-06-17 09:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/d1fe2c2fbdac 6851829: solaris build fails with 5.8 compilers Summary: Solaris builds with the CC 5.8 compilers (used for jdk6 update builds) fail while compiling adlc. Reviewed-by: never ! make/solaris/makefiles/adlc.make Changeset: e306d7c7222c Author: twisti Date: 2009-06-24 02:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/e306d7c7222c Merge Changeset: 14367225a853 Author: kvn Date: 2009-06-24 12:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/14367225a853 6841800: Incorrect boundary values behavior for option -XX:MaxLabelRootDepth=0-6 leads to jvm crash Summary: MaxLabelRootDepth value less then 10 is invalid. Reviewed-by: never ! src/share/vm/opto/matcher.cpp Changeset: 18a08a7e16b5 Author: twisti Date: 2009-06-26 07:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/18a08a7e16b5 5057225: Remove useless I2L conversions Summary: The optimizer should be told to normalize (AndL (ConvI2L x) 0xFF) to (ConvI2L (AndI x 0xFF)), and then the existing matcher rule will work for free. Reviewed-by: kvn ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/mulnode.cpp + test/compiler/5057225/Test5057225.java Changeset: 8f5825e0aeaa Author: never Date: 2009-06-26 13:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/8f5825e0aeaa 6818666: G1: Type lost in g1 pre-barrier Reviewed-by: kvn ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp Changeset: 3f06f139ef53 Author: never Date: 2009-06-26 16:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/3f06f139ef53 6851908: interpreter null check profiling broken causing extra compilation invalidation Reviewed-by: kvn ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp Changeset: bf3489cc0aa0 Author: never Date: 2009-07-01 12:22 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/bf3489cc0aa0 6856025: assert(_base >= OopPtr && _base <= KlassPtr,"Not a Java pointer") Reviewed-by: kvn ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp Changeset: b64314863098 Author: kvn Date: 2009-07-01 15:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/b64314863098 Merge From john.coomes at sun.com Thu Jul 2 20:37:03 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 03 Jul 2009 03:37:03 +0000 Subject: hg: jdk7/hotspot: Added tag jdk7-b63 for changeset 57f7e028c7ad Message-ID: <20090703033703.91BA3E9C2@hg.openjdk.java.net> Changeset: 9849536536d2 Author: xdono Date: 2009-07-02 11:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/9849536536d2 Added tag jdk7-b63 for changeset 57f7e028c7ad ! .hgtags From john.coomes at sun.com Thu Jul 2 20:41:51 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 03 Jul 2009 03:41:51 +0000 Subject: hg: jdk7/hotspot/corba: Added tag jdk7-b63 for changeset d20e45cd539f Message-ID: <20090703034153.0B2ADE9C7@hg.openjdk.java.net> Changeset: b3ad991d9534 Author: xdono Date: 2009-07-02 11:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/b3ad991d9534 Added tag jdk7-b63 for changeset d20e45cd539f ! .hgtags From john.coomes at sun.com Thu Jul 2 20:51:15 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 03 Jul 2009 03:51:15 +0000 Subject: hg: jdk7/hotspot/jaxp: Added tag jdk7-b63 for changeset ae449e9c04c1 Message-ID: <20090703035118.552F8E9CE@hg.openjdk.java.net> Changeset: a10eec7a1edf Author: xdono Date: 2009-07-02 11:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/a10eec7a1edf Added tag jdk7-b63 for changeset ae449e9c04c1 ! .hgtags From john.coomes at sun.com Thu Jul 2 20:56:10 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 03 Jul 2009 03:56:10 +0000 Subject: hg: jdk7/hotspot/jaxws: Added tag jdk7-b63 for changeset b8a6e883c0a6 Message-ID: <20090703035613.23FC5E9D9@hg.openjdk.java.net> Changeset: aaa25dfd3de6 Author: xdono Date: 2009-07-02 11:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/aaa25dfd3de6 Added tag jdk7-b63 for changeset b8a6e883c0a6 ! .hgtags From john.coomes at sun.com Thu Jul 2 21:01:59 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 03 Jul 2009 04:01:59 +0000 Subject: hg: jdk7/hotspot/jdk: 15 new changesets Message-ID: <20090703040547.9EDD8E9DE@hg.openjdk.java.net> Changeset: 9cf4ef04d9a7 Author: prr Date: 2009-05-06 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9cf4ef04d9a7 6806822: Font.getFontName() is slow in Java5 and 6 Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/TrueTypeFont.java Changeset: ec0a8acd4737 Author: jgodinez Date: 2009-05-14 09:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ec0a8acd4737 Merge Changeset: fb03586d68b6 Author: jgodinez Date: 2009-05-21 09:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/fb03586d68b6 6829659: Circle is rendered in C shape Reviewed-by: campbell, flar Contributed-by: Google ! src/share/classes/sun/java2d/pisces/PiscesCache.java + test/sun/pisces/ScaleTest.java Changeset: 907324eb3e64 Author: bae Date: 2009-05-23 08:35 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/907324eb3e64 4893408: JPEGReader throws IllegalArgException when setting the destination to BYTE_GRAY Reviewed-by: igor, prr ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEG.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageWriter.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGMetadata.java ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c + test/javax/imageio/plugins/jpeg/ReadAsGrayTest.java Changeset: b92e3fbbcb63 Author: jgodinez Date: 2009-06-08 13:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b92e3fbbcb63 Merge Changeset: 378feb59435b Author: bae Date: 2009-06-11 13:47 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/378feb59435b 6296893: BMP Writer handles TopDown property incorrectly for some of the compression types Reviewed-by: igor, prr ! src/share/classes/com/sun/imageio/plugins/bmp/BMPImageWriter.java + test/javax/imageio/plugins/bmp/TopDownTest.java Changeset: e138ae33b128 Author: bae Date: 2009-06-11 14:22 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e138ae33b128 5101862: WBMP Image reader tries to load Quicktime MOV files Reviewed-by: igor, prr ! src/share/classes/com/sun/imageio/plugins/common/ReaderUtil.java ! src/share/classes/com/sun/imageio/plugins/wbmp/WBMPImageReader.java ! src/share/classes/com/sun/imageio/plugins/wbmp/WBMPImageReaderSpi.java + test/javax/imageio/plugins/wbmp/CanDecodeTest.java Changeset: 0ce29cbeb6a9 Author: bae Date: 2009-06-15 14:49 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0ce29cbeb6a9 6829549: JVM crash on certain images Reviewed-by: igor, prr ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java Changeset: 5896dcd01fe3 Author: bae Date: 2009-06-15 17:19 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5896dcd01fe3 6684104: Applets fails to launch using ImageIO if .java.policy with File permissions present on the system Reviewed-by: igor, prr ! src/share/classes/javax/imageio/ImageIO.java + test/javax/imageio/CachePremissionsTest/CachePermissionsTest.java + test/javax/imageio/CachePremissionsTest/rw.policy + test/javax/imageio/CachePremissionsTest/rwd.policy + test/javax/imageio/CachePremissionsTest/w.policy Changeset: 956715ded919 Author: jgodinez Date: 2009-06-15 09:59 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/956715ded919 Merge Changeset: 70903e2c39e3 Author: jgodinez Date: 2009-06-22 09:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/70903e2c39e3 6850398: Allow GraphicsEnvironment to be loaded by system classloader (edit) Reviewed-by: campbell, prr ! src/share/classes/java/awt/GraphicsEnvironment.java Changeset: fafa991c27ac Author: prr Date: 2009-06-22 14:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/fafa991c27ac 6853617: race condition in java.awt.Font.getAttributes() (private method) Reviewed-by: igor, jgodinez ! src/share/classes/java/awt/Font.java Changeset: 2886eb650801 Author: jgodinez Date: 2009-06-24 11:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/2886eb650801 Merge - src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java - src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java - src/share/classes/sun/nio/cs/ext/IBM1381.java - src/share/classes/sun/nio/cs/ext/IBM1383.java - src/share/classes/sun/nio/cs/ext/IBM930.java - src/share/classes/sun/nio/cs/ext/IBM933.java - src/share/classes/sun/nio/cs/ext/IBM935.java - src/share/classes/sun/nio/cs/ext/IBM937.java - src/share/classes/sun/nio/cs/ext/IBM939.java - src/share/classes/sun/nio/cs/ext/IBM942.java - src/share/classes/sun/nio/cs/ext/IBM943.java - src/share/classes/sun/nio/cs/ext/IBM948.java - src/share/classes/sun/nio/cs/ext/IBM949.java - src/share/classes/sun/nio/cs/ext/IBM950.java - src/share/classes/sun/nio/cs/ext/IBM970.java - src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java - src/share/native/sun/font/bidi/cmemory.h - src/share/native/sun/font/bidi/jbidi.c - src/share/native/sun/font/bidi/jbidi.h - src/share/native/sun/font/bidi/ubidi.c - src/share/native/sun/font/bidi/ubidi.h - src/share/native/sun/font/bidi/ubidiimp.h - src/share/native/sun/font/bidi/ubidiln.c - src/share/native/sun/font/bidi/uchardir.c - src/share/native/sun/font/bidi/uchardir.h - src/share/native/sun/font/bidi/utypes.h Changeset: 2ed6ed6b5bfc Author: jgodinez Date: 2009-06-29 14:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/2ed6ed6b5bfc Merge Changeset: 120df7f49509 Author: xdono Date: 2009-07-02 11:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/120df7f49509 Added tag jdk7-b63 for changeset 2ed6ed6b5bfc ! .hgtags From john.coomes at sun.com Thu Jul 2 21:21:23 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 03 Jul 2009 04:21:23 +0000 Subject: hg: jdk7/hotspot/langtools: Added tag jdk7-b63 for changeset 5c2c81120555 Message-ID: <20090703042128.73040E9F6@hg.openjdk.java.net> Changeset: 619c768ad104 Author: xdono Date: 2009-07-02 11:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/619c768ad104 Added tag jdk7-b63 for changeset 5c2c81120555 ! .hgtags From jon.masamitsu at sun.com Thu Jul 2 22:34:07 2009 From: jon.masamitsu at sun.com (jon.masamitsu at sun.com) Date: Fri, 03 Jul 2009 05:34:07 +0000 Subject: hg: jdk7/hotspot/hotspot: 4 new changesets Message-ID: <20090703053420.29638EA27@hg.openjdk.java.net> Changeset: 30b9b25b9cc1 Author: tonyp Date: 2009-06-24 11:42 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/30b9b25b9cc1 6850869: G1: RSet "scrubbing" scrubs too much Summary: RSet scrubbing incorrectly deletes RSet entries that point to regions tagged as "continues humongous" due to a race when RSet scrubbing iterates over regions in parallel. Reviewed-by: apetrusenko, iveresov ! src/share/vm/gc_implementation/g1/concurrentMark.cpp Changeset: 00f7ec32f290 Author: apetrusenko Date: 2009-06-26 09:22 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/00f7ec32f290 6854027: Precompiled headers are not being updated in Linux/GCC builds Summary: Fixes incorrect handling of precompiled headers in diff mode. Reviewed-by: never, twisti ! src/share/tools/MakeDeps/Database.java Changeset: 3eb9872b10ce Author: tonyp Date: 2009-06-29 12:17 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/3eb9872b10ce 6855115: G1: Fix for 6850869 is incorrect Summary: Missed updating two variable names when improving the code for 6850869. Reviewed-by: iveresov, jmasa, ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp Changeset: e7d5557ad624 Author: jmasa Date: 2009-07-02 16:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/e7d5557ad624 Merge From Christian.Thalinger at Sun.COM Fri Jul 3 02:11:31 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Fri, 03 Jul 2009 11:11:31 +0200 Subject: serialize.cpp uses objArrayOopDesc::base_offset_in_bytes(T_BYTE) Message-ID: <4A4DCB43.6030802@Sun.COM> Hi! Yesterday I wanted to add: objArrayOopDesc::base_offset_in_bytes() (note: with no argument) because an objArrayOopDesc holds only oops anyway, so always using T_OBJECT seems correct to me. After adding the method and doing a compile, I noticed that serialize.cpp:54 uses it like this: soc->do_tag(objArrayOopDesc::base_offset_in_bytes(T_BYTE)); That looks very odd and, unfortunately, does not have a comment that explains why it is done that way. Can someone explain to me why T_BYTE is used in that case and if it could be changed to T_OBJECT? -- Christian From Keith.McGuigan at Sun.COM Mon Jul 6 08:39:54 2009 From: Keith.McGuigan at Sun.COM (Keith McGuigan) Date: Mon, 06 Jul 2009 11:39:54 -0400 Subject: serialize.cpp uses objArrayOopDesc::base_offset_in_bytes(T_BYTE) In-Reply-To: <4A4DCB43.6030802@Sun.COM> References: <4A4DCB43.6030802@Sun.COM> Message-ID: <4A521ACA.9020306@sun.com> I suspect that's a bug that should be able to be safely converted to a T_OBJECT. The code you reference in serialize.cpp is used to write out and read in data to/from the shared class archive file for class data sharing (CDS). It writes out a number of constants in the header of the file and then verifies that these constants haven't changed when the archive file is read back in. If you change this from T_BYTE to T_OBJECT, it will likely change that value (unless we're real lucky with the alignments), and this may prevent archive files created before your change from being loaded into VMs after your change. I think that's ok, though, since deployments run -Xshare:dump (creating a new archive) whenever a new JDK is installed. -- - Keith Christian Thalinger wrote: > Hi! > > Yesterday I wanted to add: > > objArrayOopDesc::base_offset_in_bytes() (note: with no argument) > > because an objArrayOopDesc holds only oops anyway, so always using > T_OBJECT seems correct to me. > > After adding the method and doing a compile, I noticed that > serialize.cpp:54 uses it like this: > > soc->do_tag(objArrayOopDesc::base_offset_in_bytes(T_BYTE)); > > That looks very odd and, unfortunately, does not have a comment that > explains why it is done that way. Can someone explain to me why T_BYTE > is used in that case and if it could be changed to T_OBJECT? > > -- Christian From Christian.Thalinger at Sun.COM Tue Jul 7 08:22:16 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Tue, 07 Jul 2009 17:22:16 +0200 Subject: serialize.cpp uses objArrayOopDesc::base_offset_in_bytes(T_BYTE) In-Reply-To: <4A521ACA.9020306@sun.com> References: <4A4DCB43.6030802@Sun.COM> <4A521ACA.9020306@sun.com> Message-ID: <4A536828.5090304@Sun.COM> Keith McGuigan wrote: > I suspect that's a bug that should be able to be safely converted to a > T_OBJECT. > > The code you reference in serialize.cpp is used to write out and read in > data to/from the shared class archive file for class data sharing (CDS). > It writes out a number of constants in the header of the file and then > verifies that these constants haven't changed when the archive file is > read back in. If you change this from T_BYTE to T_OBJECT, it will > likely change that value (unless we're real lucky with the alignments), > and this may prevent archive files created before your change from being > loaded into VMs after your change. I think that's ok, though, since > deployments run -Xshare:dump (creating a new archive) whenever a new JDK > is installed. Thanks for the explanation, that seems reasonable to me. Should I open a CR and propose a patch on hotspot-runtime-dev (Tom told me that this code is owned by the runtime team)? -- Christian From Keith.McGuigan at Sun.COM Tue Jul 7 08:27:26 2009 From: Keith.McGuigan at Sun.COM (Keith McGuigan) Date: Tue, 07 Jul 2009 11:27:26 -0400 Subject: serialize.cpp uses objArrayOopDesc::base_offset_in_bytes(T_BYTE) In-Reply-To: <4A536828.5090304@Sun.COM> References: <4A4DCB43.6030802@Sun.COM> <4A521ACA.9020306@sun.com> <4A536828.5090304@Sun.COM> Message-ID: <4A53695E.2060000@sun.com> Christian Thalinger wrote: > Keith McGuigan wrote: >> I suspect that's a bug that should be able to be safely converted to a >> T_OBJECT. >> >> The code you reference in serialize.cpp is used to write out and read in >> data to/from the shared class archive file for class data sharing (CDS). >> It writes out a number of constants in the header of the file and then >> verifies that these constants haven't changed when the archive file is >> read back in. If you change this from T_BYTE to T_OBJECT, it will >> likely change that value (unless we're real lucky with the alignments), >> and this may prevent archive files created before your change from being >> loaded into VMs after your change. I think that's ok, though, since >> deployments run -Xshare:dump (creating a new archive) whenever a new JDK >> is installed. > > Thanks for the explanation, that seems reasonable to me. Should I open > a CR and propose a patch on hotspot-runtime-dev (Tom told me that this > code is owned by the runtime team)? Sure. -- - Keith From vladimir.kozlov at sun.com Tue Jul 7 15:13:56 2009 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Tue, 07 Jul 2009 22:13:56 +0000 Subject: hg: jdk7/hotspot/hotspot: 5 new changesets Message-ID: <20090707221410.BC28FECD3@hg.openjdk.java.net> Changeset: acba6af809c8 Author: kvn Date: 2009-07-01 20:22 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/acba6af809c8 6840775: Multiple JVM crashes seen with 1.6.0_10 through 1.6.0_14 Summary: Put missed reference to allocated array in copyOf() intrinsic into OopMap for the call slow_arraycopy(). Reviewed-by: never ! agent/src/share/classes/sun/jvm/hotspot/ui/tree/OopTreeNodeAdapter.java ! make/solaris/makefiles/optimized.make ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/buildOopMap.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/library_call.cpp Changeset: 0f2d888530e7 Author: cfang Date: 2009-07-02 16:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/0f2d888530e7 6855164: SIGSEGV during compilation of method involving loop over CharSequence. Summary: Don not split a block if it contains a FastLockNode with a PhiNode input. Reviewed-by: kvn, never ! src/share/vm/opto/loopopts.cpp Changeset: 73dac61fe300 Author: cfang Date: 2009-07-06 12:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/73dac61fe300 6857707: Add missing test case for CR 6855164 from its bug description. Summary: Add missing test case for CR 6855164 from its bug description. Reviewed-by: never + test/compiler/6855164/Test.java Changeset: 4325cdaa78ad Author: kvn Date: 2009-07-06 15:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/4325cdaa78ad 6857661: 64-bit server VM: assert(is_Initialize(),"invalid node class") Summary: Move the secondary raw memory barrier to the correct place in generate_arraycopy(). Reviewed-by: never ! src/share/vm/opto/library_call.cpp Changeset: f0bd02f95856 Author: kvn Date: 2009-07-07 09:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f0bd02f95856 Merge From y.s.ramakrishna at sun.com Sat Jul 11 02:44:59 2009 From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com) Date: Sat, 11 Jul 2009 09:44:59 +0000 Subject: hg: jdk7/hotspot/hotspot: 2 new changesets Message-ID: <20090711094508.1ADC1EE90@hg.openjdk.java.net> Changeset: 0316eac49d5a Author: tonyp Date: 2009-07-07 14:23 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/0316eac49d5a 6855834: G1: minimize the output when -XX:+PrintHeapAtGC is set Summary: Changing the behavior of -XX:+PrintHeapAtGC for G1 from printing lengthy, per-region information to instead printing a concise summary. Reviewed-by: ysr, apetrusenko, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/runtime/globals.hpp Changeset: bb18957ad21e Author: ysr Date: 2009-07-10 16:01 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/bb18957ad21e Merge From dawn2004 at gmail.com Sun Jul 12 19:01:51 2009 From: dawn2004 at gmail.com (Colin(Du Li)) Date: Sun, 12 Jul 2009 19:01:51 -0700 (PDT) Subject: How to counter object created by hotspot Message-ID: <24454920.post@talk.nabble.com> Hi, guys, I wanna count the number of Java Objects created by Hotspot. Does Hotspot have some tool to count them? If no, I just count how many times the following two methods are invoked, is that accurate? CollectedHeap::common_permanent_mem_allocate_init(size_t size, TRAPS) CollectedHeap::common_mem_allocate_init(size_t size, bool is_noref, TRAPS) Is there better solution to do this counting? p.s. I use serial GC. Thanks a lot! Colin -- View this message in context: http://www.nabble.com/How-to-counter-object-created-by-hotspot-tp24454920p24454920.html Sent from the OpenJDK Hotspot Virtual Machine mailing list archive at Nabble.com. From dawn2004 at gmail.com Mon Jul 13 14:58:39 2009 From: dawn2004 at gmail.com (Colin(Du Li)) Date: Mon, 13 Jul 2009 14:58:39 -0700 (PDT) Subject: How to counter object created by hotspot In-Reply-To: <24454920.post@talk.nabble.com> References: <24454920.post@talk.nabble.com> Message-ID: <24470194.post@talk.nabble.com> Can anyone give a hand? Thanks a lot! Colin Colin(Du Li) wrote: > > Hi, guys, > > I wanna count the number of Java Objects created by Hotspot. Does Hotspot > have some tool to count them? > > If no, I just count how many times the following two methods are invoked, > is that accurate? > CollectedHeap::common_permanent_mem_allocate_init(size_t size, > TRAPS) > CollectedHeap::common_mem_allocate_init(size_t size, bool > is_noref, TRAPS) > > Is there better solution to do this counting? > > p.s. I use serial GC. > > Thanks a lot! > > Colin > -- View this message in context: http://www.nabble.com/How-to-counter-object-created-by-hotspot-tp24454920p24470194.html Sent from the OpenJDK Hotspot Virtual Machine mailing list archive at Nabble.com. From Peter.Kessler at Sun.COM Mon Jul 13 16:07:23 2009 From: Peter.Kessler at Sun.COM (Peter B. Kessler) Date: Mon, 13 Jul 2009 16:07:23 -0700 Subject: How to counter object created by hotspot In-Reply-To: <24470194.post@talk.nabble.com> References: <24454920.post@talk.nabble.com> <24470194.post@talk.nabble.com> Message-ID: <4A5BBE2B.3040504@Sun.COM> Those methods are only used for "slow-path" allocations: when an object can't be allocated by the inline code generated by the runtime compilers. So, if you *just* count those, you should see almost no allocations. You _can_ force all allocations to go through the slow path to make the counts accurate. Needless to say, it's a major hit on performance to call into the runtime for each object allocation. And you'd be serializing allocation, which will hurt even more on a big machine. I think JVMTI forces slow-path allocation to notify on object allocations, I think by filling up the young generation, so the fast inline allocation fails, but maybe we complained so much that they don't do that any more. Maybe JVMTI has some better kind of object histogram by type mechanism, and maybe the performance is acceptable. I just haven't looked recently. What problem are you trying to solve? If you just want to know how many of what kind of objects have been created, why not iterate over the young generation *before* each young generation collection? You'd have to look at all the dead objects, so it wouldn't be fast, but you'd be iterating in address order, so it might not be so bad. You might want to keep track of a high-water mark in the old generation, too, so you could find objects allocated directly in the old generation. Oh, serial GC can allocate objects in the from-space, when pushed to the wall, so for completeness you want to track that too. If you just want to count particular kinds of regular Objects you can probably do that with bytecode annotations on their methods. That won't work for arrays, since they don't have methods. Maybe someone else has some different hammers in their toolbag. ... peter Colin(Du Li) wrote: > Can anyone give a hand? > Thanks a lot! > > Colin > > Colin(Du Li) wrote: >> Hi, guys, >> >> I wanna count the number of Java Objects created by Hotspot. Does Hotspot >> have some tool to count them? >> >> If no, I just count how many times the following two methods are invoked, >> is that accurate? >> CollectedHeap::common_permanent_mem_allocate_init(size_t size, TRAPS) >> CollectedHeap::common_mem_allocate_init(size_t size, bool is_noref, TRAPS) >> >> Is there better solution to do this counting? >> >> p.s. I use serial GC. >> >> Thanks a lot! >> >> Colin From Coleen.Phillimore at Sun.COM Mon Jul 13 17:51:40 2009 From: Coleen.Phillimore at Sun.COM (Coleen Phillimore - Sun Microsystems) Date: Mon, 13 Jul 2009 20:51:40 -0400 Subject: How to counter object created by hotspot In-Reply-To: <4A5BB233.2040905@sun.com> References: <24454920.post@talk.nabble.com> <24470194.post@talk.nabble.com> <4A5BB233.2040905@sun.com> Message-ID: <4A5BD69C.60206@sun.com> Forgot to also copy hotspot-dev. On 07/13/09 18:16, Coleen Phillimore - Sun Microsystems wrote: > > There are monitoring and management tools, try jmap and jhat. > http://java.sun.com/developer/technicalArticles/J2SE/monitoring/ > > Coleen > > On 07/13/09 17:58, Colin(Du Li) wrote: >> Can anyone give a hand? >> Thanks a lot! >> >> Colin >> >> Colin(Du Li) wrote: >> >>> Hi, guys, >>> >>> I wanna count the number of Java Objects created by Hotspot. Does Hotspot >>> have some tool to count them? >>> >>> If no, I just count how many times the following two methods are invoked, >>> is that accurate? >>> CollectedHeap::common_permanent_mem_allocate_init(size_t size, >>> TRAPS) >>> CollectedHeap::common_mem_allocate_init(size_t size, bool >>> is_noref, TRAPS) >>> >>> Is there better solution to do this counting? >>> >>> p.s. I use serial GC. >>> >>> Thanks a lot! >>> >>> Colin >>> >>> >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20090713/a77a355e/attachment.html From bockisch at informatik.tu-darmstadt.de Tue Jul 14 10:30:51 2009 From: bockisch at informatik.tu-darmstadt.de (Christoph Bockisch) Date: Tue, 14 Jul 2009 19:30:51 +0200 Subject: Invitation to submit to VMIL'09 Message-ID: <4A5CC0CB.7080707@informatik.tu-darmstadt.de> Dear Colleagues: It gives us great pleasure to invite you to submit your contributions to **the third international workshop on Virtual Machines and Intermediate Languages (VMIL 2009)**, which will be co-located with OOPSLA 2009. This workshop is a forum for research in virtual machines (VM) and intermediate languages (IL). It is dedicated to identifying programming mechanisms and constructs that are currently realized as code transformations or implemented in libraries but should rather be supported at VM and IL level. -------------------------------------------------------------------- **Invited Talks** VMIL 2009 will feature talks by Steve Blackburn, Vivek Sarkar and Doug Simon (tentative). -------------------------------------------------------------------- **Due Dates** Abstracts for VMIL are due Aug 8, 2009 and full papers are due Aug 15, 2009. -------------------------------------------------------------------- **PC** We have once again assembled an excellent program committee which consists of Eric Bodden, Alex Buckley, Andreas Gal, Doug Lea, Stefan Marr, Filip Pizlo, Andreas Sewe, Jan Vitek, and the organizers. -------------------------------------------------------------------- For more details please see: http://www.cs.iastate.edu/~design/vmil/ We look forward to your submissions to VMIL 2009. Best regards, Hridesh Rajan, Christoph Bockisch, Michael Haupt, and Robert Dyer VMIL 2009 Organizers From erik.trimble at sun.com Tue Jul 14 19:45:37 2009 From: erik.trimble at sun.com (erik.trimble at sun.com) Date: Wed, 15 Jul 2009 02:45:37 +0000 Subject: hg: jdk7/hotspot/hotspot: 3 new changesets Message-ID: <20090715024547.F2369E0D0@hg.openjdk.java.net> Changeset: ba36394eb84b Author: xdono Date: 2009-07-02 11:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/ba36394eb84b Added tag jdk7-b63 for changeset 32c83fb84370 ! .hgtags Changeset: 45c4b1fe45e4 Author: trims Date: 2009-07-10 19:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/45c4b1fe45e4 6859411: Bump the HS16 build number to 06 Summary: Update the HS16 build number to 06 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 218f6b67f9c5 Author: trims Date: 2009-07-11 03:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/218f6b67f9c5 Merge From erik.trimble at sun.com Tue Jul 14 20:04:26 2009 From: erik.trimble at sun.com (erik.trimble at sun.com) Date: Wed, 15 Jul 2009 03:04:26 +0000 Subject: hg: jdk7/hotspot/hotspot: 2 new changesets Message-ID: <20090715030438.69E83E0E6@hg.openjdk.java.net> Changeset: 92b5fbbe8477 Author: xdono Date: 2009-07-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/92b5fbbe8477 Added tag jdk7-b64 for changeset ba36394eb84b ! .hgtags Changeset: ba313800759b Author: trims Date: 2009-07-14 19:43 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/ba313800759b Merge From gustav.trede at gmail.com Wed Jul 15 05:43:52 2009 From: gustav.trede at gmail.com (gustav trede) Date: Wed, 15 Jul 2009 14:43:52 +0200 Subject: Math trig intrinsics and compiler options Message-ID: <311e0eaf0907150543v5d877f55t3e6377b88ea43008@mail.gmail.com> Hello, Azeem Jiva told me an easy way to improve trig performance. Changing the intrinsics to use an existing but faster path gives me a boost of roughly 40% for the Math cos and sin on solaris x64. library_call.cpp bool LibraryCallKit::inline_math_native(vmIntrinsics::ID id) { switch (id) { case vmIntrinsics::_dcos: return Matcher::has_match_rule(Op_CosD) ? runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, SharedRuntime::dcos), "COS") : false; case vmIntrinsics::_dsin: return Matcher::has_match_rule(Op_SinD) ? runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, SharedRuntime::dsin), "SIN") : false; case vmIntrinsics::_dtan: return Matcher::has_match_rule(Op_TanD) ? runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, SharedRuntime::dtan), "TAN") : false; case vmIntrinsics::_dlog: return Matcher::has_match_rule(Op_LogD) ? runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, SharedRuntime::dlog), "LOG") : false; case vmIntrinsics::_dlog10: return Matcher::has_match_rule(Op_Log10D) ? runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, SharedRuntime::dlog10), "LOG10") : false; Is there any potential problem with such a patch ? Compiler flags is another area of interest. Both linux and windows platforms seems to turn off optimizations for sharedRuntimeTrig.cpp : Is it known what specific bugs or problems that is the cause ? I would like to be able to check if the problems are gone in newer compiler versions so targeted compiler flags can be added to make files. sharedRuntimeTrig.cpp has #ifdef WIN32 # pragma optimize ( "", off ) #endif hotspot/make/linux/makefiles/i486.make:# The copied fdlibm routines in sharedRuntimeTrig.o must not be optimized hotspot/make/linux/makefiles/i486.make:OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT) hotspot/make/linux/makefiles/amd64.make:# The copied fdlibm routines in sharedRuntimeTrig.o must not be optimized hotspot/make/linux/makefiles/amd64.make:OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT) -- regards gustav trede -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20090715/57f927af/attachment.html From Christian.Thalinger at Sun.COM Wed Jul 15 06:21:45 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Wed, 15 Jul 2009 15:21:45 +0200 Subject: Math trig intrinsics and compiler options In-Reply-To: <311e0eaf0907150543v5d877f55t3e6377b88ea43008@mail.gmail.com> References: <311e0eaf0907150543v5d877f55t3e6377b88ea43008@mail.gmail.com> Message-ID: <4A5DD7E9.8070904@Sun.COM> gustav trede wrote: > Hello, > > Azeem Jiva told me an easy way to improve trig performance. > Changing the intrinsics to use an existing but faster path gives me a > boost of roughly 40% for the Math cos and sin on solaris x64. > > > library_call.cpp > > bool LibraryCallKit::inline_math_ > native(vmIntrinsics::ID id) { > switch (id) { > > case vmIntrinsics::_dcos: return Matcher::has_match_rule(Op_CosD) ? > runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, > SharedRuntime::dcos), "COS") : false; > case vmIntrinsics::_dsin: return Matcher::has_match_rule(Op_SinD) ? > runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, > SharedRuntime::dsin), "SIN") : false; > case vmIntrinsics::_dtan: return Matcher::has_match_rule(Op_TanD) ? > runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, > SharedRuntime::dtan), "TAN") : false; > case vmIntrinsics::_dlog: return Matcher::has_match_rule(Op_LogD) ? > runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, > SharedRuntime::dlog), "LOG") : false; > case vmIntrinsics::_dlog10: return Matcher::has_match_rule(Op_Log10D) > ? runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, > SharedRuntime::dlog10), "LOG10") : false; > > > Is there any potential problem with such a patch ? I'm not sure I understand this "patch". Why should the code above be faster than the current code in HotSpot, which tries to inline the trigonometric functions? Maybe the speedup you're seeing is because of the missing fast/slow path check and you are always using the slow path because of rounding? Just a guess... -- Christian From gbenson at redhat.com Wed Jul 15 06:57:45 2009 From: gbenson at redhat.com (Gary Benson) Date: Wed, 15 Jul 2009 14:57:45 +0100 Subject: Review request: Zero assembler port Message-ID: <20090715135745.GB3179@redhat.com> Hi all, Zero is an interpreter-only port of HotSpot that uses no assembler and can trivially be built on any Linux system. The following webrev adds Zero support to OpenJDK: http://cr.openjdk.java.net/~gbenson/zero-03/ In order to enable the Zero build, the following environment variables must be set: CORE_BUILD Setting CORE_BUILD to "true" will result in an interpreter-only HotSpot being built, with neither the client nor the server compilers. If CORE_BUILD is unset, or set to any other value than "true", then the compiler(s) will be built as normal. ZERO_BUILD Setting ZERO_BUILD to "true" will cause the Zero interpreter to be used. If ZERO_BUILD is unset, or set to any other value than "true", the standard, platform-specific interpreter will be used. The reason for having two separate flags is to allow for Zero builds with JIT compilers such as Shark (not included in this webrev). To build HotSpot with Zero and Shark you would set ZERO_BUILD to "true" but leave CORE_BUILD unset. There are five variables which are required when ZERO_BUILD is set to "true". These are set by jdk/make/jdk_generic_profile.sh based on the result of uname -m: ZERO_LIBARCH This is the name of the architecture-specific subdirectory under $JAVA_HOME/jre/lib. Typically this will be the same as the output of uname -m, although there are some exceptions: "amd64" instead of "x86_64", for example, and "i386" instead of "i686". ZERO_ARCHDEF The value of ZERO_ARCHDEF will be passed to the C++ compiler using -D${ZERO_ARCHDEF} to allow conditionalized platform-specific code. This is typically set to ZERO_LIBARCH converted to uppercase but, again, there are exceptions. "i386" becomes "IA32", to match what HotSpot already does, and on platforms with both 32- and 64-bit variants ZERO_ARCHDEF corresponds to the 32-bit version, so both ppc and ppc64 have ZERO_ARCHDEF set to "PPC". ZERO_ENDIANNESS This is set to "little" or "big". ZERO_BITSPERWORD This is set to "32" or "64". ZERO_ARCHFLAG This is a flag that will be passed to the C++ compiler and to the linker to instruct them to generate code for the particular platform. This is required for platforms with both 32- and 64-bit variants where the compiler needs to be told which variant to build for. ZERO_ARCHFLAG will typically be set to "-m32" or "-m64", except on 31-bit zSeries where it will be set to "-m31". Zero uses one external library, libffi, for JNI method invocation. The following two variables are used to tell the compiler and linker how to find libffi. These can be set by the user, but if left unset then jdk/make/jdk_generic_profile.sh will attempt to set them using pkg-config: LIBFFI_CFLAGS Flags to be passed to the C++ compiler to build against libffi. LIBFFI_LIBS Flags to be passed to the linker to link against libffi. Ok, I think that's it! Cheers, Gary -- http://gbenson.net/ From gustav.trede at gmail.com Wed Jul 15 07:07:54 2009 From: gustav.trede at gmail.com (gustav trede) Date: Wed, 15 Jul 2009 16:07:54 +0200 Subject: Math trig intrinsics and compiler options In-Reply-To: <4A5DD7E9.8070904@Sun.COM> References: <311e0eaf0907150543v5d877f55t3e6377b88ea43008@mail.gmail.com> <4A5DD7E9.8070904@Sun.COM> Message-ID: <311e0eaf0907150707i2606a040s8418872b22da46f5@mail.gmail.com> 2009/7/15 Christian Thalinger > gustav trede wrote: > > Hello, > > > > Azeem Jiva told me an easy way to improve trig performance. > > Changing the intrinsics to use an existing but faster path gives me a > > boost of roughly 40% for the Math cos and sin on solaris x64. > > > > > > library_call.cpp > > > > bool LibraryCallKit::inline_math_ > > native(vmIntrinsics::ID id) { > > switch (id) { > > > > case vmIntrinsics::_dcos: return Matcher::has_match_rule(Op_CosD) ? > > runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, > > SharedRuntime::dcos), "COS") : false; > > case vmIntrinsics::_dsin: return Matcher::has_match_rule(Op_SinD) ? > > runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, > > SharedRuntime::dsin), "SIN") : false; > > case vmIntrinsics::_dtan: return Matcher::has_match_rule(Op_TanD) ? > > runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, > > SharedRuntime::dtan), "TAN") : false; > > case vmIntrinsics::_dlog: return Matcher::has_match_rule(Op_LogD) ? > > runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, > > SharedRuntime::dlog), "LOG") : false; > > case vmIntrinsics::_dlog10: return Matcher::has_match_rule(Op_Log10D) > > ? runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, > > SharedRuntime::dlog10), "LOG10") : false; > > > > > > Is there any potential problem with such a patch ? > > I'm not sure I understand this "patch". Why should the code above be > faster than the current code in HotSpot, which tries to inline the > trigonometric functions? Maybe the speedup you're seeing is because of > the missing fast/slow path check and you are always using the slow path > because of rounding? Just a guess... > > -- Christian > Thats how i interpret the difference too, and correct me if im wrong but the rounding is only needed for the strictmath to get its platform independent exact results and not for Math ?. when testing with the input ranges that matches the different code paths (PI/4 , 3PI/4, 2^19*(pi/2)) with 1 minute runtime per test i get consistent improvement of roughly (40%, 100%, 32% ) for Math.sin and similar for cos. -- regards gustav trede -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20090715/c5393f41/attachment.html From Thomas.Rodriguez at Sun.COM Wed Jul 15 10:03:05 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 15 Jul 2009 10:03:05 -0700 Subject: Math trig intrinsics and compiler options In-Reply-To: <311e0eaf0907150707i2606a040s8418872b22da46f5@mail.gmail.com> References: <311e0eaf0907150543v5d877f55t3e6377b88ea43008@mail.gmail.com> <4A5DD7E9.8070904@Sun.COM> <311e0eaf0907150707i2606a040s8418872b22da46f5@mail.gmail.com> Message-ID: <924C32CF-2CD7-4BDF-91B7-9EB40FFC36FF@sun.com> > Thats how i interpret the difference too, and correct me if im > wrong but the rounding is only needed for the strictmath to get its > platform independent exact results and not for Math ?. StrictMath requires exact answers for all of these routines and the intel instructions don't have adequate accuracy to be used for them. The regular Math routines have some freedom to differ from the strict implementation but they can't be arbitrarily bad and the rounding logic that wraps the instructions ensures that we get back valid values outside the range where those instructions return reasonable answers. Check out http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4345903 . As far as why sharedRuntimeTrig.cpp disables compiler optimizations, these functions are from fdlibm and require very precise fp semantics which are generally violated by the optimizers in most compilers. If you turn on optimizations then these routines won't return the right answer anymore. tom > > when testing with the input ranges that matches the different code > paths (PI/4 , 3PI/4, 2^19*(pi/2)) with 1 minute runtime per test i > get consistent improvement of roughly (40%, 100%, 32% ) for > Math.sin and similar for cos. > > > -- > regards > gustav trede > > From Joe.Darcy at Sun.COM Wed Jul 15 09:58:08 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Wed, 15 Jul 2009 09:58:08 -0700 Subject: Math trig intrinsics and compiler options In-Reply-To: <4A5DD7E9.8070904@Sun.COM> References: <311e0eaf0907150543v5d877f55t3e6377b88ea43008@mail.gmail.com> <4A5DD7E9.8070904@Sun.COM> Message-ID: <4A5E0AA0.4080306@sun.com> Christian Thalinger wrote: > gustav trede wrote: > >> Hello, >> >> Azeem Jiva told me an easy way to improve trig performance. >> Changing the intrinsics to use an existing but faster path gives me a >> boost of roughly 40% for the Math cos and sin on solaris x64. >> >> >> library_call.cpp >> >> bool LibraryCallKit::inline_math_ >> native(vmIntrinsics::ID id) { >> switch (id) { >> >> case vmIntrinsics::_dcos: return Matcher::has_match_rule(Op_CosD) ? >> runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >> SharedRuntime::dcos), "COS") : false; >> case vmIntrinsics::_dsin: return Matcher::has_match_rule(Op_SinD) ? >> runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >> SharedRuntime::dsin), "SIN") : false; >> case vmIntrinsics::_dtan: return Matcher::has_match_rule(Op_TanD) ? >> runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >> SharedRuntime::dtan), "TAN") : false; >> case vmIntrinsics::_dlog: return Matcher::has_match_rule(Op_LogD) ? >> runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >> SharedRuntime::dlog), "LOG") : false; >> case vmIntrinsics::_dlog10: return Matcher::has_match_rule(Op_Log10D) >> ? runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >> SharedRuntime::dlog10), "LOG10") : false; >> >> >> Is there any potential problem with such a patch ? >> > > I'm not sure I understand this "patch". Why should the code above be > faster than the current code in HotSpot, which tries to inline the > trigonometric functions? Maybe the speedup you're seeing is because of > the missing fast/slow path check and you are always using the slow path > because of rounding? Just a guess... > Hello. Can you explain the nature of the selection difference? Better semantics are provided if the instrinsified versions of sin, cos, etc. are always used to implement the java.lang.Math flavor of those methods. -Joe From john.coomes at sun.com Wed Jul 15 11:00:21 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Wed, 15 Jul 2009 18:00:21 +0000 Subject: hg: jdk7/hotspot: 11 new changesets Message-ID: <20090715180022.3B67FE19E@hg.openjdk.java.net> Changeset: c50469cf63cd Author: herrick Date: 2009-06-11 15:15 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/c50469cf63cd 6797688: Umbrella: Merge all JDK 6u4 - 6u12 deployment code into JDK7 6845973: Update JDK7 with deployment changes in 6u13, 6u14 4802695: Support 64-bit Java Plug-in and Java webstart on Windows/Linux on AMD64 6825019: DownloadManager should not be loaded and referenced for full JRE 6738770: REGRESSION:JSException throws when use LiveConnect javascript facility 6772884: plugin2 : java.lang.OutOfMemoryError or crash 6707535: Crossing domain hole affecting multiple sites/domains using plug-in 6728071: Non-verification of Update files may allow unintended updates 6704154: Code loaded from local filesystem should not get access to localhost 6727081: Web Start security restrictions bypass using special extension jnlp 6727079: Java Web Start Socket() restriction bypass 6727071: Cache location/user name information disclosure in SingleInstanceImpl. 6716217: AppletClassLoader adds permissions based on codebase regardless of CS 6694892: Java Webstart inclusion via system properties override [CVE-2008-2086] 6704074: localhost socket access due to cache location exposed 6703909: Java webstart arbitrary file creation using nativelib 6665315: browser crashes when deployment.properties has more slashes ( / ) 6660121: Encoding values in JNLP files can cause buffer overflow 6606110: URLConnection.setProxiedHost for resources that are loaded via proxy 6581221: SSV(VISTA): Redirection FAILS to work if user does a downgrade install 6609756: Buffer Overflow in Java ActiveX component 6608712: Bypassing the same origin policy in Java with crafted names 6534630: "gnumake clobber" doesn't 6849953: JDK7 - replacement of bufferoverflowU.lib on amd64 breaks build 6849029: Need some JDK7 merge clean-up after comments on the webrev 6847582: Build problem on JDK7 with isSecureProperty in merge 6827935: JDK 7 deployment merging - problem in Compiler-msvm.gmk 6823215: latest merge fixes from 6u12 -> JDK7 6816153: further mergers for JDK7 deployment integration 6807074: Fix Java Kernel and JQS in initial JDK7 builds Summary: Initial changeset for implementing 6uX Deployment Features into JDK7 Reviewed-by: dgu, billyh ! make/deploy-rules.gmk Changeset: c7c4850f1478 Author: herrick Date: 2009-06-15 13:07 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/c7c4850f1478 Merge Changeset: d28a8c422df1 Author: herrick Date: 2009-06-22 09:14 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/d28a8c422df1 Merge Changeset: 528e4cc7541b Author: herrick Date: 2009-06-29 12:00 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/528e4cc7541b Merge Changeset: 9f4fc871bf4d Author: herrick Date: 2009-07-06 15:02 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/9f4fc871bf4d Merge Changeset: 03119516abbc Author: herrick Date: 2009-07-06 14:01 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/03119516abbc Merge Changeset: 633840bd4c5b Author: jqzuo Date: 2009-07-07 10:14 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/633840bd4c5b Merge Changeset: 46c0f8989eb2 Author: herrick Date: 2009-07-06 17:12 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/46c0f8989eb2 Merge Changeset: 3e781aa606d4 Author: ohair Date: 2009-07-06 22:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/3e781aa606d4 6857805: Fix openjdk builds to avoid building deploy repository Reviewed-by: xdono ! make/Defs-internal.gmk ! make/deploy-rules.gmk Changeset: 269c1ec4435d Author: jqzuo Date: 2009-07-07 10:20 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/269c1ec4435d Merge Changeset: d92b13b3c138 Author: xdono Date: 2009-07-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/d92b13b3c138 Added tag jdk7-b64 for changeset 269c1ec4435d ! .hgtags From john.coomes at sun.com Wed Jul 15 11:06:43 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Wed, 15 Jul 2009 18:06:43 +0000 Subject: hg: jdk7/hotspot/corba: 8 new changesets Message-ID: <20090715180655.5D54FE1A3@hg.openjdk.java.net> Changeset: ffb590b42ed1 Author: herrick Date: 2009-06-11 15:16 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/ffb590b42ed1 6797688: Umbrella: Merge all JDK 6u4 - 6u12 deployment code into JDK7 6845973: Update JDK7 with deployment changes in 6u13, 6u14 4802695: Support 64-bit Java Plug-in and Java webstart on Windows/Linux on AMD64 6825019: DownloadManager should not be loaded and referenced for full JRE 6738770: REGRESSION:JSException throws when use LiveConnect javascript facility 6772884: plugin2 : java.lang.OutOfMemoryError or crash 6707535: Crossing domain hole affecting multiple sites/domains using plug-in 6728071: Non-verification of Update files may allow unintended updates 6704154: Code loaded from local filesystem should not get access to localhost 6727081: Web Start security restrictions bypass using special extension jnlp 6727079: Java Web Start Socket() restriction bypass 6727071: Cache location/user name information disclosure in SingleInstanceImpl. 6716217: AppletClassLoader adds permissions based on codebase regardless of CS 6694892: Java Webstart inclusion via system properties override [CVE-2008-2086] 6704074: localhost socket access due to cache location exposed 6703909: Java webstart arbitrary file creation using nativelib 6665315: browser crashes when deployment.properties has more slashes ( / ) 6660121: Encoding values in JNLP files can cause buffer overflow 6606110: URLConnection.setProxiedHost for resources that are loaded via proxy 6581221: SSV(VISTA): Redirection FAILS to work if user does a downgrade install 6609756: Buffer Overflow in Java ActiveX component 6608712: Bypassing the same origin policy in Java with crafted names 6534630: "gnumake clobber" doesn't 6849953: JDK7 - replacement of bufferoverflowU.lib on amd64 breaks build 6849029: Need some JDK7 merge clean-up after comments on the webrev 6847582: Build problem on JDK7 with isSecureProperty in merge 6827935: JDK 7 deployment merging - problem in Compiler-msvm.gmk 6823215: latest merge fixes from 6u12 -> JDK7 6816153: further mergers for JDK7 deployment integration 6807074: Fix Java Kernel and JQS in initial JDK7 builds Summary: Initial changeset for implementing 6uX Deployment Features into JDK7 Reviewed-by: dgu, billyh ! make/common/Defs-windows.gmk ! make/common/Library.gmk ! make/org/omg/idl/Makefile ! src/windows/resource/version.rc Changeset: 79d8fd9e74b9 Author: herrick Date: 2009-06-15 13:07 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/79d8fd9e74b9 Merge - make/README Changeset: 1b3e9fdc4fc5 Author: herrick Date: 2009-06-22 09:14 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/1b3e9fdc4fc5 Merge Changeset: 27f41fcf3d6a Author: herrick Date: 2009-06-29 12:00 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/27f41fcf3d6a Merge Changeset: f982791bb7d4 Author: herrick Date: 2009-07-06 15:04 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/f982791bb7d4 Merge Changeset: 863559dbbced Author: herrick Date: 2009-07-06 14:02 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/863559dbbced Merge Changeset: 047dd27fddb6 Author: herrick Date: 2009-07-06 17:11 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/047dd27fddb6 Merge Changeset: 97fd9b42f5c2 Author: xdono Date: 2009-07-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/97fd9b42f5c2 Added tag jdk7-b64 for changeset 047dd27fddb6 ! .hgtags From john.coomes at sun.com Wed Jul 15 11:35:21 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Wed, 15 Jul 2009 18:35:21 +0000 Subject: hg: jdk7/hotspot/jaxp: Added tag jdk7-b64 for changeset a10eec7a1edf Message-ID: <20090715183523.DD164E1AC@hg.openjdk.java.net> Changeset: 008c662e0ee9 Author: xdono Date: 2009-07-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/008c662e0ee9 Added tag jdk7-b64 for changeset a10eec7a1edf ! .hgtags From john.coomes at sun.com Wed Jul 15 11:41:51 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Wed, 15 Jul 2009 18:41:51 +0000 Subject: hg: jdk7/hotspot/jaxws: Added tag jdk7-b64 for changeset aaa25dfd3de6 Message-ID: <20090715184154.0027DE1B1@hg.openjdk.java.net> Changeset: aa22a1be5866 Author: xdono Date: 2009-07-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/aa22a1be5866 Added tag jdk7-b64 for changeset aaa25dfd3de6 ! .hgtags From john.coomes at sun.com Wed Jul 15 11:50:22 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Wed, 15 Jul 2009 18:50:22 +0000 Subject: hg: jdk7/hotspot/jdk: 78 new changesets Message-ID: <20090715191032.3E157E1BA@hg.openjdk.java.net> Changeset: 1299804aa6e7 Author: xuelei Date: 2009-06-16 20:46 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1299804aa6e7 6850783: InvalidityDateExtension returns reference to internal mutable state Summary: return cloned instead of referenced object Reviewed-by: weijun ! src/share/classes/sun/security/x509/CertificateVersion.java ! src/share/classes/sun/security/x509/InvalidityDateExtension.java Changeset: bc2c9dbdcc70 Author: weijun Date: 2009-06-17 15:26 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/bc2c9dbdcc70 6849275: enhance krb5 reg tests Reviewed-by: xuelei ! test/sun/security/krb5/auto/CrossRealm.java ! test/sun/security/krb5/auto/HttpNegotiateServer.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor ! test/sun/security/krb5/auto/OneKDC.java ! test/sun/security/krb5/auto/basic.sh Changeset: 863351d5d244 Author: weijun Date: 2009-06-18 11:12 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/863351d5d244 6712755: jarsigner fails to sign itextasian.jar since 1.5.0_b14, it works with 1.5.0_13 Reviewed-by: mullan ! src/share/classes/sun/security/tools/JarSigner.java + test/sun/security/tools/jarsigner/emptymanifest.sh Changeset: e387bb1367a7 Author: mullan Date: 2009-06-18 09:04 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e387bb1367a7 6833839: RFE: improve ManifestDigester by instantiating StringBuilder constructor w/ initial value Reviewed-by: weijun ! src/share/classes/sun/security/util/ManifestDigester.java Changeset: 81c176909720 Author: mullan Date: 2009-06-18 10:38 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/81c176909720 Merge Changeset: 37ed72fe7561 Author: weijun Date: 2009-06-19 18:03 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/37ed72fe7561 6851973: ignore incoming channel binding if acceptor does not set one Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/krb5/InitialToken.java + test/sun/security/krb5/auto/IgnoreChannelBinding.java Changeset: ed38f9e6ad9a Author: jccollet Date: 2009-06-19 14:12 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ed38f9e6ad9a 6852108: Remove Preferences dependance from SocksSocketImpl Summary: Removed Preferences API use and fixed a few findbugs gotchas Reviewed-by: alanb ! src/share/classes/java/net/SocksSocketImpl.java Changeset: 77367060d119 Author: sherman Date: 2009-06-19 14:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/77367060d119 6299219: euro sign failed to be printed in Console on Localized Windows platform with GBK encoding 4891024: EUC-KR and JOHAB converters need to be updated to include two new characters 4287467: Character converter generator tool Summary: Migrated some of the doublebyte charsets to the new implementation. Reviewed-by: okutsu ! make/sun/nio/FILES_java.gmk ! make/sun/nio/Makefile + make/tools/CharsetMapping/EUC_CN.map + make/tools/CharsetMapping/EUC_KR.map + make/tools/CharsetMapping/GBK.map + make/tools/CharsetMapping/Johab.map + make/tools/CharsetMapping/MS932.c2b + make/tools/CharsetMapping/MS932.map + make/tools/CharsetMapping/MS932.nr + make/tools/CharsetMapping/MS936.map + make/tools/CharsetMapping/MS949.map + make/tools/CharsetMapping/MS950.map + make/tools/CharsetMapping/MS950.nr ! make/tools/CharsetMapping/dbcs ! make/tools/src/build/tools/charsetmapping/GenerateDBCS.java ! src/share/classes/sun/io/ByteToCharEUC_CN.java ! src/share/classes/sun/io/ByteToCharEUC_KR.java ! src/share/classes/sun/io/ByteToCharGBK.java ! src/share/classes/sun/io/ByteToCharJohab.java ! src/share/classes/sun/io/ByteToCharMS932.java - src/share/classes/sun/io/ByteToCharMS932DB.java ! src/share/classes/sun/io/ByteToCharMS936.java ! src/share/classes/sun/io/ByteToCharMS949.java ! src/share/classes/sun/io/ByteToCharMS950.java ! src/share/classes/sun/io/ByteToCharMS950_HKSCS.java ! src/share/classes/sun/io/CharToByteEUC_CN.java ! src/share/classes/sun/io/CharToByteEUC_KR.java ! src/share/classes/sun/io/CharToByteGBK.java ! src/share/classes/sun/io/CharToByteJohab.java ! src/share/classes/sun/io/CharToByteMS932.java - src/share/classes/sun/io/CharToByteMS932DB.java ! src/share/classes/sun/io/CharToByteMS936.java ! src/share/classes/sun/io/CharToByteMS949.java ! src/share/classes/sun/io/CharToByteMS950.java ! src/share/classes/sun/io/CharToByteMS950_HKSCS.java ! src/share/classes/sun/nio/cs/ext/DoubleByte.java - src/share/classes/sun/nio/cs/ext/EUC_CN.java - src/share/classes/sun/nio/cs/ext/EUC_KR.java - src/share/classes/sun/nio/cs/ext/GBK.java ! src/share/classes/sun/nio/cs/ext/ISO2022_CN.java - src/share/classes/sun/nio/cs/ext/Johab.java - src/share/classes/sun/nio/cs/ext/MS932.java - src/share/classes/sun/nio/cs/ext/MS932DB.java ! src/share/classes/sun/nio/cs/ext/MS932_0213.java - src/share/classes/sun/nio/cs/ext/MS936.java - src/share/classes/sun/nio/cs/ext/MS949.java - src/share/classes/sun/nio/cs/ext/MS950.java ! src/share/classes/sun/nio/cs/ext/MS950_HKSCS.java ! src/solaris/classes/sun/awt/motif/X11GB2312.java ! src/solaris/classes/sun/awt/motif/X11GBK.java ! src/solaris/classes/sun/awt/motif/X11KSC5601.java + test/sun/nio/cs/OLD/DoubleByteDecoder.java + test/sun/nio/cs/OLD/DoubleByteEncoder.java + test/sun/nio/cs/OLD/EUC_CN_OLD.java + test/sun/nio/cs/OLD/EUC_KR_OLD.java + test/sun/nio/cs/OLD/GBK_OLD.java + test/sun/nio/cs/OLD/Johab_OLD.java + test/sun/nio/cs/OLD/MS932DB.java + test/sun/nio/cs/OLD/MS932_OLD.java + test/sun/nio/cs/OLD/MS936_OLD.java + test/sun/nio/cs/OLD/MS949_OLD.java + test/sun/nio/cs/OLD/MS950_OLD.java ! test/sun/nio/cs/OLD/TestIBMDB.java + test/sun/nio/cs/OLD/TestX11CS.java + test/sun/nio/cs/OLD/X11GB2312_OLD.java + test/sun/nio/cs/OLD/X11GBK_OLD.java + test/sun/nio/cs/OLD/X11KSC5601_OLD.java Changeset: 28d4c9f5c9e9 Author: xlu Date: 2009-06-20 13:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/28d4c9f5c9e9 6850606: Regression from JDK 1.6.0_12 Summary: The returned result from multiply should be constructed by using valueOf to take care of the INFLATED case. Reviewed-by: darcy ! src/share/classes/java/math/BigDecimal.java ! test/java/math/BigDecimal/MultiplyTests.java Changeset: b0b249933c37 Author: martin Date: 2009-06-22 16:41 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b0b249933c37 6851653: (launcher) Make every java process 20 bytes smaller Summary: Carefully keep track of every byte Reviewed-by: ksrini, xlu ! src/share/bin/java.c Changeset: 7704895771b5 Author: sherman Date: 2009-06-22 19:22 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7704895771b5 6847092: (cs) CharsetEncoder.isLegalReplacement of US_ASCII behaves differently since Summary: Updated the US_ASCII and ISO-8859-1 to fix the failure. Reviewed-by: alanb, martin ! src/share/classes/sun/nio/cs/ISO_8859_1.java ! src/share/classes/sun/nio/cs/US_ASCII.java + test/sun/nio/cs/FindASCIIReplBugs.java Changeset: ce55eb6668d9 Author: martin Date: 2009-06-22 20:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ce55eb6668d9 6834805: Improve jar -C performance Summary: Store "-C" directories in a HashSet, not List, to remove duplicates Reviewed-by: sherman Contributed-by: jeremymanson at google.com ! src/share/classes/sun/tools/jar/Main.java Changeset: ff32c270102a Author: martin Date: 2009-06-22 21:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ff32c270102a 6853806: Prefer (cd $dir && jar) to jar -C for performance reasons Summary: Eliminate (most) uses of jar -C Reviewed-by: ohair ! make/common/Release.gmk Changeset: b3444a42fd40 Author: tbell Date: 2009-06-23 22:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b3444a42fd40 Merge - src/share/classes/sun/io/ByteToCharMS932DB.java - src/share/classes/sun/io/CharToByteMS932DB.java - src/share/classes/sun/nio/cs/ext/EUC_CN.java - src/share/classes/sun/nio/cs/ext/EUC_KR.java - src/share/classes/sun/nio/cs/ext/GBK.java - src/share/classes/sun/nio/cs/ext/Johab.java - src/share/classes/sun/nio/cs/ext/MS932.java - src/share/classes/sun/nio/cs/ext/MS932DB.java - src/share/classes/sun/nio/cs/ext/MS936.java - src/share/classes/sun/nio/cs/ext/MS949.java - src/share/classes/sun/nio/cs/ext/MS950.java Changeset: 70c0a927e21a Author: jccollet Date: 2009-06-25 18:56 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/70c0a927e21a 6811297: Add more logging to HTTP protocol handler Summary: Added extra logging to HttpURLConnection and HttpClient. Added a capture tool. Reviewed-by: chegar ! make/sun/net/FILES_java.gmk + src/share/classes/sun/net/www/http/HttpCapture.java + src/share/classes/sun/net/www/http/HttpCaptureInputStream.java + src/share/classes/sun/net/www/http/HttpCaptureOutputStream.java ! src/share/classes/sun/net/www/http/HttpClient.java + src/share/classes/sun/net/www/protocol/http/HttpLogFormatter.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: 5a3a5388756c Author: langel Date: 2009-06-25 17:01 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5a3a5388756c 6852607: MessageUtils JVM crash Summary: Fixes crash by checking null field Reviewed-by: alanb ! src/share/native/sun/misc/MessageUtils.c Changeset: 0b6571d4b4b5 Author: jccollet Date: 2009-06-26 16:50 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0b6571d4b4b5 6855297: Windows build breaks after 6811297 Summary: re-introduced the mistakenly taken out authObj member Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: 9f243df213fa Author: tbell Date: 2009-06-26 10:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9f243df213fa Merge - src/share/classes/sun/io/ByteToCharMS932DB.java - src/share/classes/sun/io/CharToByteMS932DB.java - src/share/classes/sun/nio/cs/ext/EUC_CN.java - src/share/classes/sun/nio/cs/ext/EUC_KR.java - src/share/classes/sun/nio/cs/ext/GBK.java - src/share/classes/sun/nio/cs/ext/Johab.java - src/share/classes/sun/nio/cs/ext/MS932.java - src/share/classes/sun/nio/cs/ext/MS932DB.java - src/share/classes/sun/nio/cs/ext/MS936.java - src/share/classes/sun/nio/cs/ext/MS949.java - src/share/classes/sun/nio/cs/ext/MS950.java Changeset: a5f7d97c3f82 Author: jjg Date: 2009-06-26 18:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a5f7d97c3f82 6843077: JSR 308: Annotations on types Reviewed-by: jjg, mcimadamore, darcy Contributed-by: mernst at cs.washington.edu, mali at csail.mit.edu, mpapi at csail.mit.edu ! src/share/classes/java/lang/annotation/ElementType.java Changeset: bd4f0613dd92 Author: tbell Date: 2009-06-28 00:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/bd4f0613dd92 Merge Changeset: 5208d0c90d73 Author: alanb Date: 2009-06-27 21:46 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5208d0c90d73 6838333: New I/O: Update file system API to jsr203/nio2-b101 6844313: New I/O: File timestamps should be represented by a FileTime rather than a long+TimeUnit Reviewed-by: sherman ! make/java/java/FILES_java.gmk ! make/java/nio/FILES_java.gmk ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! src/share/classes/java/io/File.java + src/share/classes/java/io/TempFileHelper.java ! src/share/classes/java/nio/channels/SeekableByteChannel.java ! src/share/classes/java/nio/file/AccessMode.java ! src/share/classes/java/nio/file/DirectoryStream.java - src/share/classes/java/nio/file/DirectoryStreamFilters.java - src/share/classes/java/nio/file/FileAction.java ! src/share/classes/java/nio/file/FileRef.java ! src/share/classes/java/nio/file/FileStore.java ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/FileVisitor.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/LinkPermission.java ! src/share/classes/java/nio/file/OpenOption.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/Paths.java ! src/share/classes/java/nio/file/SecureDirectoryStream.java ! src/share/classes/java/nio/file/SimpleFileVisitor.java ! src/share/classes/java/nio/file/StandardWatchEventKind.java ! src/share/classes/java/nio/file/WatchKey.java ! src/share/classes/java/nio/file/attribute/AclFileAttributeView.java ! src/share/classes/java/nio/file/attribute/AttributeView.java ! src/share/classes/java/nio/file/attribute/Attributes.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributeView.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributes.java ! src/share/classes/java/nio/file/attribute/DosFileAttributeView.java ! src/share/classes/java/nio/file/attribute/FileAttributeView.java ! src/share/classes/java/nio/file/attribute/FileOwnerAttributeView.java ! src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java + src/share/classes/java/nio/file/attribute/FileTime.java ! src/share/classes/java/nio/file/attribute/PosixFileAttributeView.java ! src/share/classes/java/nio/file/attribute/PosixFilePermissions.java ! src/share/classes/java/nio/file/attribute/UserDefinedFileAttributeView.java ! src/share/classes/java/nio/file/attribute/UserPrincipalLookupService.java - src/share/classes/java/nio/file/spi/AbstractPath.java ! src/share/classes/java/nio/file/spi/FileSystemProvider.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/sun/nio/fs/AbstractAclFileAttributeView.java ! src/share/classes/sun/nio/fs/AbstractBasicFileAttributeView.java - src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java ! src/share/classes/sun/nio/fs/AbstractFileTypeDetector.java + src/share/classes/sun/nio/fs/AbstractPath.java ! src/share/classes/sun/nio/fs/AbstractUserDefinedFileAttributeView.java + src/share/classes/sun/nio/fs/DynamicFileAttributeView.java ! src/share/classes/sun/nio/fs/FileOwnerAttributeViewImpl.java - src/share/classes/sun/nio/fs/MimeType.java ! src/share/classes/sun/nio/fs/PollingWatchService.java + src/share/classes/sun/nio/fs/Util.java ! src/share/sample/nio/file/Copy.java ! src/share/sample/nio/file/Xdd.java ! src/solaris/classes/sun/nio/fs/LinuxDosFileAttributeView.java ! src/solaris/classes/sun/nio/fs/LinuxFileStore.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystem.java ! src/solaris/classes/sun/nio/fs/SolarisAclFileAttributeView.java ! src/solaris/classes/sun/nio/fs/SolarisFileStore.java ! src/solaris/classes/sun/nio/fs/SolarisFileSystem.java ! src/solaris/classes/sun/nio/fs/UnixChannelFactory.java ! src/solaris/classes/sun/nio/fs/UnixCopyFile.java ! src/solaris/classes/sun/nio/fs/UnixDirectoryStream.java ! src/solaris/classes/sun/nio/fs/UnixFileAttributeViews.java ! src/solaris/classes/sun/nio/fs/UnixFileAttributes.java ! src/solaris/classes/sun/nio/fs/UnixFileKey.java ! src/solaris/classes/sun/nio/fs/UnixFileModeAttribute.java ! src/solaris/classes/sun/nio/fs/UnixFileStore.java ! src/solaris/classes/sun/nio/fs/UnixFileSystem.java ! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/UnixMountEntry.java ! src/solaris/classes/sun/nio/fs/UnixNativeDispatcher.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/solaris/classes/sun/nio/fs/UnixSecureDirectoryStream.java ! src/solaris/classes/sun/nio/fs/UnixUserPrincipals.java ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c ! src/solaris/native/sun/nio/fs/genUnixConstants.c ! src/windows/classes/sun/nio/fs/WindowsConstants.java ! src/windows/classes/sun/nio/fs/WindowsDirectoryStream.java ! src/windows/classes/sun/nio/fs/WindowsFileAttributeViews.java ! src/windows/classes/sun/nio/fs/WindowsFileAttributes.java ! src/windows/classes/sun/nio/fs/WindowsFileStore.java ! src/windows/classes/sun/nio/fs/WindowsFileSystem.java ! src/windows/classes/sun/nio/fs/WindowsLinkSupport.java ! src/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java ! src/windows/classes/sun/nio/fs/WindowsPath.java ! src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c ! test/java/nio/file/DirectoryStream/Basic.java - test/java/nio/file/DirectoryStream/Filters.java ! test/java/nio/file/DirectoryStream/SecureDS.java ! test/java/nio/file/FileSystem/Basic.java ! test/java/nio/file/Files/ContentType.java ! test/java/nio/file/Files/Misc.java - test/java/nio/file/Files/content_type.sh ! test/java/nio/file/Path/CopyAndMove.java + test/java/nio/file/Path/FileAttributes.java ! test/java/nio/file/Path/Links.java ! test/java/nio/file/Path/Misc.java ! test/java/nio/file/Path/PathOps.java ! test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/temporary_files.sh ! test/java/nio/file/TestUtil.java ! test/java/nio/file/WatchService/Basic.java ! test/java/nio/file/WatchService/FileTreeModifier.java ! test/java/nio/file/attribute/AclFileAttributeView/Basic.java - test/java/nio/file/attribute/Attributes/Basic.java ! test/java/nio/file/attribute/BasicFileAttributeView/Basic.java ! test/java/nio/file/attribute/DosFileAttributeView/Basic.java ! test/java/nio/file/attribute/FileStoreAttributeView/Basic.java + test/java/nio/file/attribute/FileTime/Basic.java ! test/java/nio/file/attribute/PosixFileAttributeView/Basic.java ! test/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java Changeset: 77dd50ba670b Author: alanb Date: 2009-06-27 21:49 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/77dd50ba670b 6844054: (bf) Eliminate dependency on javax.management.ObjectName Reviewed-by: mchung ! src/share/classes/java/lang/management/PlatformComponent.java ! src/share/classes/java/nio/Bits.java ! src/share/classes/java/nio/Direct-X-Buffer.java ! src/share/classes/sun/management/ManagementFactoryHelper.java ! src/share/classes/sun/misc/JavaNioAccess.java ! src/share/classes/sun/nio/ch/FileChannelImpl.java Changeset: dd20c662d463 Author: ohair Date: 2009-06-26 21:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/dd20c662d463 6855180: Fix classfile version check in java_crw_demo Reviewed-by: jjg ! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c ! src/share/javavm/export/classfile_constants.h Changeset: cbb5964d97ef Author: ohair Date: 2009-06-28 11:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/cbb5964d97ef Merge - src/share/classes/java/nio/file/DirectoryStreamFilters.java - src/share/classes/java/nio/file/FileAction.java - src/share/classes/java/nio/file/spi/AbstractPath.java - src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java - src/share/classes/sun/nio/fs/MimeType.java - test/java/nio/file/DirectoryStream/Filters.java - test/java/nio/file/Files/content_type.sh - test/java/nio/file/Path/temporary_files.sh - test/java/nio/file/attribute/Attributes/Basic.java Changeset: 35b19adcb215 Author: tbell Date: 2009-06-28 23:16 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/35b19adcb215 Merge - src/share/classes/java/nio/file/DirectoryStreamFilters.java - src/share/classes/java/nio/file/FileAction.java - src/share/classes/java/nio/file/spi/AbstractPath.java - src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java - src/share/classes/sun/nio/fs/MimeType.java - test/java/nio/file/DirectoryStream/Filters.java - test/java/nio/file/Files/content_type.sh - test/java/nio/file/Path/temporary_files.sh - test/java/nio/file/attribute/Attributes/Basic.java Changeset: 806c5e4d1265 Author: michaelm Date: 2009-06-29 13:10 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/806c5e4d1265 6513803: httpserver regression test Test13 failing and causing NullPointerException Summary: check for NPEs Reviewed-by: chegar ! test/com/sun/net/httpserver/Test1.java ! test/com/sun/net/httpserver/Test12.java ! test/com/sun/net/httpserver/Test13.java ! test/com/sun/net/httpserver/Test3.java ! test/com/sun/net/httpserver/Test4.java ! test/com/sun/net/httpserver/Test5.java ! test/com/sun/net/httpserver/Test9.java ! test/com/sun/net/httpserver/Test9a.java ! test/com/sun/net/httpserver/TestLogging.java Changeset: b6721df9ae0a Author: michaelm Date: 2009-06-29 13:29 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b6721df9ae0a Merge Changeset: a44009aba19f Author: chegar Date: 2009-06-29 14:53 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a44009aba19f 6855335: Several changes in the SCTP implementation. Reviewed-by: michaelm ! make/com/sun/nio/sctp/mapfile-vers ! src/solaris/classes/sun/nio/ch/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpNet.java ! src/solaris/classes/sun/nio/ch/SctpResultContainer.java ! src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java ! src/solaris/native/sun/nio/ch/Sctp.h ! src/solaris/native/sun/nio/ch/SctpChannelImpl.c ! src/solaris/native/sun/nio/ch/SctpNet.c ! test/com/sun/nio/sctp/SctpChannel/Connect.java ! test/com/sun/nio/sctp/SctpChannel/Shutdown.java ! test/com/sun/nio/sctp/SctpChannel/SocketOptionTests.java + test/com/sun/nio/sctp/SctpMultiChannel/Branch.java + test/com/sun/nio/sctp/SctpMultiChannel/SocketOptionTests.java Changeset: 89b14d3740dc Author: michaelm Date: 2009-06-29 15:05 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/89b14d3740dc 6827999: 6827999: URLClassLoader.addURL(URL) adds URLs to closed class loader Reviewed-by: chegar ! src/share/classes/sun/misc/URLClassPath.java + test/java/net/URLClassLoader/B6827999.java Changeset: 424420bf5917 Author: michaelm Date: 2009-06-29 15:08 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/424420bf5917 Merge - src/share/classes/java/nio/file/DirectoryStreamFilters.java - src/share/classes/java/nio/file/FileAction.java - src/share/classes/java/nio/file/spi/AbstractPath.java - src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java - src/share/classes/sun/nio/fs/MimeType.java - test/java/nio/file/DirectoryStream/Filters.java - test/java/nio/file/Files/content_type.sh - test/java/nio/file/Path/temporary_files.sh - test/java/nio/file/attribute/Attributes/Basic.java Changeset: d926534a1c17 Author: jjg Date: 2009-06-29 16:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d926534a1c17 6855069: rmic should support v51 class files. Reviewed-by: jrose ! src/share/classes/sun/tools/java/RuntimeConstants.java Changeset: cb20a8a1f22f Author: tbell Date: 2009-06-29 17:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/cb20a8a1f22f Merge Changeset: 605d3fa6764e Author: weijun Date: 2009-06-30 11:55 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/605d3fa6764e 6855671: DerOutputStream encodes negative integer incorrectly Reviewed-by: xuelei ! src/share/classes/sun/security/util/DerOutputStream.java + test/sun/security/util/DerValue/NegInt.java Changeset: 1cc9eb0c952e Author: sherman Date: 2009-06-29 19:57 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1cc9eb0c952e 6707281: Adler32.update() JavaDoc is wrong 6553961: java.util.zip.{CRC32,Adler32}.update(int) doc errors 6646605: Missing method ZipFile.getComment() 6841232: ZipFile should implement Closeable 4985614: Failure on calls to ZipFile constructor 5032358: "java.util.zip.ZipException: The system cannot find the file specified" 6846616: java/util/zip/ZipFile/ReadAfterClose.java failed after fix for 6735255 Summary: some misc bug/rfe fixes for zipfile Reviewed-by: alanb ! make/java/java/mapfile-vers ! make/java/zip/mapfile-vers ! src/share/classes/java/util/zip/Adler32.java ! src/share/classes/java/util/zip/CRC32.java ! src/share/classes/java/util/zip/ZipFile.java ! src/share/native/java/util/zip/ZipFile.c ! src/share/native/java/util/zip/zip_util.c ! src/share/native/java/util/zip/zip_util.h ! test/java/util/zip/ZipFile/ReadAfterClose.java ! test/java/util/zip/ZipFile/ReadZip.java Changeset: b144685f6694 Author: sherman Date: 2009-06-29 21:16 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b144685f6694 Merge Changeset: 861f23119072 Author: tbell Date: 2009-06-29 23:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/861f23119072 Merge Changeset: 4e4ff42f3140 Author: tbell Date: 2009-07-03 09:15 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4e4ff42f3140 Merge Changeset: 49e7d22262a9 Author: ant Date: 2009-06-18 11:28 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/49e7d22262a9 4788402: SortingFocusTraversalPolicy: prob with non-focusable focus Cycle Root as first Reviewed-by: dcherepanov ! src/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java ! src/share/classes/javax/swing/SortingFocusTraversalPolicy.java ! test/java/awt/Focus/FocusTraversalPolicy/DefaultFTPTest.java ! test/java/awt/Focus/FocusTraversalPolicy/LayoutFTPTest.java Changeset: 06f35d090a5e Author: langel Date: 2009-06-19 16:49 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/06f35d090a5e 6721086: Toolkit beep does not work consistently Summary: Flush out after bell is sounded Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: d1bdaf29e531 Author: dcherepanov Date: 2009-06-23 13:35 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d1bdaf29e531 6824169: Need to remove some AWT class dependencies Reviewed-by: art, anthony, igor, alexp ! src/share/classes/java/awt/AWTEvent.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/MenuComponent.java ! src/share/classes/java/awt/PopupMenu.java ! src/share/classes/java/awt/Window.java ! src/share/classes/javax/swing/BufferStrategyPaintManager.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/LayoutFocusTraversalPolicy.java ! src/share/classes/javax/swing/LookAndFeel.java ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/javax/swing/UIManager.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/awt/SunToolkit.java ! src/share/classes/sun/awt/shell/ShellFolder.java - src/share/classes/sun/swing/AccessibleMethod.java + src/share/classes/sun/swing/SwingAccessor.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WPopupMenuPeer.java ! src/windows/classes/sun/awt/windows/WPrintDialogPeer.java ! src/windows/classes/sun/java2d/windows/GDIWindowSurfaceData.java Changeset: 61e25d428bfe Author: dcherepanov Date: 2009-06-23 15:10 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/61e25d428bfe 6736247: Component.printAll Invalid local JNI handle Reviewed-by: anthony ! src/windows/native/sun/windows/awt_Component.cpp + test/java/awt/Component/PrintAllXcheckJNI/PrintAllXcheckJNI.java Changeset: e279dd2c5a2c Author: ant Date: 2009-06-23 15:53 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e279dd2c5a2c 6821291: assertion failure in awt_Frame.h Reviewed-by: dcherepanov, art ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_Frame.h Changeset: 51e452ff726a Author: anthony Date: 2009-06-23 16:10 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/51e452ff726a 6851646: test/closed/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.java can fail Summary: Added realSync() call. Made the test public. Reviewed-by: dcherepanov + test/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html + test/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.java Changeset: 5e880ea33ddc Author: yan Date: 2009-06-26 11:48 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5e880ea33ddc 6711676: Numpad keys trigger more than one KeyEvent. Summary: Introduce a new sniffer based on server keymap. Reviewed-by: art ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XlibWrapper.java ! src/solaris/classes/sun/awt/X11/keysym2ucs.h ! src/solaris/native/sun/xawt/XlibWrapper.c Changeset: 60290477fe73 Author: dav Date: 2009-06-26 19:50 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/60290477fe73 6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java fails Summary: consider gap between the component edge and container borders instead of just getX() and getY() Reviewed-by: dav Contributed-by: mwong at redhat.com ! test/java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java Changeset: 2df0d81c4201 Author: ant Date: 2009-06-30 12:55 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/2df0d81c4201 6855713: jdk7: debug build failure in awt_Frame.cpp Reviewed-by: dcherepanov, yan ! src/windows/native/sun/windows/awt_Frame.cpp Changeset: 75497b840ed0 Author: yan Date: 2009-06-30 02:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/75497b840ed0 Merge - src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java - src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java - src/share/classes/sun/nio/cs/ext/IBM1381.java - src/share/classes/sun/nio/cs/ext/IBM1383.java - src/share/classes/sun/nio/cs/ext/IBM930.java - src/share/classes/sun/nio/cs/ext/IBM933.java - src/share/classes/sun/nio/cs/ext/IBM935.java - src/share/classes/sun/nio/cs/ext/IBM937.java - src/share/classes/sun/nio/cs/ext/IBM939.java - src/share/classes/sun/nio/cs/ext/IBM942.java - src/share/classes/sun/nio/cs/ext/IBM943.java - src/share/classes/sun/nio/cs/ext/IBM948.java - src/share/classes/sun/nio/cs/ext/IBM949.java - src/share/classes/sun/nio/cs/ext/IBM950.java - src/share/classes/sun/nio/cs/ext/IBM970.java - src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java - src/share/native/sun/font/bidi/cmemory.h - src/share/native/sun/font/bidi/jbidi.c - src/share/native/sun/font/bidi/jbidi.h - src/share/native/sun/font/bidi/ubidi.c - src/share/native/sun/font/bidi/ubidi.h - src/share/native/sun/font/bidi/ubidiimp.h - src/share/native/sun/font/bidi/ubidiln.c - src/share/native/sun/font/bidi/uchardir.c - src/share/native/sun/font/bidi/uchardir.h - src/share/native/sun/font/bidi/utypes.h Changeset: 4d7e08935d95 Author: yan Date: 2009-07-01 00:17 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4d7e08935d95 Merge - src/share/classes/sun/swing/AccessibleMethod.java Changeset: 743021a4938c Author: peterz Date: 2009-06-22 18:08 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/743021a4938c 6849277: Nimbus L&F: lots of painter classes were added to JDK7 as public Reviewed-by: malenkov ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template ! src/share/classes/javax/swing/plaf/nimbus/PainterImpl.template Changeset: ce347002bbd9 Author: peterz Date: 2009-06-23 12:24 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ce347002bbd9 6844273: jdk/make/docs/CORE_PKGS.gmk does not list Nimbus Reviewed-by: prr ! make/docs/CORE_PKGS.gmk ! src/share/classes/javax/swing/plaf/nimbus/package.html Changeset: b75fc6019d5f Author: malenkov Date: 2009-06-24 13:59 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b75fc6019d5f 6852574: EnumPersistenceDelegate fails to persist instances with blocks Reviewed-by: peterz ! src/share/classes/java/beans/MetaData.java + test/java/beans/XMLEncoder/Test6852574.java Changeset: 404a13b063f9 Author: malenkov Date: 2009-06-24 17:45 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/404a13b063f9 6737700: api/javax_swing/table/DefaultTableCellRenderer/index.html#getset:DefaultTableCellRenderer Reviewed-by: alexp ! src/share/classes/javax/swing/table/DefaultTableCellRenderer.java Changeset: e006119341de Author: peytoia Date: 2009-06-25 07:38 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e006119341de 6853792: test/java/text/Bidi/Bug6850113.java compilation error Reviewed-by: okutsu ! test/java/text/Bidi/Bug6850113.java Changeset: d6f2dd2bd8d0 Author: peytoia Date: 2009-06-25 17:37 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d6f2dd2bd8d0 6609750: [Fmt-De] SimpleDateFormat.format() doesn't handle pattern "y" correctly Reviewed-by: okutsu ! src/share/classes/java/text/SimpleDateFormat.java + test/java/text/Format/DateFormat/Bug6609750.java Changeset: d086e324775c Author: yan Date: 2009-06-25 00:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d086e324775c Merge - src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java - src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java - src/share/classes/sun/nio/cs/ext/IBM1381.java - src/share/classes/sun/nio/cs/ext/IBM1383.java - src/share/classes/sun/nio/cs/ext/IBM930.java - src/share/classes/sun/nio/cs/ext/IBM933.java - src/share/classes/sun/nio/cs/ext/IBM935.java - src/share/classes/sun/nio/cs/ext/IBM937.java - src/share/classes/sun/nio/cs/ext/IBM939.java - src/share/classes/sun/nio/cs/ext/IBM942.java - src/share/classes/sun/nio/cs/ext/IBM943.java - src/share/classes/sun/nio/cs/ext/IBM948.java - src/share/classes/sun/nio/cs/ext/IBM949.java - src/share/classes/sun/nio/cs/ext/IBM950.java - src/share/classes/sun/nio/cs/ext/IBM970.java - src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java Changeset: 4d54d6e7bcef Author: yan Date: 2009-06-25 02:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4d54d6e7bcef Merge Changeset: e0707baa1593 Author: peytoia Date: 2009-06-25 21:55 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e0707baa1593 6792400: Avoid loading of Normalizer resources for simple uses Reviewed-by: okutsu ! src/share/classes/sun/text/normalizer/NormalizerBase.java Changeset: ae9e74a17059 Author: malenkov Date: 2009-06-25 18:50 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ae9e74a17059 6848364: javax/swing/border/Test4856008.java regression test fails due to BorderedComponent package not found Reviewed-by: alexp ! test/javax/swing/border/Test4856008.java Changeset: f1f9d228800e Author: peterz Date: 2009-06-26 08:09 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f1f9d228800e 6827032: NIMBUS: Drag and drop throws a NPE in SwingSet2 ColorChooser Reviewed-by: malenkov ! src/share/classes/javax/swing/plaf/synth/SynthColorChooserUI.java Changeset: e60d3354ab9f Author: malenkov Date: 2009-06-26 16:30 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e60d3354ab9f 6557223: Resize cursor stays after fast outline-resize of JInternalFrame with JScrollPane Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameUI.java Changeset: 1b40ddc3688c Author: malenkov Date: 2009-06-26 16:58 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1b40ddc3688c 6679840: provide a way to choose v-synced BufferStrategy Reviewed-by: peterz ! src/share/classes/com/sun/java/swing/SwingUtilities3.java ! src/share/classes/javax/swing/BufferStrategyPaintManager.java Changeset: 800082d9b8df Author: malenkov Date: 2009-06-26 17:15 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/800082d9b8df 6742850: Antialiasing for GTK L&F should be turned on by default if there is no embedded bitmap. Reviewed-by: peterz ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java Changeset: 95f3fb73cf60 Author: peterz Date: 2009-06-26 21:43 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/95f3fb73cf60 6849805: Nimbus L&F: NimbusLookAndFeel.getDerivedColor() not always returns color2 for 1.0 midPoint Summary: Different rounding mode used for float->int conversion Reviewed-by: malenkov ! src/share/classes/javax/swing/plaf/nimbus/AbstractRegionPainter.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java + test/javax/swing/plaf/nimbus/Test6849805.java Changeset: 0bc2fa2d1938 Author: peytoia Date: 2009-06-30 09:38 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0bc2fa2d1938 6855715: Font2Dtest demo needs to be updated to support Unicode 5.1.0. Reviewed-by: okutsu ! src/share/demo/jfc/Font2DTest/RangeMenu.java Changeset: 9be953f877a8 Author: yan Date: 2009-07-01 00:23 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9be953f877a8 Merge ! src/share/classes/javax/swing/BufferStrategyPaintManager.java Changeset: 1a52b17a18d2 Author: yan Date: 2009-07-07 23:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1a52b17a18d2 Merge - src/share/classes/sun/swing/AccessibleMethod.java Changeset: 9053bcc8eef0 Author: herrick Date: 2009-06-12 14:56 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9053bcc8eef0 6797688: Umbrella: Merge all JDK 6u4 - 6u12 deployment code into JDK7 6845973: Update JDK7 with deployment changes in 6u13, 6u14 4802695: Support 64-bit Java Plug-in and Java webstart on Windows/Linux on AMD64 6825019: DownloadManager should not be loaded and referenced for full JRE 6738770: REGRESSION:JSException throws when use LiveConnect javascript facility 6772884: plugin2 : java.lang.OutOfMemoryError or crash 6707535: Crossing domain hole affecting multiple sites/domains using plug-in 6728071: Non-verification of Update files may allow unintended updates 6704154: Code loaded from local filesystem should not get access to localhost 6727081: Web Start security restrictions bypass using special extension jnlp 6727079: Java Web Start Socket() restriction bypass 6727071: Cache location/user name information disclosure in SingleInstanceImpl. 6716217: AppletClassLoader adds permissions based on codebase regardless of CS 6694892: Java Webstart inclusion via system properties override [CVE-2008-2086] 6704074: localhost socket access due to cache location exposed 6703909: Java webstart arbitrary file creation using nativelib 6665315: browser crashes when deployment.properties has more slashes ( / ) 6660121: Encoding values in JNLP files can cause buffer overflow 6606110: URLConnection.setProxiedHost for resources that are loaded via proxy 6581221: SSV(VISTA): Redirection FAILS to work if user does a downgrade install 6609756: Buffer Overflow in Java ActiveX component 6608712: Bypassing the same origin policy in Java with crafted names 6534630: "gnumake clobber" doesn't 6849953: JDK7 - replacement of bufferoverflowU.lib on amd64 breaks build 6849029: Need some JDK7 merge clean-up after comments on the webrev 6847582: Build problem on JDK7 with isSecureProperty in merge 6827935: JDK 7 deployment merging - problem in Compiler-msvm.gmk 6823215: latest merge fixes from 6u12 -> JDK7 6816153: further mergers for JDK7 deployment integration 6807074: Fix Java Kernel and JQS in initial JDK7 builds Summary: Initial changeset for implementing 6uX Deployment Features into JDK7 Reviewed-by: dgu, billyh ! make/com/sun/java/pack/Makefile ! make/common/Defs-windows.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Sanity.gmk ! make/java/java/FILES_c.gmk ! make/java/redist/Makefile ! make/jpda/tty/Makefile ! make/sun/Makefile ! make/sun/applet/Makefile ! make/sun/jar/Makefile ! make/sun/javazic/tzdata_jdk/jdk11_full_backward ! make/sun/jconsole/Makefile + make/sun/jkernel/FILES_c_windows.gmk + make/sun/jkernel/FILES_java.gmk + make/sun/jkernel/Makefile ! make/sun/native2ascii/Makefile ! make/sun/rmi/rmic/Makefile ! make/sun/serialver/Makefile ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/util/zip/ZipEntry.java ! src/share/classes/sun/applet/AppletClassLoader.java ! src/share/classes/sun/applet/AppletPanel.java + src/share/classes/sun/jkernel/BackgroundDownloader.java + src/share/classes/sun/jkernel/Bundle.java + src/share/classes/sun/jkernel/BundleCheck.java + src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java + src/share/classes/sun/jkernel/DigestOutputStream.java + src/share/classes/sun/jkernel/DownloadManager.java + src/share/classes/sun/jkernel/KernelError.java + src/share/classes/sun/jkernel/Mutex.java + src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java + src/share/classes/sun/jkernel/StandaloneMessageDigest.java + src/share/classes/sun/jkernel/StandaloneSHA.java ! src/share/classes/sun/management/OperatingSystemImpl.java ! src/share/classes/sun/management/ThreadImpl.java ! src/share/classes/sun/misc/Launcher.java ! src/share/classes/sun/misc/PerformanceLogger.java ! src/share/classes/sun/misc/VM.java ! src/share/native/common/jni_util.c ! src/share/native/common/jni_util.h ! src/share/native/sun/misc/VM.c + src/solaris/native/common/jni_util_md.c ! src/windows/bin/java_md.c + src/windows/native/common/jni_util_md.c + src/windows/native/sun/jkernel/DownloadDialog.cpp + src/windows/native/sun/jkernel/DownloadDialog.h + src/windows/native/sun/jkernel/DownloadHelper.cpp + src/windows/native/sun/jkernel/DownloadHelper.h + src/windows/native/sun/jkernel/graphics/bullet.bmp + src/windows/native/sun/jkernel/graphics/cautionshield32.bmp + src/windows/native/sun/jkernel/graphics/java-icon.ico + src/windows/native/sun/jkernel/graphics/masthead.bmp + src/windows/native/sun/jkernel/graphics/warningmasthead.bmp + src/windows/native/sun/jkernel/kernel.cpp + src/windows/native/sun/jkernel/kernel.def + src/windows/native/sun/jkernel/kernel.h + src/windows/native/sun/jkernel/kernel.rc + src/windows/native/sun/jkernel/kernel_de.rc + src/windows/native/sun/jkernel/kernel_en.rc + src/windows/native/sun/jkernel/kernel_es.rc + src/windows/native/sun/jkernel/kernel_fr.rc + src/windows/native/sun/jkernel/kernel_it.rc + src/windows/native/sun/jkernel/kernel_ja.rc + src/windows/native/sun/jkernel/kernel_ko.rc + src/windows/native/sun/jkernel/kernel_sv.rc + src/windows/native/sun/jkernel/kernel_zh.rc + src/windows/native/sun/jkernel/kernel_zh_TW.rc + src/windows/native/sun/jkernel/resource.h + src/windows/native/sun/jkernel/stdafx.cpp + src/windows/native/sun/jkernel/stdafx.h + src/windows/native/sun/jkernel/version.rc ! src/windows/native/sun/windows/awt.rc + src/windows/resource/unpack200_proto.exe.manifest ! src/windows/resource/version.rc ! test/java/awt/Focus/NonFocusableWindowTest/NoEventsTest.java ! test/java/awt/Focus/RestoreFocusOnDisabledComponentTest/RestoreFocusOnDisabledComponentTest.java ! test/java/awt/font/Rotate/TranslatedOutlineTest.java ! test/java/awt/font/Threads/FontThread.java ! test/java/security/AccessControlContext/FailureDebugOption.java ! test/javax/swing/JPopupMenu/6691503/bug6691503.java ! test/sun/security/pkcs11/Cipher/TestRSACipherWrap.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/AsyncSSLSocketClose.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java Changeset: ea7620b05a58 Author: herrick Date: 2009-06-15 13:08 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ea7620b05a58 Merge ! make/common/shared/Defs-windows.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Sanity.gmk Changeset: 4f207797e185 Author: herrick Date: 2009-06-19 11:46 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4f207797e185 6852646: JDK 7 cannot build w/o ALT_HOTSPOT_KERNEL_PATH set. Summary: This problem was discovered testing initial changeset for implementing 6uX Deployment Features into JDK7 Reviewed-by: dgu, billyh ! make/common/shared/Defs-windows.gmk ! make/common/shared/Sanity.gmk Changeset: 23c7d780c1b3 Author: herrick Date: 2009-06-19 15:04 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/23c7d780c1b3 6853152: JDK 7 cannot build w/o ALT_HOTSPOT_KERNEL_PATH set. - still broken Summary: This problem was discovered testing initial changeset for implementing 6uX Deployment Features into JDK7 Reviewed-by: dgu, billyh ! make/common/shared/Defs-windows.gmk ! make/java/redist/Makefile Changeset: f509fe92a102 Author: herrick Date: 2009-06-22 09:16 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f509fe92a102 Merge Changeset: 9362d0114c3a Author: herrick Date: 2009-06-24 14:49 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9362d0114c3a 6633813: Add standard hotspot import path for Kernel VM Summary: This problem was discovered testing initial changeset for implementing 6uX Deployment Features into JDK7 Reviewed-by: dgu, billyh ! make/common/shared/Defs-windows.gmk ! make/java/redist/Makefile Changeset: dd0371861841 Author: herrick Date: 2009-06-29 12:06 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/dd0371861841 Merge ! make/common/Release.gmk ! make/sun/Makefile ! src/share/classes/java/lang/System.java - src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java - src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java - src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java - src/share/classes/sun/nio/cs/ext/IBM1381.java - src/share/classes/sun/nio/cs/ext/IBM1383.java - src/share/classes/sun/nio/cs/ext/IBM930.java - src/share/classes/sun/nio/cs/ext/IBM933.java - src/share/classes/sun/nio/cs/ext/IBM935.java - src/share/classes/sun/nio/cs/ext/IBM937.java - src/share/classes/sun/nio/cs/ext/IBM939.java - src/share/classes/sun/nio/cs/ext/IBM942.java - src/share/classes/sun/nio/cs/ext/IBM943.java - src/share/classes/sun/nio/cs/ext/IBM948.java - src/share/classes/sun/nio/cs/ext/IBM949.java - src/share/classes/sun/nio/cs/ext/IBM950.java - src/share/classes/sun/nio/cs/ext/IBM970.java - src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java - src/share/native/sun/font/bidi/cmemory.h - src/share/native/sun/font/bidi/jbidi.c - src/share/native/sun/font/bidi/jbidi.h - src/share/native/sun/font/bidi/ubidi.c - src/share/native/sun/font/bidi/ubidi.h - src/share/native/sun/font/bidi/ubidiimp.h - src/share/native/sun/font/bidi/ubidiln.c - src/share/native/sun/font/bidi/uchardir.c - src/share/native/sun/font/bidi/uchardir.h - src/share/native/sun/font/bidi/utypes.h Changeset: 4caa574b3993 Author: herrick Date: 2009-06-29 17:34 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4caa574b3993 6855953: JDK7 - merger error of deployment changes with b62 -in jdk/make/sun/Makefile Summary: This problem was discovered testing initial changeset for implementing 6uX Deployment Features into JDK7 Reviewed-by: dgu, billyh ! make/sun/Makefile Changeset: 9710ed723163 Author: herrick Date: 2009-07-01 10:18 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9710ed723163 Merge ! src/share/classes/java/awt/color/ICC_Profile.java Changeset: c51ead46c547 Author: herrick Date: 2009-07-06 14:10 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c51ead46c547 Merge ! make/common/Release.gmk - src/share/classes/java/nio/file/DirectoryStreamFilters.java - src/share/classes/java/nio/file/FileAction.java - src/share/classes/java/nio/file/spi/AbstractPath.java - src/share/classes/sun/io/ByteToCharMS932DB.java - src/share/classes/sun/io/CharToByteMS932DB.java - src/share/classes/sun/nio/cs/ext/EUC_CN.java - src/share/classes/sun/nio/cs/ext/EUC_KR.java - src/share/classes/sun/nio/cs/ext/GBK.java - src/share/classes/sun/nio/cs/ext/Johab.java - src/share/classes/sun/nio/cs/ext/MS932.java - src/share/classes/sun/nio/cs/ext/MS932DB.java - src/share/classes/sun/nio/cs/ext/MS936.java - src/share/classes/sun/nio/cs/ext/MS949.java - src/share/classes/sun/nio/cs/ext/MS950.java - src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java - src/share/classes/sun/nio/fs/MimeType.java - test/java/nio/file/DirectoryStream/Filters.java - test/java/nio/file/Files/content_type.sh - test/java/nio/file/Path/temporary_files.sh - test/java/nio/file/attribute/Attributes/Basic.java Changeset: a50217eb3ee1 Author: jqzuo Date: 2009-07-09 13:53 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a50217eb3ee1 Merge - src/share/classes/sun/swing/AccessibleMethod.java Changeset: 382a27aa78d3 Author: xdono Date: 2009-07-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/382a27aa78d3 Added tag jdk7-b64 for changeset a50217eb3ee1 ! .hgtags From john.coomes at sun.com Wed Jul 15 12:30:10 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Wed, 15 Jul 2009 19:30:10 +0000 Subject: hg: jdk7/hotspot/langtools: 25 new changesets Message-ID: <20090715193051.CA87FE1C0@hg.openjdk.java.net> Changeset: a9c04a57a39f Author: mcimadamore Date: 2009-06-16 10:45 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/a9c04a57a39f 6845686: basic and raw formatters do not display captured var id properly when javac runs in -XDoldDiags mode Summary: Basic and raw formatters do not override Printer methods properly Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! test/tools/javac/Diagnostics/6799605/T6799605.java ! test/tools/javac/Diagnostics/6799605/T6799605.out Changeset: 3d539f4123b8 Author: mcimadamore Date: 2009-06-16 10:45 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/3d539f4123b8 6835430: javac does not generate signature attributes for classes extending parameterized inner classes Summary: ClassWriter does not consider outer params of an inner class when emitting signature attributes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java + test/tools/javac/6835430/A.java + test/tools/javac/6835430/T6835430.java Changeset: 3ac205ad1f05 Author: mcimadamore Date: 2009-06-16 10:46 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/3ac205ad1f05 6835428: regression: return-type inference rejects valid code Summary: Redundant subtyping test during type-inference ends up in rejecting legal code Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/T6835428.java Changeset: 22872b24d38c Author: mcimadamore Date: 2009-06-16 10:46 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/22872b24d38c 6638712: Inference with wildcard types causes selection of inapplicable method Summary: Added global sanity check in order to make sure that return type inference does not violate bounds constraints Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/generics/inference/6302954/T6476073.java + test/tools/javac/generics/inference/6638712/T6638712a.java + test/tools/javac/generics/inference/6638712/T6638712a.out + test/tools/javac/generics/inference/6638712/T6638712b.java + test/tools/javac/generics/inference/6638712/T6638712b.out + test/tools/javac/generics/inference/6638712/T6638712c.java + test/tools/javac/generics/inference/6638712/T6638712c.out + test/tools/javac/generics/inference/6638712/T6638712d.java + test/tools/javac/generics/inference/6638712/T6638712d.out + test/tools/javac/generics/inference/6638712/T6638712e.java + test/tools/javac/generics/inference/6638712/T6638712e.out Changeset: ed989c347b3c Author: jjg Date: 2009-06-19 11:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/ed989c347b3c 6852856: javap changes to facilitate subclassing javap for variants Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/AccessFlags.java ! src/share/classes/com/sun/tools/classfile/ConstantPool.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! src/share/classes/com/sun/tools/javap/ConstantWriter.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/SourceWriter.java Changeset: fe077c71cd47 Author: tbell Date: 2009-06-23 22:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/fe077c71cd47 Merge Changeset: 18e0269f25e3 Author: mcimadamore Date: 2009-06-24 10:50 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/18e0269f25e3 6822637: ResolveError hierarchy needs to be refactored Summary: Break ResolveError class into a hierarchy representing different kinds of resolution errors Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java Changeset: 8ec37cf2b37e Author: mcimadamore Date: 2009-06-24 10:50 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/8ec37cf2b37e 6852595: Accessing scope using JSR199 API on erroneous tree causes Illegal Argument Exception Summary: Fixed problem with empty DiagnosticSource objects causing IAE in the JCDiagnostic constructor Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java + test/tools/javac/api/6852595/T6852595.java Changeset: 1d9e61e0a075 Author: mcimadamore Date: 2009-06-24 10:51 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/1d9e61e0a075 6852649: The Rich formatter printer should be an explicit class to facilitate overriding Summary: Improve reusabiliy of the rich formatter by removing anonymous inner classes/changing visibility of fields Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java Changeset: 812d5486a023 Author: tbell Date: 2009-06-24 17:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/812d5486a023 Merge Changeset: e71fd3fcebf5 Author: tbell Date: 2009-06-26 10:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/e71fd3fcebf5 Merge Changeset: ca063536e4a6 Author: darcy Date: 2009-06-26 12:22 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/ca063536e4a6 6593082: MirroredTypeException constructor does not throw NPE when type is null Reviewed-by: jjg ! src/share/classes/javax/lang/model/type/MirroredTypeException.java + test/tools/javac/processing/model/type/MirroredTypeEx/NpeTest.java Changeset: 03944ee4fac4 Author: jjg Date: 2009-06-26 18:51 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/03944ee4fac4 6843077: JSR 308: Annotations on types Reviewed-by: jjg, mcimadamore, darcy Contributed-by: mernst at cs.washington.edu, mali at csail.mit.edu, mpapi at csail.mit.edu ! src/share/bin/launcher.sh-template ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreePath.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/Names.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! test/tools/javac/6341866/T6341866.java ! test/tools/javac/processing/6348499/T6348499.java ! test/tools/javac/processing/6414633/T6414633.java ! test/tools/javac/processing/6430209/T6430209.java ! test/tools/javac/processing/T6439826.java Changeset: 664edca41e34 Author: jjg Date: 2009-06-26 19:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/664edca41e34 6855544: add missing files Reviewed-by: jjg, mcimadamore, darcy Contributed-by: mernst at cs.washington.edu, mali at csail.mit.edu, mpapi at csail.mit.edu + src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java + src/share/classes/com/sun/source/util/AbstractTypeProcessor.java + src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java + src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/javac/code/TargetType.java + src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java + test/tools/javac/api/TestTreePath.java + test/tools/javac/meth/InvokeMH_BAD68.java + test/tools/javac/meth/InvokeMH_BAD72.java + test/tools/javac/quid/QuotedIdent_BAD61.java + test/tools/javac/quid/QuotedIdent_BAD62.java + test/tools/javac/quid/QuotedIdent_BAD63.java + test/tools/javac/typeAnnotations/InnerClass.java + test/tools/javac/typeAnnotations/MultipleTargets.java + test/tools/javac/typeAnnotations/TypeParameterTarget.java + test/tools/javac/typeAnnotations/TypeUseTarget.java + test/tools/javac/typeAnnotations/attribution/Scopes.java + test/tools/javac/typeAnnotations/failures/AnnotationVersion.java + test/tools/javac/typeAnnotations/failures/AnnotationVersion.out + test/tools/javac/typeAnnotations/failures/IncompleteArray.java + test/tools/javac/typeAnnotations/failures/IncompleteArray.out + test/tools/javac/typeAnnotations/failures/IncompleteVararg.java + test/tools/javac/typeAnnotations/failures/IncompleteVararg.out + test/tools/javac/typeAnnotations/failures/IndexArray.java + test/tools/javac/typeAnnotations/failures/IndexArray.out + test/tools/javac/typeAnnotations/failures/LintCast.java + test/tools/javac/typeAnnotations/failures/LintCast.out + test/tools/javac/typeAnnotations/failures/OldArray.java + test/tools/javac/typeAnnotations/failures/OldArray.out + test/tools/javac/typeAnnotations/failures/Scopes.java + test/tools/javac/typeAnnotations/failures/Scopes.out + test/tools/javac/typeAnnotations/failures/StaticFields.java + test/tools/javac/typeAnnotations/failures/StaticFields.out + test/tools/javac/typeAnnotations/failures/StaticMethods.java + test/tools/javac/typeAnnotations/failures/StaticMethods.out + test/tools/javac/typeAnnotations/failures/VoidGenericMethod.java + test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/arrayclass/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/arrayclass/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/arrayclass/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/arrayclass/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/arrays/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/arrays/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/arrays/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/arrays/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/innertypeparams/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/innertypeparams/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/newarray/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/newarray/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/newarray/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/newarray/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/parambounds/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/parambounds/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/receiver/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/receiver/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/receiver/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/receiver/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/rest/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/rest/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/rest/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/rest/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/typeArgs/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/typeArgs/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/typeparams/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/typeparams/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.out + test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.java + test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.out + test/tools/javac/typeAnnotations/failures/common/wildcards/InvalidLocation.java + test/tools/javac/typeAnnotations/failures/common/wildcards/InvalidLocation.out + test/tools/javac/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.java + test/tools/javac/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.out + test/tools/javac/typeAnnotations/failures/target/Constructor.java + test/tools/javac/typeAnnotations/failures/target/Constructor.out + test/tools/javac/typeAnnotations/failures/target/IncompleteArray.java + test/tools/javac/typeAnnotations/failures/target/IncompleteArray.out + test/tools/javac/typeAnnotations/failures/target/NotTypeParameter.java + test/tools/javac/typeAnnotations/failures/target/NotTypeParameter.out + test/tools/javac/typeAnnotations/failures/target/NotTypeUse.java + test/tools/javac/typeAnnotations/failures/target/NotTypeUse.out + test/tools/javac/typeAnnotations/failures/target/VoidMethod.java + test/tools/javac/typeAnnotations/failures/target/VoidMethod.out + test/tools/javac/typeAnnotations/newlocations/BasicTest.java + test/tools/javac/typeAnnotations/newlocations/ClassExtends.java + test/tools/javac/typeAnnotations/newlocations/ClassLiterals.java + test/tools/javac/typeAnnotations/newlocations/ClassParameters.java + test/tools/javac/typeAnnotations/newlocations/ConstructorTypeArgs.java + test/tools/javac/typeAnnotations/newlocations/Expressions.java + test/tools/javac/typeAnnotations/newlocations/Fields.java + test/tools/javac/typeAnnotations/newlocations/LocalVariables.java + test/tools/javac/typeAnnotations/newlocations/MethodReturnType.java + test/tools/javac/typeAnnotations/newlocations/MethodTypeArgs.java + test/tools/javac/typeAnnotations/newlocations/MethodTypeParameters.java + test/tools/javac/typeAnnotations/newlocations/Parameters.java + test/tools/javac/typeAnnotations/newlocations/Receivers.java + test/tools/javac/typeAnnotations/newlocations/Throws.java + test/tools/javac/typeAnnotations/newlocations/TypeCasts.java + test/tools/javac/typeAnnotations/newlocations/TypeParameters.java + test/tools/javac/typeAnnotations/newlocations/Wildcards.java + test/tools/javap/typeAnnotations/ClassLiterals.java + test/tools/javap/typeAnnotations/JSR175Annotations.java + test/tools/javap/typeAnnotations/NewArray.java + test/tools/javap/typeAnnotations/Presence.java + test/tools/javap/typeAnnotations/PresenceInner.java + test/tools/javap/typeAnnotations/Visibility.java Changeset: 7c154fdc3547 Author: jjg Date: 2009-06-26 19:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/7c154fdc3547 6854796: update JSR308 impl with latest code from type-annotations repo Reviewed-by: jjg, mcimadamore, darcy Contributed-by: mernst at cs.washington.edu, mali at csail.mit.edu, mpapi at csail.mit.edu ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java Changeset: 464d58654324 Author: jjg Date: 2009-06-27 12:04 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/464d58654324 6855563: test broken after merge with latest parser Reviewed-by: jjg Contributed-by: mali at csail.mit.edu ! test/tools/javac/typeAnnotations/failures/OldArray.java - test/tools/javac/typeAnnotations/failures/OldArray.out Changeset: c391a167ac57 Author: tbell Date: 2009-06-28 00:01 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/c391a167ac57 Merge Changeset: 7913e72a24b0 Author: jjg Date: 2009-06-29 17:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/7913e72a24b0 6855993: fix comments in langtools launcher script Reviewed-by: ohair ! src/share/bin/launcher.sh-template Changeset: ec1acd3af057 Author: tbell Date: 2009-06-29 23:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/ec1acd3af057 Merge Changeset: 24374861f91e Author: tbell Date: 2009-07-03 09:16 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/24374861f91e Merge Changeset: e4a1c76c1abb Author: peterz Date: 2009-06-23 12:24 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/e4a1c76c1abb 6844273: jdk/make/docs/CORE_PKGS.gmk does not list Nimbus Reviewed-by: prr ! src/share/classes/com/sun/tools/javac/resources/legacy.properties Changeset: ddef2ef424d8 Author: yan Date: 2009-06-25 00:20 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/ddef2ef424d8 Merge - make/README - src/share/classes/sun/tools/javap/AttrData.java - src/share/classes/sun/tools/javap/CPX.java - src/share/classes/sun/tools/javap/CPX2.java - src/share/classes/sun/tools/javap/ClassData.java - src/share/classes/sun/tools/javap/Constants.java - src/share/classes/sun/tools/javap/FieldData.java - src/share/classes/sun/tools/javap/InnerClassData.java - src/share/classes/sun/tools/javap/JavapEnvironment.java - src/share/classes/sun/tools/javap/JavapPrinter.java - src/share/classes/sun/tools/javap/LineNumData.java - src/share/classes/sun/tools/javap/LocVarData.java - src/share/classes/sun/tools/javap/Main.java - src/share/classes/sun/tools/javap/MethodData.java - src/share/classes/sun/tools/javap/RuntimeConstants.java - src/share/classes/sun/tools/javap/StackMapData.java - src/share/classes/sun/tools/javap/StackMapTableData.java - src/share/classes/sun/tools/javap/Tables.java - src/share/classes/sun/tools/javap/TrapData.java - src/share/classes/sun/tools/javap/TypeSignature.java - test/tools/javac/code/ArrayClone.sh - test/tools/javap/ListTest.java - test/tools/javap/OptionTest.java Changeset: 09dc14c713f0 Author: yan Date: 2009-07-01 00:24 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/09dc14c713f0 Merge Changeset: d8f23a81d46f Author: yan Date: 2009-07-07 23:13 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/d8f23a81d46f Merge Changeset: 7e0056ded28c Author: xdono Date: 2009-07-13 14:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/7e0056ded28c Added tag jdk7-b64 for changeset d8f23a81d46f ! .hgtags From gustav.trede at gmail.com Wed Jul 15 13:07:35 2009 From: gustav.trede at gmail.com (gustav trede) Date: Wed, 15 Jul 2009 22:07:35 +0200 Subject: Math trig intrinsics and compiler options In-Reply-To: <924C32CF-2CD7-4BDF-91B7-9EB40FFC36FF@sun.com> References: <311e0eaf0907150543v5d877f55t3e6377b88ea43008@mail.gmail.com> <4A5DD7E9.8070904@Sun.COM> <311e0eaf0907150707i2606a040s8418872b22da46f5@mail.gmail.com> <924C32CF-2CD7-4BDF-91B7-9EB40FFC36FF@sun.com> Message-ID: <311e0eaf0907151307h68a0eebcw4522bc5476bc64b1@mail.gmail.com> 2009/7/15 Tom Rodriguez > Thats how i interpret the difference too, and correct me if im wrong but >> the rounding is only needed for the strictmath to get its platform >> independent exact results and not for Math ?. >> > > StrictMath requires exact answers for all of these routines and the intel > instructions don't have adequate accuracy to be used for them. The regular > Math routines have some freedom to differ from the strict implementation but > they can't be arbitrarily bad and the rounding logic that wraps the > instructions ensures that we get back valid values outside the range where > those instructions return reasonable answers. Check out > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4345903. > > As far as why sharedRuntimeTrig.cpp disables compiler optimizations, these > functions are from fdlibm and require very precise fp semantics which are > generally violated by the optimizers in most compilers. If you turn on > optimizations then these routines won't return the right answer anymore. > > tom > sharedRuntimeTrig.cpp seems to be ieee754 and should provide the needed precision for math or is there any documented empirical evidence or test cases that will break if the rounding is not in place for the trig methods in Math and hence violates the 1 ulp and semi monotonic spec for cos and sin ? If such test case exists, how do i get hold of it ?. It would make testing of current compiler optimization status easier too. I assume there is good test cases for this in the JCK, but its not available for mortal people.. regards gustav trede -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20090715/8d63ff8f/attachment.html From Tim.Bell at Sun.COM Wed Jul 15 13:15:20 2009 From: Tim.Bell at Sun.COM (Tim Bell) Date: Wed, 15 Jul 2009 13:15:20 -0700 Subject: Math trig intrinsics and compiler options In-Reply-To: <311e0eaf0907151307h68a0eebcw4522bc5476bc64b1@mail.gmail.com> References: <311e0eaf0907150543v5d877f55t3e6377b88ea43008@mail.gmail.com> <4A5DD7E9.8070904@Sun.COM> <311e0eaf0907150707i2606a040s8418872b22da46f5@mail.gmail.com> <924C32CF-2CD7-4BDF-91B7-9EB40FFC36FF@sun.com> <311e0eaf0907151307h68a0eebcw4522bc5476bc64b1@mail.gmail.com> Message-ID: <4A5E38D8.5020601@sun.com> gustav trede wrote: > If such test case exists, how do i get hold of it ?. > It would make testing of current compiler optimization status easier too. You could start with the open source Math and StrictMath tests in the jdk repository: jdk/test/java/lang/Math/* jdk/test/java/lang/StrictMath/* These tests might make interesting reading: jdk/test/java/math/BigDecimal/* HTH- Tim From gnu_andrew at member.fsf.org Wed Jul 15 13:23:22 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Wed, 15 Jul 2009 21:23:22 +0100 Subject: Switching to HotSpot 14 on OpenJDK6 Message-ID: <17c6771e0907151323q1725f046laf0182502f75a22e@mail.gmail.com> We discussed this a while back, but discussions seem to have come to a halt. Using the rebase extension to hg, I've succeeded in producing a version of the OpenJDK6 repository based on the same 0 revision as the hs14 master: http://fuseyism.com/hg/hotspot This means that pulls from the hs14 master can be used to update this repository, which isn't the case with the current OpenJDK6 repository as they have no common parent. However, unlike hs14, it does include all the history and fixes from OpenJDK6 (some of which don't seem to have made the HS7 repos, such as deleting binary jar files). Does this look ok? If so, can someone with ssh access to hg.openjdk.java.net please replace the current hotspot repository with this one, so we can update it to the current hs14 revision and add any other pending changes? It would be nice to finally let HotSpot development in OpenJDK6 move on! Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From John.Coomes at sun.com Wed Jul 15 14:25:57 2009 From: John.Coomes at sun.com (John Coomes) Date: Wed, 15 Jul 2009 14:25:57 -0700 Subject: Review request: Zero assembler port In-Reply-To: <20090715135745.GB3179@redhat.com> References: <20090715135745.GB3179@redhat.com> Message-ID: <19038.18789.410774.774181@sun.com> Gary Benson (gbenson at redhat.com) wrote: > Hi all, > > Zero is an interpreter-only port of HotSpot that uses no assembler and > can trivially be built on any Linux system. The following webrev adds > Zero support to OpenJDK: > > http://cr.openjdk.java.net/~gbenson/zero-03/ > ... I started to take a look, but there's something strange with the webrev. A dozen or more files have 0 lines changed, and some other files are listed because you are not in sync with the parent repo. The latter is easy to fix; compare against a parent repo that you control and make sure you're completely up to date. Not sure about the former. Looks like all the files with 0 lines changed show "rev 831" while the others show rev 830. Maybe comparing against your own parent repo will fix those also. -John From Joe.Darcy at Sun.COM Wed Jul 15 15:07:22 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Wed, 15 Jul 2009 15:07:22 -0700 Subject: Math trig intrinsics and compiler options In-Reply-To: <311e0eaf0907151307h68a0eebcw4522bc5476bc64b1@mail.gmail.com> References: <311e0eaf0907150543v5d877f55t3e6377b88ea43008@mail.gmail.com> <4A5DD7E9.8070904@Sun.COM> <311e0eaf0907150707i2606a040s8418872b22da46f5@mail.gmail.com> <924C32CF-2CD7-4BDF-91B7-9EB40FFC36FF@sun.com> <311e0eaf0907151307h68a0eebcw4522bc5476bc64b1@mail.gmail.com> Message-ID: <4A5E531A.9040206@sun.com> gustav trede wrote: > > 2009/7/15 Tom Rodriguez > > > Thats how i interpret the difference too, and correct me if im > wrong but the rounding is only needed for the strictmath to > get its platform independent exact results and not for Math ?. > > > StrictMath requires exact answers for all of these routines and > the intel instructions don't have adequate accuracy to be used for > them. The regular Math routines have some freedom to differ from > the strict implementation but they can't be arbitrarily bad and > the rounding logic that wraps the instructions ensures that we get > back valid values outside the range where those instructions > return reasonable answers. Check out > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4345903. > > As far as why sharedRuntimeTrig.cpp disables compiler > optimizations, these functions are from fdlibm and require very > precise fp semantics which are generally violated by the > optimizers in most compilers. If you turn on optimizations then > these routines won't return the right answer anymore. > > tom > > > sharedRuntimeTrig.cpp seems to be ieee754 and should provide the > needed precision for math or IEEE 754 is not the governing standard here; the javadoc for java.lang.Math is. > is there any documented empirical evidence or test cases that will > break if the rounding is not in place for the trig methods in Math and > hence violates the 1 ulp and semi monotonic spec for cos and sin ? As a general comment, accepting a change unless it has been demonstrated to be faulty is not our engineering approach in the JDK; a change must present evidence it is good. And yes, the raw fsin/fcos instructions are known to not implement the specified semantics of java.lang.Math's sin and cos methods (except on the amd k5 where fsin/fcos could be used on the whole, IIRC, [-2^64, 2^64] range the instructions are defined to work). As Tim already suggested, look at the regression tests under jdk/test/java/lang/Math. Even just looking at sin(Math.PI) will reveal whether proper argument reduction is being done. -Joe > > If such test case exists, how do i get hold of it ?. > It would make testing of current compiler optimization status easier too. > > I assume there is good test cases for this in the JCK, but its not > available for mortal people.. > > > regards > gustav trede > > From gustav.trede at gmail.com Wed Jul 15 15:09:47 2009 From: gustav.trede at gmail.com (gustav trede) Date: Thu, 16 Jul 2009 00:09:47 +0200 Subject: Math trig intrinsics and compiler options In-Reply-To: <4A5E38D8.5020601@sun.com> References: <311e0eaf0907150543v5d877f55t3e6377b88ea43008@mail.gmail.com> <4A5DD7E9.8070904@Sun.COM> <311e0eaf0907150707i2606a040s8418872b22da46f5@mail.gmail.com> <924C32CF-2CD7-4BDF-91B7-9EB40FFC36FF@sun.com> <311e0eaf0907151307h68a0eebcw4522bc5476bc64b1@mail.gmail.com> <4A5E38D8.5020601@sun.com> Message-ID: <311e0eaf0907151509o39e9bf8lb76737e8b67076a6@mail.gmail.com> 2009/7/15 Tim Bell > gustav trede wrote: > > > If such test case exists, how do i get hold of it ?. > > It would make testing of current compiler optimization status easier too. > > You could start with the open source Math and StrictMath tests in the jdk > repository: > > jdk/test/java/lang/Math/* > jdk/test/java/lang/StrictMath/* > > These tests might make interesting reading: > > jdk/test/java/math/BigDecimal/* > > > HTH- > Tim > I have already looked for Math cos and sin specific tests in the opendjk, grep -RH --include '*' 'cos' * and i did not find it. i only find calls to those methods as part of other, non math tests. Several other trig methods do have some kind of tests in test/java/lang/Math , jdk/test/java/lang/StrictMath Those completes successfully with this patch applied. Azeem Jiva , a former hotspot developer that implemented some of the trig intrinsics did propose this patch to me along with stating that to hes (old) knowledge there should be no precision problems for math trig without the rounding. - Thanks for all of yours time, trying to help and guide me. gustav trede -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20090716/06f78537/attachment.html From gnu_andrew at member.fsf.org Wed Jul 15 16:06:03 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 16 Jul 2009 00:06:03 +0100 Subject: Review request: Zero assembler port In-Reply-To: <19038.18789.410774.774181@sun.com> References: <20090715135745.GB3179@redhat.com> <19038.18789.410774.774181@sun.com> Message-ID: <17c6771e0907151606h4f96190dj7d00cc10b5e3995@mail.gmail.com> 2009/7/15 John Coomes : > Gary Benson (gbenson at redhat.com) wrote: >> Hi all, >> >> Zero is an interpreter-only port of HotSpot that uses no assembler and >> can trivially be built on any Linux system. ?The following webrev adds >> Zero support to OpenJDK: >> >> ? http://cr.openjdk.java.net/~gbenson/zero-03/ >> ... > > I started to take a look, but there's something strange with the > webrev. ?A dozen or more files have 0 lines changed, and some other > files are listed because you are not in sync with the parent repo. > > The latter is easy to fix; compare against a parent repo that you > control and make sure you're completely up to date. > > Not sure about the former. ?Looks like all the files with 0 lines > changed show "rev 831" while the others show rev 830. ?Maybe comparing > against your own parent repo will fix those also. > > -John > > Hi John, I also noticed that the patch didn't apply cleanly when I tried it. On Gary's behalf, here's an alternate webrev against OpenJDK7 b64 that doesn't seem to have these issues: http://fuseyism.com/zero/webrev.01/ (sniff, cr is still not working for me it seems...) -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From John.Coomes at sun.com Wed Jul 15 16:30:52 2009 From: John.Coomes at sun.com (John Coomes) Date: Wed, 15 Jul 2009 16:30:52 -0700 Subject: Review request: Zero assembler port In-Reply-To: <17c6771e0907151606h4f96190dj7d00cc10b5e3995@mail.gmail.com> References: <20090715135745.GB3179@redhat.com> <19038.18789.410774.774181@sun.com> <17c6771e0907151606h4f96190dj7d00cc10b5e3995@mail.gmail.com> Message-ID: <19038.26284.704540.418526@sun.com> Andrew John Hughes (gnu_andrew at member.fsf.org) wrote: > 2009/7/15 John Coomes : > > Gary Benson (gbenson at redhat.com) wrote: > >> Hi all, > >> > >> Zero is an interpreter-only port of HotSpot that uses no assembler and > >> can trivially be built on any Linux system. ??The following webrev adds > >> Zero support to OpenJDK: > >> > >> ?? http://cr.openjdk.java.net/~gbenson/zero-03/ > >> ... > > > > I started to take a look, but there's something strange with the > > webrev. ??A dozen or more files have 0 lines changed, and some other > > files are listed because you are not in sync with the parent repo. > > > > The latter is easy to fix; compare against a parent repo that you > > control and make sure you're completely up to date. > > > > Not sure about the former. ??Looks like all the files with 0 lines > > changed show "rev 831" while the others show rev 830. ??Maybe comparing > > against your own parent repo will fix those also. > > > > Hi John, > > I also noticed that the patch didn't apply cleanly when I tried it. > On Gary's behalf, here's an alternate webrev against OpenJDK7 b64 that > doesn't seem to have these issues: > > http://fuseyism.com/zero/webrev.01/ Hi Andrew, This doesn't include any of the new zero files, e.g., hotspot/src/cpu/zero/vm/assembler_zero.hpp. That might be explained if you generated this from a repo after applying the patch from the original webrev. I think Gary will have to get to the bottom of this. -John From gnu_andrew at member.fsf.org Wed Jul 15 17:00:03 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 16 Jul 2009 01:00:03 +0100 Subject: Review request: Zero assembler port In-Reply-To: <19038.26284.704540.418526@sun.com> References: <20090715135745.GB3179@redhat.com> <19038.18789.410774.774181@sun.com> <17c6771e0907151606h4f96190dj7d00cc10b5e3995@mail.gmail.com> <19038.26284.704540.418526@sun.com> Message-ID: <17c6771e0907151700g5b27a207r136a1e431199b7b5@mail.gmail.com> 2009/7/16 John Coomes : > Andrew John Hughes (gnu_andrew at member.fsf.org) wrote: >> 2009/7/15 John Coomes : >> > Gary Benson (gbenson at redhat.com) wrote: >> >> Hi all, >> >> >> >> Zero is an interpreter-only port of HotSpot that uses no assembler and >> >> can trivially be built on any Linux system. ??The following webrev adds >> >> Zero support to OpenJDK: >> >> >> >> ?? http://cr.openjdk.java.net/~gbenson/zero-03/ >> >> ... >> > >> > I started to take a look, but there's something strange with the >> > webrev. ??A dozen or more files have 0 lines changed, and some other >> > files are listed because you are not in sync with the parent repo. >> > >> > The latter is easy to fix; compare against a parent repo that you >> > control and make sure you're completely up to date. >> > >> > Not sure about the former. ??Looks like all the files with 0 lines >> > changed show "rev 831" while the others show rev 830. ??Maybe comparing >> > against your own parent repo will fix those also. >> > >> >> Hi John, >> >> I also noticed that the patch didn't apply cleanly when I tried it. >> On Gary's behalf, here's an alternate webrev against OpenJDK7 b64 that >> doesn't seem to have these issues: >> >> http://fuseyism.com/zero/webrev.01/ > > Hi Andrew, > > This doesn't include any of the new zero files, e.g., > hotspot/src/cpu/zero/vm/assembler_zero.hpp. ?That might be explained > if you generated this from a repo after applying the patch from the > original webrev. ?I think Gary will have to get to the bottom of this. > > -John > > Sorry, I of course applied the patch but forgot to hg add the new files. A revised version will be available shortly from http://fuseyism.com/zero/webrev.02/ -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From gbenson at redhat.com Thu Jul 16 03:15:04 2009 From: gbenson at redhat.com (Gary Benson) Date: Thu, 16 Jul 2009 11:15:04 +0100 Subject: Review request: Zero assembler port In-Reply-To: <19038.18789.410774.774181@sun.com> References: <20090715135745.GB3179@redhat.com> <19038.18789.410774.774181@sun.com> Message-ID: <20090716101503.GB3177@redhat.com> John Coomes wrote: > Gary Benson (gbenson at redhat.com) wrote: > > Zero is an interpreter-only port of HotSpot that uses no assembler > > and can trivially be built on any Linux system. The following > > webrev adds Zero support to OpenJDK: > > > > http://cr.openjdk.java.net/~gbenson/zero-03/ > > ... > > I started to take a look, but there's something strange with the > webrev. A dozen or more files have 0 lines changed, and some other > files are listed because you are not in sync with the parent repo. > > The latter is easy to fix; compare against a parent repo that you > control and make sure you're completely up to date. > > Not sure about the former. Looks like all the files with 0 lines > changed show "rev 831" while the others show rev 830. Maybe > comparing against your own parent repo will fix those also. Sorry about that. This is my first submission using webrev, so I'm figuring it out as I go along. An updated webrev is here: http://cr.openjdk.java.net/~gbenson/zero-05/ Hopefully I got it right this time! Cheers, Gary -- http://gbenson.net/ From gbenson at redhat.com Thu Jul 16 03:29:53 2009 From: gbenson at redhat.com (Gary Benson) Date: Thu, 16 Jul 2009 11:29:53 +0100 Subject: Review request: Zero assembler port In-Reply-To: <20090715135745.GB3179@redhat.com> References: <20090715135745.GB3179@redhat.com> Message-ID: <20090716102953.GC3177@redhat.com> Hi all, I had an email this morning from someone whose build was breaking because of unset environment variables so I wanted to mail a small clarification. * To build Zero there are nine environment variables that need setting before make runs: CORE_BUILD ZERO_BUILD ZERO_LIBARCH ZERO_ARCHDEF ZERO_ENDIANNESS ZERO_BITSPERWORD ZERO_ARCHFLAG LIBFFI_CFLAGS LIBFFI_LIBS * If you are using jdk/make/jdk_generic_profile.sh then all but the first two will be set for you. You would build like this: export CORE_BUILD=true export ZERO_BUILD=true . jdk/make/jdk_generic_profile.sh make * If you are not using jdk/make/jdk_generic_profile.sh then you must set all nine yourself. Cheers, Gary Gary Benson wrote: > Hi all, > > Zero is an interpreter-only port of HotSpot that uses no assembler and > can trivially be built on any Linux system. The following webrev adds > Zero support to OpenJDK: > > http://cr.openjdk.java.net/~gbenson/zero-03/ > > In order to enable the Zero build, the following environment variables > must be set: > > CORE_BUILD > Setting CORE_BUILD to "true" will result in an interpreter-only > HotSpot being built, with neither the client nor the server > compilers. If CORE_BUILD is unset, or set to any other value > than "true", then the compiler(s) will be built as normal. > > ZERO_BUILD > Setting ZERO_BUILD to "true" will cause the Zero interpreter to > be used. If ZERO_BUILD is unset, or set to any other value than > "true", the standard, platform-specific interpreter will be used. > > The reason for having two separate flags is to allow for Zero builds > with JIT compilers such as Shark (not included in this webrev). To > build HotSpot with Zero and Shark you would set ZERO_BUILD to "true" > but leave CORE_BUILD unset. > > There are five variables which are required when ZERO_BUILD is set to > "true". These are set by jdk/make/jdk_generic_profile.sh based on the > result of uname -m: > > ZERO_LIBARCH > This is the name of the architecture-specific subdirectory under > $JAVA_HOME/jre/lib. Typically this will be the same as the output > of uname -m, although there are some exceptions: "amd64" instead > of "x86_64", for example, and "i386" instead of "i686". > > ZERO_ARCHDEF > The value of ZERO_ARCHDEF will be passed to the C++ compiler using > -D${ZERO_ARCHDEF} to allow conditionalized platform-specific code. > This is typically set to ZERO_LIBARCH converted to uppercase but, > again, there are exceptions. "i386" becomes "IA32", to match what > HotSpot already does, and on platforms with both 32- and 64-bit > variants ZERO_ARCHDEF corresponds to the 32-bit version, so both > ppc and ppc64 have ZERO_ARCHDEF set to "PPC". > > ZERO_ENDIANNESS > This is set to "little" or "big". > > ZERO_BITSPERWORD > This is set to "32" or "64". > > ZERO_ARCHFLAG > This is a flag that will be passed to the C++ compiler and to the > linker to instruct them to generate code for the particular > platform. This is required for platforms with both 32- and 64-bit > variants where the compiler needs to be told which variant to > build for. ZERO_ARCHFLAG will typically be set to "-m32" or > "-m64", except on 31-bit zSeries where it will be set to "-m31". > > Zero uses one external library, libffi, for JNI method invocation. > The following two variables are used to tell the compiler and linker > how to find libffi. These can be set by the user, but if left unset > then jdk/make/jdk_generic_profile.sh will attempt to set them using > pkg-config: > > LIBFFI_CFLAGS > Flags to be passed to the C++ compiler to build against libffi. > > LIBFFI_LIBS > Flags to be passed to the linker to link against libffi. > > Ok, I think that's it! > > Cheers, > Gary > > -- > http://gbenson.net/ From Christian.Thalinger at Sun.COM Thu Jul 16 04:26:47 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Thu, 16 Jul 2009 13:26:47 +0200 Subject: Math trig intrinsics and compiler options In-Reply-To: <4A5E0AA0.4080306@sun.com> References: <311e0eaf0907150543v5d877f55t3e6377b88ea43008@mail.gmail.com> <4A5DD7E9.8070904@Sun.COM> <4A5E0AA0.4080306@sun.com> Message-ID: <4A5F0E77.6080304@Sun.COM> Joseph D. Darcy wrote: > Christian Thalinger wrote: >> gustav trede wrote: >> >>> Hello, >>> >>> Azeem Jiva told me an easy way to improve trig performance. >>> Changing the intrinsics to use an existing but faster path gives me a >>> boost of roughly 40% for the Math cos and sin on solaris x64. >>> >>> >>> library_call.cpp >>> >>> bool LibraryCallKit::inline_math_ >>> native(vmIntrinsics::ID id) { >>> switch (id) { >>> >>> case vmIntrinsics::_dcos: return Matcher::has_match_rule(Op_CosD) ? >>> runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >>> SharedRuntime::dcos), "COS") : false; >>> case vmIntrinsics::_dsin: return Matcher::has_match_rule(Op_SinD) ? >>> runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >>> SharedRuntime::dsin), "SIN") : false; >>> case vmIntrinsics::_dtan: return Matcher::has_match_rule(Op_TanD) ? >>> runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >>> SharedRuntime::dtan), "TAN") : false; >>> case vmIntrinsics::_dlog: return Matcher::has_match_rule(Op_LogD) ? >>> runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >>> SharedRuntime::dlog), "LOG") : false; >>> case vmIntrinsics::_dlog10: return Matcher::has_match_rule(Op_Log10D) >>> ? runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >>> SharedRuntime::dlog10), "LOG10") : false; >>> >>> >>> Is there any potential problem with such a patch ? >>> >> I'm not sure I understand this "patch". Why should the code above be >> faster than the current code in HotSpot, which tries to inline the >> trigonometric functions? Maybe the speedup you're seeing is because of >> the missing fast/slow path check and you are always using the slow path >> because of rounding? Just a guess... >> > > Hello. > > Can you explain the nature of the selection difference? It seems all boils down to: // Check: If PI/4 < abs(arg) then go slow As also explained in CR 4345903: The solution is to have the Math.{sin, cos} do their own argument reduction to [-pi/4, pi/4] and then call fsin/fcos; this will guarantee the specified accuracy and monotonicity properties. > > Better semantics are provided if the instrinsified versions of sin, cos, > etc. are always used to implement the java.lang.Math flavor of those > methods. -- Christian From vikram.account at gmail.com Thu Jul 16 04:47:08 2009 From: vikram.account at gmail.com (Vikram A) Date: Thu, 16 Jul 2009 17:17:08 +0530 Subject: Review request: Zero assembler port In-Reply-To: <20090716101503.GB3177@redhat.com> References: <20090715135745.GB3179@redhat.com> <19038.18789.410774.774181@sun.com> <20090716101503.GB3177@redhat.com> Message-ID: <10ffa8f60907160447q80e38ch2ddd32d734392714@mail.gmail.com> hi, Some files (these and few more) ------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/interp_masm_zero.cpp 24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg ------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/templateInterpreter_zero.cpp 24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg ------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/templateInterpreter_zero.hpp 24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg ------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/templateTable_zero.cpp 24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg still show only the copyright header, no source code. some have only 4 lines of code. is that what you wanted. rgds. On Thu, Jul 16, 2009 at 3:45 PM, Gary Benson wrote: > John Coomes wrote: >> Gary Benson (gbenson at redhat.com) wrote: >> > Zero is an interpreter-only port of HotSpot that uses no assembler >> > and can trivially be built on any Linux system. ?The following >> > webrev adds Zero support to OpenJDK: >> > >> > ? http://cr.openjdk.java.net/~gbenson/zero-03/ >> > ... >> >> I started to take a look, but there's something strange with the >> webrev. ?A dozen or more files have 0 lines changed, and some other >> files are listed because you are not in sync with the parent repo. >> >> The latter is easy to fix; compare against a parent repo that you >> control and make sure you're completely up to date. >> >> Not sure about the former. ?Looks like all the files with 0 lines >> changed show "rev 831" while the others show rev 830. ?Maybe >> comparing against your own parent repo will fix those also. > > Sorry about that. ?This is my first submission using webrev, so I'm > figuring it out as I go along. ?An updated webrev is here: > > ?http://cr.openjdk.java.net/~gbenson/zero-05/ > > Hopefully I got it right this time! > > Cheers, > Gary > > -- > http://gbenson.net/ > From gnu_andrew at member.fsf.org Thu Jul 16 04:57:30 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 16 Jul 2009 12:57:30 +0100 Subject: Review request: Zero assembler port In-Reply-To: <10ffa8f60907160447q80e38ch2ddd32d734392714@mail.gmail.com> References: <20090715135745.GB3179@redhat.com> <19038.18789.410774.774181@sun.com> <20090716101503.GB3177@redhat.com> <10ffa8f60907160447q80e38ch2ddd32d734392714@mail.gmail.com> Message-ID: <17c6771e0907160457r56abb506s79ad478e8f97e92b@mail.gmail.com> 2009/7/16 Vikram A : > hi, > > Some files (these and few more) > ?------ ------ ------ ------ --- New Patch Raw > hotspot/src/cpu/zero/vm/interp_masm_zero.cpp > ? ?24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg > ?------ ------ ------ ------ --- New Patch Raw > hotspot/src/cpu/zero/vm/templateInterpreter_zero.cpp > ? ?24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg > ------ ------ ------ ------ --- New Patch Raw > hotspot/src/cpu/zero/vm/templateInterpreter_zero.hpp > ? ?24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg > ------ ------ ------ ------ --- New Patch Raw > hotspot/src/cpu/zero/vm/templateTable_zero.cpp > ? ?24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg > > still show only the copyright header, no source code. > some have only 4 lines of code. is that what you wanted. > > rgds. > ------ ------ ------ ------ --- New Patch Raw hotspot/src/cpu/zero/vm/interp_masm_zero.hpp 34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg >From my version at http://fuseyism.com/zero/webrev.02/ -- there is code in that version. > > On Thu, Jul 16, 2009 at 3:45 PM, Gary Benson wrote: >> John Coomes wrote: >>> Gary Benson (gbenson at redhat.com) wrote: >>> > Zero is an interpreter-only port of HotSpot that uses no assembler >>> > and can trivially be built on any Linux system. ?The following >>> > webrev adds Zero support to OpenJDK: >>> > >>> > ? http://cr.openjdk.java.net/~gbenson/zero-03/ >>> > ... >>> >>> I started to take a look, but there's something strange with the >>> webrev. ?A dozen or more files have 0 lines changed, and some other >>> files are listed because you are not in sync with the parent repo. >>> >>> The latter is easy to fix; compare against a parent repo that you >>> control and make sure you're completely up to date. >>> >>> Not sure about the former. ?Looks like all the files with 0 lines >>> changed show "rev 831" while the others show rev 830. ?Maybe >>> comparing against your own parent repo will fix those also. >> >> Sorry about that. ?This is my first submission using webrev, so I'm >> figuring it out as I go along. ?An updated webrev is here: >> >> ?http://cr.openjdk.java.net/~gbenson/zero-05/ >> >> Hopefully I got it right this time! >> >> Cheers, >> Gary >> >> -- >> http://gbenson.net/ >> > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From gbenson at redhat.com Thu Jul 16 05:19:54 2009 From: gbenson at redhat.com (Gary Benson) Date: Thu, 16 Jul 2009 13:19:54 +0100 Subject: Review request: Zero assembler port In-Reply-To: <10ffa8f60907160447q80e38ch2ddd32d734392714@mail.gmail.com> References: <20090715135745.GB3179@redhat.com> <19038.18789.410774.774181@sun.com> <20090716101503.GB3177@redhat.com> <10ffa8f60907160447q80e38ch2ddd32d734392714@mail.gmail.com> Message-ID: <20090716121954.GE3177@redhat.com> Hi Vikram, Vikram A wrote: > Some files (these and few more) > ------ ------ ------ ------ --- New Patch Raw > hotspot/src/cpu/zero/vm/interp_masm_zero.cpp > 24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg > ------ ------ ------ ------ --- New Patch Raw > hotspot/src/cpu/zero/vm/templateInterpreter_zero.cpp > 24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg > ------ ------ ------ ------ --- New Patch Raw > hotspot/src/cpu/zero/vm/templateInterpreter_zero.hpp > 24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg > ------ ------ ------ ------ --- New Patch Raw > hotspot/src/cpu/zero/vm/templateTable_zero.cpp > 24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg > > still show only the copyright header, no source code. > some have only 4 lines of code. is that what you wanted. Yes, that's correct. The files are there because the includeDB lists them, so the build system expects them to be present, but they don't contain anything. In the IcedTea version of Zero these files are empty -- they don't even contain the copyright header -- but patch won't create empty files so the webrev ended up unbuildable. Cheers, Gary -- http://gbenson.net/ From gbenson at redhat.com Thu Jul 16 05:22:11 2009 From: gbenson at redhat.com (Gary Benson) Date: Thu, 16 Jul 2009 13:22:11 +0100 Subject: Review request: Zero assembler port In-Reply-To: <17c6771e0907160457r56abb506s79ad478e8f97e92b@mail.gmail.com> References: <20090715135745.GB3179@redhat.com> <19038.18789.410774.774181@sun.com> <20090716101503.GB3177@redhat.com> <10ffa8f60907160447q80e38ch2ddd32d734392714@mail.gmail.com> <17c6771e0907160457r56abb506s79ad478e8f97e92b@mail.gmail.com> Message-ID: <20090716122211.GF3177@redhat.com> Andrew John Hughes wrote: > 2009/7/16 Vikram A : > > Some files (these and few more) > > ?------ ------ ------ ------ --- New Patch Raw > > hotspot/src/cpu/zero/vm/interp_masm_zero.cpp > > ? ?24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg > > ?------ ------ ------ ------ --- New Patch Raw > > hotspot/src/cpu/zero/vm/templateInterpreter_zero.cpp > > ? ?24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg > > ------ ------ ------ ------ --- New Patch Raw > > hotspot/src/cpu/zero/vm/templateInterpreter_zero.hpp > > ? ?24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg > > ------ ------ ------ ------ --- New Patch Raw > > hotspot/src/cpu/zero/vm/templateTable_zero.cpp > > ? ?24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg > > > > still show only the copyright header, no source code. > > some have only 4 lines of code. is that what you wanted. > > > > rgds. > > > > ------ ------ ------ ------ --- New Patch Raw > hotspot/src/cpu/zero/vm/interp_masm_zero.hpp > > 34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg > > From my version at http://fuseyism.com/zero/webrev.02/ -- there is > code in that version. You're looking at the .hpp file, Vikram listed the .cpp. Cheers, Gary -- http://gbenson.net/ From gnu_andrew at member.fsf.org Thu Jul 16 05:26:04 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 16 Jul 2009 13:26:04 +0100 Subject: Review request: Zero assembler port In-Reply-To: <20090716122211.GF3177@redhat.com> References: <20090715135745.GB3179@redhat.com> <19038.18789.410774.774181@sun.com> <20090716101503.GB3177@redhat.com> <10ffa8f60907160447q80e38ch2ddd32d734392714@mail.gmail.com> <17c6771e0907160457r56abb506s79ad478e8f97e92b@mail.gmail.com> <20090716122211.GF3177@redhat.com> Message-ID: <17c6771e0907160526m16cb172br42da6da4b0f440bf@mail.gmail.com> 2009/7/16 Gary Benson : > Andrew John Hughes wrote: >> 2009/7/16 Vikram A : >> > Some files (these and few more) >> > ?------ ------ ------ ------ --- New Patch Raw >> > hotspot/src/cpu/zero/vm/interp_masm_zero.cpp >> > ? ?24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg >> > ?------ ------ ------ ------ --- New Patch Raw >> > hotspot/src/cpu/zero/vm/templateInterpreter_zero.cpp >> > ? ?24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg >> > ------ ------ ------ ------ --- New Patch Raw >> > hotspot/src/cpu/zero/vm/templateInterpreter_zero.hpp >> > ? ?24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg >> > ------ ------ ------ ------ --- New Patch Raw >> > hotspot/src/cpu/zero/vm/templateTable_zero.cpp >> > ? ?24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg >> > >> > still show only the copyright header, no source code. >> > some have only 4 lines of code. is that what you wanted. >> > >> > rgds. >> > >> >> ?------ ------ ------ ------ --- New Patch Raw >> hotspot/src/cpu/zero/vm/interp_masm_zero.hpp >> >> ? ? 34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg >> >> From my version at http://fuseyism.com/zero/webrev.02/ -- there is >> code in that version. > > You're looking at the .hpp file, Vikram listed the .cpp. > > Cheers, > Gary > > -- > http://gbenson.net/ > Ok that's because there isn't a cpp in the webrev, presumably because, as you said, it's empty. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From gbenson at redhat.com Thu Jul 16 06:29:02 2009 From: gbenson at redhat.com (Gary Benson) Date: Thu, 16 Jul 2009 14:29:02 +0100 Subject: Review request: Zero assembler port In-Reply-To: <20090715135745.GB3179@redhat.com> References: <20090715135745.GB3179@redhat.com> Message-ID: <20090716132902.GG3177@redhat.com> Gary Benson wrote: > Zero uses one external library, libffi, for JNI method invocation. > The following two variables are used to tell the compiler and linker > how to find libffi. These can be set by the user, but if left unset > then jdk/make/jdk_generic_profile.sh will attempt to set them using > pkg-config: > > LIBFFI_CFLAGS > Flags to be passed to the C++ compiler to build against libffi. > > LIBFFI_LIBS > Flags to be passed to the linker to link against libffi. It turns out that Gentoo builds libffi without the pkg-config stuff. The following webrev has a modified jdk/make/jdk_generic_profile.sh that adds default values to these two (LIBFFI_CFLAGS="" and LIBFFI_LIBS="-lffi") to work with Gentoo (and any other distributions that don't pkg-config libffi): http://cr.openjdk.java.net/~gbenson/zero-06/ Cheers, Gary -- http://gbenson.net/ From Christian.Thalinger at Sun.COM Thu Jul 16 06:34:40 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Thu, 16 Jul 2009 15:34:40 +0200 Subject: Review request: Zero assembler port In-Reply-To: <20090716121954.GE3177@redhat.com> References: <20090715135745.GB3179@redhat.com> <19038.18789.410774.774181@sun.com> <20090716101503.GB3177@redhat.com> <10ffa8f60907160447q80e38ch2ddd32d734392714@mail.gmail.com> <20090716121954.GE3177@redhat.com> Message-ID: <4A5F2C70.8010904@Sun.COM> Gary Benson wrote: > Hi Vikram, > > Vikram A wrote: >> Some files (these and few more) >> ------ ------ ------ ------ --- New Patch Raw >> hotspot/src/cpu/zero/vm/interp_masm_zero.cpp >> 24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg >> ------ ------ ------ ------ --- New Patch Raw >> hotspot/src/cpu/zero/vm/templateInterpreter_zero.cpp >> 24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg >> ------ ------ ------ ------ --- New Patch Raw >> hotspot/src/cpu/zero/vm/templateInterpreter_zero.hpp >> 24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg >> ------ ------ ------ ------ --- New Patch Raw >> hotspot/src/cpu/zero/vm/templateTable_zero.cpp >> 24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg >> >> still show only the copyright header, no source code. >> some have only 4 lines of code. is that what you wanted. > > Yes, that's correct. The files are there because the includeDB lists > them, so the build system expects them to be present, but they don't > contain anything. In the IcedTea version of Zero these files are > empty -- they don't even contain the copyright header -- but patch > won't create empty files so the webrev ended up unbuildable. Maybe you should add a comment saying that the file is intentionally empty. -- Christian From azeemj at gmail.com Wed Jul 15 19:21:58 2009 From: azeemj at gmail.com (Azeem Jiva) Date: Wed, 15 Jul 2009 21:21:58 -0500 Subject: Math trig intrinsics and compiler options Message-ID: <2793ec670907151921p3b558286we89f7e3e0575ed3c@mail.gmail.com> Joe, Gustav sent me an email asking for help with the intrinsification of the trig functions and a suggestion I gave him was to not call fsin/fcos/ftan since those instructions are microcoded on Intel/AMD hardware and very slow. Slower than the call to sharedRuntimeTrig.cpp, and in all cases it's best to stay away from the hardware instructions. The change Gustav proposes only enables calling the sharedRuntime calls. Granted sharedRuntime* files are not optimized by the Windows compiler, but on Solaris and Linux they are and depending on what current version of MSVC++ you guys are using it might be worth enabling optimizations. -- Azeem Jiva From gnu_andrew at member.fsf.org Thu Jul 16 06:54:26 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 16 Jul 2009 14:54:26 +0100 Subject: Review request: Zero assembler port In-Reply-To: <20090716132902.GG3177@redhat.com> References: <20090715135745.GB3179@redhat.com> <20090716132902.GG3177@redhat.com> Message-ID: <17c6771e0907160654r392b2010r95259d44e2bdb9a4@mail.gmail.com> 2009/7/16 Gary Benson : > Gary Benson wrote: >> Zero uses one external library, libffi, for JNI method invocation. >> The following two variables are used to tell the compiler and linker >> how to find libffi. ?These can be set by the user, but if left unset >> then jdk/make/jdk_generic_profile.sh will attempt to set them using >> pkg-config: >> >> ? LIBFFI_CFLAGS >> ? ? Flags to be passed to the C++ compiler to build against libffi. >> >> ? LIBFFI_LIBS >> ? ? Flags to be passed to the linker to link against libffi. > > It turns out that Gentoo builds libffi without the pkg-config stuff. > The following webrev has a modified jdk/make/jdk_generic_profile.sh > that adds default values to these two (LIBFFI_CFLAGS="" and > LIBFFI_LIBS="-lffi") to work with Gentoo (and any other distributions > that don't pkg-config libffi): > > ?http://cr.openjdk.java.net/~gbenson/zero-06/ > Gentoo users generally build libffi as part of gcc. I remember something about it being split out and maintained separately, but not the whole story. > Cheers, > Gary > > -- > http://gbenson.net/ > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From gbenson at redhat.com Thu Jul 16 07:00:27 2009 From: gbenson at redhat.com (Gary Benson) Date: Thu, 16 Jul 2009 15:00:27 +0100 Subject: Review request: Zero assembler port In-Reply-To: <4A5F2C70.8010904@Sun.COM> References: <20090715135745.GB3179@redhat.com> <19038.18789.410774.774181@sun.com> <20090716101503.GB3177@redhat.com> <10ffa8f60907160447q80e38ch2ddd32d734392714@mail.gmail.com> <20090716121954.GE3177@redhat.com> <4A5F2C70.8010904@Sun.COM> Message-ID: <20090716140027.GH3177@redhat.com> Christian Thalinger wrote: > Gary Benson wrote: > > Hi Vikram, > > > > Vikram A wrote: > > > Some files ... still show only the copyright header, no source > > > code. some have only 4 lines of code. is that what you wanted. > > > > Yes, that's correct. The files are there because the includeDB > > lists them, so the build system expects them to be present, but > > they don't contain anything. In the IcedTea version of Zero these > > files are empty -- they don't even contain the copyright header -- > > but patch won't create empty files so the webrev ended up > > unbuildable. > > Maybe you should add a comment saying that the file is intentionally > empty. Good idea, done: http://cr.openjdk.java.net/~gbenson/zero-07/ Cheers, Gary -- http://gbenson.net/ From Christian.Thalinger at Sun.COM Thu Jul 16 08:12:03 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Thu, 16 Jul 2009 17:12:03 +0200 Subject: Math trig intrinsics and compiler options In-Reply-To: <2793ec670907151921p3b558286we89f7e3e0575ed3c@mail.gmail.com> References: <2793ec670907151921p3b558286we89f7e3e0575ed3c@mail.gmail.com> Message-ID: <4A5F4343.9020505@Sun.COM> Azeem Jiva wrote: > Joe, > Gustav sent me an email asking for help with the intrinsification of > the trig functions and a suggestion I gave him was to not call > fsin/fcos/ftan since those instructions are microcoded on Intel/AMD > hardware and very slow. Slower than the call to > sharedRuntimeTrig.cpp, and in all cases it's best to stay away from > the hardware instructions. I just did some micro-benchmarking on an Intel Core2 Duo and in the range of [0,2pi) inlining the hardware instructions is slightly faster (about 2.5%). Limiting the range to [0,pi/4) (means no runtime calls) hardware instructions are 1.5x faster. I think we should keep the current approach. -- Christian From gustav.trede at gmail.com Thu Jul 16 08:39:14 2009 From: gustav.trede at gmail.com (gustav trede) Date: Thu, 16 Jul 2009 17:39:14 +0200 Subject: Math trig intrinsics and compiler options In-Reply-To: <4A5F4343.9020505@Sun.COM> References: <2793ec670907151921p3b558286we89f7e3e0575ed3c@mail.gmail.com> <4A5F4343.9020505@Sun.COM> Message-ID: <311e0eaf0907160839r4789d10cxad6bfb19e57f51ad@mail.gmail.com> 2009/7/16 Christian Thalinger > Azeem Jiva wrote: > > Joe, > > Gustav sent me an email asking for help with the intrinsification of > > the trig functions and a suggestion I gave him was to not call > > fsin/fcos/ftan since those instructions are microcoded on Intel/AMD > > hardware and very slow. Slower than the call to > > sharedRuntimeTrig.cpp, and in all cases it's best to stay away from > > the hardware instructions. > > I just did some micro-benchmarking on an Intel Core2 Duo and in the > range of [0,2pi) inlining the hardware instructions is slightly faster > (about 2.5%). Limiting the range to [0,pi/4) (means no runtime calls) > hardware instructions are 1.5x faster. > > I think we should keep the current approach. > > -- Christian > do you mind sharing details about that test so i can reproduce it ?. -- regards gustav trede -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20090716/2a30f54e/attachment.html From Joe.Darcy at Sun.COM Thu Jul 16 08:42:42 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Thu, 16 Jul 2009 08:42:42 -0700 Subject: Math trig intrinsics and compiler options In-Reply-To: <4A5F0E77.6080304@Sun.COM> References: <311e0eaf0907150543v5d877f55t3e6377b88ea43008@mail.gmail.com> <4A5DD7E9.8070904@Sun.COM> <4A5E0AA0.4080306@sun.com> <4A5F0E77.6080304@Sun.COM> Message-ID: <4A5F4A72.8040408@sun.com> Christian Thalinger wrote: > Joseph D. Darcy wrote: > >> Christian Thalinger wrote: >> >>> gustav trede wrote: >>> >>> >>>> Hello, >>>> >>>> Azeem Jiva told me an easy way to improve trig performance. >>>> Changing the intrinsics to use an existing but faster path gives me a >>>> boost of roughly 40% for the Math cos and sin on solaris x64. >>>> >>>> >>>> library_call.cpp >>>> >>>> bool LibraryCallKit::inline_math_ >>>> native(vmIntrinsics::ID id) { >>>> switch (id) { >>>> >>>> case vmIntrinsics::_dcos: return Matcher::has_match_rule(Op_CosD) ? >>>> runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >>>> SharedRuntime::dcos), "COS") : false; >>>> case vmIntrinsics::_dsin: return Matcher::has_match_rule(Op_SinD) ? >>>> runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >>>> SharedRuntime::dsin), "SIN") : false; >>>> case vmIntrinsics::_dtan: return Matcher::has_match_rule(Op_TanD) ? >>>> runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >>>> SharedRuntime::dtan), "TAN") : false; >>>> case vmIntrinsics::_dlog: return Matcher::has_match_rule(Op_LogD) ? >>>> runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >>>> SharedRuntime::dlog), "LOG") : false; >>>> case vmIntrinsics::_dlog10: return Matcher::has_match_rule(Op_Log10D) >>>> ? runtime_math(OptoRuntime::Math_D_D_Type(), CAST_FROM_FN_PTR(address, >>>> SharedRuntime::dlog10), "LOG10") : false; >>>> >>>> >>>> Is there any potential problem with such a patch ? >>>> >>>> >>> I'm not sure I understand this "patch". Why should the code above be >>> faster than the current code in HotSpot, which tries to inline the >>> trigonometric functions? Maybe the speedup you're seeing is because of >>> the missing fast/slow path check and you are always using the slow path >>> because of rounding? Just a guess... >>> >>> >> Hello. >> >> Can you explain the nature of the selection difference? >> > > It seems all boils down to: > > // Check: If PI/4 < abs(arg) then go slow > Yes, the fsin/fcos instructions can be used directly if abs(arg) < pi/4. > As also explained in CR 4345903: > > The solution is to have the Math.{sin, cos} do their own argument > reduction to [-pi/4, pi/4] and then call fsin/fcos; this will > guarantee the specified accuracy and monotonicity properties. > More than double precision is needed to hold the reduced argument, and as I recall, more than the double extended precision available on the x87 as well, so that approach is not directly applicable. -Joe > >> Better semantics are provided if the instrinsified versions of sin, cos, >> etc. are always used to implement the java.lang.Math flavor of those >> methods. >> > > -- Christian > From gustav.trede at gmail.com Thu Jul 16 08:49:48 2009 From: gustav.trede at gmail.com (gustav trede) Date: Thu, 16 Jul 2009 17:49:48 +0200 Subject: Math trig intrinsics and compiler options In-Reply-To: <311e0eaf0907160839r4789d10cxad6bfb19e57f51ad@mail.gmail.com> References: <2793ec670907151921p3b558286we89f7e3e0575ed3c@mail.gmail.com> <4A5F4343.9020505@Sun.COM> <311e0eaf0907160839r4789d10cxad6bfb19e57f51ad@mail.gmail.com> Message-ID: <311e0eaf0907160849r5b077f67vf3bed606136da883@mail.gmail.com> 2009/7/16 gustav trede > > > 2009/7/16 Christian Thalinger > > Azeem Jiva wrote: >> > Joe, >> > Gustav sent me an email asking for help with the intrinsification of >> > the trig functions and a suggestion I gave him was to not call >> > fsin/fcos/ftan since those instructions are microcoded on Intel/AMD >> > hardware and very slow. Slower than the call to >> > sharedRuntimeTrig.cpp, and in all cases it's best to stay away from >> > the hardware instructions. >> >> I just did some micro-benchmarking on an Intel Core2 Duo and in the >> range of [0,2pi) inlining the hardware instructions is slightly faster >> (about 2.5%). Limiting the range to [0,pi/4) (means no runtime calls) >> hardware instructions are 1.5x faster. >> >> I think we should keep the current approach. >> >> -- Christian >> > > on opensolaris 118 x64 core2 with the patch applied i get 44 cycles as cost per Math cos , sin on average, including the loop overhead for the 0 to PI/4 range . what cost do you get with fcos , fsin in this test ? : private void dotest(final double start, final double end){ final int innerIter = 150000; final int iter = 5000; double ret = 0; long t1= System.nanoTime(); for (int i=0;i Changeset: 8ca3d95b1ea3 Author: xdono Date: 2009-06-22 10:13 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/8ca3d95b1ea3 6853596: Update Build README-build.html with new info regarding update for Solaris 10u2 and BOOTDIR update Reviewed-by: tbell, ohair ! README-builds.html Changeset: 38c6ee1015aa Author: xdono Date: 2009-06-29 22:13 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/38c6ee1015aa Merge ! README-builds.html Changeset: 9ed059501673 Author: xdono Date: 2009-07-08 10:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/9ed059501673 Merge Changeset: e01380cd1de4 Author: xdono Date: 2009-07-14 14:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/e01380cd1de4 Merge Changeset: 6bad5e3fe503 Author: xdono Date: 2009-07-16 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/6bad5e3fe503 Added tag jdk7-b65 for changeset e01380cd1de4 ! .hgtags From john.coomes at sun.com Thu Jul 16 20:43:40 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 17 Jul 2009 03:43:40 +0000 Subject: hg: jdk7/hotspot/corba: Added tag jdk7-b65 for changeset 97fd9b42f5c2 Message-ID: <20090717034342.2926BE42A@hg.openjdk.java.net> Changeset: a821e059a961 Author: xdono Date: 2009-07-16 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/a821e059a961 Added tag jdk7-b65 for changeset 97fd9b42f5c2 ! .hgtags From john.coomes at sun.com Thu Jul 16 20:53:36 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 17 Jul 2009 03:53:36 +0000 Subject: hg: jdk7/hotspot/jaxp: Added tag jdk7-b65 for changeset 008c662e0ee9 Message-ID: <20090717035338.72024E431@hg.openjdk.java.net> Changeset: 22f9d5d5b5fe Author: xdono Date: 2009-07-16 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/22f9d5d5b5fe Added tag jdk7-b65 for changeset 008c662e0ee9 ! .hgtags From john.coomes at sun.com Thu Jul 16 20:58:40 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 17 Jul 2009 03:58:40 +0000 Subject: hg: jdk7/hotspot/jaxws: Added tag jdk7-b65 for changeset aa22a1be5866 Message-ID: <20090717035842.8BA73E436@hg.openjdk.java.net> Changeset: fa8712c099ed Author: xdono Date: 2009-07-16 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/fa8712c099ed Added tag jdk7-b65 for changeset aa22a1be5866 ! .hgtags From john.coomes at sun.com Thu Jul 16 21:03:52 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 17 Jul 2009 04:03:52 +0000 Subject: hg: jdk7/hotspot/jdk: Added tag jdk7-b65 for changeset 382a27aa78d3 Message-ID: <20090717040443.6DA7EE43B@hg.openjdk.java.net> Changeset: 6ec0174d4f36 Author: xdono Date: 2009-07-16 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6ec0174d4f36 Added tag jdk7-b65 for changeset 382a27aa78d3 ! .hgtags From john.coomes at sun.com Thu Jul 16 21:18:56 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 17 Jul 2009 04:18:56 +0000 Subject: hg: jdk7/hotspot/langtools: Added tag jdk7-b65 for changeset 7e0056ded28c Message-ID: <20090717041901.56CAFE440@hg.openjdk.java.net> Changeset: 634f519d6f9a Author: xdono Date: 2009-07-16 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/634f519d6f9a Added tag jdk7-b65 for changeset 7e0056ded28c ! .hgtags From Joe.Darcy at Sun.COM Fri Jul 17 11:43:15 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Fri, 17 Jul 2009 11:43:15 -0700 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <17c6771e0907151323q1725f046laf0182502f75a22e@mail.gmail.com> References: <17c6771e0907151323q1725f046laf0182502f75a22e@mail.gmail.com> Message-ID: <4A60C643.3090306@sun.com> Andrew John Hughes wrote: > We discussed this a while back, but discussions seem to have come to a halt. > > Using the rebase extension to hg, I've succeeded in producing a > version of the OpenJDK6 repository based on the same 0 revision as the > hs14 master: > > http://fuseyism.com/hg/hotspot > > This means that pulls from the hs14 master can be used to update this > repository, which isn't the case with the current OpenJDK6 repository > as they have no common parent. However, unlike hs14, it does include > all the history and fixes from OpenJDK6 (some of which don't seem to > have made the HS7 repos, such as deleting binary jar files). > > Does this look ok? If so, can someone with ssh access to > hg.openjdk.java.net please replace the current hotspot repository with > this one, so we can update it to the current hs14 revision and add any > other pending changes? > > It would be nice to finally let HotSpot development in OpenJDK6 move on! > > Thanks, > Hi Andrew. I'll discuss this matter with Kelly when we are both not on vacation. Thanks, -Joe From Thomas.Rodriguez at Sun.COM Fri Jul 17 18:36:45 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Fri, 17 Jul 2009 18:36:45 -0700 Subject: review (S) for 6861984: solaris version of libsaproc.so should support SA_ALTROOT directly Message-ID: <31A56654-5E42-4E12-8F73-F610D1822C3D@Sun.COM> http://cr.openjdk.java.net/~never/6861984 From Joe.Darcy at Sun.COM Tue Jul 21 13:30:25 2009 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Tue, 21 Jul 2009 13:30:25 -0700 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <4A60C643.3090306@sun.com> References: <17c6771e0907151323q1725f046laf0182502f75a22e@mail.gmail.com> <4A60C643.3090306@sun.com> Message-ID: <4A662561.8040707@sun.com> Joseph D. Darcy wrote: > Andrew John Hughes wrote: >> We discussed this a while back, but discussions seem to have come to a >> halt. >> >> Using the rebase extension to hg, I've succeeded in producing a >> version of the OpenJDK6 repository based on the same 0 revision as the >> hs14 master: >> >> http://fuseyism.com/hg/hotspot >> >> This means that pulls from the hs14 master can be used to update this >> repository, which isn't the case with the current OpenJDK6 repository >> as they have no common parent. However, unlike hs14, it does include >> all the history and fixes from OpenJDK6 (some of which don't seem to >> have made the HS7 repos, such as deleting binary jar files). >> >> Does this look ok? If so, can someone with ssh access to >> hg.openjdk.java.net please replace the current hotspot repository with >> this one, so we can update it to the current hs14 revision and add any >> other pending changes? >> >> It would be nice to finally let HotSpot development in OpenJDK6 move on! >> >> Thanks, >> > > Hi Andrew. > > I'll discuss this matter with Kelly when we are both not on vacation. > > Thanks, > > -Joe Hello. I've discussed the rebasing with Mark R. and we've agreed to go forward with it. Mark has offered to do the actual replacing of the repository contents. Thanks, -Joe From gnu_andrew at member.fsf.org Tue Jul 21 13:44:45 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Tue, 21 Jul 2009 21:44:45 +0100 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <4A662561.8040707@sun.com> References: <17c6771e0907151323q1725f046laf0182502f75a22e@mail.gmail.com> <4A60C643.3090306@sun.com> <4A662561.8040707@sun.com> Message-ID: <17c6771e0907211344y1518bcd3w76b71eb005249aa2@mail.gmail.com> 2009/7/21 Joe Darcy : > Joseph D. Darcy wrote: >> >> Andrew John Hughes wrote: >>> >>> We discussed this a while back, but discussions seem to have come to a >>> halt. >>> >>> Using the rebase extension to hg, I've succeeded in producing a >>> version of the OpenJDK6 repository based on the same 0 revision as the >>> hs14 master: >>> >>> http://fuseyism.com/hg/hotspot >>> >>> This means that pulls from the hs14 master can be used to update this >>> repository, which isn't the case with the current OpenJDK6 repository >>> as they have no common parent. ?However, unlike hs14, it does include >>> all the history and fixes from OpenJDK6 (some of which don't seem to >>> have made the HS7 repos, such as deleting binary jar files). >>> >>> Does this look ok? If so, can someone with ssh access to >>> hg.openjdk.java.net please replace the current hotspot repository with >>> this one, so we can update it to the current hs14 revision and add any >>> other pending changes? >>> >>> It would be nice to finally let HotSpot development in OpenJDK6 move on! >>> >>> Thanks, >>> >> >> Hi Andrew. >> >> I'll discuss this matter with Kelly when we are both not on vacation. >> >> Thanks, >> >> -Joe > > Hello. > > I've discussed the rebasing with Mark R. and we've agreed to go forward with > it. ?Mark has offered to do the actual replacing of the repository contents. > > Thanks, > > -Joe > Thanks. That's great news :) -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From y.s.ramakrishna at sun.com Wed Jul 22 05:07:57 2009 From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com) Date: Wed, 22 Jul 2009 12:07:57 +0000 Subject: hg: jdk7/hotspot/hotspot: 3 new changesets Message-ID: <20090722120807.2E74DEBFE@hg.openjdk.java.net> Changeset: df6caf649ff7 Author: ysr Date: 2009-07-14 15:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/df6caf649ff7 6700789: G1: Enable use of compressed oops with G1 heaps Summary: Modifications to G1 so as to allow the use of compressed oops. Reviewed-by: apetrusenko, coleenp, jmasa, kvn, never, phh, tonyp ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/share/vm/gc_implementation/g1/bufferingOopClosure.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.inline.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/satbQueue.cpp ! src/share/vm/gc_implementation/g1/satbQueue.hpp ! src/share/vm/gc_implementation/includeDB_gc_g1 ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/includeDB_core ! src/share/vm/includeDB_features ! src/share/vm/memory/barrierSet.cpp ! src/share/vm/memory/barrierSet.hpp ! src/share/vm/memory/barrierSet.inline.hpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/genOopClosures.hpp ! src/share/vm/memory/genOopClosures.inline.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/oops/oopsHierarchy.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/taskqueue.hpp Changeset: 42d84bbbecf4 Author: tonyp Date: 2009-07-15 12:22 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/42d84bbbecf4 6859911: G1: assert(Heap_lock->owner() = NULL, "Should be owned on this thread's behalf") Summary: The used() method assumes that the heap lock is held when it is called. However, when used() is called from print_on(), this is not the case. Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: f0a1cbbaf3c0 Author: ysr Date: 2009-07-16 12:38 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f0a1cbbaf3c0 Merge From mr at sun.com Wed Jul 22 14:48:10 2009 From: mr at sun.com (Mark Reinhold) Date: Wed, 22 Jul 2009 14:48:10 -0700 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: gnu_andrew@member.fsf.org; Wed, 15 Jul 2009 21:23:22 BST; <17c6771e0907151323q1725f046laf0182502f75a22e@mail.gmail.com> Message-ID: <20090722214810.175B451B@eggemoggin.niobe.net> > Date: Wed, 15 Jul 2009 21:23:22 +0100 > From: Andrew John Hughes > Using the rebase extension to hg, I've succeeded in producing a > version of the OpenJDK6 repository based on the same 0 revision as the > hs14 master: > > http://fuseyism.com/hg/hotspot > > This means that pulls from the hs14 master can be used to update this > repository, which isn't the case with the current OpenJDK6 repository > as they have no common parent. However, unlike hs14, it does include > all the history and fixes from OpenJDK6 (some of which don't seem to > have made the HS7 repos, such as deleting binary jar files). > > Does this look ok? If so, can someone with ssh access to > hg.openjdk.java.net please replace the current hotspot repository with > this one, so we can update it to the current hs14 revision and add any > other pending changes? Your repo looks fine to me -- thanks for creating it. Shall I go ahead and replace the current jdk6/hotspot repo with this? (That is, does anyone have any concerns?) > It would be nice to finally let HotSpot development in OpenJDK6 move on! Indeed! - Mark From gnu_andrew at member.fsf.org Thu Jul 23 07:48:05 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 23 Jul 2009 15:48:05 +0100 Subject: Review request: Zero assembler port In-Reply-To: <20090716140027.GH3177@redhat.com> References: <20090715135745.GB3179@redhat.com> <19038.18789.410774.774181@sun.com> <20090716101503.GB3177@redhat.com> <10ffa8f60907160447q80e38ch2ddd32d734392714@mail.gmail.com> <20090716121954.GE3177@redhat.com> <4A5F2C70.8010904@Sun.COM> <20090716140027.GH3177@redhat.com> Message-ID: <17c6771e0907230748i38177c26w45e4ff252e9d9509@mail.gmail.com> 2009/7/16 Gary Benson : > Christian Thalinger wrote: >> Gary Benson wrote: >> > Hi Vikram, >> > >> > Vikram A wrote: >> > > Some files ... ?still show only the copyright header, no source >> > > code. ?some have only 4 lines of code. is that what you wanted. >> > >> > Yes, that's correct. ?The files are there because the includeDB >> > lists them, so the build system expects them to be present, but >> > they don't contain anything. ?In the IcedTea version of Zero these >> > files are empty -- they don't even contain the copyright header -- >> > but patch won't create empty files so the webrev ended up >> > unbuildable. >> >> Maybe you should add a comment saying that the file is intentionally >> empty. > > Good idea, done: > > ?http://cr.openjdk.java.net/~gbenson/zero-07/ > > Cheers, > Gary > > -- > http://gbenson.net/ > Anyone have any comments on Gary's patch? What more is necessary to commit this to the hotspot forest? -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From mr at sun.com Thu Jul 23 08:26:50 2009 From: mr at sun.com (Mark Reinhold) Date: Thu, 23 Jul 2009 08:26:50 -0700 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: mr@sun.com; Wed, 22 Jul 2009 14:48:10 PDT; <20090722214810.175B451B@eggemoggin.niobe.net> Message-ID: <20090723152650.1C8206F6@eggemoggin.niobe.net> > From: Mark Reinhold > Date: Wed, 22 Jul 2009 14:48:10 -0700 > ... > > Your repo looks fine to me -- thanks for creating it. > > Shall I go ahead and replace the current jdk6/hotspot repo with this? > (That is, does anyone have any concerns?) Here's something (perhaps) to be concerned about: A recently-reported regression in Sun's proprietary 6u14 (and hence also in hsx14) causes debugging breakpoints to be ignored in some circumstances. The bug is reproducible with both the client and server VMs, but only using the serial GC. The primary Sun bugid is 6862295 [1]; see also the downstream bug first reported in Eclipse [2]. Dan Daugherty is working on a fix, which we'll publish when available, but in the meantime hsx14 has this bug. Is the existence of this bug in hsx14 a reason to delay replacing the current jdk6/hotspot repo with Andrew's newer version? Let me know. - Mark [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6862295 [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=279137 From gnu_andrew at member.fsf.org Thu Jul 23 08:36:48 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 23 Jul 2009 16:36:48 +0100 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <20090723152650.1C8206F6@eggemoggin.niobe.net> References: <20090722214810.175B451B@eggemoggin.niobe.net> <20090723152650.1C8206F6@eggemoggin.niobe.net> Message-ID: <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> 2009/7/23 Mark Reinhold : >> From: Mark Reinhold >> Date: Wed, 22 Jul 2009 14:48:10 -0700 > >> ... >> >> Your repo looks fine to me -- thanks for creating it. >> >> Shall I go ahead and replace the current jdk6/hotspot repo with this? >> (That is, does anyone have any concerns?) > > Here's something (perhaps) to be concerned about: A recently-reported > regression in Sun's proprietary 6u14 (and hence also in hsx14) causes > debugging breakpoints to be ignored in some circumstances. ?The bug is > reproducible with both the client and server VMs, but only using the > serial GC. > > The primary Sun bugid is 6862295 [1]; see also the downstream bug first > reported in Eclipse [2]. ?Dan Daugherty is working on a fix, which we'll > publish when available, but in the meantime hsx14 has this bug. > > Is the existence of this bug in hsx14 a reason to delay replacing the > current jdk6/hotspot repo with Andrew's newer version? ?Let me know. > > - Mark > > > [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6862295 > [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=279137 > It's a concern, no doubt about that, but not moving to hs14 because of it is a bit like shutting the stable door after the horse has bolted; both IcedTea and Sun's proprietary releases have been shipping hs14 for some time. I think the better course of action is to get the patch in as soon as it is available and then roll it out in new releases. Besides, the proposed update doesn't (yet) move OpenJDK6 to HotSpot 14. It rebases the repository so it's now at revision 0 of the current HotSpot7 repositories (plus the OpenJDK6 fixes), allowing changesets from the hs14 master and also the main HotSpot7 repository to be merged (as they all then have a common parent). This is actually hs12b0 I believe (from b24 of OpenJDK7). -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From aph at redhat.com Thu Jul 23 08:52:00 2009 From: aph at redhat.com (Andrew Haley) Date: Thu, 23 Jul 2009 17:52:00 +0200 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> References: <20090722214810.175B451B@eggemoggin.niobe.net> <20090723152650.1C8206F6@eggemoggin.niobe.net> <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> Message-ID: <4A688720.5090800@redhat.com> On 07/23/2009 05:36 PM, Andrew John Hughes wrote: > 2009/7/23 Mark Reinhold : >>> From: Mark Reinhold >>> Date: Wed, 22 Jul 2009 14:48:10 -0700 >>> ... >>> >>> Your repo looks fine to me -- thanks for creating it. >>> >>> Shall I go ahead and replace the current jdk6/hotspot repo with this? >>> (That is, does anyone have any concerns?) >> Here's something (perhaps) to be concerned about: A recently-reported >> regression in Sun's proprietary 6u14 (and hence also in hsx14) causes >> debugging breakpoints to be ignored in some circumstances. The bug is >> reproducible with both the client and server VMs, but only using the >> serial GC. >> >> The primary Sun bugid is 6862295 [1]; see also the downstream bug first >> reported in Eclipse [2]. Dan Daugherty is working on a fix, which we'll >> publish when available, but in the meantime hsx14 has this bug. >> >> Is the existence of this bug in hsx14 a reason to delay replacing the >> current jdk6/hotspot repo with Andrew's newer version? Let me know. >> >> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6862295 >> [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=279137 >> > > It's a concern, no doubt about that, but not moving to hs14 because of > it is a bit like shutting the stable door after the horse has bolted; > both IcedTea and Sun's proprietary releases have been shipping hs14 > for some time. I think the better course of action is to get the > patch in as soon as it is available and then roll it out in new > releases. That sounds right to me. > Besides, the proposed update doesn't (yet) move OpenJDK6 to HotSpot > 14. It rebases the repository so it's now at revision 0 of the > current HotSpot7 repositories (plus the OpenJDK6 fixes), allowing > changesets from the hs14 master and also the main HotSpot7 repository > to be merged (as they all then have a common parent). This is > actually hs12b0 I believe (from b24 of OpenJDK7). Do I take it that you intend soon to submit a patch that moves OpenJDK 6 to HS 14? Andrew. From gnu_andrew at member.fsf.org Thu Jul 23 09:17:11 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 23 Jul 2009 17:17:11 +0100 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <4A688720.5090800@redhat.com> References: <20090722214810.175B451B@eggemoggin.niobe.net> <20090723152650.1C8206F6@eggemoggin.niobe.net> <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> <4A688720.5090800@redhat.com> Message-ID: <17c6771e0907230917h59c26566hd72acffe44a23ddc@mail.gmail.com> 2009/7/23 Andrew Haley : > On 07/23/2009 05:36 PM, Andrew John Hughes wrote: >> 2009/7/23 Mark Reinhold : >>>> From: Mark Reinhold >>>> Date: Wed, 22 Jul 2009 14:48:10 -0700 >>>> ... >>>> >>>> Your repo looks fine to me -- thanks for creating it. >>>> >>>> Shall I go ahead and replace the current jdk6/hotspot repo with this? >>>> (That is, does anyone have any concerns?) >>> Here's something (perhaps) to be concerned about: A recently-reported >>> regression in Sun's proprietary 6u14 (and hence also in hsx14) causes >>> debugging breakpoints to be ignored in some circumstances. ?The bug is >>> reproducible with both the client and server VMs, but only using the >>> serial GC. >>> >>> The primary Sun bugid is 6862295 [1]; see also the downstream bug first >>> reported in Eclipse [2]. ?Dan Daugherty is working on a fix, which we'll >>> publish when available, but in the meantime hsx14 has this bug. >>> >>> Is the existence of this bug in hsx14 a reason to delay replacing the >>> current jdk6/hotspot repo with Andrew's newer version? ?Let me know. > >>> >>> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6862295 >>> [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=279137 >>> >> >> It's a concern, no doubt about that, but not moving to hs14 because of >> it is a bit like shutting the stable door after the horse has bolted; >> both IcedTea and Sun's proprietary releases have been shipping hs14 >> for some time. ?I think the better course of action is to get the >> patch in as soon as it is available and then roll it out in new >> releases. > > That sounds right to me. > >> Besides, the proposed update doesn't (yet) move OpenJDK6 to HotSpot >> 14. ?It rebases the repository so it's now at revision 0 of the >> current HotSpot7 repositories (plus the OpenJDK6 fixes), allowing >> changesets from the hs14 master and also the main HotSpot7 repository >> to be merged (as they all then have a common parent). ?This is >> actually hs12b0 I believe (from b24 of OpenJDK7). > > Do I take it that you intend soon to submit a patch that moves OpenJDK 6 > to HS 14? > Indeed, that's the intention. I wanted to do as little as possible by replacing directories on the server side, leaving the actual merge to hs14 itself to the usual webrev-and-push process. So expect one mega-patch to update to hs14 once OpenJDK6 is rebased. > Andrew. > Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Thomas.Rodriguez at Sun.COM Thu Jul 23 11:15:28 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Thu, 23 Jul 2009 11:15:28 -0700 Subject: review (S) for 6861984: solaris version of libsaproc.so should support SA_ALTROOT directly In-Reply-To: <31A56654-5E42-4E12-8F73-F610D1822C3D@Sun.COM> References: <31A56654-5E42-4E12-8F73-F610D1822C3D@Sun.COM> Message-ID: <69CD9F5A-CAA1-45B6-BCC5-2D86FADB5E1C@sun.com> No takers on this? tom On Jul 17, 2009, at 6:36 PM, Tom Rodriguez wrote: > http://cr.openjdk.java.net/~never/6861984 From mr at sun.com Thu Jul 23 12:12:25 2009 From: mr at sun.com (Mark Reinhold) Date: Thu, 23 Jul 2009 12:12:25 -0700 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: gnu_andrew@member.fsf.org; Thu, 23 Jul 2009 16:36:48 BST; <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> Message-ID: <20090723191225.1C96A8E7@eggemoggin.niobe.net> > Date: Thu, 23 Jul 2009 16:36:48 +0100 > From: Andrew John Hughes > ... > > Besides, the proposed update doesn't (yet) move OpenJDK6 to HotSpot > 14. It rebases the repository so it's now at revision 0 of the > current HotSpot7 repositories (plus the OpenJDK6 fixes), allowing > changesets from the hs14 master and also the main HotSpot7 repository > to be merged (as they all then have a common parent). This is > actually hs12b0 I believe (from b24 of OpenJDK7). Ah, okay, I hadn't realized that. I've blown away the current jdk6/hotspot repository in preparation for dropping in your new repo. I need to make a couple of adjustments on the server prior to doing that, most likely some time tonight PDT. - Mark From Vladimir.Kozlov at Sun.COM Thu Jul 23 17:56:46 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Thu, 23 Jul 2009 17:56:46 -0700 Subject: Request for reviews (S): 6863420: os::javaTimeNanos() go backward on Solaris x86 Message-ID: <4A6906CE.5090905@sun.com> http://cr.openjdk.java.net/~kvn/6863420/webrev.00 Fixed 6863420: os::javaTimeNanos() go backward on Solaris x86 Problem: The problem is non atomic load from max_hrtime in getTimeNanos() on platforms where long is kept in 2 32-bit register. The loaded value could be invalid (> current time) since registers are loaded separately and store could happened in between. It could be returned as result if it is greater then current time. And if the next call getTimeNanos() returns the correct time it will be less then previous result. Solution: Use new atomic long load method Atomic::load() which uses FPU to move long value atomically. Added the regression test which shows the problem. Reviewed by: Fix verified (y/n): y, regression test Other testing: JPRT From David.Holmes at Sun.COM Thu Jul 23 21:06:23 2009 From: David.Holmes at Sun.COM (David Holmes - Sun Microsystems) Date: Fri, 24 Jul 2009 14:06:23 +1000 Subject: Request for reviews (S): 6863420: os::javaTimeNanos() go backward on Solaris x86 In-Reply-To: <4A6906CE.5090905@sun.com> References: <4A6906CE.5090905@sun.com> Message-ID: <4A69333F.6030602@sun.com> Hi Vladimir, This is a good catch in some quite old code! I wonder if there are any other word-tearing bugs lurking ... "normal" CAS-loops wouldn't be affected because the word-tearing would cause the CAS to fail, but any "optimized" ones where the value normally updated by CAS is simply read and used, would suffer the same problem as here. But it seems odd to define a platform-independent Atomic::load(jlong, jlong) function but then only implement it for 32-bit Solaris x86 and use conditional compilation at the call site. It would seem much cleaner to always use Atomic::load(jlong, jlong) and have it evaporate to nothing on platforms for which it is a direct load. Given the spread of the JDK I suspect there are other platforms where non-atomic 64-bit loads could be an issue. Cheers, David Holmes Vladimir Kozlov said the following on 07/24/09 10:56: > http://cr.openjdk.java.net/~kvn/6863420/webrev.00 > > Fixed 6863420: os::javaTimeNanos() go backward on Solaris x86 > > Problem: > The problem is non atomic load from max_hrtime in getTimeNanos() > on platforms where long is kept in 2 32-bit register. > The loaded value could be invalid (> current time) since registers > are loaded separately and store could happened in between. > It could be returned as result if it is greater then current time. > And if the next call getTimeNanos() returns the correct time > it will be less then previous result. > > Solution: > Use new atomic long load method Atomic::load() which uses > FPU to move long value atomically. > > Added the regression test which shows the problem. > > Reviewed by: > > Fix verified (y/n): y, regression test > > Other testing: > JPRT > From Vladimir.Kozlov at Sun.COM Thu Jul 23 23:16:48 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Thu, 23 Jul 2009 23:16:48 -0700 Subject: Request for reviews (S): 6863420: os::javaTimeNanos() go backward on Solaris x86 In-Reply-To: <4A69333F.6030602@sun.com> References: <4A6906CE.5090905@sun.com> <4A69333F.6030602@sun.com> Message-ID: <4A6951D0.60200@sun.com> Thank you, David I will update Atomic::load(). Vladimir David Holmes - Sun Microsystems wrote: > Hi Vladimir, > > This is a good catch in some quite old code! I wonder if there are any > other word-tearing bugs lurking ... "normal" CAS-loops wouldn't be > affected because the word-tearing would cause the CAS to fail, but any > "optimized" ones where the value normally updated by CAS is simply read > and used, would suffer the same problem as here. > > But it seems odd to define a platform-independent Atomic::load(jlong, > jlong) function but then only implement it for 32-bit Solaris x86 and > use conditional compilation at the call site. It would seem much cleaner > to always use Atomic::load(jlong, jlong) and have it evaporate to > nothing on platforms for which it is a direct load. Given the spread of > the JDK I suspect there are other platforms where non-atomic 64-bit > loads could be an issue. > > Cheers, > David Holmes > > Vladimir Kozlov said the following on 07/24/09 10:56: >> http://cr.openjdk.java.net/~kvn/6863420/webrev.00 >> >> Fixed 6863420: os::javaTimeNanos() go backward on Solaris x86 >> >> Problem: >> The problem is non atomic load from max_hrtime in getTimeNanos() >> on platforms where long is kept in 2 32-bit register. >> The loaded value could be invalid (> current time) since registers >> are loaded separately and store could happened in between. >> It could be returned as result if it is greater then current time. >> And if the next call getTimeNanos() returns the correct time >> it will be less then previous result. >> >> Solution: >> Use new atomic long load method Atomic::load() which uses >> FPU to move long value atomically. >> >> Added the regression test which shows the problem. >> >> Reviewed by: >> >> Fix verified (y/n): y, regression test >> >> Other testing: >> JPRT >> From mr at sun.com Fri Jul 24 00:04:05 2009 From: mr at sun.com (Mark Reinhold) Date: Fri, 24 Jul 2009 00:04:05 -0700 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: mr@sun.com; Thu, 23 Jul 2009 12:12:25 PDT; <20090723191225.1C96A8E7@eggemoggin.niobe.net> Message-ID: <20090724070405.54CAEE92@eggemoggin.niobe.net> > From: Mark Reinhold > Date: Thu, 23 Jul 2009 12:12:25 -0700 > ... > > I've blown away the current jdk6/hotspot repository in preparation for > dropping in your new repo. I need to make a couple of adjustments on > the server prior to doing that, most likely some time tonight PDT. Done. http://hg.openjdk.java.net/jdk6/jdk6/hotspot is now a clone of http://fuseyism.com/hg/hotspot, plus the addition of one tiny changeset so that the jcheck hook will allow lax comments. - Mark From mark at klomp.org Fri Jul 24 01:37:19 2009 From: mark at klomp.org (Mark Wielaard) Date: Fri, 24 Jul 2009 10:37:19 +0200 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <20090724070405.54CAEE92@eggemoggin.niobe.net> References: <20090724070405.54CAEE92@eggemoggin.niobe.net> Message-ID: <1248424639.3544.8.camel@springer.wildebeest.org> On Fri, 2009-07-24 at 00:04 -0700, Mark Reinhold wrote: > > From: Mark Reinhold > > Date: Thu, 23 Jul 2009 12:12:25 -0700 > > > I've blown away the current jdk6/hotspot repository in preparation for > > dropping in your new repo. I need to make a couple of adjustments on > > the server prior to doing that, most likely some time tonight PDT. > > Done. > > http://hg.openjdk.java.net/jdk6/jdk6/hotspot is now a clone of > http://fuseyism.com/hg/hotspot, plus the addition of one tiny > changeset so that the jcheck hook will allow lax comments. Thanks. For those doing their morning fpull, this means you will have to blow away your jdk6 forest jdk/hotspot subtree, or you will see: [hotspot] pulling from http://hg.openjdk.java.net/jdk6/jdk6/hotspot searching for changes skipped: repository is unrelated You can just move the jdk/hotpot dir away from under the jdk/ dir and a hg fpull will get you a completely new fresh copy. [hotspot] requesting all changes adding changesets adding manifests adding file changes added 58 changesets with 7893 changes to 3278 files Mirrors updated. For those interested in the old hotspot6 repo I kept a clone here: http://classpath.wildebeest.org/hg/hotspot6.old Cheers, Mark From gnu_andrew at member.fsf.org Fri Jul 24 08:31:27 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Fri, 24 Jul 2009 16:31:27 +0100 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <20090724070405.54CAEE92@eggemoggin.niobe.net> References: <20090723191225.1C96A8E7@eggemoggin.niobe.net> <20090724070405.54CAEE92@eggemoggin.niobe.net> Message-ID: <17c6771e0907240831r45dc2114p433e8d4424e05d5e@mail.gmail.com> 2009/7/24 Mark Reinhold : >> From: Mark Reinhold >> Date: Thu, 23 Jul 2009 12:12:25 -0700 > >> ... >> >> I've blown away the current jdk6/hotspot repository in preparation for >> dropping in your new repo. ?I need to make a couple of adjustments on >> the server prior to doing that, most likely some time tonight PDT. > > Done. > > http://hg.openjdk.java.net/jdk6/jdk6/hotspot is now a clone of > http://fuseyism.com/hg/hotspot, plus the addition of one tiny > changeset so that the jcheck hook will allow lax comments. > > - Mark > Thanks. I'm guessing the changeset 'Remove old jdk6-b00.' needed the lax comments filter, so sorry about that. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Vladimir.Kozlov at Sun.COM Fri Jul 24 11:20:22 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Fri, 24 Jul 2009 11:20:22 -0700 Subject: Request for reviews (update)(S): 6863420: os::javaTimeNanos() go backward on Solaris x86] Message-ID: <4A69FB66.20405@sun.com> I updated the fix to use Atomic::load() always as David H. suggested. http://cr.openjdk.java.net/~kvn/6863420/webrev.01 Fixed 6863420: os::javaTimeNanos() go backward on Solaris x86 Problem: The problem is non atomic load from max_hrtime in getTimeNanos() on platforms where long is kept in 2 32-bit register. The loaded value could be invalid (> current time) since registers are loaded separately and store could happened in between. It could be returned as result if it is greater then current time. And if the next call getTimeNanos() returns the correct time it will be less then previous result. Solution: Use new atomic long load method Atomic::load() which uses FPU to move long value atomically on 32-bit x86 or simply returns *src in other cases. Added the regression test which shows the problem. Reviewed by: Fix verified (y/n): y, regression test Other testing: JPRT, ScaleHarness(6784100) From vladimir.kozlov at sun.com Fri Jul 24 11:43:54 2009 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Fri, 24 Jul 2009 18:43:54 +0000 Subject: hg: jdk7/hotspot/hotspot: 13 new changesets Message-ID: <20090724184423.5BDB2E55F@hg.openjdk.java.net> Changeset: fe95187e8882 Author: never Date: 2009-07-13 14:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/fe95187e8882 6859338: amd64 native unverified entry point pushes values before implicit null check Reviewed-by: kvn, twisti ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp + test/compiler/6859338/Test6859338.java Changeset: 83906a156fc0 Author: never Date: 2009-07-13 15:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/83906a156fc0 Merge Changeset: fd50a67f97d1 Author: never Date: 2009-07-15 13:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/fd50a67f97d1 6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post Reviewed-by: never, kvn Contributed-by: yamauchi at google.com, rasbold at google.com ! src/share/vm/opto/loopopts.cpp + test/compiler/6860469/Test.java Changeset: fc4be448891f Author: kvn Date: 2009-07-16 14:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/fc4be448891f 6851742: (EA) allocation elimination doesn't work with UseG1GC Summary: Fix eliminate_card_mark() to eliminate G1 pre/post barriers. Reviewed-by: never ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/type.hpp Changeset: 84770322b304 Author: never Date: 2009-07-16 17:59 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/84770322b304 6861513: correct copyright attribution in test for 6837094 and 6860469 Reviewed-by: rasbold ! test/compiler/6837094/Test.java ! test/compiler/6860469/Test.java Changeset: 64219d2a6493 Author: kvn Date: 2009-07-16 16:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/64219d2a6493 6851282: JIT miscompilation results in null entry in array when using CompressedOops Summary: Get type for new Phi from non dead path. Reviewed-by: never ! src/share/vm/opto/cfgnode.cpp + test/compiler/6851282/Test.java Changeset: 606c988ff684 Author: kvn Date: 2009-07-17 00:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/606c988ff684 Merge Changeset: f9094a5e1c8a Author: never Date: 2009-07-21 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f9094a5e1c8a 6857159: local schedule failed with checkcast of Thread.currentThread() Reviewed-by: kvn ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp + test/compiler/6857159/Test6857159.java + test/compiler/6857159/Test6857159.sh Changeset: 75596850f863 Author: jrose Date: 2009-07-21 16:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/75596850f863 6862576: vmIntrinsics needs cleanup in order to support JSR 292 intrinsics Summary: remove useless lazy evaluation of intrinsics; add LAST_COMPILER_INLINE to help categorize them Reviewed-by: kvn ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/oops/methodKlass.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/library_call.cpp Changeset: 17173cb6e48d Author: jrose Date: 2009-07-21 21:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/17173cb6e48d Merge Changeset: 5314d85ffd54 Author: kvn Date: 2009-07-22 15:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/5314d85ffd54 6826736: CMS: core dump with -XX:+UseCompressedOops Summary: Fix deoptimization code and OopMapSet::all_do() to check for oop = narrow_oop_base. Reviewed-by: jcoomes, phh, ysr, never ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/compiler/oopMap.hpp ! src/share/vm/memory/universe.hpp ! src/share/vm/runtime/stackValue.cpp + test/compiler/6826736/Test.java Changeset: ea3f9723b5cf Author: kvn Date: 2009-07-23 14:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/ea3f9723b5cf 6860599: nodes limit could be reached during Output phase Summary: Bailout compilation if nodes limit could be reached during Output phase. Reviewed-by: never, twisti ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/output.cpp Changeset: 433f394ab509 Author: kvn Date: 2009-07-24 09:01 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/433f394ab509 Merge ! src/share/vm/memory/universe.hpp ! src/share/vm/opto/cfgnode.cpp From Christian.Thalinger at Sun.COM Fri Jul 24 11:56:27 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Fri, 24 Jul 2009 20:56:27 +0200 Subject: review (S) for 6861984: solaris version of libsaproc.so should support SA_ALTROOT directly In-Reply-To: <69CD9F5A-CAA1-45B6-BCC5-2D86FADB5E1C@sun.com> References: <31A56654-5E42-4E12-8F73-F610D1822C3D@Sun.COM> <69CD9F5A-CAA1-45B6-BCC5-2D86FADB5E1C@sun.com> Message-ID: <4A6A03DB.7000903@Sun.COM> Tom Rodriguez wrote: > No takers on this? Ohh, I had a look at the code and it looks good to me. -- Christian From Daniel.Daugherty at Sun.COM Fri Jul 24 12:18:44 2009 From: Daniel.Daugherty at Sun.COM (Daniel D. Daugherty) Date: Fri, 24 Jul 2009 13:18:44 -0600 Subject: Request for reviews (update)(S): 6863420: os::javaTimeNanos() go backward on Solaris x86] In-Reply-To: <4A69FB66.20405@sun.com> References: <4A69FB66.20405@sun.com> Message-ID: <4A6A0914.7090408@sun.com> Looks good to me. And a very nice catch! Dan Vladimir Kozlov wrote: > I updated the fix to use Atomic::load() always as David H. suggested. > > http://cr.openjdk.java.net/~kvn/6863420/webrev.01 > > Fixed 6863420: os::javaTimeNanos() go backward on Solaris x86 > > Problem: > The problem is non atomic load from max_hrtime in getTimeNanos() > on platforms where long is kept in 2 32-bit register. > The loaded value could be invalid (> current time) since registers > are loaded separately and store could happened in between. > It could be returned as result if it is greater then current time. > And if the next call getTimeNanos() returns the correct time > it will be less then previous result. > > Solution: > Use new atomic long load method Atomic::load() which uses > FPU to move long value atomically on 32-bit x86 or > simply returns *src in other cases. > > Added the regression test which shows the problem. > > Reviewed by: > > Fix verified (y/n): y, regression test > > Other testing: > JPRT, ScaleHarness(6784100) > From Thomas.Rodriguez at Sun.COM Fri Jul 24 12:36:40 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Fri, 24 Jul 2009 12:36:40 -0700 Subject: review (S) for 6861984: solaris version of libsaproc.so should support SA_ALTROOT directly In-Reply-To: <4A6A03DB.7000903@Sun.COM> References: <31A56654-5E42-4E12-8F73-F610D1822C3D@Sun.COM> <69CD9F5A-CAA1-45B6-BCC5-2D86FADB5E1C@sun.com> <4A6A03DB.7000903@Sun.COM> Message-ID: <90469750-DE50-45C7-8325-07AD4ACF70BD@Sun.COM> Thanks! tom On Jul 24, 2009, at 11:56 AM, Christian Thalinger wrote: > Tom Rodriguez wrote: >> No takers on this? > > Ohh, I had a look at the code and it looks good to me. > > -- Christian From Paul.Hohensee at Sun.COM Fri Jul 24 12:39:01 2009 From: Paul.Hohensee at Sun.COM (Paul Hohensee) Date: Fri, 24 Jul 2009 15:39:01 -0400 Subject: Request for reviews (update)(S): 6863420: os::javaTimeNanos() go backward on Solaris x86] In-Reply-To: <4A69FB66.20405@sun.com> References: <4A69FB66.20405@sun.com> Message-ID: <4A6A0DD5.4090508@sun.com> Nice. :) Sometime we should update the other os platforms with their own implementations. Nop for now of course. Paul Vladimir Kozlov wrote: > I updated the fix to use Atomic::load() always as David H. suggested. > > http://cr.openjdk.java.net/~kvn/6863420/webrev.01 > > Fixed 6863420: os::javaTimeNanos() go backward on Solaris x86 > > Problem: > The problem is non atomic load from max_hrtime in getTimeNanos() > on platforms where long is kept in 2 32-bit register. > The loaded value could be invalid (> current time) since registers > are loaded separately and store could happened in between. > It could be returned as result if it is greater then current time. > And if the next call getTimeNanos() returns the correct time > it will be less then previous result. > > Solution: > Use new atomic long load method Atomic::load() which uses > FPU to move long value atomically on 32-bit x86 or > simply returns *src in other cases. > > Added the regression test which shows the problem. > > Reviewed by: > > Fix verified (y/n): y, regression test > > Other testing: > JPRT, ScaleHarness(6784100) > From Thomas.Rodriguez at Sun.COM Fri Jul 24 12:42:02 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Fri, 24 Jul 2009 12:42:02 -0700 Subject: Request for reviews (update)(S): 6863420: os::javaTimeNanos() go backward on Solaris x86] In-Reply-To: <4A69FB66.20405@sun.com> References: <4A69FB66.20405@sun.com> Message-ID: Looks good. tom On Jul 24, 2009, at 11:20 AM, Vladimir Kozlov wrote: > I updated the fix to use Atomic::load() always as David H. suggested. > > http://cr.openjdk.java.net/~kvn/6863420/webrev.01 > > Fixed 6863420: os::javaTimeNanos() go backward on Solaris x86 > > Problem: > The problem is non atomic load from max_hrtime in getTimeNanos() > on platforms where long is kept in 2 32-bit register. > The loaded value could be invalid (> current time) since registers > are loaded separately and store could happened in between. > It could be returned as result if it is greater then current time. > And if the next call getTimeNanos() returns the correct time > it will be less then previous result. > > Solution: > Use new atomic long load method Atomic::load() which uses > FPU to move long value atomically on 32-bit x86 or > simply returns *src in other cases. > > Added the regression test which shows the problem. > > Reviewed by: > > Fix verified (y/n): y, regression test > > Other testing: > JPRT, ScaleHarness(6784100) > From y.s.ramakrishna at sun.com Fri Jul 24 16:29:04 2009 From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com) Date: Fri, 24 Jul 2009 23:29:04 +0000 Subject: hg: jdk7/hotspot/hotspot: 3 new changesets Message-ID: <20090724232942.871BAE599@hg.openjdk.java.net> Changeset: 45d97a99715b Author: apetrusenko Date: 2009-07-22 02:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/45d97a99715b 6862661: G1: _gc_alloc_region_counts is not updated properly after 6604422 Summary: Implementation of RFE 6604422 (G1: re-use half-promoted regions) introduced incorrect _gc_alloc_region_counts updates which effectively disabled survivor spaces. Reviewed-by: johnc, jmasa, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: 36b5611220a7 Author: ysr Date: 2009-07-22 18:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/36b5611220a7 6863216: Clean up debugging debris inadvertently pushed with 6700789 Summary: Anti-delta for debugging debris that was inadvertently pushed. Reviewed-by: kvn, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/opto/cfgnode.cpp Changeset: 0a83664f978b Author: ysr Date: 2009-07-24 12:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/0a83664f978b Merge ! src/share/vm/opto/cfgnode.cpp From David.Holmes at Sun.COM Fri Jul 24 19:00:17 2009 From: David.Holmes at Sun.COM (David Holmes - Sun Microsystems) Date: Sat, 25 Jul 2009 12:00:17 +1000 Subject: Request for reviews (update)(S): 6863420: os::javaTimeNanos() go backward on Solaris x86] In-Reply-To: <4A69FB66.20405@sun.com> References: <4A69FB66.20405@sun.com> Message-ID: <4A6A6731.5090902@sun.com> Looks good to me. Thanks Vladimir! David Vladimir Kozlov said the following on 07/25/09 04:20: > I updated the fix to use Atomic::load() always as David H. suggested. > > http://cr.openjdk.java.net/~kvn/6863420/webrev.01 > > Fixed 6863420: os::javaTimeNanos() go backward on Solaris x86 > > Problem: > The problem is non atomic load from max_hrtime in getTimeNanos() > on platforms where long is kept in 2 32-bit register. > The loaded value could be invalid (> current time) since registers > are loaded separately and store could happened in between. > It could be returned as result if it is greater then current time. > And if the next call getTimeNanos() returns the correct time > it will be less then previous result. > > Solution: > Use new atomic long load method Atomic::load() which uses > FPU to move long value atomically on 32-bit x86 or > simply returns *src in other cases. > > Added the regression test which shows the problem. > > Reviewed by: > > Fix verified (y/n): y, regression test > > Other testing: > JPRT, ScaleHarness(6784100) > From john.coomes at sun.com Sat Jul 25 03:10:55 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sat, 25 Jul 2009 10:10:55 +0000 Subject: hg: jdk7/hotspot: Added tag jdk7-b66 for changeset 6bad5e3fe503 Message-ID: <20090725101056.2DB21E69E@hg.openjdk.java.net> Changeset: 5dc862ec024e Author: xdono Date: 2009-07-24 13:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/5dc862ec024e Added tag jdk7-b66 for changeset 6bad5e3fe503 ! .hgtags From john.coomes at sun.com Sat Jul 25 03:18:12 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sat, 25 Jul 2009 10:18:12 +0000 Subject: hg: jdk7/hotspot/corba: Added tag jdk7-b66 for changeset a821e059a961 Message-ID: <20090725101814.9B827E6A3@hg.openjdk.java.net> Changeset: d5e36cb83d8c Author: xdono Date: 2009-07-24 13:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/d5e36cb83d8c Added tag jdk7-b66 for changeset a821e059a961 ! .hgtags From john.coomes at sun.com Sat Jul 25 03:28:00 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sat, 25 Jul 2009 10:28:00 +0000 Subject: hg: jdk7/hotspot/jaxp: Added tag jdk7-b66 for changeset 22f9d5d5b5fe Message-ID: <20090725102802.93D8EE6A8@hg.openjdk.java.net> Changeset: f8f9c0186d87 Author: xdono Date: 2009-07-24 13:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/f8f9c0186d87 Added tag jdk7-b66 for changeset 22f9d5d5b5fe ! .hgtags From john.coomes at sun.com Sat Jul 25 03:33:41 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sat, 25 Jul 2009 10:33:41 +0000 Subject: hg: jdk7/hotspot/jaxws: Added tag jdk7-b66 for changeset fa8712c099ed Message-ID: <20090725103344.3DB05E6AD@hg.openjdk.java.net> Changeset: 58f51e3cc0fa Author: xdono Date: 2009-07-24 13:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/58f51e3cc0fa Added tag jdk7-b66 for changeset fa8712c099ed ! .hgtags From john.coomes at sun.com Sat Jul 25 03:41:32 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sat, 25 Jul 2009 10:41:32 +0000 Subject: hg: jdk7/hotspot/jdk: 36 new changesets Message-ID: <20090725105125.79AD9E6B2@hg.openjdk.java.net> Changeset: b22f9e823be7 Author: alanb Date: 2009-06-30 11:11 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b22f9e823be7 6843003: Windows Server 2008 R2 system recognition Reviewed-by: ohair, sherman ! src/windows/native/java/lang/java_props_md.c Changeset: d57c10cf07c5 Author: alanb Date: 2009-06-30 11:13 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d57c10cf07c5 Merge Changeset: c2baa2f0415e Author: xuelei Date: 2009-07-03 11:13 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c2baa2f0415e 6853793: OutOfMemoryError in sun.security.provider.certpath.OCSPChecker.check Summary: allocate memory dynamically, keep reading until EOF. Reviewed-by: weijun ! src/share/classes/sun/security/provider/certpath/OCSPChecker.java ! src/share/classes/sun/security/timestamp/HttpTimestamper.java Changeset: 803db6c94a3b Author: martin Date: 2009-07-03 07:24 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/803db6c94a3b 6857287: (file) Clarifications for symbolic link related javadoc Summary: Fix up jsr203 file javadoc related to symbolic links Reviewed-by: alanb ! src/share/classes/java/nio/file/LinkPermission.java ! src/share/classes/java/nio/file/NotLinkException.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/SecureDirectoryStream.java ! src/share/classes/java/nio/file/attribute/Attributes.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributes.java Changeset: 75459b125461 Author: tbell Date: 2009-07-03 16:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/75459b125461 Merge Changeset: fa488e4ff685 Author: jccollet Date: 2009-07-06 15:13 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/fa488e4ff685 6856856: NPE in HTTP protocol handler logging Summary: Fixed the NPE and Moved the java.util.logging dependency to a single class and used reflection to make it a soft one. Reviewed-by: chegar ! src/share/classes/sun/net/www/http/HttpCapture.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpLogFormatter.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: 0cabe1192c8b Author: martin Date: 2009-07-06 11:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0cabe1192c8b 6854795: Miscellaneous improvements to "jar" Summary: cleanup of jar/Main.java (Initial patch by tobyr at google.com, additional review by jeremymanson at google.com, ulf.zibis at gmx.de) Reviewed-by: sherman, alanb ! src/share/classes/sun/tools/jar/Main.java ! test/tools/jar/index/MetaInf.java Changeset: 0a294c066e7a Author: darcy Date: 2009-07-07 16:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0a294c066e7a 6857803: Missing links to exceptions in javadoc for Class.getGeneric{Superclass, Interfaces} Reviewed-by: chegar ! src/share/classes/java/lang/Class.java Changeset: 1175f872a968 Author: weijun Date: 2009-07-08 12:07 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1175f872a968 6857802: GSS getRemainingInitLifetime method returns milliseconds not seconds Reviewed-by: xuelei ! src/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java + test/sun/security/krb5/auto/LifeTimeInSeconds.java Changeset: 1df67a3ecce8 Author: weijun Date: 2009-07-08 12:07 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1df67a3ecce8 6857795: krb5.conf ignored if system properties on realm and kdc are provided Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/Config.java + test/sun/security/krb5/ConfPlusProp.java + test/sun/security/krb5/confplusprop.conf + test/sun/security/krb5/confplusprop2.conf Changeset: d133d4052378 Author: ohair Date: 2009-07-08 09:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d133d4052378 6858127: Missing -DNDEBUG on Linux and Windows native code compiles Reviewed-by: tbell, dcubed ! make/common/Defs-linux.gmk ! make/common/Defs-windows.gmk Changeset: d3a08f8c3c86 Author: ohair Date: 2009-07-08 09:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d3a08f8c3c86 6855551: java -Xrunhprof crashes when running with classes compiled with targed=7 Reviewed-by: tbell, dcubed ! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c ! test/demo/jvmti/hprof/HelloWorld.java ! test/demo/jvmti/hprof/StackMapTableTest.java Changeset: ae60bb671e54 Author: darcy Date: 2009-07-09 12:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ae60bb671e54 6628737: Specification of wrapper class valueOf static factories should require caching Reviewed-by: mr ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java Changeset: 6f26e2e5f4f3 Author: xuelei Date: 2009-07-10 17:27 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6f26e2e5f4f3 6852744: PIT b61: PKI test suite fails because self signed certificates are beingrejected Summary: make the builder aware of SKID/AKID, break the internal circular dependences Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java + test/java/security/cert/CertPathBuilder/selfIssued/DisableRevocation.java + test/java/security/cert/CertPathBuilder/selfIssued/KeyUsageMatters.java + test/java/security/cert/CertPathBuilder/selfIssued/README + test/java/security/cert/CertPathBuilder/selfIssued/StatusLoopDependency.java + test/java/security/cert/CertPathBuilder/selfIssued/generate.sh + test/java/security/cert/CertPathBuilder/selfIssued/openssl.cnf Changeset: 880896883a47 Author: andrew Date: 2009-07-11 16:43 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/880896883a47 6562614: Compiler warnings for gettimeofday in Inet4/Inet6AddressImpl.c Summary: Add missing header to remove compiler warnings. Reviewed-by: martin Contributed-by: Matthew Flaschen ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c Changeset: d0ce095004b2 Author: xuelei Date: 2009-07-13 23:01 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d0ce095004b2 6453837: PartialCompositeContext.allEmpty is buggy Reviewed-by: weijun ! src/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java Changeset: beb5e5cad3ae Author: valeriep Date: 2009-07-13 15:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/beb5e5cad3ae 6832540: IllegalArgumentException in ClassLoader.definePackage when classes are loaded in parallel Summary: Modified to handle race condition for parallel-capable classloaders by re-trying/re-verifying package Reviewed-by: alanb ! src/share/classes/java/net/URLClassLoader.java Changeset: 53b27ac4f706 Author: tbell Date: 2009-07-13 23:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/53b27ac4f706 Merge ! make/common/Defs-windows.gmk Changeset: 51ccb32e6d14 Author: tbell Date: 2009-07-16 18:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/51ccb32e6d14 Merge Changeset: 043c7100a752 Author: anthony Date: 2009-07-07 17:05 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/043c7100a752 6853916: java.awt.Window.setBackground(null) throws NullPointerException Summary: Window.setBackground() should check for null. Reviewed-by: art, dcherepanov ! src/share/classes/java/awt/Window.java + test/java/awt/Window/SetBackgroundNPE/SetBackgroundNPE.java Changeset: 99cdc0268e4b Author: dcherepanov Date: 2009-07-09 15:15 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/99cdc0268e4b 6855323: Robot(GraphicsDevice) constructor initializes LEGAL_BUTTON_MASK variable improperly Reviewed-by: art ! src/share/classes/java/awt/Robot.java + test/java/awt/Robot/CtorTest/CtorTest.java Changeset: 9b1e640af25e Author: dcherepanov Date: 2009-07-09 15:18 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9b1e640af25e 6759726: TrayIcon constructor throws NPE instead of documented IAE Reviewed-by: art ! src/share/classes/java/awt/TrayIcon.java + test/java/awt/TrayIcon/CtorTest/CtorTest.java Changeset: df34ec9f3e26 Author: dcherepanov Date: 2009-07-09 15:23 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/df34ec9f3e26 6847958: MouseWheel event is getting triggered for the disabled Textarea in jdk7 b60 pit build. Reviewed-by: art ! src/solaris/classes/sun/awt/X11/XBaseWindow.java + test/java/awt/event/MouseWheelEvent/DisabledComponent/DisabledComponent.java Changeset: c27d7c1d1918 Author: dcherepanov Date: 2009-07-09 15:53 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c27d7c1d1918 6847149: test/java/awt/Window/OwnedWindowsLeak/OwnedWindowsLeak.java fails Reviewed-by: art ! test/java/awt/Window/OwnedWindowsLeak/OwnedWindowsLeak.java Changeset: 6d92ce5fe15b Author: yan Date: 2009-07-12 23:20 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6d92ce5fe15b Merge - src/share/classes/java/nio/file/DirectoryStreamFilters.java - src/share/classes/java/nio/file/FileAction.java - src/share/classes/java/nio/file/spi/AbstractPath.java - src/share/classes/sun/io/ByteToCharMS932DB.java - src/share/classes/sun/io/CharToByteMS932DB.java - src/share/classes/sun/nio/cs/ext/EUC_CN.java - src/share/classes/sun/nio/cs/ext/EUC_KR.java - src/share/classes/sun/nio/cs/ext/GBK.java - src/share/classes/sun/nio/cs/ext/Johab.java - src/share/classes/sun/nio/cs/ext/MS932.java - src/share/classes/sun/nio/cs/ext/MS932DB.java - src/share/classes/sun/nio/cs/ext/MS936.java - src/share/classes/sun/nio/cs/ext/MS949.java - src/share/classes/sun/nio/cs/ext/MS950.java - src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java - src/share/classes/sun/nio/fs/MimeType.java - test/java/nio/file/DirectoryStream/Filters.java - test/java/nio/file/Files/content_type.sh - test/java/nio/file/Path/temporary_files.sh - test/java/nio/file/attribute/Attributes/Basic.java Changeset: 4cd623432e7d Author: anthony Date: 2009-07-14 14:08 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4cd623432e7d 6837446: Introduce Window.isOpaque() method Reviewed-by: art, alexp ! src/share/classes/com/sun/awt/AWTUtilities.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/GraphicsDevice.java ! src/share/classes/java/awt/Window.java ! src/share/classes/javax/swing/DefaultDesktopManager.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/awt/SunToolkit.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: fc869bc0cd63 Author: yan Date: 2009-07-14 22:13 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/fc869bc0cd63 Merge Changeset: bccc4d5e8d6a Author: malenkov Date: 2009-07-02 19:48 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/bccc4d5e8d6a 6380849: RFE: Automatic discovery of PersistanceDelegates Reviewed-by: rupashka, alexp + src/share/classes/com/sun/beans/finder/BeanInfoFinder.java + src/share/classes/com/sun/beans/finder/InstanceFinder.java + src/share/classes/com/sun/beans/finder/PersistenceDelegateFinder.java + src/share/classes/com/sun/beans/finder/PropertyEditorFinder.java ! src/share/classes/java/beans/Encoder.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyEditorManager.java + test/java/beans/Introspector/6380849/TestBeanInfo.java + test/java/beans/Introspector/6380849/beans/FirstBean.java + test/java/beans/Introspector/6380849/beans/FirstBeanBeanInfo.java + test/java/beans/Introspector/6380849/beans/SecondBean.java + test/java/beans/Introspector/6380849/beans/ThirdBean.java + test/java/beans/Introspector/6380849/infos/SecondBeanBeanInfo.java + test/java/beans/Introspector/6380849/infos/ThirdBeanBeanInfo.java + test/java/beans/PropertyEditor/6380849/FirstBean.java + test/java/beans/PropertyEditor/6380849/FirstBeanEditor.java + test/java/beans/PropertyEditor/6380849/SecondBean.java + test/java/beans/PropertyEditor/6380849/TestPropertyEditor.java + test/java/beans/PropertyEditor/6380849/ThirdBean.java + test/java/beans/PropertyEditor/6380849/editors/SecondBeanEditor.java + test/java/beans/PropertyEditor/6380849/editors/ThirdBeanEditor.java + test/java/beans/XMLEncoder/6380849/Bean.java + test/java/beans/XMLEncoder/6380849/BeanPersistenceDelegate.java + test/java/beans/XMLEncoder/6380849/TestPersistenceDelegate.java Changeset: 7720d6c079ca Author: malenkov Date: 2009-07-03 16:56 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7720d6c079ca 6329581: RFE: LTP: java.beans.XMLEncoder does not manage ClassLoader. Reviewed-by: rupashka, alexp ! src/share/classes/java/beans/Encoder.java ! src/share/classes/java/beans/MetaData.java ! src/share/classes/java/beans/Statement.java + test/java/beans/XMLEncoder/6329581/Test6329581.java Changeset: ef20a15b3569 Author: malenkov Date: 2009-07-06 14:32 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ef20a15b3569 6723447: Introspector doesn't check return type for indexed property setters Reviewed-by: rupashka ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/Introspector/Test6723447.java Changeset: 0407df5a768e Author: rupashka Date: 2009-07-07 14:11 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0407df5a768e 6489447: Apply the more robust fix for 6449933 to dolphin and 6ux Reviewed-by: malenkov ! src/windows/native/sun/windows/ShellFolder2.cpp Changeset: 913ad033bb37 Author: yan Date: 2009-07-12 06:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/913ad033bb37 Merge - src/share/classes/java/nio/file/DirectoryStreamFilters.java - src/share/classes/java/nio/file/FileAction.java - src/share/classes/java/nio/file/spi/AbstractPath.java - src/share/classes/sun/io/ByteToCharMS932DB.java - src/share/classes/sun/io/CharToByteMS932DB.java - src/share/classes/sun/nio/cs/ext/EUC_CN.java - src/share/classes/sun/nio/cs/ext/EUC_KR.java - src/share/classes/sun/nio/cs/ext/GBK.java - src/share/classes/sun/nio/cs/ext/Johab.java - src/share/classes/sun/nio/cs/ext/MS932.java - src/share/classes/sun/nio/cs/ext/MS932DB.java - src/share/classes/sun/nio/cs/ext/MS936.java - src/share/classes/sun/nio/cs/ext/MS949.java - src/share/classes/sun/nio/cs/ext/MS950.java - src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java - src/share/classes/sun/nio/fs/MimeType.java - src/share/classes/sun/swing/AccessibleMethod.java - test/java/nio/file/DirectoryStream/Filters.java - test/java/nio/file/Files/content_type.sh - test/java/nio/file/Path/temporary_files.sh - test/java/nio/file/attribute/Attributes/Basic.java Changeset: c8da3750c7ca Author: yan Date: 2009-07-14 22:15 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c8da3750c7ca Merge Changeset: f88379effbcf Author: yan Date: 2009-07-21 23:23 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f88379effbcf Merge Changeset: bd31b30a5b21 Author: dcherepanov Date: 2009-07-23 11:30 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/bd31b30a5b21 6857870: Regression tests are failing with ExceptionInInitializerError Reviewed-by: art ! src/windows/classes/sun/awt/windows/WToolkit.java Changeset: 11a8f0936228 Author: xdono Date: 2009-07-24 13:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/11a8f0936228 Added tag jdk7-b66 for changeset bd31b30a5b21 ! .hgtags From john.coomes at sun.com Sat Jul 25 04:04:09 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sat, 25 Jul 2009 11:04:09 +0000 Subject: hg: jdk7/hotspot/langtools: Added tag jdk7-b66 for changeset 634f519d6f9a Message-ID: <20090725110413.AFA49E6B7@hg.openjdk.java.net> Changeset: 0695e8ebae88 Author: xdono Date: 2009-07-24 13:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/0695e8ebae88 Added tag jdk7-b66 for changeset 634f519d6f9a ! .hgtags From Christian.Thalinger at Sun.COM Mon Jul 27 04:16:10 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Mon, 27 Jul 2009 13:16:10 +0200 Subject: Math trig intrinsics and compiler options In-Reply-To: <311e0eaf0907160839r4789d10cxad6bfb19e57f51ad@mail.gmail.com> References: <2793ec670907151921p3b558286we89f7e3e0575ed3c@mail.gmail.com> <4A5F4343.9020505@Sun.COM> <311e0eaf0907160839r4789d10cxad6bfb19e57f51ad@mail.gmail.com> Message-ID: <4A6D8C7A.4020303@Sun.COM> [Sorry for the long delay, I was on vacation.] gustav trede wrote: > do you mind sharing details about that test so i can reproduce it ?. Sure, it's a very simple testcase: public class sin { public static void main(String[] args) { System.out.println(foo()); } static double foo() { double sum = 0.0; for (double d = 0.0; d < 2 * Math.PI; d += 0.00000005) { sum += bar(d); } // for (double d = 0.0; d < Math.PI / 4; d += 0.000000001) { // sum += bar(d); // } return sum; } static double bar(double d) { return Math.sin(d); } } -- Christian From Christian.Thalinger at Sun.COM Tue Jul 28 03:50:56 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Tue, 28 Jul 2009 12:50:56 +0200 Subject: Request for reviews (XS): 6865583: Verbose CIPrintMethodCodes asserts when ldc an empty String Message-ID: <4A6ED810.6020201@Sun.COM> http://cr.openjdk.java.net/~twisti/6865583/webrev.01/ From Vladimir.Kozlov at Sun.COM Tue Jul 28 08:43:11 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Tue, 28 Jul 2009 08:43:11 -0700 Subject: Request for reviews (XS): 6865583: Verbose CIPrintMethodCodes asserts when ldc an empty String In-Reply-To: <4A6ED810.6020201@Sun.COM> References: <4A6ED810.6020201@Sun.COM> Message-ID: <4A6F1C8F.5030807@sun.com> Looks good. Could you also fix java_lang_String::as_symbol_or_null() ? Thanks, Vladimir Christian Thalinger wrote: > http://cr.openjdk.java.net/~twisti/6865583/webrev.01/ From Christian.Thalinger at Sun.COM Tue Jul 28 09:03:36 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Tue, 28 Jul 2009 18:03:36 +0200 Subject: Request for reviews (XS): 6865583: Verbose CIPrintMethodCodes asserts when ldc an empty String In-Reply-To: <4A6F1C8F.5030807@sun.com> References: <4A6ED810.6020201@Sun.COM> <4A6F1C8F.5030807@sun.com> Message-ID: <4A6F2158.2080703@Sun.COM> Vladimir Kozlov wrote: > Looks good. Could you also fix java_lang_String::as_symbol_or_null() ? Sure. I just wanted to hear someone saying that :-) -- Christian From Christian.Thalinger at Sun.COM Tue Jul 28 09:39:52 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Tue, 28 Jul 2009 18:39:52 +0200 Subject: Request for reviews (XS): 6865583: Verbose CIPrintMethodCodes asserts when ldc an empty String In-Reply-To: <4A6F1C8F.5030807@sun.com> References: <4A6ED810.6020201@Sun.COM> <4A6F1C8F.5030807@sun.com> Message-ID: <4A6F29D8.8040407@Sun.COM> Vladimir Kozlov wrote: > Looks good. Could you also fix java_lang_String::as_symbol_or_null() ? For the record, here it is: http://cr.openjdk.java.net/~twisti/6865583/webrev.02/ -- Christian From Thomas.Rodriguez at Sun.COM Tue Jul 28 09:44:35 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 28 Jul 2009 09:44:35 -0700 Subject: Request for reviews (XS): 6865583: Verbose CIPrintMethodCodes asserts when ldc an empty String In-Reply-To: <4A6F29D8.8040407@Sun.COM> References: <4A6ED810.6020201@Sun.COM> <4A6F1C8F.5030807@sun.com> <4A6F29D8.8040407@Sun.COM> Message-ID: Looks good. tom On Jul 28, 2009, at 9:39 AM, Christian Thalinger wrote: > Vladimir Kozlov wrote: >> Looks good. Could you also fix >> java_lang_String::as_symbol_or_null() ? > > For the record, here it is: > > http://cr.openjdk.java.net/~twisti/6865583/webrev.02/ > > -- Christian From Vladimir.Kozlov at Sun.COM Tue Jul 28 16:14:33 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Tue, 28 Jul 2009 16:14:33 -0700 Subject: Request for reviews (M): 6580131: Exposing Method Inlining Information To JVMTI Agents Message-ID: <4A6F8659.3090802@sun.com> http://cr.openjdk.java.net/~kvn/6580131/webrev.00 Fixed 6580131: CompiledMethodLoad events don't produce the expected extra notifications to describe inlining and https://bugs.openjdk.java.net/show_bug.cgi?id=100085 Exposing Method Inlining Information To JVMTI Agents Problem: (from 6580131 Description) The spec for JVMTI says or implies that CompiledMethodLoad should generate extra events to describe the inlining in a piece of compiled code. Currently we don't do this which really limits the amount of information available for methods with heavy inlining. We should probably be producing the extra events, assuming that existing tools don't barf when they get them. Solution: (from 100085 Description) Whenever Hotspot JVM compiles a method, it creates a list of records that specify what method invocations are on the compile-time stack at each program address. Hotspot JVM was extended to make this information visible to external tools through the JVMTI layer, without altering the JVMTI specification. The main change was to pass this stack information through the CompiledMethodLoad JVMTI callback. As a result, external tools can use this information to produce better source-to-address mapping. Contributed-by: Vasanth.Venkatachalam at amd.com Reviewed by: Other testing: JPRT From Daniel.Daugherty at Sun.COM Wed Jul 29 08:11:46 2009 From: Daniel.Daugherty at Sun.COM (Daniel D. Daugherty) Date: Wed, 29 Jul 2009 09:11:46 -0600 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> References: <20090722214810.175B451B@eggemoggin.niobe.net> <20090723152650.1C8206F6@eggemoggin.niobe.net> <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> Message-ID: <4A7066B2.7050905@sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20090729/9c6f9bf6/attachment.html From gnu_andrew at member.fsf.org Wed Jul 29 08:14:34 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Wed, 29 Jul 2009 16:14:34 +0100 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <4A7066B2.7050905@sun.com> References: <20090722214810.175B451B@eggemoggin.niobe.net> <20090723152650.1C8206F6@eggemoggin.niobe.net> <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> <4A7066B2.7050905@sun.com> Message-ID: <17c6771e0907290814sa8aa2b7hf075217d0ca2c922@mail.gmail.com> 2009/7/29 Daniel D. Daugherty : > Andrew John Hughes wrote: > > 2009/7/23 Mark Reinhold : > > > From: Mark Reinhold > Date: Wed, 22 Jul 2009 14:48:10 -0700 > > > ... > > Your repo looks fine to me -- thanks for creating it. > > Shall I go ahead and replace the current jdk6/hotspot repo with this? > (That is, does anyone have any concerns?) > > > Here's something (perhaps) to be concerned about: A recently-reported > regression in Sun's proprietary 6u14 (and hence also in hsx14) causes > debugging breakpoints to be ignored in some circumstances. ?The bug is > reproducible with both the client and server VMs, but only using the > serial GC. > > The primary Sun bugid is 6862295 [1]; see also the downstream bug first > reported in Eclipse [2]. ?Dan Daugherty is working on a fix, which we'll > publish when available, but in the meantime hsx14 has this bug. > > Is the existence of this bug in hsx14 a reason to delay replacing the > current jdk6/hotspot repo with Andrew's newer version? ?Let me know. > > - Mark > > > [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6862295 > [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=279137 > > > > It's a concern, no doubt about that, but not moving to hs14 because of > it is a bit like shutting the stable door after the horse has bolted; > both IcedTea and Sun's proprietary releases have been shipping hs14 > for some time. I think the better course of action is to get the > patch in as soon as it is available and then roll it out in new > releases. > > Besides, the proposed update doesn't (yet) move OpenJDK6 to HotSpot > 14. It rebases the repository so it's now at revision 0 of the > current HotSpot7 repositories (plus the OpenJDK6 fixes), allowing > changesets from the hs14 master and also the main HotSpot7 repository > to be merged (as they all then have a common parent). This is > actually hs12b0 I believe (from b24 of OpenJDK7). > > > The fix for 6862295 was pushed to the hotspot-rt repo for HSX-16 > last night; it should be integrated in HSX-16-B08. I have the > same fix queued up for HSX-14.1 or HSX-14.2 depending on whether > the fix is approved for 6u15 or 6u16. > > I also have the fix ready for the > http://hg.openjdk.java.net/jdk6/jdk6/hotspot repo. The only odd > thing I see is that the changeset ID is different for openjdk6 > version: > > changeset:?? 58:52f2c77b32e1 > tag:???????? tip > user:??????? dcubed > date:??????? Tue Jul 28 13:35:00 2009 -0600 > files:?????? src/share/vm/memory/genCollectedHeap.cpp > src/share/vm/prims/jvmtiExport.cpp src/share/vm/runtime/globals.hpp > description: > 6862295: JDWP threadid changes during debugging session (leading to ingored > breakpoints) > Summary: Correctly count full GC operations for framework collectors. Add > ForceFullGCJVMTIEpilogues as a future work around if needed. > Reviewed-by: jcoomes, alanb, ysr > > > Here is the changeset from the HSX-14.[12] and HSX-16 versions: > > changeset:?? 558:2b4230d1e589 > parent:????? 501:26bc4770e671 > user:??????? dcubed > date:??????? Tue Jul 28 13:35:00 2009 -0600 > files:?????? src/share/vm/memory/genCollectedHeap.cpp > src/share/vm/prims/jvmtiExport.cpp src/share/vm/runtime/globals.hpp > description: > 6862295: JDWP threadid changes during debugging session (leading to ingored > breakpoints) > Summary: Correctly count full GC operations for framework collectors. Add > ForceFullGCJVMTIEpilogues as a future work around if needed. > Reviewed-by: jcoomes, alanb, ysr > > > I used "hg export" from the HSX-14.1 version to generate the > patch for the openjdk6 version and I used "hg import" on the > patch file. I expected the changeset ID to be the same. > > For the HSX-14.[12] and HSX-16 versions, I found the common > ancestor changeset (501:26bc4770e671), made the changes > relative to that changeset and merged the changes forward > to each release's repo. The common changeset for HSX-14.1 > and openjdk6 goes all the way back to changeset 1. Ouch! > > Maybe there's a better way to do this... > > Dan > > P.S. > What's the process for getting the fix into openjdk6? > Hi Dan, As I mentioned in my last mail, OpenJDK6's repo is still as it was before: at hs12b0. It and the other HotSpot repositories now have a common ancestor, but it's not yet a copy of hs14. I plan to post a webrev moving it forward to hs14 (via a pull from hs14/master). It might be easier to just wait until this is applied, or, if the patch you mention is already in hs14/master it will get applied as part of this merge anyway. Hope that helps, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From erik.trimble at sun.com Wed Jul 29 16:26:29 2009 From: erik.trimble at sun.com (erik.trimble at sun.com) Date: Wed, 29 Jul 2009 23:26:29 +0000 Subject: hg: jdk7/hotspot/hotspot: 6 new changesets Message-ID: <20090729232650.70959EBD6@hg.openjdk.java.net> Changeset: 57c71ad0341b Author: xdono Date: 2009-07-16 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/57c71ad0341b Added tag jdk7-b65 for changeset ba313800759b ! .hgtags Changeset: 1c2487639400 Author: trims Date: 2009-07-24 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/1c2487639400 Merge Changeset: 3c0f72981560 Author: trims Date: 2009-07-24 16:41 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/3c0f72981560 6864901: Bump the HS16 build number to 07 Summary: Update the HS16 build number to 07 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 96e4ccadd5f6 Author: xdono Date: 2009-07-24 13:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/96e4ccadd5f6 Added tag jdk7-b66 for changeset 57c71ad0341b ! .hgtags Changeset: bd02caa94611 Author: xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/bd02caa94611 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! agent/src/os/linux/Makefile ! agent/src/share/classes/sun/jvm/hotspot/HotSpotTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/code/DebugInfoReadStream.java ! agent/src/share/classes/sun/jvm/hotspot/code/MonitorValue.java ! agent/src/share/classes/sun/jvm/hotspot/code/ScopeDesc.java ! agent/src/share/classes/sun/jvm/hotspot/code/ScopeValue.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/Debugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/DebuggerBase.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/JVMDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerServer.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/ObjectReferenceImpl.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/ThreadReferenceImpl.java ! agent/src/share/classes/sun/jvm/hotspot/memory/Universe.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/ClassConstants.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/CompiledVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/InterpretedVFrame.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/MonitorInfo.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/StackValue.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/StubRoutines.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Thread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ByteCodeRewriter.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! agent/src/share/classes/sun/jvm/hotspot/ui/tree/OopTreeNodeAdapter.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaThread.java ! make/jprt.properties ! make/linux/makefiles/jsig.make ! make/linux/makefiles/saproc.make ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/sparcWorks.make ! make/windows/build_vm_def.sh ! make/windows/create.bat ! make/windows/get_msc_ver.sh ! make/windows/makefiles/adlc.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/makedeps.make ! make/windows/makefiles/rules.make ! make/windows/makefiles/sa.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/vm.make ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/sparc/vm/globals_sparc.hpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/x86/vm/interpreterRT_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.hpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/x86/vm/vtableStubs_x86_32.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/solaris/dtrace/generateJvmOffsets.cpp ! src/os/solaris/dtrace/jhelper.d ! src/os/solaris/dtrace/libjvm_db.c ! src/os_cpu/linux_sparc/vm/globals_linux_sparc.hpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.hpp ! src/os_cpu/linux_x86/vm/globals_linux_x86.hpp ! src/os_cpu/linux_x86/vm/orderAccess_linux_x86.inline.hpp ! src/os_cpu/solaris_sparc/vm/globals_solaris_sparc.hpp ! src/os_cpu/solaris_sparc/vm/orderAccess_solaris_sparc.inline.hpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/globals_solaris_x86.hpp ! src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp ! src/os_cpu/windows_x86/vm/globals_windows_x86.hpp ! src/os_cpu/windows_x86/vm/orderAccess_windows_x86.inline.hpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.hpp ! src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp ! src/share/tools/MakeDeps/BuildConfig.java ! src/share/tools/MakeDeps/WinGammaPlatformVC7.java ! src/share/tools/MakeDeps/WinGammaPlatformVC8.java ! src/share/tools/MakeDeps/WinGammaPlatformVC9.java ! src/share/tools/hsdis/Makefile ! src/share/tools/hsdis/hsdis-demo.c ! src/share/tools/hsdis/hsdis.c ! src/share/vm/adlc/adlc.hpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciMethodBlocks.cpp ! src/share/vm/ci/ciStreams.cpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/ci/ciTypeFlow.cpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.hpp ! src/share/vm/gc_implementation/g1/concurrentZFThread.hpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.hpp ! src/share/vm/gc_implementation/parNew/parGCAllocBuffer.hpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp ! src/share/vm/gc_implementation/shared/concurrentGCThread.cpp ! src/share/vm/gc_implementation/shared/concurrentGCThread.hpp ! src/share/vm/gc_interface/gcCause.hpp ! src/share/vm/includeDB_compiler1 ! src/share/vm/includeDB_jvmti ! src/share/vm/interpreter/bytecode.cpp ! src/share/vm/interpreter/bytecode.hpp ! src/share/vm/interpreter/bytecodeStream.hpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/bytecodes.cpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/interpreter/invocationCounter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/interpreter/templateTable.cpp ! src/share/vm/interpreter/templateTable.hpp ! src/share/vm/memory/blockOffsetTable.hpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/heap.cpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/generateOopMap.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/buildOopMap.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/coalesce.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/superword.hpp ! src/share/vm/prims/jvm_misc.hpp ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/methodComparator.cpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/dtraceJSDT.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/hpi.hpp ! src/share/vm/runtime/interfaceSupport.cpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp ! src/share/vm/runtime/orderAccess.cpp ! src/share/vm/runtime/orderAccess.hpp ! src/share/vm/runtime/stackValue.cpp ! src/share/vm/runtime/stackValue.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/runtime/vframe.hpp ! src/share/vm/runtime/vframeArray.cpp ! src/share/vm/runtime/vframe_hp.cpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vm_operations.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/utilities/bitMap.cpp ! src/share/vm/utilities/bitMap.hpp ! src/share/vm/utilities/bitMap.inline.hpp ! src/share/vm/utilities/exceptions.hpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp ! src/share/vm/utilities/macros.hpp ! test/compiler/6772683/InterruptedTest.java ! test/compiler/6832293/Test.java ! test/runtime/6819213/TestBootNativeLibraryPath.java Changeset: 18f526145aea Author: trims Date: 2009-07-29 16:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/18f526145aea Merge ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/stackValue.cpp From Thomas.Rodriguez at Sun.COM Thu Jul 30 11:34:14 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Thu, 30 Jul 2009 11:34:14 -0700 Subject: Request for reviews (M): 6580131: Exposing Method Inlining Information To JVMTI Agents In-Reply-To: <4A6F8659.3090802@sun.com> References: <4A6F8659.3090802@sun.com> Message-ID: <1C51CDB7-653A-4350-A7BE-81D09F8B239E@sun.com> So I have a bunch of issues with the code itself but before even getting into that I have a larger question. This is essentially a new public API to HotSpot so we need a standard header file that can be used to get the definition of the data we're passing. Where is that going to live and where is this going to be documented? I also think that we need to define some sort of header for the compile_info argument so that it can be properly identified and versioned assuming that we might extend or improve it in the future. As far as the code itself: Function names should be all lower case with underscores. Don't use CHeapObj::operator new for C heap allocations. Use NEW_C_HEAP_ARRAY. Actually I don't see why it can't simply use resource allocation instead. There's an appropriate ResourceMark at the use site. PCDescriptorList should inherit from StackObj since it is designed to be used with stack discipline. We don't use the ifndef/define idiom for header files. The date in the copyright notice for the new files is wrong. the jint type field of InlineInfoRecord is unused. Why does it contain both a pc and an offset? I think the pc is sufficient given the other information in the event. The jmethodID[] should be named methods instead of frames and bytecodeindexes should simply be bcis. The comment on PCDescriptorList says that it's using arena allocation which isn't true. It also needs at least a couple sentences of comments describing what it does and how. The "if(pclist != NULL && pclist->tail != NULL)" checks in addActivationRecord and intializeActivationRecords should really be asserts. Failing that test indicates a misuse of the API. Same with the pclist == NULL test in addPCDescriptor. I think the passed out void * should have some facility for identifying what's being passed and versioning that data. Passing out a raw pointer seems like a bad idea. The _compile_info pointer should be passed through the constructor instead of being set separately. get_pc_descriptors should be part of PCDescriptorList instead of nmethod since it's implementable using only public API. I think the checks for null and numstackframes != 0 should be asserts since those should be impossible values. tom On Jul 28, 2009, at 4:14 PM, Vladimir Kozlov wrote: > http://cr.openjdk.java.net/~kvn/6580131/webrev.00 > > Fixed 6580131: CompiledMethodLoad events don't produce the expected > extra notifications to describe inlining > > and > > https://bugs.openjdk.java.net/show_bug.cgi?id=100085 Exposing Method > Inlining Information To JVMTI Agents > > Problem: (from 6580131 Description) > The spec for JVMTI says or implies that CompiledMethodLoad > should generate extra events to describe the inlining in > a piece of compiled code. Currently we don't do this which > really limits the amount of information available for methods > with heavy inlining. We should probably be producing the extra > events, assuming that existing tools don't barf when they > get them. > > Solution: (from 100085 Description) > Whenever Hotspot JVM compiles a method, it creates > a list of records that specify what method invocations are > on the compile-time stack at each program address. Hotspot JVM > was extended to make this information visible to external > tools through the JVMTI layer, without altering the JVMTI > specification. The main change was to pass this stack > information through the CompiledMethodLoad JVMTI callback. > As a result, external tools can use this information > to produce better source-to-address mapping. > > Contributed-by: Vasanth.Venkatachalam at amd.com > > Reviewed by: > > Other testing: > JPRT > From coleen.phillimore at sun.com Thu Jul 30 16:10:13 2009 From: coleen.phillimore at sun.com (coleen.phillimore at sun.com) Date: Thu, 30 Jul 2009 23:10:13 +0000 Subject: hg: jdk7/hotspot/hotspot: 8 new changesets Message-ID: <20090730231033.4BB56ED2E@hg.openjdk.java.net> Changeset: 6a93908f268f Author: mchung Date: 2009-07-10 11:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/6a93908f268f 6857194: Add hotspot perf counters to aid class loading performance measurement Summary: Add new jvmstat counters to measure detailed class loading time Reviewed-by: acorn, kamg ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoader.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/includeDB_core ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/perfData.hpp ! src/share/vm/services/threadService.cpp ! src/share/vm/services/threadService.hpp Changeset: 1413494da700 Author: martin Date: 2009-06-29 14:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/1413494da700 6850957: Honor -XX:OnOutOfMemoryError when array size exceeds VM limit Summary: call report_java_out_of_memory("Requested array size exceeds VM limit") Reviewed-by: tbell, dholmes, alanb, ysr Contributed-by: jeremymanson at google.com ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.cpp Changeset: 8c79517a9300 Author: poonam Date: 2009-07-16 18:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/8c79517a9300 6840305: Discrepancy in system memory details (when 4G or greater) reported by JVM and Windows OS Summary: GlobalMemoryStatus() does not report correct memory usage when the system has more than 4gb of RAM. GlobalMemoryStatusEx() should be used in place of GlobalMemoryStatus(). Reviewed-by: kamg, coleenp ! src/os/windows/vm/os_windows.cpp Changeset: abe076e3636f Author: mchung Date: 2009-07-27 09:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/abe076e3636f 6864003: Modify JVM_FindClassFromBootLoader to return null if class not found Summary: JVM_FindClassFromBootLoader returns null if class not found Reviewed-by: acorn, alanb, dholmes ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h Changeset: 494244ae0171 Author: coleenp Date: 2009-07-27 17:23 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/494244ae0171 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/includeDB_core ! src/share/vm/oops/objArrayKlass.cpp Changeset: 2b4230d1e589 Author: dcubed Date: 2009-07-28 13:35 -0600 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/2b4230d1e589 6862295: JDWP threadid changes during debugging session (leading to ingored breakpoints) Summary: Correctly count full GC operations for framework collectors. Add ForceFullGCJVMTIEpilogues as a future work around if needed. Reviewed-by: jcoomes, alanb, ysr ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/globals.hpp Changeset: 16c930df1e9b Author: dcubed Date: 2009-07-28 13:50 -0600 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/16c930df1e9b Merge ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/globals.hpp Changeset: 66b0f834a440 Author: coleenp Date: 2009-07-30 15:06 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/66b0f834a440 Merge ! src/share/vm/classfile/classLoader.cpp From john.coomes at sun.com Thu Jul 30 20:38:27 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 31 Jul 2009 03:38:27 +0000 Subject: hg: jdk7/hotspot: 2 new changesets Message-ID: <20090731033827.60A63ED8E@hg.openjdk.java.net> Changeset: c4523c6f8204 Author: xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/c4523c6f8204 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! make/deploy-rules.gmk ! make/jprt.properties ! make/sanity-rules.gmk Changeset: cab520b37e9a Author: xdono Date: 2009-07-30 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/cab520b37e9a Added tag jdk7-b67 for changeset c4523c6f8204 ! .hgtags From john.coomes at sun.com Thu Jul 30 20:43:46 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 31 Jul 2009 03:43:46 +0000 Subject: hg: jdk7/hotspot/corba: 2 new changesets Message-ID: <20090731034348.CFD60ED93@hg.openjdk.java.net> Changeset: a12ea7c7b497 Author: xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/a12ea7c7b497 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! make/Makefile ! make/common/Library.gmk ! make/common/Rules.gmk ! make/common/shared/Compiler-gcc.gmk ! make/common/shared/Defs-java.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Platform.gmk ! make/jprt.properties ! make/org/omg/idl/Makefile ! make/tools/logutil/Makefile ! src/share/classes/com/sun/corba/se/impl/encoding/BufferManagerReadStream.java ! src/share/classes/com/sun/corba/se/impl/io/ObjectStreamClass.java ! src/share/classes/com/sun/corba/se/impl/oa/poa/POAFactory.java ! src/share/classes/com/sun/corba/se/impl/orb/ORBImpl.java ! src/share/classes/com/sun/corba/se/impl/orb/ORBSingleton.java ! src/share/classes/com/sun/corba/se/impl/orbutil/ORBUtility.java ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLNameTranslatorImpl.java ! src/share/classes/com/sun/corba/se/impl/resolver/INSURLOperationImpl.java ! src/share/classes/com/sun/corba/se/impl/transport/SocketOrChannelConnectionImpl.java ! src/share/classes/com/sun/corba/se/spi/logging/data/ORBUtil.mc ! src/share/classes/com/sun/tools/corba/se/idl/Parser.java ! src/share/classes/com/sun/tools/corba/se/idl/first.set ! src/share/classes/com/sun/tools/corba/se/idl/follow.set ! src/share/classes/com/sun/tools/corba/se/idl/grammar.idl ! src/share/classes/com/sun/tools/corba/se/idl/grammar3.idl ! src/share/classes/com/sun/tools/corba/se/idl/idl.prp ! src/share/classes/com/sun/tools/corba/se/idl/idl_ja.prp ! src/share/classes/com/sun/tools/corba/se/idl/idl_zh_CN.prp ! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable.prp ! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_ja.prp ! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_zh_CN.prp ! src/share/classes/com/sun/tools/corba/se/logutil/Input.java ! src/share/classes/com/sun/tools/corba/se/logutil/InputCode.java ! src/share/classes/com/sun/tools/corba/se/logutil/InputException.java ! src/share/classes/com/sun/tools/corba/se/logutil/MC.java ! src/share/classes/org/omg/CORBA/ORB.java ! src/windows/resource/version.rc Changeset: ec55ebb18a61 Author: xdono Date: 2009-07-30 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/ec55ebb18a61 Added tag jdk7-b67 for changeset a12ea7c7b497 ! .hgtags From john.coomes at sun.com Thu Jul 30 20:51:50 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 31 Jul 2009 03:51:50 +0000 Subject: hg: jdk7/hotspot/jaxp: 2 new changesets Message-ID: <20090731035154.28B02ED98@hg.openjdk.java.net> Changeset: a033af8d824a Author: xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/a033af8d824a 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! make/build.properties ! make/build.xml ! make/jprt.properties ! src/share/classes/com/sun/org/apache/xerces/internal/impl/PropertyManager.java ! src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java ! src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLStreamFilterImpl.java ! src/share/classes/com/sun/xml/internal/stream/events/XMLEventAllocatorImpl.java Changeset: c77f6ec0bd9b Author: xdono Date: 2009-07-30 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/c77f6ec0bd9b Added tag jdk7-b67 for changeset a033af8d824a ! .hgtags From john.coomes at sun.com Thu Jul 30 20:57:11 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 31 Jul 2009 03:57:11 +0000 Subject: hg: jdk7/hotspot/jaxws: 2 new changesets Message-ID: <20090731035714.C7BC0ED9D@hg.openjdk.java.net> Changeset: faa13cd4d6cd Author: xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/faa13cd4d6cd 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! make/Makefile ! make/build.properties ! make/build.xml Changeset: b70ce5b02bbc Author: xdono Date: 2009-07-30 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/b70ce5b02bbc Added tag jdk7-b67 for changeset faa13cd4d6cd ! .hgtags From john.coomes at sun.com Thu Jul 30 21:02:46 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 31 Jul 2009 04:02:46 +0000 Subject: hg: jdk7/hotspot/jdk: 4 new changesets Message-ID: <20090731040436.E28C1EDA2@hg.openjdk.java.net> Changeset: 8eddead6a701 Author: yhuang Date: 2009-07-02 20:17 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/8eddead6a701 6606396: Notepad and Stylepad demos don't run in Japanese locale. Reviewed-by: peytoia, ogino ! src/share/demo/jfc/Notepad/resources/Notepad_ja.properties Changeset: d8ff2f23a8fc Author: yhuang Date: 2009-07-26 19:51 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d8ff2f23a8fc Merge Changeset: a952aafd5181 Author: xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a952aafd5181 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! make/common/Defs-linux.gmk ! make/common/Release.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Sanity.gmk ! make/java/redist/Makefile ! make/sun/Makefile ! src/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java ! src/share/classes/java/awt/Robot.java ! src/share/classes/java/awt/TrayIcon.java ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/lang/System.java ! src/share/classes/javax/swing/DefaultDesktopManager.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/tools/jar/Main.java ! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/windows/native/java/lang/java_props_md.c ! test/demo/jvmti/hprof/HelloWorld.java ! test/demo/jvmti/hprof/StackMapTableTest.java ! test/java/awt/Window/OwnedWindowsLeak/OwnedWindowsLeak.java ! test/tools/jar/index/MetaInf.java Changeset: 5c52dcbde260 Author: xdono Date: 2009-07-30 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5c52dcbde260 Added tag jdk7-b67 for changeset a952aafd5181 ! .hgtags From john.coomes at sun.com Thu Jul 30 21:15:19 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 31 Jul 2009 04:15:19 +0000 Subject: hg: jdk7/hotspot/langtools: 2 new changesets Message-ID: <20090731041525.026FAEDA7@hg.openjdk.java.net> Changeset: 14b1a8ede954 Author: xdono Date: 2009-07-28 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/14b1a8ede954 6862919: Update copyright year Summary: Update copyright for files that have been modified in 2009, up to 07/09 Reviewed-by: tbell, ohair ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/legacy.properties ! test/tools/javac/typeAnnotations/failures/OldArray.java Changeset: 689bec60a482 Author: xdono Date: 2009-07-30 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/689bec60a482 Added tag jdk7-b67 for changeset 14b1a8ede954 ! .hgtags From y.s.ramakrishna at sun.com Fri Jul 31 13:08:42 2009 From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com) Date: Fri, 31 Jul 2009 20:08:42 +0000 Subject: hg: jdk7/hotspot/hotspot: 3 new changesets Message-ID: <20090731200852.8D404EE9B@hg.openjdk.java.net> Changeset: 27f6a9b9c311 Author: tonyp Date: 2009-07-29 11:01 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/27f6a9b9c311 6864886: G1: rename -XX parameters related to update buffers Summary: renaming a couple of update buffer-related parameters to make them more understandable and consistent. Reviewed-by: iveresov, ysr ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/runtime/globals.hpp Changeset: 83b687ce3090 Author: tonyp Date: 2009-07-30 14:50 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/83b687ce3090 6866591: G1: print update buffer processing stats more often Summary: It adds parameter -XX:+G1SummarizeRSetStatsPeriod that causes update buffer processing information to be printed periodically. It also includes two small formatting changes. Reviewed-by: jmasa, jcoomes, ysr ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: 7f807f55161a Author: ysr Date: 2009-07-31 10:41 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/7f807f55161a Merge ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp ! src/share/vm/runtime/globals.hpp From Tim.Bell at Sun.COM Fri Jul 31 17:35:15 2009 From: Tim.Bell at Sun.COM (Tim Bell) Date: Fri, 31 Jul 2009 17:35:15 -0700 Subject: solaris_i586-fastdebug-c1-jvm98 FAILED "permanent generation read only space is not large enough" Message-ID: <4A738DC3.8020702@sun.com> Hi- Several of my JPRT build/test jobs failed recently with: > Failure reason: Target solaris_i586-fastdebug-c1-jvm98 FAILED. The > preparation of the built bits failed. Post install step failed: > rv=2,stdout="Loading classes to share ... done. > Rewriting and unlinking classes ... done. > Calculating hash values for String objects .. done. > Calculating fingerprints ... done. > Removing unshareable information ... done. > Moving pre-ordered read-only objects to shared space at 0xd8000000 ... done. > Moving read-only objects to shared space at 0xd85eb338 ... done. > Moving common symbols to shared space at 0xd85ed2e8 ... done. > Moving remaining symbols to shared space at 0xd86c2728 ... done. > Moving string char arrays to shared space at 0xd86c38d8 ... done. > Moving additional symbols to shared space at 0xd8782d08 ... Java HotSpot(TM) > Client VM warning: > The permanent generation read only space is not large enough to > preload requested classes. Use -XX:SharedReadOnlySize= to increase > the initial size of the read only space. > > ",stderr="" Target solaris_i586-fastdebug-c2-jvm98 FAILED. The preparation of > the built bits failed. Post install step failed: rv=2,stdout="Loading > classes to share ... done. > Rewriting and unlinking classes ... done. > Calculating hash values for String objects .. done. > Calculating fingerprints ... done. > Removing unshareable information ... done. > Moving pre-ordered read-only objects to shared space at 0xd8000000 ... done. > Moving read-only objects to shared space at 0xd85eb338 ... done. > Moving common symbols to shared space at 0xd85ed2e8 ... done. > Moving remaining symbols to shared space at 0xd86c2728 ... done. > Moving string char arrays to shared space at 0xd86c38d8 ... done. > Moving additional symbols to shared space at 0xd8782d08 ... Java HotSpot(TM) > Client VM warning: > The permanent generation read only space is not large enough to > preload requested classes. Use -XX:SharedReadOnlySize= to increase > the initial size of the read only space. > > ",stderr="" Target solaris_x64-fastdebug-c2-jvm98 FAILED. The preparation of > the built bits failed. Post install step failed: rv=2,stdout="Loading > classes to share ... done. > Rewriting and unlinking classes ... done. > Calculating hash values for String objects .. done. > Calculating fingerprints ... done. > Removing unshareable information ... done. > Moving pre-ordered read-only objects to shared space at 0xd8000000 ... done. > Moving read-only objects to shared space at 0xd85eb338 ... done. > Moving common symbols to shared space at 0xd85ed2e8 ... done. > Moving remaining symbols to shared space at 0xd86c2728 ... done. > Moving string char arrays to shared space at 0xd86c38d8 ... done. > Moving additional symbols to shared space at 0xd8782d08 ... Java HotSpot(TM) > Client VM warning: > The permanent generation read only space is not large enough to > preload requested classes. Use -XX:SharedReadOnlySize= to increase > the initial size of the read only space. > > ",stderr="" It appears the fastdebug build has grown enough to blow through some preallocated size. What setting needs to be increased? I did not see a bug open on this... let me know if you would like one filed. Thanks- Tim From Kelly.Ohair at Sun.COM Fri Jul 31 17:51:07 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Fri, 31 Jul 2009 17:51:07 -0700 Subject: solaris_i586-fastdebug-c1-jvm98 FAILED "permanent generation read only space is not large enough" In-Reply-To: <4A738DC3.8020702@sun.com> References: <4A738DC3.8020702@sun.com> Message-ID: <4A73917B.6060605@sun.com> Please file a hotspot bug. If they end up with a workaround, I can adjust JPRT. -kto Tim Bell wrote: > Hi- > > Several of my JPRT build/test jobs failed recently with: > >> Failure reason: Target solaris_i586-fastdebug-c1-jvm98 FAILED. The >> preparation of the built bits failed. Post install step failed: >> rv=2,stdout="Loading classes to share ... done. >> Rewriting and unlinking classes ... done. >> Calculating hash values for String objects .. done. >> Calculating fingerprints ... done. >> Removing unshareable information ... done. >> Moving pre-ordered read-only objects to shared space at 0xd8000000 ... done. >> Moving read-only objects to shared space at 0xd85eb338 ... done. >> Moving common symbols to shared space at 0xd85ed2e8 ... done. >> Moving remaining symbols to shared space at 0xd86c2728 ... done. >> Moving string char arrays to shared space at 0xd86c38d8 ... done. >> Moving additional symbols to shared space at 0xd8782d08 ... Java HotSpot(TM) >> Client VM warning: >> The permanent generation read only space is not large enough to >> preload requested classes. Use -XX:SharedReadOnlySize= to increase >> the initial size of the read only space. >> >> ",stderr="" Target solaris_i586-fastdebug-c2-jvm98 FAILED. The preparation of >> the built bits failed. Post install step failed: rv=2,stdout="Loading >> classes to share ... done. >> Rewriting and unlinking classes ... done. >> Calculating hash values for String objects .. done. >> Calculating fingerprints ... done. >> Removing unshareable information ... done. >> Moving pre-ordered read-only objects to shared space at 0xd8000000 ... done. >> Moving read-only objects to shared space at 0xd85eb338 ... done. >> Moving common symbols to shared space at 0xd85ed2e8 ... done. >> Moving remaining symbols to shared space at 0xd86c2728 ... done. >> Moving string char arrays to shared space at 0xd86c38d8 ... done. >> Moving additional symbols to shared space at 0xd8782d08 ... Java HotSpot(TM) >> Client VM warning: >> The permanent generation read only space is not large enough to >> preload requested classes. Use -XX:SharedReadOnlySize= to increase >> the initial size of the read only space. >> >> ",stderr="" Target solaris_x64-fastdebug-c2-jvm98 FAILED. The preparation of >> the built bits failed. Post install step failed: rv=2,stdout="Loading >> classes to share ... done. >> Rewriting and unlinking classes ... done. >> Calculating hash values for String objects .. done. >> Calculating fingerprints ... done. >> Removing unshareable information ... done. >> Moving pre-ordered read-only objects to shared space at 0xd8000000 ... done. >> Moving read-only objects to shared space at 0xd85eb338 ... done. >> Moving common symbols to shared space at 0xd85ed2e8 ... done. >> Moving remaining symbols to shared space at 0xd86c2728 ... done. >> Moving string char arrays to shared space at 0xd86c38d8 ... done. >> Moving additional symbols to shared space at 0xd8782d08 ... Java HotSpot(TM) >> Client VM warning: >> The permanent generation read only space is not large enough to >> preload requested classes. Use -XX:SharedReadOnlySize= to increase >> the initial size of the read only space. >> >> ",stderr="" > > It appears the fastdebug build has grown enough to blow through some > preallocated size. > > What setting needs to be increased? I did not see a bug open on this... > let me know if you would like one filed. > > Thanks- > Tim From Tim.Bell at Sun.COM Fri Jul 31 18:03:48 2009 From: Tim.Bell at Sun.COM (Tim Bell) Date: Fri, 31 Jul 2009 18:03:48 -0700 Subject: solaris_i586-fastdebug-c1-jvm98 FAILED "permanent generation read only space is not large enough" In-Reply-To: <4A73917B.6060605@sun.com> References: <4A738DC3.8020702@sun.com> <4A73917B.6060605@sun.com> Message-ID: <4A739474.8030606@sun.com> Kelly O'Hair wrote: > Please file a hotspot bug. OK - done: 6867645 It should be visible in a few days at: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6867645 > If they end up with a workaround, I can adjust JPRT. Based on the numbers in the error output, I estimate the current (too small) size was about 7.8M. I tried passing "-XX:SharedReadOnlySize=10M" in my JPRT rerun, but that did not help... maybe I didn't get the flag sent down to the right JVM. Tim From gnu_andrew at member.fsf.org Fri Jul 31 20:44:29 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Sat, 1 Aug 2009 04:44:29 +0100 Subject: [FOR REVIEW] hs14 merge for OpenJDK6 Message-ID: <17c6771e0907312044q43080f55y3353927a57dca99f@mail.gmail.com> Here it is, the mother of all webrevs: http://cr.openjdk.java.net/~andrew/jdk6-hs14-merge/webrev.01/ with the patch itself being ~13mb. This takes OpenJDK6 up to HotSpot 14 build 16 (see http://hg.openjdk.java.net/hsx/hsx14/master/), incorporating 553 changesets from the hs14 repo. and one merge changeset. I'll shortly push this to http://fuseyism.com/hg/hotspot too. Ok to push? -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Erik.Trimble at Sun.COM Fri Jul 31 23:49:51 2009 From: Erik.Trimble at Sun.COM (Erik Trimble) Date: Fri, 31 Jul 2009 23:49:51 -0700 Subject: [FOR REVIEW] hs14 merge for OpenJDK6 In-Reply-To: <17c6771e0907312044q43080f55y3353927a57dca99f@mail.gmail.com> References: <17c6771e0907312044q43080f55y3353927a57dca99f@mail.gmail.com> Message-ID: <4A73E58F.9020502@sun.com> Andrew John Hughes wrote: > Here it is, the mother of all webrevs: > > http://cr.openjdk.java.net/~andrew/jdk6-hs14-merge/webrev.01/ > > with the patch itself being ~13mb. > > This takes OpenJDK6 up to HotSpot 14 build 16 (see > http://hg.openjdk.java.net/hsx/hsx14/master/), incorporating 553 > changesets from the hs14 repo. and one merge changeset. > I'll shortly push this to http://fuseyism.com/hg/hotspot too. > > Ok to push? > I approve. -- Erik Trimble Java System Support Mailstop: usca22-123 Phone: x17195 Santa Clara, CA Timezone: US/Pacific (GMT-0800)