Review request: Zero assembler port

[Andrew John Hughes]

2009/7/16 John Coomes <John.Coomes at sun.com>:
> Andrew John Hughes (gnu_andrew at member.fsf.org) wrote:
>> 2009/7/15 John Coomes <John.Coomes at sun.com>:
>> > Gary Benson (gbenson at redhat.com) wrote:
>> >> Hi all,
>> >>
>> >> Zero is an interpreter-only port of HotSpot that uses no assembler and
>> >> can trivially be built on any Linux system. Â The following webrev adds
>> >> Zero support to OpenJDK:
>> >>
>> >> Â  http://cr.openjdk.java.net/~gbenson/zero-03/
>> >> ...
>> >
>> > I started to take a look, but there's something strange with the
>> > webrev. Â A dozen or more files have 0 lines changed, and some other
>> > files are listed because you are not in sync with the parent repo.
>> >
>> > The latter is easy to fix; compare against a parent repo that you
>> > control and make sure you're completely up to date.
>> >
>> > Not sure about the former. Â Looks like all the files with 0 lines
>> > changed show "rev 831" while the others show rev 830. Â Maybe comparing
>> > against your own parent repo will fix those also.
>> >
>>
>> Hi John,
>>
>> I also noticed that the patch didn't apply cleanly when I tried it.
>> On Gary's behalf, here's an alternate webrev against OpenJDK7 b64 that
>> doesn't seem to have these issues:
>>
>> http://fuseyism.com/zero/webrev.01/
>
> Hi Andrew,
>
> This doesn't include any of the new zero files, e.g.,
> hotspot/src/cpu/zero/vm/assembler_zero.hpp.  That might be explained
> if you generated this from a repo after applying the patch from the
> original webrev.  I think Gary will have to get to the bottom of this.
>
> -John
>
>

Sorry, I of course applied the patch but forgot to hg add the new files.

A revised version will be available shortly from
http://fuseyism.com/zero/webrev.02/
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8