Review request: Zero assembler port

[Andrew John Hughes]

2009/7/16 Vikram A <vikram.account at gmail.com>:
> hi,
>
> Some files (these and few more)
>  ------ ------ ------ ------ --- New Patch Raw
> hotspot/src/cpu/zero/vm/interp_masm_zero.cpp
>    24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg
>  ------ ------ ------ ------ --- New Patch Raw
> hotspot/src/cpu/zero/vm/templateInterpreter_zero.cpp
>    24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg
> ------ ------ ------ ------ --- New Patch Raw
> hotspot/src/cpu/zero/vm/templateInterpreter_zero.hpp
>    24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg
> ------ ------ ------ ------ --- New Patch Raw
> hotspot/src/cpu/zero/vm/templateTable_zero.cpp
>    24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg
>
> still show only the copyright header, no source code.
> some have only 4 lines of code. is that what you wanted.
>
> rgds.
>

 ------ ------ ------ ------ --- New Patch Raw
hotspot/src/cpu/zero/vm/interp_masm_zero.hpp

    34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

>From my version at http://fuseyism.com/zero/webrev.02/ -- there is
code in that version.

>
> On Thu, Jul 16, 2009 at 3:45 PM, Gary Benson<gbenson at redhat.com> wrote:
>> John Coomes wrote:
>>> Gary Benson (gbenson at redhat.com) wrote:
>>> > Zero is an interpreter-only port of HotSpot that uses no assembler
>>> > and can trivially be built on any Linux system.  The following
>>> > webrev adds Zero support to OpenJDK:
>>> >
>>> >   http://cr.openjdk.java.net/~gbenson/zero-03/
>>> > ...
>>>
>>> I started to take a look, but there's something strange with the
>>> webrev.  A dozen or more files have 0 lines changed, and some other
>>> files are listed because you are not in sync with the parent repo.
>>>
>>> The latter is easy to fix; compare against a parent repo that you
>>> control and make sure you're completely up to date.
>>>
>>> Not sure about the former.  Looks like all the files with 0 lines
>>> changed show "rev 831" while the others show rev 830.  Maybe
>>> comparing against your own parent repo will fix those also.
>>
>> Sorry about that.  This is my first submission using webrev, so I'm
>> figuring it out as I go along.  An updated webrev is here:
>>
>>  http://cr.openjdk.java.net/~gbenson/zero-05/
>>
>> Hopefully I got it right this time!
>>
>> Cheers,
>> Gary
>>
>> --
>> http://gbenson.net/
>>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8