Review request: Zero assembler port

Andrew John Hughes gnu_andrew at member.fsf.org
Thu Jul 16 05:26:04 PDT 2009


2009/7/16 Gary Benson <gbenson at redhat.com>:
> Andrew John Hughes wrote:
>> 2009/7/16 Vikram A <vikram.account at gmail.com>:
>> > Some files (these and few more)
>> >  ------ ------ ------ ------ --- New Patch Raw
>> > hotspot/src/cpu/zero/vm/interp_masm_zero.cpp
>> >    24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg
>> >  ------ ------ ------ ------ --- New Patch Raw
>> > hotspot/src/cpu/zero/vm/templateInterpreter_zero.cpp
>> >    24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg
>> > ------ ------ ------ ------ --- New Patch Raw
>> > hotspot/src/cpu/zero/vm/templateInterpreter_zero.hpp
>> >    24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg
>> > ------ ------ ------ ------ --- New Patch Raw
>> > hotspot/src/cpu/zero/vm/templateTable_zero.cpp
>> >    24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg
>> >
>> > still show only the copyright header, no source code.
>> > some have only 4 lines of code. is that what you wanted.
>> >
>> > rgds.
>> >
>>
>>  ------ ------ ------ ------ --- New Patch Raw
>> hotspot/src/cpu/zero/vm/interp_masm_zero.hpp
>>
>>     34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg
>>
>> From my version at http://fuseyism.com/zero/webrev.02/ -- there is
>> code in that version.
>
> You're looking at the .hpp file, Vikram listed the .cpp.
>
> Cheers,
> Gary
>
> --
> http://gbenson.net/
>

Ok that's because there isn't a cpp in the webrev, presumably because,
as you said, it's empty.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the hotspot-dev mailing list