Review request: Zero assembler port

Christian Thalinger Christian.Thalinger at Sun.COM
Thu Jul 16 06:34:40 PDT 2009


Gary Benson wrote:
> Hi Vikram,
> 
> Vikram A wrote:
>> Some files (these and few more)
>>  ------ ------ ------ ------ --- New Patch Raw
>> hotspot/src/cpu/zero/vm/interp_masm_zero.cpp
>>     24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg
>>  ------ ------ ------ ------ --- New Patch Raw
>> hotspot/src/cpu/zero/vm/templateInterpreter_zero.cpp
>>     24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg
>> ------ ------ ------ ------ --- New Patch Raw
>> hotspot/src/cpu/zero/vm/templateInterpreter_zero.hpp
>>     24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg
>> ------ ------ ------ ------ --- New Patch Raw
>> hotspot/src/cpu/zero/vm/templateTable_zero.cpp
>>     24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg
>>
>> still show only the copyright header, no source code.
>> some have only 4 lines of code. is that what you wanted.
> 
> Yes, that's correct.  The files are there because the includeDB lists
> them, so the build system expects them to be present, but they don't
> contain anything.  In the IcedTea version of Zero these files are
> empty -- they don't even contain the copyright header -- but patch
> won't create empty files so the webrev ended up unbuildable.

Maybe you should add a comment saying that the file is intentionally empty.

-- Christian



More information about the hotspot-dev mailing list