Review request: Zero assembler port
Gary Benson
gbenson at redhat.com
Thu Jul 16 07:00:27 PDT 2009
Christian Thalinger wrote:
> Gary Benson wrote:
> > Hi Vikram,
> >
> > Vikram A wrote:
> > > Some files ... still show only the copyright header, no source
> > > code. some have only 4 lines of code. is that what you wanted.
> >
> > Yes, that's correct. The files are there because the includeDB
> > lists them, so the build system expects them to be present, but
> > they don't contain anything. In the IcedTea version of Zero these
> > files are empty -- they don't even contain the copyright header --
> > but patch won't create empty files so the webrev ended up
> > unbuildable.
>
> Maybe you should add a comment saying that the file is intentionally
> empty.
Good idea, done:
http://cr.openjdk.java.net/~gbenson/zero-07/
Cheers,
Gary
--
http://gbenson.net/
More information about the hotspot-dev
mailing list