Review request: Zero assembler port

[Andrew John Hughes]

2009/7/16 Gary Benson <gbenson at redhat.com>:
> Christian Thalinger wrote:
>> Gary Benson wrote:
>> > Hi Vikram,
>> >
>> > Vikram A wrote:
>> > > Some files ...  still show only the copyright header, no source
>> > > code.  some have only 4 lines of code. is that what you wanted.
>> >
>> > Yes, that's correct.  The files are there because the includeDB
>> > lists them, so the build system expects them to be present, but
>> > they don't contain anything.  In the IcedTea version of Zero these
>> > files are empty -- they don't even contain the copyright header --
>> > but patch won't create empty files so the webrev ended up
>> > unbuildable.
>>
>> Maybe you should add a comment saying that the file is intentionally
>> empty.
>
> Good idea, done:
>
>  http://cr.openjdk.java.net/~gbenson/zero-07/
>
> Cheers,
> Gary
>
> --
> http://gbenson.net/
>

Anyone have any comments on Gary's patch?  What more is necessary to
commit this to the hotspot forest?
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8