review (S) for 6847305: solaris reorder mapfiles generate too many warnings

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Tue Jun 2 14:41:50 PDT 2009


I started to do it once before by hand but gave up.  This time I did  
use a script.  I was going to drop it into the bug report.   
Unsurprisingly it's kind of hacky.  Originally I'd written a validator  
that checked the mapfile against the object files to see if the lines  
were valid but that left a bunch of warnings.  Sometimes the compiler  
generates multiple copies of the same function in different files but  
only ends up using one of them.  If there are mapfile entries for each  
of them then it complains about all the others after the first.  So  
basically I resorted to parsing the warnings and mapping them to lines  
in the reorder file and deleting those lines.  Gack.

tom

On Jun 2, 2009, at 1:45 PM, Vladimir Kozlov wrote:

> So you are finally tired of these warnings :)
> Did you use a script? Could you keep it around to use after an other  
> few years? ;)
>
> Looks good. Thanks for cleaning it
>
> Vladimir
>
> Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/6847305




More information about the hotspot-dev mailing list