Request for review (M): 6812587: Use auxv to determine SPARC hardware features on Solaris

Christian Thalinger Christian.Thalinger at Sun.COM
Tue Mar 10 11:07:00 PDT 2009


On Tue, 2009-03-10 at 10:50 -0700, Vladimir Kozlov wrote:
> Changes look good. Did you verify it on Solaris 9 at least?
> My U3 workstation is running Solaris 9.

Yes, I did.  On Solaris 9 everything should be as it was before, since
we use the legacy code.  Though there may be differences on Solaris 10
and later, like VIS1 and VIS2 are (correctly) reported to be not
supported although they have been before.

> 
> vm_version_sparc.hpp:
> typo in the comment:
> !     // Temporary until whave something more accurate

Thanks.

> 
> vm_version_solaris_sparc.cpp:
> I would remove ", using it" and ", using old legacy code":
> !       tty->print_cr("getisax(2) supported, using it.");
> !       tty->print_cr("getisax(2) not supported, using old legacy code.");

I will change that.

-- Christian




More information about the hotspot-dev mailing list