Pls review 6813274 (M)

John Rose John.Rose at Sun.COM
Fri Mar 13 15:29:10 PDT 2009


On Mar 13, 2009, at 11:06 AM, Paul Hohensee wrote:

> Webrev and comments at
>
> http://cr.openjdk.java.net/~phh/6813274/6813274/webrev.00/

It looks fine.

Now that we are adding more buildtree targets, it is a perfect time to  
get rid of the 'profiled' flavor, since you are changing the set of  
buildtree targets.

I made the 'profiled' target at the Dawn of Java Time, in the old days  
when profiling code on Unix required special compilation options.  It  
was lightly used then and is (AFAIK) never used now.

If someone is desperate to make a build with special profiling flags,  
they can set the same environmental variables that profiled.make  
does.  It is the same use case as for anybody that wants to add  
compile-time flags to the mix; use EXTRA_CFLAGS, etc.  But having  
'profiled' as a separately defined target is useless noise.

(One annoyance continually reminds me of the existence of 'profiled':   
I keep bumping into it with pathname completion, when I am aiming at  
the product directory.)

-- John



More information about the hotspot-dev mailing list