Pls review 6813274 (M)
John Coomes
John.Coomes at sun.com
Tue Mar 17 09:01:08 PDT 2009
Christian Thalinger (Christian.Thalinger at Sun.COM) wrote:
> On Mon, 2009-03-16 at 08:51 -0400, Paul Hohensee wrote:
> > Thanks for the review. I'll remove the profiled targets.
> >
> > Tom suggests that instead of adding many new targets, I use KERNEL=1
> > on the command line, as the 64-bit builds use LP64=1. I'd need to keep the
> > kernel targets though, because the otherwise the jdk build would have to
> > specify KERNEL=1 like it specifies ARCH_DATA_MODEL=64 now
> > (it turns ARCH_DATA_MODEL=64 into LP64=1). I'll try that out
> > and see how it goes.
>
> Hi Paul!
>
> I just talked to John about that. There is also still a debug directory
> around which does not even have a make target. Probably you can get rid
> of that one too.
The debug target exists, it's just not explicit in the makefile (and
it builds, at least on solaris). I'm not sure of the difference
between debug and jvmg--IIRC, it used to create a fat gamma launcher,
but doesn't seem to do that now.
FWIW, I think the cleanups are better done separately from the KERNEL
change.
-John
More information about the hotspot-dev
mailing list