Please review: 6541756: Reduce executable C-heap

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Tue Mar 24 17:25:50 PDT 2009


Looks good.

Vladimir

Coleen Phillimore - Sun Microsystems wrote:
> 
> I have changed the code a bit and would like another code review.  
> Microsoft docs say that you should set executable permissions for 
> allocated memory with VirtualProtect, rather than VirtualAlloc so we 
> only need to set the execute permissions when committing memory.  Also 
> added comments and did more testing.  New webrev:
> 
> http://cr.openjdk.java.net/~coleenp/6541756.2/
> 
> Could someone from the linux community check out the os_linux.cpp changes?
> Thanks!
> Coleen
> 
> On 03/23/09 20:30, Coleen Phillimore wrote:
>> Summary: Add executable parameters to reserve_memory and commit_memory 
>> to reduce executable memory to only the Code Heap.
>>
>> Tested this on solaris, linux (ubuntu) and windows Vista (with nx 
>> AlwaysOn)
>>
>> Webrev:
>> http://cr.openjdk.java.net/~coleenp/6541756/
>> Bug:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6541756
>>
>> Thanks,
>> Coleen



More information about the hotspot-dev mailing list