typo in TemplateInterpreterGenerator::set_short_entry_points?

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Thu Nov 12 09:44:18 PST 2009


If you want.

tom

On Nov 12, 2009, at 7:48 AM, Christian Thalinger wrote:

> On Fri, 2009-10-30 at 14:06 -0700, Tom Rodriguez wrote:
>> set_entry_point is only ever used with the tos states of bytecode  
>> templates in templateTable.cpp and none of those use the subword tos  
>> states like btos,ctos and stos.  Those are all smeared into itos:
>> 
>>   def(Bytecodes::_i2c                 , ____|____|____|____, itos,  
>> itos, convert             ,  _ )
>> 
>> The subword types don't really exist in the representation of the  
>> stack and locals.  Probably btos,ctos and stos could be converted into  
>> ShouldNotReachHere in the switch below.
> 
> Should I open a CR for that and do the change?  -- Christian
> 



More information about the hotspot-dev mailing list