Request for reviews (XS): 6902000: use ShouldNotReachHere() for btos/ctos/stos in TemplateInterpreterGenerator::set_short_entry_points

Christian Thalinger Christian.Thalinger at Sun.COM
Wed Nov 18 09:12:07 PST 2009


On Wed, 2009-11-18 at 08:56 -0800, Vladimir Kozlov wrote:
> Changes are fine but I would place ShouldNotReachHere on separate line.
> I think it would be more clear this way that it applies to all previous cases.

You're right.  I also missed a break:

http://cr.openjdk.java.net/~twisti/6902000/webrev.02/

-- Christian



More information about the hotspot-dev mailing list