Second Zero review request

[Gary Benson]

Tom Rodriguez wrote:
> On Sep 24, 2009, at 5:56 AM, Gary Benson wrote:
> > Zero is an interpreter-only port of HotSpot that uses no assembler
> > and can trivially be built on any Linux system.  The following
> > webrev adds Zero support to OpenJDK:
> > 
> >  http://cr.openjdk.java.net/~gbenson/zero-10/
> > 
> > Building is largely the same as the previous webrev (zero-07) except
> > for the following changes:
> > 
> >  - The variable CORE_BUILD is no longer used.
> >  - The variable ZERO_BITSPERWORD has been replaced with ARCH_DATA_MODEL
> > 
> > Summary of changes
> > ==================
> 
> This all looks fine.

Excellent :)

> > - The build directory is linux_zero_zero (or linux_zero_shark) rather
> >   than linux_$(ARCH)_zero.  There is no variable defining the name
> >   of the build directory as such, it's always referenced as
> >   $(OSNAME)_$(BUILDARCH)_whatever, and in addition to specifiying
> >   the build directory, BUILDARCH is used in conditionals in
> >   various makefiles to add extra compiler flags, etc.  If
> >   BUILDARCH is set to "i486", for example, then extra compiler
> >   flags are added which are unnecessary (and possibly problematic)
> >   for Zero.
> 
> I'll assume you're ok with my change to make work, combined with you  
> change to make i386 be i486.

Yes.

> So I'm fine with the hotspot parts and assume others have no
> complaints since we haven't heard any.  Have you gotten reviews of
> the other parts from their respective owners?

No, but I haven't posted it anywhere but this list yet.  I'm not 100%
familiar with how everything is organised, but I'm assuming your
approval goes for paths starting with "hotspot" and that other bits
need approving by others?

I guess core-libs-dev is the list for the "jdk" makefiles.  Is that
list the one for the "corba" makefile change too?  Also, who owns the
top-level file make/hotspot-rules.gmk?

I'll roll a new webrev with the build directory changes before I post
anything, and copy it here.

Cheers,
Gary

-- 
http://gbenson.net/