Second Zero review request

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Wed Oct 7 13:27:23 PDT 2009


>> So I'm fine with the hotspot parts and assume others have no
>> complaints since we haven't heard any.  Have you gotten reviews of
>> the other parts from their respective owners?
>
> No, but I haven't posted it anywhere but this list yet.  I'm not 100%
> familiar with how everything is organised, but I'm assuming your
> approval goes for paths starting with "hotspot" and that other bits
> need approving by others?
>
> I guess core-libs-dev is the list for the "jdk" makefiles.  Is that
> list the one for the "corba" makefile change too?  Also, who owns the
> top-level file make/hotspot-rules.gmk?

I think Andrew might be right that build-dev might be the place to  
start.  I believe Kelly essentially owns hotspot-rules.gmk.

>
> I'll roll a new webrev with the build directory changes before I post
> anything, and copy it here.

Since these changes largely affect hotspot we definitely want the  
hotspot part to go through JPRT but there really isn't any easy way to  
push both hotspot and jdk changes through at one time.  Would you mind  
if we separated the hotspot and non-hotspot changes into different  
changesets to make the mechanics simpler?

tom

>
> Cheers,
> Gary
>
> -- 
> http://gbenson.net/



More information about the hotspot-dev mailing list