Second Zero review request

Gary Benson gbenson at redhat.com
Thu Oct 8 02:38:50 PDT 2009


Tom Rodriguez wrote:
> Gary Benson wrote:
> > I guess core-libs-dev is the list for the "jdk" makefiles.  Is
> > that list the one for the "corba" makefile change too?  Also, who
> > owns the top-level file make/hotspot-rules.gmk?
>
> I think Andrew might be right that build-dev might be the place to  
> start.  I believe Kelly essentially owns hotspot-rules.gmk.

Ok.

> > I'll roll a new webrev with the build directory changes before I
> > post anything, and copy it here.
>
> Since these changes largely affect hotspot we definitely want the
> hotspot part to go through JPRT but there really isn't any easy way
> to push both hotspot and jdk changes through at one time.  Would you
> mind if we separated the hotspot and non-hotspot changes into
> different changesets to make the mechanics simpler?

No, that's simple enough, and it should make the review easier for
the build-dev guys; that way they don't have to filter through a huge
webrev.  I'm just testing a couple of fixes I had to make as a result
of the build directory change (and trying to replicate your test_gamma
failure) and then I'll post them, by end of day Friday at the latest.

Cheers,
Gary

PS what is JPRT?

-- 
http://gbenson.net/


More information about the hotspot-dev mailing list