review request (M) 6888954 - arg formatting for assert

[Vladimir Kozlov]

It looks good.

In FormatBuffer class specify _buf[] first then copy constructor and
then public constructor and operator.

I don't think you need to break some long lines to two,
especially for just one word, for example:

-      if (index != -1) fatal1("binary search bug: should have found entry %d", index);
+      assert(index == -1, err_msg("binary search should have found entry %d",
+                                  index));

Vladimir

John Coomes wrote:
> 6888954: argument formatting for assert() and friends
> 
> Enable argument formatting for assert(), guarantee() and related
> macros.
> 
> http://cr.openjdk.java.net/~jcoomes/6888954-assert-args/
> 
> -John
>