review request (M) 6888954 - arg formatting for assert
Tom Rodriguez
Thomas.Rodriguez at Sun.COM
Tue Oct 13 15:18:47 PDT 2009
> Scratch the assert and guarantee from the above paragraph. The
> suggestion would only work with fatal, which doesn't have a condition
> to evaluate. I'm not too fond of the assymetry.
>
> I could just add
>
> #define fatal1(p, msg, arg) fatal(p, err_msg(msg, arg))
>
> to the proposed changes. Then you can choose which style you want to
> use: numbered macro or err_msg().
None of these are very attractive and no one else seems to mind so
just stick with what you had.
tom
>
> -John
>
>>> On Oct 10, 2009, at 4:21 PM, John Coomes wrote:
>>>
>>>> 6888954: argument formatting for assert() and friends
>>>>
>>>> Enable argument formatting for assert(), guarantee() and related
>>>> macros.
>>>>
>>>> http://cr.openjdk.java.net/~jcoomes/6888954-assert-args/
>>>>
>>>> -John
>>>>
>>>
>>
>
More information about the hotspot-dev
mailing list