Pls review 6887571

Y.S.Ramakrishna at Sun.COM Y.S.Ramakrishna at Sun.COM
Tue Oct 27 12:22:54 PDT 2009


Hi Paul --

Did you forget to remove the commenting out of the second conjunct in
arguments.cpp:1383 below:-

   1383     if (PrintGCDetails/* && Verbose*/) {

Could you do me a favour and change the following in arguments.cpp:1612 from:-

   1612       if (UseSharedSpaces) {

to:-

   1612       if (UseSharedSpaces && Verbose) {

The verbosity of the message at 1613:1615 has been
bothering some of us for a while (mea culpa for adding
it recentkly), but i didn't get around to removing it, and this
looks like an good opportunity to do so with no new overhead :-)

On 10/27/09 09:26, Paul Hohensee wrote:
...
> 6. In arguments.cpp, set_heap_size() replaces set_server_heap_size() and 
> is used for everything
> except CMS.  CMS has it's own, incompatible (I know: I tried it), heap 
> sizing ergonomics.

Could you provide the result of:-

% java -XX:+UseConcMarkSweepGC -XX:+PrintGCDetails -version

with the baseline VM and with the VM after yr changes?


Rest looks good to me; thanks!
-- ramki



More information about the hotspot-dev mailing list