PING 3: [PATCH FOR REVIEW]: Make source/target options explicit for MakeDeps and jvmti

[Andrew John Hughes]

2009/9/13 John Coomes <John.Coomes at sun.com>:
> Andrew John Hughes (gnu_andrew at member.fsf.org) wrote:
>> 2009/9/11 John Coomes <John.Coomes at sun.com>:
>> > Andrew John Hughes (gnu_andrew at member.fsf.org) wrote:
> ...
>> > Note that we (hotspot) use an auto-build system called jprt for all
>> > changes; it builds & tests on all platforms and does the push if
>> > everything is clean. Â If you create a changeset that jcheck will
>> > accept I'll submit it for you to jprt. Â Include me as a reviewer
>> > (jcoomes).
>> >
>> > You can publish the repo or generate a patch w/hg headers using 'hg
>> > export'.
>> >
>> ...
>> The exported patch is attached.  It builds for me, so I hope all
>> finally goes well with the push :)
>
> After trying a windows build (successful), I submitted your patch to
> jprt, it will take a couple of hours.
>

Thanks.  Good to finally get this in.

> Administrivia:  I imported the patch into a copy of the current
> hotspot-rt repo, effectively rebasing it; it applied cleanly.  I also
> removed the Contributed-by: line from the comment since you have
> commit rights and the changeset lists you as the author.  When to use
> the Contributed-by: line should be more clearly spelled out in the
> relevant part of the Developer's Guide[1].  I'll send a note to
> web-discuss about it.
>

I don't usually add it for my own patches for exactly the reasons you
list, but wasn't sure what would happen with doing the commit via
jprt.

> [1] http://openjdk.java.net/guide/producingChangeset.html
>
> -John
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8