Review request: Zero assembler port of HotSpot

Gary Benson gbenson at redhat.com
Wed Sep 23 09:00:10 PDT 2009


Tom Rodriguez wrote:
> > > I'm going to look into making it work the way I want.  The logic
> > > is mainly driven through buildtree.make and I recently was
> > > experimenting with driving that differently so I think I can see
> > > how to do it.  I'll take a stab and get back to you.  If I can't
> > > then linux_zero_zero will have to do.
> >
> > I'll make a new webrev so you can work on the partially right one.
>
> OK.

http://cr.openjdk.java.net/~gbenson/zero-10/

I'll mail the list tomorrow (it's end of day here) detailing the
changes since the last one you reviewed, but you should be able to
build it using exactly the same variables.

> > > Do you insert dummy stub frames to deal with other places that
> > > use that idiom or are you not using entry points that have that
> > > pattern?
> >
> > There's nowhere else in Zero or Shark that creates dummy frames
> > like this.
>
> So I guess this means you never use any of the other compiled stub
> entry points.  Maybe the deopt entry points could be refactored so
> shark doesn't need a fake frame.  Would that make sense?

It would be possible, though that would require a fair amount of
conditionalized code in deoptimization.cpp.

Cheers,
Gary

-- 
http://gbenson.net/


More information about the hotspot-dev mailing list