Filename buffers too small after fix for 6938627

Andreas Kohn andreas.kohn at fredhopper.com
Sun Apr 18 01:26:35 PDT 2010


On Sun, 2010-04-11 at 20:57 +0200, Andreas Kohn wrote:
> Hi,
> 
> while reading a bit the hotspot sources I noticed a potential issue with
> the fix for 6938627 (Make temporary directory use property
> java.io.tmpdir when specified) in some places.
> 
> Before the fix the callers of get_temp_directory() could hardcode the
> size of the filename buffer to a small number, but now that
> get_temp_directory() returns a value settable by the user this looks a
> bit dangerous.
> 
> In particular:
> attachListener_linux.cpp:AttachListener::is_init_trigger()
> attachListener_solaris.cpp:AttachListener::is_init_trigger()
>   both use a 128 byte buffer
> 
> os_linux.cpp:linux_wrap_code()
>   uses a 40 byte buffer.


Should I open a bug for this one? 

Regards,
--
Andreas




More information about the hotspot-dev mailing list