review (S) for 6945219: minor SA fixes

[Tom Rodriguez]

On Apr 20, 2010, at 2:05 AM, Christian Thalinger wrote:

> On Mon, 2010-04-19 at 16:13 -0700, Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/6945219
>> 
>> 6945219: minor SA fixes
>> Reviewed-by:
>> 
>> These are some small SA improvements and fixes that I've collected.
>> It includes ignoring an error case when reading core that happens
>> regularly when reading 64 bit core files on linux, removing the use of
>> show() to avoid deprecation warnings, more fixes to class file
>> dumping, improved exception handling/reporting, adding field offsets
>> to the information dumped when describing the fields of a class,
>> allowing suppression of Assert.that, new commands for the command line
>> HSDB and fixes to the handling of history.  Tested by debugging
>> crashes with it.
> 
> This looks good.  Just a few minor comments.
> 
> agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPool.java:
> 
> 471                   throw new InternalError("unknown tag:" + cpConstType);
> 
> Missing space after ":".
> 
> agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java:
> 
> 301                   throw new InternalError("unknowon tag: " + cpConstType);

I corrected those, including the typo above and fixed another place with a similar throw to also report the tag.  Thanks!

tom

> 
> Typo.
> 
> -- Christian
>