review request (S) - small add-on to 6888954 assert arg formatting

daniel.daugherty at oracle.com daniel.daugherty at oracle.com
Tue Apr 27 10:20:33 PDT 2010


Thumbs up. What kind of problems did you run into with "$!" on
Windows? Also, using MKS, Cygwin or both?

Dan


On 4/26/2010 4:00 PM, John Coomes wrote:
> I (John.Coomes at oracle.com) wrote:
>   
>> This patch adds some code and a test script to exercise the error
>> handler.  It was useful when testing the changes for
>>
>> 	6888954 argument formatting for assert() and friends
>>
>> http://cr.openjdk.java.net/~jcoomes/6888954-error-test/
>>     
>
> After running the test on different platforms (with and without
> jtreg), I made some minor changes, mostly to the test script.  The
> above URL has details on the changes and a link to the original
> webrev.
>
> -John


More information about the hotspot-dev mailing list