review request (S) - small add-on to 6888954 assert arg formatting

[John Coomes]

John Coomes (John.Coomes at oracle.com) wrote:
> Daniel Daugherty (daniel.daugherty at oracle.com) wrote:
> > Thumbs up.
> 
> Thanks!
> 
> >            What kind of problems did you run into with "$!" on
> > Windows? Also, using MKS, Cygwin or both?
> 
> The pid returned by $! wasn't the java process; ...

Minor correction - the pid returned by $! doesn't match the pid that
hotspot uses to generate the hs_err_pidXXX.log file.  I only get the
pid to determine the name of the file, so it's useless.

-John

> ...                                             I'm not sure why.  I
> only tested cygwin before changing the script; could be specific to
> cygwin.  Another possibility - if the windows launcher does an exec
> like the solaris/linux launcher does, that may a create new process
> id.  FWIW, $! worked correctly for other programs (e.g., sleep).
> 
> -John
> 
> > On 4/26/2010 4:00 PM, John Coomes wrote:
> > > I (John.Coomes at oracle.com) wrote:
> > >   
> > >> This patch adds some code and a test script to exercise the error
> > >> handler.  It was useful when testing the changes for
> > >>
> > >> 	6888954 argument formatting for assert() and friends
> > >>
> > >> http://cr.openjdk.java.net/~jcoomes/6888954-error-test/
> > >>     
> > >
> > > After running the test on different platforms (with and without
> > > jtreg), I made some minor changes, mostly to the test script.  The
> > > above URL has details on the changes and a link to the original
> > > webrev.
> > >
> > > -John