Request for reviews (XXL): 6943304: remove tagged stack interpreter

Coleen Phillimore coleen.phillimore at oracle.com
Wed Apr 28 07:16:55 PDT 2010


Looks great!
Thanks,
Coleen

On 04/27/10 13:38, Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/6943304/webrev.01/
>
> 6943304: remove tagged stack interpreter
> Reviewed-by:
>
> 4734748 introduced the tagged stack interpreter (TaggedStackInterpreter)
> to find the source of some bugs back then.  Since it failed some JCK
> tests it was never used as default or even tested and so it started
> bit-rotting.  Recent JSR 292 changes didn't implement the tagged stack
> interpreter anymore and other ongoing porting for different platforms
> and features would need to implemented it too.  We decided to drop it.
>
> Testing: JPRT
>
> src/cpu/sparc/vm/assembler_sparc.cpp
> src/cpu/sparc/vm/cppInterpreter_sparc.hpp
> src/cpu/sparc/vm/frame_sparc.cpp
> src/cpu/sparc/vm/interp_masm_sparc.cpp
> src/cpu/sparc/vm/interp_masm_sparc.hpp
> src/cpu/sparc/vm/interpreterRT_sparc.cpp
> src/cpu/sparc/vm/interpreter_sparc.hpp
> src/cpu/sparc/vm/sharedRuntime_sparc.cpp
> src/cpu/sparc/vm/stubGenerator_sparc.cpp
> src/cpu/sparc/vm/templateInterpreter_sparc.cpp
> src/cpu/sparc/vm/templateInterpreter_sparc.hpp
> src/cpu/sparc/vm/templateTable_sparc.cpp
> src/cpu/x86/vm/assembler_x86.cpp
> src/cpu/x86/vm/cppInterpreter_x86.hpp
> src/cpu/x86/vm/frame_x86.cpp
> src/cpu/x86/vm/interp_masm_x86_32.cpp
> src/cpu/x86/vm/interp_masm_x86_32.hpp
> src/cpu/x86/vm/interp_masm_x86_64.cpp
> src/cpu/x86/vm/interp_masm_x86_64.hpp
> src/cpu/x86/vm/interpreterRT_x86_32.cpp
> src/cpu/x86/vm/interpreterRT_x86_64.cpp
> src/cpu/x86/vm/interpreter_x86.hpp
> src/cpu/x86/vm/interpreter_x86_32.cpp
> src/cpu/x86/vm/methodHandles_x86.cpp
> src/cpu/x86/vm/sharedRuntime_x86_32.cpp
> src/cpu/x86/vm/sharedRuntime_x86_64.cpp
> src/cpu/x86/vm/stubGenerator_x86_32.cpp
> src/cpu/x86/vm/stubGenerator_x86_64.cpp
> src/cpu/x86/vm/templateInterpreter_x86.hpp
> src/cpu/x86/vm/templateInterpreter_x86_32.cpp
> src/cpu/x86/vm/templateInterpreter_x86_64.cpp
> src/cpu/x86/vm/templateTable_x86_32.cpp
> src/cpu/x86/vm/templateTable_x86_64.cpp
> src/cpu/zero/vm/interpreter_zero.hpp
> src/os_cpu/linux_x86/vm/globals_linux_x86.hpp
> src/os_cpu/solaris_x86/vm/globals_solaris_x86.hpp
> src/share/vm/interpreter/abstractInterpreter.hpp
> src/share/vm/interpreter/bytecodeInterpreter.cpp
> src/share/vm/interpreter/interpreterRuntime.cpp
> src/share/vm/oops/methodOop.cpp
> src/share/vm/prims/methodHandles.hpp
> src/share/vm/runtime/arguments.cpp
> src/share/vm/runtime/frame.cpp
> src/share/vm/runtime/frame.hpp
> src/share/vm/runtime/globals.hpp
> src/share/vm/runtime/javaCalls.cpp
> src/share/vm/runtime/javaCalls.hpp
> src/share/vm/runtime/sharedRuntime.cpp
> src/share/vm/runtime/vframe.cpp
> src/share/vm/runtime/vframeArray.cpp
>
>
>   



More information about the hotspot-dev mailing list