Review request (M): Updates to Visual Studio project creation and development launcher
Kelly O'Hair
kelly.ohair at oracle.com
Mon Dec 13 08:35:32 PST 2010
I see you added vsbuild to the .hgignore file. Is this a new 'created'
build area?
Is it at all possible to put this directory under the already created
build/ directory?
Traditionally we have tried to keep the created files under a top
level 'build/'
directory so that it's easy for tools like JPRT to exclude those files
on submissions
and for people to manually clean up a repository quickly, e.g. 'rm -f -
r build/'.
I'm glad to see some IDE usage coming in, all for it. I'll try and
review the makefiles
and get right back to you.
---
And I know you did not add them, but I'm just noticing now the lines
in .hgignore:
4 ^src/share/tools/hsdis/build/
5 ^src/share/tools/IdealGraphVisualizer/[a-zA-Z0-9]*/build/
6 ^src/share/tools/IdealGraphVisualizer/build/
7 ^src/share/tools/IdealGraphVisualizer/dist/
I really wish they had not done that. I know you didn't do this. But
another goal
has been to treat the source as a kind of read-only area, in fact the
entire
repository should be treatable as read-only with something like:
make ALT_OUTPUTDIR=/tmp/out
knowing that ALL output landed in one directory tree and the
repository area was
never written to. Well, a goal anyway... obviously not possible now. :^(
-kto
On Dec 13, 2010, at 5:06 AM, Staffan Larsen wrote:
> Webrev: http://cr.openjdk.java.net/~sla/7006354/webrev.00/
>
> This update makes it easier to work with Visual Studio projects.
>
> After this update you can create a VS project by:
> 1) Run “vsvars32.cmd”
> 2) Run “make\windows\create.bat <path to JDK to use for running
> against>”
> From inside Visual Studio you can open the generated vsbuild
> \jvm.vcproj. Edit the properties to set the debugging command to “$
> (TargetDir)\hotspot.exe”. Compile and run/debug from inside VS.
>
> Limitations:
> · Changes have only been tested on VS2008 and VS2010.
> · The script do not generate VS2010 project, but the
> conversion wizard in VS2010 can read the generated VS2008 project
> file.
> · Only 32-bit targets work.
>
> This change includes the proposed patch in CR7002870.
>
> Thanks,
> /Staffan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20101213/0a88166a/attachment.html
More information about the hotspot-dev
mailing list