Request for reviews (M): 7006505: Use kstat info to identify SPARC processor

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Dec 15 08:31:13 PST 2010


On 12/15/10 12:56 AM, Christian Thalinger wrote:
>
> Looks good.  I guess we can rely on libkstat being available, but have you thought about dlopen'ing it?
>
> -- Christian

Thank you, Christian

No. It is standard Solaris library (at least in Solaris 8 and newer) and we always need to execute this code.

Vladimir

> On Dec 15, 2010, at 2:36 AM, Vladimir Kozlov wrote:
>> http://cr.openjdk.java.net/~kvn/7006505/webrev
>>
>> Fixed 7006505: Use kstat info to identify SPARC processor
>>
>> Currently we use cpu count (32) to distinguish T1 Sparc
>> from latest T processors and it is not clear when/if we can
>> get an interface which provides information we need.
>>
>> It was suggested to read Solaris kstat data to get more
>> precise CPU information:
>>
>> implementation:   UltraSPARC-T2+ (chipid 0, clock 1414 MHz)
>>
>> Unfortunately Solaris 8 (used to build JDK6) has different
>> kstat structure vs Solaris 10 (used to build JDK7) so
>> I have to work around this problem.
>>
>> Verified with JPRT build and test for jdk6 and jdk7.
>>
>> Additional changes:
>> Renamed is_niagara1 to is_niagara since it checks for
>> T family cpus not just T1.
>> Reduced heap size for test_gamma to -Xmx32m since
>> 64bit VM reserves 1/4 of physical memory by default.
>> Fixed print format for reserved heap size.
>> Print compressed oops mode with -XX:+PrintMiscellaneous -XX:+Verbose.
>> Add check for VIS3.
>> Use FXTOD and FXTOS on T series and SPARC64
>> (tested with microbenchmark).
>


More information about the hotspot-dev mailing list