hg: jdk7/hotspot/hotspot: 7003707: need to remove (some) system include files from the HotSpot header files

David Holmes David.Holmes at oracle.com
Thu Dec 16 20:56:07 PST 2010


FYI this was an urgent changeset that we needed to push through to fix 
an internal build problem caused by the HPI changes. From the CR:

"os_linux.inline.hpp includes sys/ioctl.h for use in the 
socket_available method. The include of ioctl.h causes name space 
pollution on some systems due to subsequent includes (eg termios.h) that 
causes compilation failure. As there is really no reason for 
socket_available to be inlined (it is used as part of a Java -> native 
-> VM invocation sequence, so the extra call is insignificant compared 
to the state transitions) the fix here is to move socket_available into 
os_linux.cpp and delete the inclusion of sys/ioctl.h from 
os_linux.inline.hpp"

David Holmes

david.holmes at oracle.com said the following on 12/17/10 14:44:
> Changeset: 03e1b9fce89d
> Author:    dholmes
> Date:      2010-12-16 20:57 -0500
> URL:       http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/03e1b9fce89d
> 
> 7003707: need to remove (some) system include files from the HotSpot header files
> Summary: move socket_available into os_linux.cpp to avoid inclusion of ioctl.h in os_linux.inline.hpp
> Reviewed-by: coleenp, stefank, ikrylov
> 
> ! src/os/linux/vm/os_linux.cpp
> ! src/os/linux/vm/os_linux.inline.hpp
> 


More information about the hotspot-dev mailing list