From Daniel.Daugherty at Sun.COM Wed Feb 3 08:06:48 2010 From: Daniel.Daugherty at Sun.COM (Daniel D. Daugherty) Date: Wed, 03 Feb 2010 09:06:48 -0700 Subject: Hotspot Debugger on Mac OS X Java 1.6 32-bit In-Reply-To: <5A2371DE-3FCF-41EF-A7B8-03170ACFB453@shinaberry.dyndns.org> References: <5A2371DE-3FCF-41EF-A7B8-03170ACFB453@shinaberry.dyndns.org> Message-ID: <4B699F18.6080002@sun.com> Forwarding to hotspot-dev at ... Dan Derek Shinaberry wrote: > I am so far out of my depth here that I am not even sure which mailing > list to start with, but the serviceability-dev seemed as good a place > as any to begin. > > First of all, I am NOT well versed in Java, particularly the minutia > and all things VM related. I am well versed in C++, which led me to > believe that I might have half a chance when it comes to debugging a > problem inside the VM. > > I'm running Mac OS X 10.5.8 on a 32-bit Core Duo processor, which > doesn't support Java 6. So, I'm attempting to use OpenJDK 6 installed > using MacPorts. > > After some issues getting the build to work, I figured out what needed > patching and succeeded in building and installing openjdk6. So far, > so good. > > The program I'm running that required Java 6, called Marketcetera, > crashes fairly frequently. Using gdb to investigate the crash, I > figured out that it has to do with 16-byte stack alignment > requirements on Mac OS X. I discovered a patch by Landon Fuller that > attempts to address the issues. I fought for a while to get that > patch integrated and building, but it finally built and installed. > Still having the same crash and it is still related to stack alignment. > > I've tracked it down to code that is being generated at runtime, so > gdb isn't much use in discovering exactly what code is the source of > the problem. Enter the Hotspot Debugger. (Finally, he gets to the > point!) > > It doesn't appear that HSDB is built by MacPorts on Mac OS X. It > doesn't even look like there is a bsd directory which would presumably > contain that code. Has anyone successfully used HSDB on Mac OS X? > Can anyone point me in the right direction for being able to > understand what is going on inside the VM on Mac OS X? Any help would > be much appreciated. > > Cheers, > Derek From Thomas.Rodriguez at Sun.COM Wed Feb 3 11:32:09 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 03 Feb 2010 11:32:09 -0800 Subject: Hotspot Debugger on Mac OS X Java 1.6 32-bit In-Reply-To: <4B699F18.6080002@sun.com> References: <5A2371DE-3FCF-41EF-A7B8-03170ACFB453@shinaberry.dyndns.org> <4B699F18.6080002@sun.com> Message-ID: <0A19E23C-494E-4CA2-9D63-E36E985CEB39@sun.com> I assume the bits used by MacPorts are coming from http://hg.openjdk.java.net/bsd-port/bsd-port? That's the only working port of openjdk on the mac as far as I know. I know there are issues with 16 byte alignment in hotspot but I assume all of them had been fixed in the bsd-port. If this is something they missed I'm sure they'd like to know. You might try their alias at http://mail.openjdk.java.net/mailman/listinfo/bsd-port-dev. As far as HSDB I don't believe it's been ported to bsd/mac. It needs either a core file reader, which would be different on the mac since I assume it's Mach-O, or an API for control a live process like ptrace, and I don't think either has been written. If you have a debug build of hotspot there are functions that are callable from the debugger which can be used to figure some things out, like findpc which will try to indentify what a piece of generated code is and ps which will dump a Java stack trace. The full set is in src/share/vm/utilities/debug.cpp. tom On Feb 3, 2010, at 8:06 AM, Daniel D. Daugherty wrote: > Forwarding to hotspot-dev at ... > > Dan > > > Derek Shinaberry wrote: >> I am so far out of my depth here that I am not even sure which mailing list to start with, but the serviceability-dev seemed as good a place as any to begin. >> >> First of all, I am NOT well versed in Java, particularly the minutia and all things VM related. I am well versed in C++, which led me to believe that I might have half a chance when it comes to debugging a problem inside the VM. >> >> I'm running Mac OS X 10.5.8 on a 32-bit Core Duo processor, which doesn't support Java 6. So, I'm attempting to use OpenJDK 6 installed using MacPorts. >> >> After some issues getting the build to work, I figured out what needed patching and succeeded in building and installing openjdk6. So far, so good. >> >> The program I'm running that required Java 6, called Marketcetera, crashes fairly frequently. Using gdb to investigate the crash, I figured out that it has to do with 16-byte stack alignment requirements on Mac OS X. I discovered a patch by Landon Fuller that attempts to address the issues. I fought for a while to get that patch integrated and building, but it finally built and installed. Still having the same crash and it is still related to stack alignment. >> >> I've tracked it down to code that is being generated at runtime, so gdb isn't much use in discovering exactly what code is the source of the problem. Enter the Hotspot Debugger. (Finally, he gets to the point!) >> >> It doesn't appear that HSDB is built by MacPorts on Mac OS X. It doesn't even look like there is a bsd directory which would presumably contain that code. Has anyone successfully used HSDB on Mac OS X? Can anyone point me in the right direction for being able to understand what is going on inside the VM on Mac OS X? Any help would be much appreciated. >> >> Cheers, >> Derek From email.openjdk-serviceability-dev at shinaberry.dyndns.org Wed Feb 3 12:34:27 2010 From: email.openjdk-serviceability-dev at shinaberry.dyndns.org (Derek Shinaberry) Date: Wed, 3 Feb 2010 20:34:27 +0000 Subject: Hotspot Debugger on Mac OS X Java 1.6 32-bit In-Reply-To: <0A19E23C-494E-4CA2-9D63-E36E985CEB39@sun.com> References: <5A2371DE-3FCF-41EF-A7B8-03170ACFB453@shinaberry.dyndns.org> <4B699F18.6080002@sun.com> <0A19E23C-494E-4CA2-9D63-E36E985CEB39@sun.com> Message-ID: <6714EDEF-33C9-4867-9454-FE0B918DF8E0@shinaberry.dyndns.org> All I know for certain about the source is that MacPorts pulls the source tarball from the link http://download.java.net/openjdk/jdk6/promoted/b16/openjdk-6-src-b16-24_apr_2009.tar.gz . It looks like there is now a b17, but I have no idea whether it would build on a Mac or if it would work if it did build. Maybe that's the source of my troubles. I think maybe I'll give that a try. I was afraid that maybe HSDB hadn't been ported. Thanks for the info about the debug callable functions. Those might go a long way towards understanding what's going on. I tried to peek at some of the data structures, but quickly descended into casting and pointer dereferencing hell. On Feb 3, 2010, at 7:32 PM, Tom Rodriguez wrote: > I assume the bits used by MacPorts are coming from http://hg.openjdk.java.net/bsd-port/bsd-port? > That's the only working port of openjdk on the mac as far as I > know. I know there are issues with 16 byte alignment in hotspot but > I assume all of them had been fixed in the bsd-port. If this is > something they missed I'm sure they'd like to know. You might try > their alias at http://mail.openjdk.java.net/mailman/listinfo/bsd-port-dev > . As far as HSDB I don't believe it's been ported to bsd/mac. It > needs either a core file reader, which would be different on the mac > since I assume it's Mach-O, or an API for control a live process > like ptrace, and I don't think either has been written. If you have > a debug build of hotspot there are functions that are callable from > the debugger which can be used to figure some things out, like > findpc which will try to indentify what a piece of generated code is > and ps which will dump a Java stack trace. The full set is in src/ > share/vm/utilities/debug.cpp. > > tom > > On Feb 3, 2010, at 8:06 AM, Daniel D. Daugherty wrote: > >> Forwarding to hotspot-dev at ... >> >> Dan >> >> >> Derek Shinaberry wrote: >>> I am so far out of my depth here that I am not even sure which >>> mailing list to start with, but the serviceability-dev seemed as >>> good a place as any to begin. >>> >>> First of all, I am NOT well versed in Java, particularly the >>> minutia and all things VM related. I am well versed in C++, which >>> led me to believe that I might have half a chance when it comes to >>> debugging a problem inside the VM. >>> >>> I'm running Mac OS X 10.5.8 on a 32-bit Core Duo processor, which >>> doesn't support Java 6. So, I'm attempting to use OpenJDK 6 >>> installed using MacPorts. >>> >>> After some issues getting the build to work, I figured out what >>> needed patching and succeeded in building and installing >>> openjdk6. So far, so good. >>> >>> The program I'm running that required Java 6, called Marketcetera, >>> crashes fairly frequently. Using gdb to investigate the crash, I >>> figured out that it has to do with 16-byte stack alignment >>> requirements on Mac OS X. I discovered a patch by Landon Fuller >>> that attempts to address the issues. I fought for a while to get >>> that patch integrated and building, but it finally built and >>> installed. Still having the same crash and it is still related to >>> stack alignment. >>> >>> I've tracked it down to code that is being generated at runtime, >>> so gdb isn't much use in discovering exactly what code is the >>> source of the problem. Enter the Hotspot Debugger. (Finally, he >>> gets to the point!) >>> >>> It doesn't appear that HSDB is built by MacPorts on Mac OS X. It >>> doesn't even look like there is a bsd directory which would >>> presumably contain that code. Has anyone successfully used HSDB >>> on Mac OS X? Can anyone point me in the right direction for being >>> able to understand what is going on inside the VM on Mac OS X? >>> Any help would be much appreciated. >>> >>> Cheers, >>> Derek > > From Christian.Thalinger at Sun.COM Thu Feb 4 05:37:26 2010 From: Christian.Thalinger at Sun.COM (Christian.Thalinger at Sun.COM) Date: Thu, 04 Feb 2010 13:37:26 +0000 Subject: hg: jdk7/hotspot/hotspot: 15 new changesets Message-ID: <20100204133813.6227C41DB4@hg.openjdk.java.net> Changeset: 9e1637a04678 Author: twisti Date: 2010-01-28 08:36 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/9e1637a04678 6920970: Zero build fixes after 6849984 and 6911204 Summary: Two recent commits broke the build on Zero. Reviewed-by: twisti Contributed-by: Gary Benson ! src/cpu/zero/vm/interpreter_zero.cpp ! src/cpu/zero/vm/sharedRuntime_zero.cpp Changeset: 8d9bfe6a446b Author: never Date: 2010-01-28 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/8d9bfe6a446b 6920346: G1: "must avoid base_memory and AliasIdxTop" Reviewed-by: kvn ! src/share/vm/opto/memnode.hpp Changeset: 0e14bd797dad Author: never Date: 2010-01-28 20:41 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/0e14bd797dad 6792161: assert("No dead instructions after post-alloc") Reviewed-by: kvn ! src/share/vm/opto/ifg.cpp + test/compiler/6792161/Test6792161.java Changeset: ba263cfb7611 Author: twisti Date: 2010-01-29 12:13 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/ba263cfb7611 6917766: JSR 292 needs its own deopt handler Summary: We need to introduce a new MH deopt handler so we can easily determine if the deopt happened at a MH call site or not. Reviewed-by: never, jrose ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 24128c2ffa87 Author: twisti Date: 2010-01-29 08:33 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/24128c2ffa87 6921339: backout 6917766 Reviewed-by: mr ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 5f24d0319e54 Author: kvn Date: 2010-01-29 09:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/5f24d0319e54 4360113: Evict nmethods when code cache gets full Summary: Speculatively unload the oldest nmethods when code cache gets full. Reviewed-by: never, kvn Contributed-by: eric.caspole at amd.com ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/includeDB_core ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/runtime/vm_operations.hpp Changeset: 844a9d73ec22 Author: never Date: 2010-01-29 22:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/844a9d73ec22 6916644: C2 compiler crash on x86 Reviewed-by: kvn, twisti ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/machnode.hpp ! src/share/vm/opto/matcher.cpp + test/compiler/6916644/Test6916644.java Changeset: 18a389214829 Author: twisti Date: 2010-02-01 19:29 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/18a389214829 6921352: JSR 292 needs its own deopt handler Summary: We need to introduce a new MH deopt handler so we can easily determine if the deopt happened at a MH call site or not. Reviewed-by: never, jrose ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.hpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 5fcfaa1ad96f Author: twisti Date: 2010-02-01 23:18 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/5fcfaa1ad96f 6921799: JSR 292 call sites should not be fixed-up Summary: MethodHandle invoke call sites should not be fixed-up by SharedRuntime::fixup_callers_callsite as c2i/i2c adapters are used to implement MethodHandle actions. Reviewed-by: kvn, never ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 87684f1a88b5 Author: kvn Date: 2010-02-01 16:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/87684f1a88b5 6614597: Performance variability in jvm2008 xml.validation Summary: Fix incorrect marking of methods as not compilable. Reviewed-by: never ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/globals.hpp Changeset: 74c848d437ab Author: never Date: 2010-02-03 12:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/74c848d437ab 6921922: fix for 6911204 breaks tagged stack interpreter Reviewed-by: kvn ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: cef333a48af6 Author: kvn Date: 2010-02-03 15:03 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/cef333a48af6 6923043: failed nightly tests which use -XX:+PrintCompilation -Xcomp -XX:CompileOnly Summary: Print "made not compilable" line only for deoptimizations. Reviewed-by: never ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp Changeset: e8443c7be117 Author: never Date: 2010-02-03 15:56 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/e8443c7be117 6921969: optimize 64 long multiply for case with high bits zero Reviewed-by: never, twisti, kvn, rasbold Contributed-by: Hiroshi Yamauchi ! src/cpu/x86/vm/x86_32.ad + test/compiler/6921969/TestMultiplyLongHiZero.java Changeset: 0fce83e8dc0e Author: never Date: 2010-02-03 18:33 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/0fce83e8dc0e Merge Changeset: c1f1137b3575 Author: twisti Date: 2010-02-04 03:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c1f1137b3575 Merge ! src/share/vm/runtime/globals.hpp From thomas.rodriguez at sun.com Thu Feb 4 13:15:25 2010 From: thomas.rodriguez at sun.com (thomas.rodriguez at sun.com) Date: Thu, 04 Feb 2010 21:15:25 +0000 Subject: hg: jdk7/hotspot/hotspot: 6921992: failure in verify scheduling after 6792161 Message-ID: <20100204211528.7AC0241E22@hg.openjdk.java.net> Changeset: c028504fdaa6 Author: never Date: 2010-02-04 11:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c028504fdaa6 6921992: failure in verify scheduling after 6792161 Reviewed-by: kvn ! src/share/vm/opto/ifg.cpp From andrei.pangin at sun.com Thu Feb 4 17:52:36 2010 From: andrei.pangin at sun.com (andrei.pangin at sun.com) Date: Fri, 05 Feb 2010 01:52:36 +0000 Subject: hg: jdk7/hotspot/hotspot: 4 new changesets Message-ID: <20100205015248.7BEAF41E64@hg.openjdk.java.net> Changeset: 6deeaebad47a Author: dcubed Date: 2010-02-01 17:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/6deeaebad47a 6902182: 4/4 Starting with jdwp agent should not incur performance penalty Summary: Rename can_post_exceptions support to can_post_on_exceptions. Add support for should_post_on_exceptions flag to permit per JavaThread optimizations. Reviewed-by: never, kvn, dcubed Contributed-by: tom.deneau at amd.com ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/jvmtiEventController.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiManageCapabilities.cpp ! src/share/vm/prims/jvmtiThreadState.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 0fc941df6fb7 Author: dcubed Date: 2010-02-02 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/0fc941df6fb7 6918421: 1/1 in-process JVM now ignores preset Windows unhandled exception filter Summary: Add support for chaining Windows UnhandledExceptionFilter handlers Reviewed-by: kamg, dholmes, never, acorn, ikrylov ! src/os/windows/vm/os_windows.cpp Changeset: f19bf22685cc Author: dcubed Date: 2010-02-02 11:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f19bf22685cc Merge ! src/os/windows/vm/os_windows.cpp Changeset: 7f8790caccb0 Author: apangin Date: 2010-02-04 15:50 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/7f8790caccb0 Merge ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/sharedRuntime.cpp From erik.trimble at sun.com Fri Feb 5 12:32:48 2010 From: erik.trimble at sun.com (erik.trimble at sun.com) Date: Fri, 05 Feb 2010 20:32:48 +0000 Subject: hg: jdk7/hotspot/hotspot: 6 new changesets Message-ID: <20100205203314.603D641F70@hg.openjdk.java.net> Changeset: 359445e739ac Author: mikejwre Date: 2010-01-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/359445e739ac Added tag jdk7-b80 for changeset 3003ddd1d433 ! .hgtags Changeset: 10f901469941 Author: trims Date: 2010-01-22 14:57 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/10f901469941 Merge Changeset: 1f9b07674480 Author: trims Date: 2010-01-22 15:01 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/1f9b07674480 6919437: Bump the HS17 build number to 08 Summary: Update the HS17 build number to 08 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1999f5b12482 Author: mikejwre Date: 2010-01-28 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/1999f5b12482 Added tag jdk7-b81 for changeset 1f9b07674480 ! .hgtags Changeset: dba18cabafec Author: trims Date: 2010-02-05 12:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/dba18cabafec Merge Changeset: ff3232b68fbb Author: trims Date: 2010-02-05 12:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/ff3232b68fbb 6921473: Bump the HS17 build number to 09 Summary: Update the HS17 build number to 09 Reviewed-by: jcoomes ! make/hotspot_version From john.coomes at sun.com Fri Feb 5 18:05:13 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sat, 06 Feb 2010 02:05:13 +0000 Subject: hg: jdk7/hotspot: Added tag jdk7-b82 for changeset e1176f86805f Message-ID: <20100206020514.1D00641FCD@hg.openjdk.java.net> Changeset: 6880a3af9add Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/6880a3af9add Added tag jdk7-b82 for changeset e1176f86805f ! .hgtags From john.coomes at sun.com Fri Feb 5 18:05:20 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sat, 06 Feb 2010 02:05:20 +0000 Subject: hg: jdk7/hotspot/corba: Added tag jdk7-b82 for changeset 1e8c1bfad1ab Message-ID: <20100206020523.948BD41FCF@hg.openjdk.java.net> Changeset: fde0df7a2384 Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/fde0df7a2384 Added tag jdk7-b82 for changeset 1e8c1bfad1ab ! .hgtags From john.coomes at sun.com Fri Feb 5 18:08:38 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sat, 06 Feb 2010 02:08:38 +0000 Subject: hg: jdk7/hotspot/jaxp: Added tag jdk7-b82 for changeset c876ad22e4bf Message-ID: <20100206020838.4CDF141FD0@hg.openjdk.java.net> Changeset: 309a0a7fc6ce Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/309a0a7fc6ce Added tag jdk7-b82 for changeset c876ad22e4bf ! .hgtags From john.coomes at sun.com Fri Feb 5 18:08:44 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sat, 06 Feb 2010 02:08:44 +0000 Subject: hg: jdk7/hotspot/jaxws: Added tag jdk7-b82 for changeset 31573ae8eed1 Message-ID: <20100206020844.7AAD941FD1@hg.openjdk.java.net> Changeset: 371e3ded591d Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/371e3ded591d Added tag jdk7-b82 for changeset 31573ae8eed1 ! .hgtags From john.coomes at sun.com Fri Feb 5 18:08:55 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sat, 06 Feb 2010 02:08:55 +0000 Subject: hg: jdk7/hotspot/jdk: 4 new changesets Message-ID: <20100206021038.5AFE641FD3@hg.openjdk.java.net> Changeset: b250e6c5a9e5 Author: andrew Date: 2010-01-28 21:01 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b250e6c5a9e5 6921068: Remove javadoc builds warnings from specdefault tag Summary: Ignore specdefault tag to avoid javadoc warnings Reviewed-by: darcy, ohair ! make/docs/Makefile Changeset: b3b10d45778a Author: andrew Date: 2010-01-29 02:38 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b3b10d45778a 6917466: Should set bootclasspath for javadoc in jdk build Summary: javadoc needs to reference the newly built classes so as not to hit APIs which differ between the boot JDK and the source files of the JDK being built. Reviewed-by: ohair ! make/common/shared/Defs-java.gmk ! make/javax/swing/beaninfo/SwingBeans.gmk Changeset: 69ef657320ad Author: ohair Date: 2010-01-29 09:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/69ef657320ad Merge Changeset: 9027c6b9d7e2 Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9027c6b9d7e2 Added tag jdk7-b82 for changeset 69ef657320ad ! .hgtags From john.coomes at sun.com Fri Feb 5 18:15:12 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sat, 06 Feb 2010 02:15:12 +0000 Subject: hg: jdk7/hotspot/langtools: Added tag jdk7-b82 for changeset 47003a3622f6 Message-ID: <20100206021518.F1AB541FD4@hg.openjdk.java.net> Changeset: c9f4ae1f1480 Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/c9f4ae1f1480 Added tag jdk7-b82 for changeset 47003a3622f6 ! .hgtags From bockisch at informatik.tu-darmstadt.de Mon Feb 8 06:00:01 2010 From: bockisch at informatik.tu-darmstadt.de (Christoph Bockisch) Date: Mon, 08 Feb 2010 15:00:01 +0100 Subject: Call for Tutorials -- CBSoft 2010 Message-ID: <4B7018E1.7050001@informatik.tu-darmstadt.de> ====================================================================== CALL FOR TUTORIALS CBSoft 2010 -- 1st Brazilian Conference on Software: Theory and Practice 27 September - 1 October, 2010 Salvador, Brazil http://cbsoft.dcc.ufba.br/ ====================================================================== == KEY CONFERENCE HIGHLIGHTS AND TUTORIALS' VISIBILITY The 1st Brazilian Conference on "Software: Theory and Practice" is an event created to aggregate three traditional and well-established symposia: - XXIV Brazilian Symposium on Software Engineering (SBES) - XIV Brazilian Symposium on Programming Languages (SBLP) - IV Brazilian Symposium on Components, Software Architecture and Software Reuse (SBCARS) Tutorials and keynote speeches have been delivered in every edition by both well-established local researchers and widely-recognized international speakers, such as Len Bass, Anthony Filkenstein, David Garlan, Carlos Hulot, Barbara Kitchenham, Jeff Krammer, Nenad Medvidovic, Gail Murphy, Jaejoon Lee, Peter Mosses, Dirk Muthig, Jens Palsberg, Simon Peyton-Jones, Kevin Sullivan, Richard Taylor, Jan Vitek, and Jon Whittle, just to name a few. These events altogether attract around 1.000 participants, similar to premier international conferences, such as OOPSLA (SPLASH) and ICSE. The audience includes undergraduate and postgraduate students and practitioners, which come from Brazil, South America, and beyond. In general, the attendance of tutorials is quite impressive, ranging from 30 to 70 participants. The conference is organized by the Brazilian Computer Society and also annually supported by respected international groups, such as ACM SIGSoft. The conference is going to run from September 27 to October 1st and the venue is one of the most popular touristic cities in Brazil: Salvador -- BA. Salvador is located on the northeast coast of Brazil on the Atlantic Ocean and is the third largest city of Brazil. Salvador has a tropical climate, several breathtaking beaches and lush vegetation. Local residents enjoy sharing their exotic dancing and music skills with tourists. The locals are also considered some of the friendliest and most outgoing people in Brazil. The cuisine in Salvador consists of spicy seafood and the culture is one of the most distinguished on the planet. For more information, please visit: http://www.salvador.info/ == OBJECTIVES This call is intended to solicit the submission of tutorial proposals to the CBSoft 2010 Conference. The text of the proposal can be written either in English or Portuguese. Each tutorial should be presented in a session of 3 hours. The one-page tutorial summary will be published in the conference proceedings. The access to the tutorial material will be available on-line to the tutorial participants. The goal of the tutorial session is to expose new, emerging topics and concepts on software development, or topics and technologies with growing impact on academia or software market. The theme of the tutorial must be associated with one or more topics that are relevant to the 3 symposia mentioned above: SBES, SBLP e SBCARS. The proponents must have wide knowledge and experience in the tutorial theme. Both introductory and advanced tutorials on theoretical and practical aspects of software development are welcomed. The introductory tutorials must offer an opportunity to systematically expose new knowledge to the participants, and are targeted at undergrad students in an advanced stage, postgraduate students, and software development practitioners. Advanced tutorials should trigger new insights for advancing the state-of-the-art on the research topic being addressed; they are targeted at junior and senior researchers and specialists interested or working on such a research topic. The CBSoft program includes, in addition to the tutorials, technical sessions and invited talks associated with the 3 events mentioned above. Moreover, it embraces panels, tool sessions, workshops and other satellite events. == IMPORTANT DATES Submission of proposals: May 12, 2010 Notification to authors: June 18, 2010 Submission of tutorial summary for the proceedings: July 15, 2010 Presentation material: August 2, 2010 == INSTRUCTIONS FOR SUBMISSION All the tutorial proposals should include the following items: 1. Title of the tutorial, name, affiliation, e-mail and URL of the authors. Indicate if all (or a subset of the) authors plan to act as instructors during the tutorial day. 2. Type (introductory or advanced), language (English or Portuguese) and a short summary (max. of 200 words) describing the main goal of the tutorial. 3. Target audience of the tutorial, and justifications of the proposal relevance to one or more of the 3 conference events: SBES, SBLP e SBCARS.(one page) 4. Resources and equipments needed. 5. The proposed structure of the tutorial, including session titles and a brief description (Max. 2 paragraphs) for each session. 6. References (no more than one page). 7. If applicable, please indicate which conferences (or other events) the proposed tutorial was (or will be) presented. 8. A short bio for each author (max. one paragraph per authors), and URLs for your CV (or website). Brazilian authors should also indicate the URLs for their CVs in the Lattes platform. Please do not include any extra information in addition to the issues described above. The proposals should be submitted electronically, in PDF format, through the JEMS on-line system, which will be accessible from the conference website (to be available soon). == IMPORTANT INFORMATION The tutorial proposals will be reviewed and selected by a program committee (TBA soon), formed by well-known researchers on three communities of the CBSoft conference: software engineering in general, programming languages, and software architecture and reuse. The evaluation criteria include: relevance of the tutorial to one or more of the three CBSoft events; adequacy of the tutorial theme for the time slot (3 hours); ability to attract participants; proposed methodology for tutorial delivery; and, experience and qualification of the authors and instructors. The committee has the right of rejecting tutorial proposals and proactively inviting researchers for delivering tutorials at the conference. The tutorial must be presented in the language used in the written proposal. The authors should register in the CBSoft 2010 conference in order to have the confirmation of their tutorial in the program. The number of accepted tutorials depends both on the quality of the proposals submitted and the number of rooms available at the conference venue. The organization of the tutorials in the program will be made by the CBSoft organizing committee. For additional information, please do not hesitate to contact the coordinator of the Tutorials Sessions: Prof. Dr. Alessandro Garcia - PUC-Rio, Brazil (afgarcia at inf.puc-rio.br) == JOINT TUTORIALS COMMITTEE Jo?o Ara?jo (Universidade Nova de Lisboa, Portugal) Daniel Berry (University of Waterloo, Canada) Thais Batista (UFRN, Brazil) Roberto Bigonha (UFMG, Brazil) Christoph Bockisch (University of Twente, The Netherlands) Rafael Bordini (UFRGS, Brazil) N?lio Cacho (ECT-UFRN, Brazil) Yuanfang Cai (Drexel University, USA) Renato Cerqueira (PUC-Rio, Brazil) Christina Chavez (UFBA, Brazil) Cleidson de Souza (UFPA, Brazil) Eduardo Figueiredo (UFU, Brazil) Lidia Fuentes (University of M?laga, Spain) Danny Hughes (Xi'an Jiaotong-Liverpool University, China) Jaejoon Lee (Lancaster University, UK) Paulo C. Masiero (ICMC-USP, Brazil) Peter Mosses (Swansea University, UK) Leonardo Murta (UFF, Brazil) Paulo Pires (UFRN, Brazil) Cec?lia Rubira (UNICAMP, Brazil) S?rgio Soares (UFPE, Brazil) Eric Tanter (University of Chile, Chile) Cl?udia Maria Lima Werner (COPPE/UFRJ, Brazil) Jon Whittle (Lancaster University, UK) -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20100208/22b236f7/attachment.html From john.cuthbertson at sun.com Mon Feb 8 13:09:19 2010 From: john.cuthbertson at sun.com (john.cuthbertson at sun.com) Date: Mon, 08 Feb 2010 21:09:19 +0000 Subject: hg: jdk7/hotspot/hotspot: 4 new changesets Message-ID: <20100208210931.B93C941782@hg.openjdk.java.net> Changeset: 745c853ee57f Author: johnc Date: 2010-01-29 14:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/745c853ee57f 6885297: java -XX:RefDiscoveryPolicy=2 or -XX:TLABWasteTargetPercent=0 cause VM crash Summary: Interval checking is now being performed on the values passed in for these two flags. The current acceptable range for RefDiscoveryPolicy is [0..1], and for TLABWasteTargetPercent it is [1..100]. Reviewed-by: apetrusenko, ysr ! src/share/vm/includeDB_core ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: 6484c4ee11cb Author: ysr Date: 2010-02-01 17:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/6484c4ee11cb 6904516: More object array barrier fixes, following up on 6906727 Summary: Fixed missing pre-barrier calls for G1, modified C1 to call pre- and correct post-barrier interfaces, deleted obsolete interface, (temporarily) disabled redundant deferred barrier in BacktraceBuilder. Reviewed-by: coleenp, jmasa, kvn, never ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/memory/barrierSet.hpp ! src/share/vm/memory/barrierSet.inline.hpp ! src/share/vm/runtime/stubRoutines.cpp Changeset: deada8912c54 Author: johnc Date: 2010-02-02 18:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/deada8912c54 6914402: G1: assert(!is_young_card(cached_ptr),"shouldn't get a card in young region") Summary: Invalid assert. Filter cards evicted from the card count cache instead. Reviewed-by: apetrusenko, tonyp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp Changeset: 230fac611b50 Author: johnc Date: 2010-02-08 09:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/230fac611b50 Merge ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/includeDB_core From andrei.pangin at sun.com Thu Feb 11 12:49:22 2010 From: andrei.pangin at sun.com (andrei.pangin at sun.com) Date: Thu, 11 Feb 2010 20:49:22 +0000 Subject: hg: jdk7/hotspot/hotspot: 2 new changesets Message-ID: <20100211204928.B6F0841BC8@hg.openjdk.java.net> Changeset: 455df1b81409 Author: kamg Date: 2010-02-08 13:49 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/455df1b81409 6587322: dtrace probe object__alloc doesn't fire in some situations on amd64 Summary: Fix misplaced probe point Reviewed-by: rasbold, phh Contributed-by: neojia at gmail.com ! src/cpu/x86/vm/templateTable_x86_64.cpp Changeset: 95d21201c29a Author: apangin Date: 2010-02-11 10:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/95d21201c29a Merge From erik.trimble at sun.com Thu Feb 11 20:30:23 2010 From: erik.trimble at sun.com (erik.trimble at sun.com) Date: Fri, 12 Feb 2010 04:30:23 +0000 Subject: hg: hsx/hsx16/baseline: 13 new changesets Message-ID: <20100212043103.4D7C941C4C@hg.openjdk.java.net> Changeset: 58ff7544194e Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/58ff7544194e Added tag hs16-b01 for changeset 981375ca07b7 ! .hgtags Changeset: 3f9db56c2d6b Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/3f9db56c2d6b Added tag hs16-b02 for changeset f4cbf78110c7 ! .hgtags Changeset: ae13a4698f0e Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/ae13a4698f0e Added tag hs16-b03 for changeset 07c1c01e0315 ! .hgtags Changeset: 3b66a571ba06 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/3b66a571ba06 Added tag hs16-b04 for changeset 08f86fa55a31 ! .hgtags Changeset: 373e25ef82f8 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/373e25ef82f8 Added tag hs16-b05 for changeset 32c83fb84370 ! .hgtags Changeset: 80da69beb2db Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/80da69beb2db Added tag hs16-b06 for changeset ba313800759b ! .hgtags Changeset: 894a8dc42646 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/894a8dc42646 Added tag hs16-b07 for changeset 3c0f72981560 ! .hgtags Changeset: 4cc301c896b4 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/4cc301c896b4 Added tag hs16-b08 for changeset ac59d4e6dae5 ! .hgtags Changeset: b07a8216e237 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/b07a8216e237 Added tag hs16-b09 for changeset 5979352804a0 ! .hgtags Changeset: c97b83006011 Author: trims Date: 2010-02-11 20:26 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c97b83006011 Added tag hs16-b10 for changeset 6bdfda9a7120 ! .hgtags Changeset: 37389679d486 Author: trims Date: 2010-02-11 20:26 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/37389679d486 Added tag hs16-b11 for changeset 38b152ff0cac ! .hgtags Changeset: dcf895a489dd Author: trims Date: 2010-02-11 20:26 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/dcf895a489dd Added tag hs16-b12 for changeset 834503c17fc1 ! .hgtags Changeset: b9408ac1b596 Author: trims Date: 2010-02-11 20:27 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/b9408ac1b596 Added tag hs16-b13 for changeset 62926c7f67a3 ! .hgtags From erik.trimble at sun.com Thu Feb 11 20:31:54 2010 From: erik.trimble at sun.com (erik.trimble at sun.com) Date: Thu, 11 Feb 2010 20:31:54 -0800 Subject: hg: hsx/hsx16/baseline/src/closed: 13 new changesets Message-ID: <20100212043157.4D5C01C49E@closedjdk.sfbay.sun.com> Changeset: dc13a79b8c55 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/dc13a79b8c55 Added tag hs16-b01 for changeset 54098bef736a ! .hgtags Changeset: 4faef5ed94ad Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/4faef5ed94ad Added tag hs16-b02 for changeset 2cfce1b8e054 ! .hgtags Changeset: 45025791c689 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/45025791c689 Added tag hs16-b03 for changeset e276364cba8d ! .hgtags Changeset: 138e97c51b20 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/138e97c51b20 Added tag hs16-b04 for changeset 24727f718579 ! .hgtags Changeset: 4dbcd99fe1a1 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/4dbcd99fe1a1 Added tag hs16-b05 for changeset 2bf33dfbf3ed ! .hgtags Changeset: 516266a19258 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/516266a19258 Added tag hs16-b06 for changeset fe8148bf2142 ! .hgtags Changeset: 3f05819a00e5 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/3f05819a00e5 Added tag hs16-b07 for changeset 1861800b6d2e ! .hgtags Changeset: e713f2c4af55 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/e713f2c4af55 Added tag hs16-b08 for changeset 64a273aa387b ! .hgtags Changeset: 96dacfd25dab Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/96dacfd25dab Added tag hs16-b09 for changeset a5d6bee9a8a7 ! .hgtags Changeset: c75af5c4daad Author: trims Date: 2010-02-11 20:26 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/c75af5c4daad Added tag hs16-b10 for changeset a5d6bee9a8a7 ! .hgtags Changeset: b380788acd14 Author: trims Date: 2010-02-11 20:26 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/b380788acd14 Added tag hs16-b11 for changeset a5d6bee9a8a7 ! .hgtags Changeset: 944dd689686b Author: trims Date: 2010-02-11 20:26 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/944dd689686b Added tag hs16-b12 for changeset a5d6bee9a8a7 ! .hgtags Changeset: 29dadbc817b1 Author: trims Date: 2010-02-11 20:28 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/src/closed/rev/29dadbc817b1 Added tag hs16-b13 for changeset a5d6bee9a8a7 ! .hgtags From erik.trimble at sun.com Thu Feb 11 20:32:16 2010 From: erik.trimble at sun.com (erik.trimble at sun.com) Date: Thu, 11 Feb 2010 20:32:16 -0800 Subject: hg: hsx/hsx16/baseline/test/closed: 13 new changesets Message-ID: <20100212043224.114041C49F@closedjdk.sfbay.sun.com> Changeset: 9edf4729b10d Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/9edf4729b10d Added tag hs16-b01 for changeset 9df21227349c ! .hgtags Changeset: c23a3ce64db7 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/c23a3ce64db7 Added tag hs16-b02 for changeset 4052c4054b26 ! .hgtags Changeset: bb4c2cfeca6f Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/bb4c2cfeca6f Added tag hs16-b03 for changeset 2733ec77764f ! .hgtags Changeset: 789e59fd9318 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/789e59fd9318 Added tag hs16-b04 for changeset c29c5d22d604 ! .hgtags Changeset: c17d9cec6a9e Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/c17d9cec6a9e Added tag hs16-b05 for changeset 5790d11efd54 ! .hgtags Changeset: 438e5446f5f7 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/438e5446f5f7 Added tag hs16-b06 for changeset ce4afc227fca ! .hgtags Changeset: debe2b632c0e Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/debe2b632c0e Added tag hs16-b07 for changeset 092381849a08 ! .hgtags Changeset: f54d526bfc08 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/f54d526bfc08 Added tag hs16-b08 for changeset 72d871f086f4 ! .hgtags Changeset: e2756e086d5b Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/e2756e086d5b Added tag hs16-b09 for changeset b145ab9b7168 ! .hgtags Changeset: 2022c3190748 Author: trims Date: 2010-02-11 20:26 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/2022c3190748 Added tag hs16-b10 for changeset b145ab9b7168 ! .hgtags Changeset: aaca2f4b5e57 Author: trims Date: 2010-02-11 20:26 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/aaca2f4b5e57 Added tag hs16-b11 for changeset b145ab9b7168 ! .hgtags Changeset: 6c60c6863afb Author: trims Date: 2010-02-11 20:26 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/6c60c6863afb Added tag hs16-b12 for changeset b145ab9b7168 ! .hgtags Changeset: 8488272bb124 Author: trims Date: 2010-02-11 20:28 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/baseline/test/closed/rev/8488272bb124 Added tag hs16-b13 for changeset b145ab9b7168 ! .hgtags From erik.trimble at sun.com Thu Feb 11 20:33:17 2010 From: erik.trimble at sun.com (erik.trimble at sun.com) Date: Fri, 12 Feb 2010 04:33:17 +0000 Subject: hg: hsx/hsx16/master: 13 new changesets Message-ID: <20100212043357.981E441C4D@hg.openjdk.java.net> Changeset: 58ff7544194e Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/58ff7544194e Added tag hs16-b01 for changeset 981375ca07b7 ! .hgtags Changeset: 3f9db56c2d6b Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/3f9db56c2d6b Added tag hs16-b02 for changeset f4cbf78110c7 ! .hgtags Changeset: ae13a4698f0e Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/ae13a4698f0e Added tag hs16-b03 for changeset 07c1c01e0315 ! .hgtags Changeset: 3b66a571ba06 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/3b66a571ba06 Added tag hs16-b04 for changeset 08f86fa55a31 ! .hgtags Changeset: 373e25ef82f8 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/373e25ef82f8 Added tag hs16-b05 for changeset 32c83fb84370 ! .hgtags Changeset: 80da69beb2db Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/80da69beb2db Added tag hs16-b06 for changeset ba313800759b ! .hgtags Changeset: 894a8dc42646 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/894a8dc42646 Added tag hs16-b07 for changeset 3c0f72981560 ! .hgtags Changeset: 4cc301c896b4 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/4cc301c896b4 Added tag hs16-b08 for changeset ac59d4e6dae5 ! .hgtags Changeset: b07a8216e237 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/b07a8216e237 Added tag hs16-b09 for changeset 5979352804a0 ! .hgtags Changeset: c97b83006011 Author: trims Date: 2010-02-11 20:26 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/c97b83006011 Added tag hs16-b10 for changeset 6bdfda9a7120 ! .hgtags Changeset: 37389679d486 Author: trims Date: 2010-02-11 20:26 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/37389679d486 Added tag hs16-b11 for changeset 38b152ff0cac ! .hgtags Changeset: dcf895a489dd Author: trims Date: 2010-02-11 20:26 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/dcf895a489dd Added tag hs16-b12 for changeset 834503c17fc1 ! .hgtags Changeset: b9408ac1b596 Author: trims Date: 2010-02-11 20:27 -0800 URL: http://hg.openjdk.java.net/hsx/hsx16/master/rev/b9408ac1b596 Added tag hs16-b13 for changeset 62926c7f67a3 ! .hgtags From erik.trimble at sun.com Thu Feb 11 20:34:52 2010 From: erik.trimble at sun.com (erik.trimble at sun.com) Date: Thu, 11 Feb 2010 20:34:52 -0800 Subject: hg: hsx/hsx16/master/src/closed: 13 new changesets Message-ID: <20100212043456.397901C4A0@closedjdk.sfbay.sun.com> Changeset: dc13a79b8c55 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/dc13a79b8c55 Added tag hs16-b01 for changeset 54098bef736a ! .hgtags Changeset: 4faef5ed94ad Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/4faef5ed94ad Added tag hs16-b02 for changeset 2cfce1b8e054 ! .hgtags Changeset: 45025791c689 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/45025791c689 Added tag hs16-b03 for changeset e276364cba8d ! .hgtags Changeset: 138e97c51b20 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/138e97c51b20 Added tag hs16-b04 for changeset 24727f718579 ! .hgtags Changeset: 4dbcd99fe1a1 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/4dbcd99fe1a1 Added tag hs16-b05 for changeset 2bf33dfbf3ed ! .hgtags Changeset: 516266a19258 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/516266a19258 Added tag hs16-b06 for changeset fe8148bf2142 ! .hgtags Changeset: 3f05819a00e5 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/3f05819a00e5 Added tag hs16-b07 for changeset 1861800b6d2e ! .hgtags Changeset: e713f2c4af55 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/e713f2c4af55 Added tag hs16-b08 for changeset 64a273aa387b ! .hgtags Changeset: 96dacfd25dab Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/96dacfd25dab Added tag hs16-b09 for changeset a5d6bee9a8a7 ! .hgtags Changeset: c75af5c4daad Author: trims Date: 2010-02-11 20:26 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/c75af5c4daad Added tag hs16-b10 for changeset a5d6bee9a8a7 ! .hgtags Changeset: b380788acd14 Author: trims Date: 2010-02-11 20:26 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/b380788acd14 Added tag hs16-b11 for changeset a5d6bee9a8a7 ! .hgtags Changeset: 944dd689686b Author: trims Date: 2010-02-11 20:26 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/944dd689686b Added tag hs16-b12 for changeset a5d6bee9a8a7 ! .hgtags Changeset: 29dadbc817b1 Author: trims Date: 2010-02-11 20:28 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/src/closed/rev/29dadbc817b1 Added tag hs16-b13 for changeset a5d6bee9a8a7 ! .hgtags From erik.trimble at sun.com Thu Feb 11 20:35:18 2010 From: erik.trimble at sun.com (erik.trimble at sun.com) Date: Thu, 11 Feb 2010 20:35:18 -0800 Subject: hg: hsx/hsx16/master/test/closed: 13 new changesets Message-ID: <20100212043526.8AF731C4A1@closedjdk.sfbay.sun.com> Changeset: 9edf4729b10d Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/9edf4729b10d Added tag hs16-b01 for changeset 9df21227349c ! .hgtags Changeset: c23a3ce64db7 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/c23a3ce64db7 Added tag hs16-b02 for changeset 4052c4054b26 ! .hgtags Changeset: bb4c2cfeca6f Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/bb4c2cfeca6f Added tag hs16-b03 for changeset 2733ec77764f ! .hgtags Changeset: 789e59fd9318 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/789e59fd9318 Added tag hs16-b04 for changeset c29c5d22d604 ! .hgtags Changeset: c17d9cec6a9e Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/c17d9cec6a9e Added tag hs16-b05 for changeset 5790d11efd54 ! .hgtags Changeset: 438e5446f5f7 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/438e5446f5f7 Added tag hs16-b06 for changeset ce4afc227fca ! .hgtags Changeset: debe2b632c0e Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/debe2b632c0e Added tag hs16-b07 for changeset 092381849a08 ! .hgtags Changeset: f54d526bfc08 Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/f54d526bfc08 Added tag hs16-b08 for changeset 72d871f086f4 ! .hgtags Changeset: e2756e086d5b Author: trims Date: 2010-02-11 20:20 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/e2756e086d5b Added tag hs16-b09 for changeset b145ab9b7168 ! .hgtags Changeset: 2022c3190748 Author: trims Date: 2010-02-11 20:26 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/2022c3190748 Added tag hs16-b10 for changeset b145ab9b7168 ! .hgtags Changeset: aaca2f4b5e57 Author: trims Date: 2010-02-11 20:26 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/aaca2f4b5e57 Added tag hs16-b11 for changeset b145ab9b7168 ! .hgtags Changeset: 6c60c6863afb Author: trims Date: 2010-02-11 20:26 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/6c60c6863afb Added tag hs16-b12 for changeset b145ab9b7168 ! .hgtags Changeset: 8488272bb124 Author: trims Date: 2010-02-11 20:28 -0800 URL: http://closedjdk.sfbay/hsx/hsx16/master/test/closed/rev/8488272bb124 Added tag hs16-b13 for changeset b145ab9b7168 ! .hgtags From Ulf.Zibis at gmx.de Fri Feb 12 06:06:41 2010 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Fri, 12 Feb 2010 15:06:41 +0100 Subject: Assertions in static blocks ? Message-ID: <4B756071.4000104@gmx.de> Hi, in the following example, I have an assert statement in a static block of my class. If accessing the static final constants from another class, the static block is not executed. This causes the assertions to remain un-proofed, even if -ea -esa is set. Is that correct ? IMO, assertions should always run, if -ea -esa is set. -Ulf package sun.nio.cs.ext; import static sun.nio.cs.CharsetMapping.*; /** * * @author Ulf Zibis, Cologne CoSoCo.de */ class EUC_TWMapping3 extends EUC_TWMapping { static final short PL0_5_B2C_RANGE = 0x2300; // plane 0, 5 b2c range static final short PLANE_B2C_RANGE = 0x1f00; // plane 2..4, 6..15 b2c range // TODO: file bug: static block should run, if assertions are enabled. static { // assert plane offsets and content for (int p=0, range, offset=0; p 0; // force assertion, TODO: JDK bug ? } } From Ulf.Zibis at gmx.de Fri Feb 12 06:44:21 2010 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Fri, 12 Feb 2010 15:44:21 +0100 Subject: Assertions in static blocks ? In-Reply-To: <4B756071.4000104@gmx.de> References: <4B756071.4000104@gmx.de> Message-ID: <4B756945.1090600@gmx.de> Am 12.02.2010 15:06, schrieb Ulf Zibis: > Hi, > > in the following example, I have an assert statement in a static block > of my class. > > If accessing the static final constants from another class, the static > block is not executed. > This causes the assertions to remain un-proofed, even if -ea -esa is set. > > Is that correct ? If yes, javac should claim the code as never reached. > > IMO, assertions should always run, if -ea -esa is set. > > -Ulf > -Ulf From Keith.McGuigan at Sun.COM Fri Feb 12 07:12:58 2010 From: Keith.McGuigan at Sun.COM (Keith McGuigan) Date: Fri, 12 Feb 2010 10:12:58 -0500 Subject: Assertions in static blocks ? In-Reply-To: <4B756071.4000104@gmx.de> References: <4B756071.4000104@gmx.de> Message-ID: <4B756FFA.9000806@sun.com> Hi Ulf - Accessing a constant static field in a class does not trigger class initialization, so your initializer is probably just not being run. See http://java.sun.com/docs/books/jvms/second_edition/html/Concepts.doc.html#19075 -- - Keith Ulf Zibis wrote: > Hi, > > in the following example, I have an assert statement in a static block > of my class. > > If accessing the static final constants from another class, the static > block is not executed. > This causes the assertions to remain un-proofed, even if -ea -esa is set. > > Is that correct ? > > IMO, assertions should always run, if -ea -esa is set. > > -Ulf > > > > package sun.nio.cs.ext; > > import static sun.nio.cs.CharsetMapping.*; > > /** > * > * @author Ulf Zibis, Cologne CoSoCo.de > */ > class EUC_TWMapping3 extends EUC_TWMapping { > static final short PL0_5_B2C_RANGE = 0x2300; // plane 0, 5 b2c range > static final short PLANE_B2C_RANGE = 0x1f00; // plane 2..4, 6..15 > b2c range > > // TODO: file bug: static block should run, if assertions are enabled. > static { > // assert plane offsets and content > for (int p=0, range, offset=0; p range = p % 4 == 0 ? PL0_5_B2C_RANGE : PLANE_B2C_RANGE; > for (int i=range; i assert b2c[p].charAt(i) == UNMAPPABLE_DECODING; > // static block should run, if assertions are enabled. For test > uncomment following line > // System.out.printf("offset: %d, range: %d, b2c[p].length(): > %d%n", offset, range, b2c[p].length()); > assert (offset += range) <= Character.MAX_VALUE + 1; > } > } > > // WORKAROUND: > // static int offset = 0; // assert from calling context to force > static block to process > // static { > // // assert plane offsets and content > // for (int p=0, range; p // range = p % 4 == 0 ? PL0_5_B2C_RANGE : PLANE_B2C_RANGE; > // for (int i=range; i // assert b2c[p].charAt(i) == UNMAPPABLE_DECODING; > //// static block should run, if assertions are enabled. For test > uncomment following line > //// System.out.printf("offset: %d, range: %d, > b2c[p].length(): %d%n", offset, range, b2c[p].length()); > // assert (offset += range) <= Character.MAX_VALUE + 1; > // } > //// static block should run, if assertions are enabled. For test > uncomment following line > //// assert false; > // } > } > > > package sun.nio.cs.ext; > > /** > * > * @author Ulf Zibis, Cologne CoSoCo.de > */ > public class AssertTest { > > public static void main(String... args) { > // static block in EUC_TWMapping3 should run, if assertions are enabled. > System.out.println(EUC_TWMapping3.PLANE_B2C_RANGE); > // WORKAROUND: For test uncomment following line > // assert EUC_TWMapping3.offset > 0; // force assertion, TODO: > JDK bug ? > } > } > > From manjiri.namjoshi at googlemail.com Fri Feb 12 13:00:36 2010 From: manjiri.namjoshi at googlemail.com (Manjiri Namjoshi) Date: Fri, 12 Feb 2010 15:00:36 -0600 Subject: SecurityException Message-ID: Hello, I am trying to run hotspot on the annotated specjvm2008 classfiles. I am using SOOT framework to annotate the classfiles. My question is regarding the compiler.compiler benchmark : After running soot, it generates some classes in the com.sun.tools.javac.util package. So these annotated classes are now present in the directory from which I run the specjvm2008 benchmarks. Also, not all the classes in the mentioned package are transformed by SOOT. I get SecurityException : class "com.sun.tools.javac.util.JavacFileManager$Archive"'s signer information does not match signer information of other classes in the same package But, if I specify -Xbootclasspath/p:.:$CLASSPATH (i.e. prepend current dir and $CLASSPATH to Xbootclasspath) and $CLASSPATH contains javac.jar, then the benchmark runs fine. So, my question is are the classes is com.sun.tools.javac loaded as library classes ? Or, are they a part of application classes ? Thank You. Sincerely, Manjiri From vladimir.kozlov at sun.com Fri Feb 12 18:30:31 2010 From: vladimir.kozlov at sun.com (vladimir.kozlov at sun.com) Date: Sat, 13 Feb 2010 02:30:31 +0000 Subject: hg: jdk7/hotspot/hotspot: 8 new changesets Message-ID: <20100213023056.4D4BD41DCA@hg.openjdk.java.net> Changeset: 3f5b7efb9642 Author: never Date: 2010-02-05 11:07 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/3f5b7efb9642 6920293: OptimizeStringConcat causing core dumps Reviewed-by: kvn, twisti ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 576e77447e3c Author: kvn Date: 2010-02-07 12:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/576e77447e3c 6923002: assert(false,"this call site should not be polymorphic") Summary: Clear the total count when a receiver information is cleared. Reviewed-by: never, jrose ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/arguments.cpp Changeset: f516d5d7a019 Author: kvn Date: 2010-02-08 12:20 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f516d5d7a019 6910605: C2: NullPointerException/ClassCaseException is thrown when C2 with DeoptimizeALot is used Summary: Set the reexecute bit for runtime calls _new_array_Java when they used for _multianewarray bytecode. Reviewed-by: never ! src/share/vm/code/pcDesc.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/parse3.cpp + test/compiler/6910605/Test.java Changeset: f70b0d9ab095 Author: kvn Date: 2010-02-09 01:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f70b0d9ab095 6910618: C2: Error: assert(d->is_oop(),"JVM_ArrayCopy: dst not an oop") Summary: Mark in PcDesc call sites which return oop and save the result oop across objects reallocation during deoptimization. Reviewed-by: never ! src/share/vm/c1/c1_IR.hpp ! src/share/vm/code/debugInfoRec.cpp ! src/share/vm/code/debugInfoRec.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/pcDesc.hpp ! src/share/vm/code/scopeDesc.cpp ! src/share/vm/code/scopeDesc.hpp ! src/share/vm/includeDB_core ! src/share/vm/opto/output.cpp ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp ! src/share/vm/runtime/deoptimization.cpp + test/compiler/6910618/Test.java Changeset: 4ee1c645110e Author: kvn Date: 2010-02-09 10:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/4ee1c645110e 6924097: assert((_type == Type::MEMORY) == (_adr_type != 0),"adr_type for memory phis only") Summary: Use PhiNode::make_blank(r, n) method to construct the phi. Reviewed-by: never ! src/share/vm/opto/loopopts.cpp Changeset: e3a4305c6bc3 Author: kvn Date: 2010-02-12 08:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/e3a4305c6bc3 6925249: assert(last_sp < (intptr_t*) interpreter_frame_monitor_begin(),"bad tos") Summary: Fix assert since top deoptimized frame has last_sp == interpreter_frame_monitor_begin if there are no expressions. Reviewed-by: twisti ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/vframeArray.cpp Changeset: c09ee209b65c Author: kvn Date: 2010-02-12 10:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c09ee209b65c 6926048: Improve Zero performance Summary: Make Zero figure out result types in a similar way to C++ interpreter implementation. Reviewed-by: kvn Contributed-by: gbenson at redhat.com ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/cpu/zero/vm/cppInterpreter_zero.hpp Changeset: 7b4415a18c8a Author: kvn Date: 2010-02-12 15:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/7b4415a18c8a Merge ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/includeDB_core ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/sharedRuntime.cpp From john.coomes at sun.com Sun Feb 14 11:38:56 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sun, 14 Feb 2010 19:38:56 +0000 Subject: hg: jdk7/hotspot: Added tag jdk7-b83 for changeset 6880a3af9add Message-ID: <20100214193858.6FA204206A@hg.openjdk.java.net> Changeset: 2f3ea057d1ad Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/2f3ea057d1ad Added tag jdk7-b83 for changeset 6880a3af9add ! .hgtags From john.coomes at sun.com Sun Feb 14 11:39:07 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sun, 14 Feb 2010 19:39:07 +0000 Subject: hg: jdk7/hotspot/corba: Added tag jdk7-b83 for changeset fde0df7a2384 Message-ID: <20100214193908.641864206B@hg.openjdk.java.net> Changeset: 68c8961a82e4 Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/68c8961a82e4 Added tag jdk7-b83 for changeset fde0df7a2384 ! .hgtags From john.coomes at sun.com Sun Feb 14 11:41:53 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sun, 14 Feb 2010 19:41:53 +0000 Subject: hg: jdk7/hotspot/jaxp: Added tag jdk7-b83 for changeset 309a0a7fc6ce Message-ID: <20100214194154.136774206D@hg.openjdk.java.net> Changeset: c664aff74b41 Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/c664aff74b41 Added tag jdk7-b83 for changeset 309a0a7fc6ce ! .hgtags From john.coomes at sun.com Sun Feb 14 11:42:03 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sun, 14 Feb 2010 19:42:03 +0000 Subject: hg: jdk7/hotspot/jaxws: Added tag jdk7-b83 for changeset 371e3ded591d Message-ID: <20100214194203.DB9BB4206E@hg.openjdk.java.net> Changeset: 8bc02839eee4 Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/8bc02839eee4 Added tag jdk7-b83 for changeset 371e3ded591d ! .hgtags From john.coomes at sun.com Sun Feb 14 11:42:18 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sun, 14 Feb 2010 19:42:18 +0000 Subject: hg: jdk7/hotspot/jdk: Added tag jdk7-b83 for changeset 9027c6b9d7e2 Message-ID: <20100214194237.5A8884206F@hg.openjdk.java.net> Changeset: 9b82fa0505bc Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9b82fa0505bc Added tag jdk7-b83 for changeset 9027c6b9d7e2 ! .hgtags From john.coomes at sun.com Sun Feb 14 11:47:25 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Sun, 14 Feb 2010 19:47:25 +0000 Subject: hg: jdk7/hotspot/langtools: Added tag jdk7-b83 for changeset c9f4ae1f1480 Message-ID: <20100214194728.BD3F542071@hg.openjdk.java.net> Changeset: 2edcb5dc642d Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/2edcb5dc642d Added tag jdk7-b83 for changeset c9f4ae1f1480 ! .hgtags From Christian.Thalinger at Sun.COM Mon Feb 15 02:23:21 2010 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Mon, 15 Feb 2010 11:23:21 +0100 Subject: SecurityException In-Reply-To: References: Message-ID: <4B792099.6050409@Sun.COM> On 02/12/10 10:00 PM, Manjiri Namjoshi wrote: > Hello, > > I am trying to run hotspot on the annotated specjvm2008 > classfiles. I am using SOOT framework to annotate the classfiles. > My question is regarding the compiler.compiler benchmark : > After running soot, it generates some classes in the > com.sun.tools.javac.util package. So these annotated classes are now > present in the directory from which I run the specjvm2008 benchmarks. > Also, not all the classes in the mentioned package are transformed by SOOT. > I get SecurityException : class > "com.sun.tools.javac.util.JavacFileManager$Archive"'s signer > information does not match signer information of other classes in the > same package > > But, if I specify -Xbootclasspath/p:.:$CLASSPATH (i.e. prepend current > dir and $CLASSPATH to Xbootclasspath) and $CLASSPATH contains > javac.jar, then the benchmark runs fine. > > So, my question is are the classes is com.sun.tools.javac loaded as > library classes ? Or, are they a part of application classes ? Well, I guess you could find out yourself by querying the ClassLoader of the class. -- Christian From john.cuthbertson at sun.com Tue Feb 16 17:02:36 2010 From: john.cuthbertson at sun.com (john.cuthbertson at sun.com) Date: Wed, 17 Feb 2010 01:02:36 +0000 Subject: hg: jdk7/hotspot/hotspot: 5 new changesets Message-ID: <20100217010253.EEC6F423EF@hg.openjdk.java.net> Changeset: 38836cf1d8d2 Author: tonyp Date: 2010-02-05 11:05 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/38836cf1d8d2 6920977: G1: guarantee(k == probe->klass(),"klass should be in dictionary") fails Summary: the guarantee is too strict and the test will fail (incorrectly) if the class is not in the system dictionary but in the placeholders. Reviewed-by: acorn, phh ! src/share/vm/classfile/loaderConstraints.cpp ! src/share/vm/classfile/loaderConstraints.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/includeDB_core Changeset: 9eee977dd1a9 Author: tonyp Date: 2010-02-08 14:23 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/9eee977dd1a9 6802453: G1: hr()->is_in_reserved(from),"Precondition." Summary: The operations of re-using a RSet component and expanding the same RSet component were not mutually exlusive, and this could lead to RSets getting corrupted and entries being dropped. Reviewed-by: iveresov, johnc ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp Changeset: 8859772195c6 Author: johnc Date: 2010-02-09 13:56 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/8859772195c6 6782663: Data produced by PrintGCApplicationConcurrentTime and PrintGCApplicationStoppedTime is not accurate. Summary: Update and display the timers associated with these flags for all safepoints. Reviewed-by: ysr, jcoomes ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/services/runtimeService.cpp Changeset: 0414c1049f15 Author: iveresov Date: 2010-02-11 15:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/0414c1049f15 6923991: G1: improve scalability of RSet scanning Summary: Implemented block-based work stealing. Moved copying during the rset scanning phase to the main copying phase. Made the size of rset table depend on the region size. Reviewed-by: apetrusenko, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 58add740c4ee Author: johnc Date: 2010-02-16 14:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/58add740c4ee Merge ! src/share/vm/includeDB_core From Christian.Thalinger at Sun.COM Thu Feb 18 12:49:13 2010 From: Christian.Thalinger at Sun.COM (Christian.Thalinger at Sun.COM) Date: Thu, 18 Feb 2010 20:49:13 +0000 Subject: hg: jdk7/hotspot/hotspot: 5 new changesets Message-ID: <20100218204929.71E75426DC@hg.openjdk.java.net> Changeset: e7b1cc79bd25 Author: kvn Date: 2010-02-16 16:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/e7b1cc79bd25 6926697: "optimized" VM build failed: The type "AdapterHandlerTableIterator" is incomplete Summary: Define AdapterHandlerTableIterator class as non product instead of debug. Reviewed-by: never ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 106f41e88c85 Author: never Date: 2010-02-16 20:07 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/106f41e88c85 6877221: Endless deoptimizations in OSR nmethod Reviewed-by: kvn ! src/share/vm/opto/parse1.cpp Changeset: b4b440360f1e Author: twisti Date: 2010-02-18 11:35 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/b4b440360f1e 6926782: CodeBuffer size too small after 6921352 Summary: After 6921352 the CodeBuffer size was too small. Reviewed-by: kvn, never ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/output.cpp Changeset: 3b687c53c266 Author: twisti Date: 2010-02-18 06:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/3b687c53c266 6927165: Zero S/390 fixes Summary: Fixes two failures on 31-bit S/390. Reviewed-by: twisti Contributed-by: Gary Benson ! src/cpu/zero/vm/globals_zero.hpp ! src/os_cpu/linux_zero/vm/os_linux_zero.hpp Changeset: 72f1840531a4 Author: twisti Date: 2010-02-18 10:44 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/72f1840531a4 Merge From jamshi.mohd at gmail.com Thu Feb 18 23:30:03 2010 From: jamshi.mohd at gmail.com (jamsheed mohammed) Date: Fri, 19 Feb 2010 13:00:03 +0530 Subject: Doubt regarding failurehandling(bailout mechanism) in c2 code Message-ID: Hi All, Can any one enlight me on design decision on why exception handling mechanism was not used in c2 failure(bailout ) code. Regards, Jamsheed -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20100219/1e538647/attachment.html From john.coomes at sun.com Fri Feb 19 06:35:12 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Feb 2010 14:35:12 +0000 Subject: hg: jdk7/hotspot: Added tag jdk7-b84 for changeset 2f3ea057d1ad Message-ID: <20100219143512.709AC42807@hg.openjdk.java.net> Changeset: cf26288a114b Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/cf26288a114b Added tag jdk7-b84 for changeset 2f3ea057d1ad ! .hgtags From john.coomes at sun.com Fri Feb 19 06:35:18 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Feb 2010 14:35:18 +0000 Subject: hg: jdk7/hotspot/corba: Added tag jdk7-b84 for changeset 68c8961a82e4 Message-ID: <20100219143521.5CD4042809@hg.openjdk.java.net> Changeset: c67a9df7bc0c Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/c67a9df7bc0c Added tag jdk7-b84 for changeset 68c8961a82e4 ! .hgtags From john.coomes at sun.com Fri Feb 19 06:39:36 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Feb 2010 14:39:36 +0000 Subject: hg: jdk7/hotspot/jaxp: 4 new changesets Message-ID: <20100219143937.1D8954280C@hg.openjdk.java.net> Changeset: df2e196a5f01 Author: ohair Date: 2010-02-03 16:44 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/df2e196a5f01 6923146: Upgrade to JAXP 1.4.3 Reviewed-by: darcy ! jaxp.properties Changeset: bf7c7f2825ef Author: lana Date: 2010-02-08 23:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/bf7c7f2825ef Merge Changeset: 32c0cf01d555 Author: lana Date: 2010-02-14 23:35 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/32c0cf01d555 Merge Changeset: 6c0ccabb430d Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/6c0ccabb430d Added tag jdk7-b84 for changeset 32c0cf01d555 ! .hgtags From john.coomes at sun.com Fri Feb 19 06:39:42 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Feb 2010 14:39:42 +0000 Subject: hg: jdk7/hotspot/jaxws: Added tag jdk7-b84 for changeset 8bc02839eee4 Message-ID: <20100219143943.319EB4280D@hg.openjdk.java.net> Changeset: 8424512588ff Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/8424512588ff Added tag jdk7-b84 for changeset 8bc02839eee4 ! .hgtags From john.coomes at sun.com Fri Feb 19 06:42:27 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Feb 2010 14:42:27 +0000 Subject: hg: jdk7/hotspot/jdk: 48 new changesets Message-ID: <20100219145811.BADED42812@hg.openjdk.java.net> Changeset: dca3a251a001 Author: xuelei Date: 2010-01-20 21:38 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/dca3a251a001 6862064: incorrect implementation of PKIXParameters.clone() Reviewed-by: weijun, mullan ! src/share/classes/java/security/cert/PKIXParameters.java Changeset: b19cd193245e Author: dcubed Date: 2010-01-20 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b19cd193245e 6580131: 3/4 CompiledMethodLoad events don't produce the expected extra notifications to describe inlining Summary: Add support for additional implementation specific info to the JVM/TI CompiledMethodLoad event via the compile_info parameter. Reviewed-by: never, ohair, tbell, tdeneau Contributed-by: Vasanth Venkatachalam ! make/common/shared/Sanity.gmk ! make/java/jvm/Makefile ! make/mkdemo/jvmti/Makefile ! make/mkdemo/jvmti/README.txt + make/mkdemo/jvmti/compiledMethodLoad/Makefile + src/share/demo/jvmti/compiledMethodLoad/README.txt + src/share/demo/jvmti/compiledMethodLoad/compiledMethodLoad.c + src/share/demo/jvmti/compiledMethodLoad/sample.makefile.txt ! src/share/demo/jvmti/index.html + src/share/javavm/export/jvmticmlr.h + test/demo/jvmti/compiledMethodLoad/CompiledMethodLoadTest.java ! test/demo/jvmti/heapTracker/HeapTrackerTest.java ! test/demo/jvmti/hprof/CpuTimesDefineClassTest.java ! test/demo/jvmti/hprof/CpuTimesTest.java ! test/demo/jvmti/minst/MinstTest.java ! test/demo/jvmti/mtrace/TraceJFrame.java Changeset: 117b245b5bb9 Author: vinnie Date: 2010-01-21 23:59 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/117b245b5bb9 6763530: Cannot decode PublicKey (Proider SunPKCS11, curve prime256v1) Reviewed-by: andrew ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11Key.java Changeset: c94ac5522d01 Author: vinnie Date: 2010-01-22 00:02 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c94ac5522d01 Merge Changeset: e67bf9abc6a5 Author: chegar Date: 2010-01-25 15:41 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e67bf9abc6a5 6707289: InterfaceAddress.getNetworkPrefixLength() does not conform to Javadoc Reviewed-by: michaelm ! src/windows/native/java/net/NetworkInterface_winXP.c + test/java/net/InterfaceAddress/NetworkPrefixLength.java Changeset: 558f2a424bfa Author: weijun Date: 2010-01-26 17:03 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/558f2a424bfa 6919610: KeyTabInputStream uses static field for per-instance value Reviewed-by: mullan ! src/share/classes/sun/security/krb5/internal/ktab/KeyTabInputStream.java + test/sun/security/krb5/ktab/KeyTabIndex.java Changeset: f544825d0976 Author: jccollet Date: 2010-01-26 11:39 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f544825d0976 6919185: test/closed/sun/net/ftp/FtpTests fails to compile Summary: Fixed a couple of regressions in FtpClient and updated the test. Reviewed-by: chegar ! src/share/classes/sun/net/ftp/impl/FtpClient.java Changeset: 8df0ffac7f4d Author: chegar Date: 2010-01-27 16:11 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/8df0ffac7f4d 6905552: libnet/nio portability issues Reviewed-by: alanb ! src/share/native/java/net/net_util.c ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/java/net/net_util_md.h ! src/solaris/native/sun/net/spi/SdpProvider.c ! src/solaris/native/sun/nio/ch/Net.c ! src/solaris/native/sun/nio/ch/SctpNet.c Changeset: 4192f6edbbf4 Author: ptisnovs Date: 2010-01-27 17:47 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4192f6edbbf4 6920143: test/java/awt/TestArea/UsingWithMouse.java needs realSync() Summary: Added small delay to make sure that TextArea animation have finished Reviewed-by: anthony ! test/java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest.java Changeset: 0126effcc249 Author: lana Date: 2010-01-27 14:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0126effcc249 Merge Changeset: 946b30073247 Author: sherman Date: 2010-01-27 19:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/946b30073247 6920732: opensource test/java/nio/charset Summary: move the test cases to openjdk Reviewed-by: martin + test/java/nio/charset/Charset/AvailableCharsetNames.java + test/java/nio/charset/Charset/CharsetContainmentTest.java + test/java/nio/charset/Charset/Contains.java + test/java/nio/charset/Charset/Default.java + test/java/nio/charset/Charset/EmptyCharsetName.java + test/java/nio/charset/Charset/EncDec.java + test/java/nio/charset/Charset/IllegalCharsetName.java + test/java/nio/charset/Charset/NIOCharsetAvailabilityTest.java + test/java/nio/charset/Charset/NullCharsetName.java + test/java/nio/charset/Charset/RegisteredCharsets.java + test/java/nio/charset/Charset/default.sh + test/java/nio/charset/CharsetDecoder/AverageMax.java + test/java/nio/charset/CharsetDecoder/EmptyInput.java + test/java/nio/charset/CharsetEncoder/CanEncode.java + test/java/nio/charset/CharsetEncoder/Flush.java + test/java/nio/charset/RemovingSunIO/SunioAlias.java + test/java/nio/charset/RemovingSunIO/TestCOMP.java + test/java/nio/charset/RemovingSunIO/TestUnmappableForLength.java + test/java/nio/charset/coders/BashCache.java + test/java/nio/charset/coders/BashStreams.java + test/java/nio/charset/coders/Check.java + test/java/nio/charset/coders/CheckSJISMappingProp.sh + test/java/nio/charset/coders/Errors.java + test/java/nio/charset/coders/FullRead.java + test/java/nio/charset/coders/IOCoders.java + test/java/nio/charset/coders/IsLegalReplacement.java + test/java/nio/charset/coders/ResetISO2022JP.java + test/java/nio/charset/coders/SJISPropTest.java + test/java/nio/charset/coders/StreamTimeout.java + test/java/nio/charset/coders/Surrogate.java + test/java/nio/charset/coders/Surrogates.java + test/java/nio/charset/coders/Util.java + test/java/nio/charset/coders/ref.shift_jis + test/java/nio/charset/coders/ref.windows-31j + test/java/nio/charset/spi/FooCharset.java + test/java/nio/charset/spi/FooProvider.java + test/java/nio/charset/spi/Test.java + test/java/nio/charset/spi/basic.sh + test/java/nio/charset/spi/charsetProvider.sp + test/java/nio/charset/spi/default-pol Changeset: 7dadd2951a8b Author: andrew Date: 2010-02-02 10:55 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7dadd2951a8b 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true Summary: Fix sun.io converters unchecked and cast warnings produced by -Xlint:all Reviewed-by: alanb, sherman ! make/java/sun_nio/Makefile ! src/share/classes/sun/io/ByteToCharUTF8.java ! src/share/classes/sun/io/CharToByteUnicode.java ! src/share/classes/sun/io/CharacterEncoding.java ! src/share/classes/sun/io/Converters.java ! src/share/classes/sun/nio/cs/AbstractCharsetProvider.java Changeset: e6ab5fabaf7e Author: weijun Date: 2010-02-03 17:04 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e6ab5fabaf7e 6922482: keytool's help on -file always shows 'output file' Reviewed-by: wetmore ! src/share/classes/sun/security/tools/KeyTool.java + test/sun/security/tools/keytool/file-in-help.sh Changeset: a39e899aa5dc Author: sherman Date: 2010-02-05 00:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a39e899aa5dc 6919132: Regex \P{Lu} selects half of a surrogate pari Summary: To use StartS for complement category/block class Reviewed-by: martin, okutsu ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java Changeset: 7136683a33d2 Author: wetmore Date: 2010-02-05 17:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7136683a33d2 6923976: TestProviderLeak.java is using too small of an initial heap under newer Hotspot (b79+) Reviewed-by: ohair ! test/com/sun/crypto/provider/KeyFactory/TestProviderLeak.java Changeset: 445b9928fb70 Author: sherman Date: 2010-02-06 09:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/445b9928fb70 6923692: java/classes_util TEST_BUG:ReadZip.java fails when Summary: to create the test file at test.dir Reviewed-by: alanb ! test/java/util/zip/ZipFile/ReadZip.java Changeset: e79d95ea2e81 Author: lana Date: 2010-02-08 23:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e79d95ea2e81 Merge Changeset: 7e8c77ae401a Author: rkennke Date: 2010-02-02 16:38 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7e8c77ae401a 6888734: PIT: regression test fails when java.security.manager is enabled Summary: Load FontManager instance in privileged block to avoid AccessControlException Reviewed-by: igor, tdv ! src/share/classes/sun/font/FontManagerFactory.java + test/java/awt/PrintJob/Security/SecurityDialogTest.java + test/java/awt/PrintJob/Security/policy Changeset: cedd0cdd5b9a Author: rkennke Date: 2010-02-03 10:02 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/cedd0cdd5b9a 6896335: GraphicsEnvironment.getDefaultScreenDevice() throws UnsatisfiedLinkError in headless mode Summary: Use local ge variable instead of localEnv field in GE. Reviewed-by: igor, prr ! src/share/classes/java/awt/GraphicsEnvironment.java + test/java/awt/GraphicsEnvironment/TestGetDefScreenDevice.java Changeset: 58d014485a29 Author: rkennke Date: 2010-02-07 11:07 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/58d014485a29 6904882: java.awt.Font.createFont() causes AccessControlException if executed with "-Djava.security.manager" Summary: Perform FontUtilities initialization in privileged block Reviewed-by: igor, prr ! src/share/classes/sun/font/FontUtilities.java + test/java/awt/FontClass/FontPrivilege.java Changeset: 89b0235188b5 Author: lana Date: 2010-02-09 00:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/89b0235188b5 Merge Changeset: 31a3f28f3326 Author: dcherepanov Date: 2009-12-23 01:22 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/31a3f28f3326 6908299: Missed changes for 6664512 during the merge with 6879044 Reviewed-by: mchung, art ! src/share/classes/sun/util/logging/PlatformLogger.java Changeset: 7b65af04d43c Author: dav Date: 2009-12-22 17:28 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7b65af04d43c 6893325: JComboBox and dragging to an item outside the bounds of the containing JFrame is not selecting that Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: 26280d1705b2 Author: dcherepanov Date: 2009-12-28 20:35 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/26280d1705b2 6857363: deadlock caused by sun.awt.X11.XTrayIconPeer$Tooltip.display Reviewed-by: ant, art ! src/solaris/classes/sun/awt/X11/InfoWindow.java Changeset: fd5bf5955e37 Author: uta Date: 2009-12-24 17:19 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/fd5bf5955e37 4874070: invoking DragSource's startDrag with an Image renders no image on drag Reviewed-by: art, denis, alexp ! make/sun/awt/FILES_c_windows.gmk ! make/sun/awt/Makefile ! make/sun/awt/make.depend ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java ! src/windows/classes/sun/awt/windows/WDataTransferer.java ! src/windows/classes/sun/awt/windows/WDragSourceContextPeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/lib/flavormap.properties ! src/windows/native/sun/windows/awt.h + src/windows/native/sun/windows/awt_DCHolder.cpp + src/windows/native/sun/windows/awt_DCHolder.h ! src/windows/native/sun/windows/awt_DnDDS.cpp ! src/windows/native/sun/windows/awt_DnDDS.h ! src/windows/native/sun/windows/awt_DnDDT.cpp ! src/windows/native/sun/windows/awt_DnDDT.h ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_Toolkit.h + src/windows/native/sun/windows/awt_ole.cpp + src/windows/native/sun/windows/awt_ole.h + test/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html + test/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java + test/java/awt/dnd/DnDFileGroupDescriptor/DnDTarget.java + test/java/awt/dnd/ImageDecoratedDnD/DnDSource.java + test/java/awt/dnd/ImageDecoratedDnD/DnDTarget.java + test/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.html + test/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java + test/java/awt/dnd/ImageDecoratedDnD/ImageGenerator.java + test/java/awt/dnd/ImageDecoratedDnD/MyCursor.java + test/java/awt/dnd/ImageDecoratedDnDInOut/DnDSource.java + test/java/awt/dnd/ImageDecoratedDnDInOut/DnDTarget.java + test/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html + test/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.java + test/java/awt/dnd/ImageDecoratedDnDInOut/ImageGenerator.java + test/java/awt/dnd/ImageDecoratedDnDInOut/MyCursor.java + test/java/awt/dnd/ImageDecoratedDnDNegative/DnDSource.java + test/java/awt/dnd/ImageDecoratedDnDNegative/DnDTarget.java + test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html + test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.java + test/java/awt/dnd/ImageDecoratedDnDNegative/ImageGenerator.java + test/java/awt/dnd/ImageDecoratedDnDNegative/MyCursor.java Changeset: 4799006d0171 Author: uta Date: 2010-01-13 17:10 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4799006d0171 Merge Changeset: f154d4943a1a Author: uta Date: 2010-01-14 17:56 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f154d4943a1a 6916867: Fastdebug build failed after CR 4874070 fix putback. Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_DnDDS.cpp Changeset: 3cc5eff94552 Author: dcherepanov Date: 2010-01-20 01:33 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3cc5eff94552 6660258: Java application stops Windows logout/shutdown (regression in 1.5.0_14) Reviewed-by: anthony, art, uta ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awtmsg.h Changeset: 0f92194cd798 Author: dcherepanov Date: 2010-01-22 19:47 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0f92194cd798 6756774: fstdebug jvm fails with assertion (result != deleted_handle(),"Used a deleted global handle.") Reviewed-by: art, anthony ! src/windows/native/sun/windows/awt_MenuItem.cpp Changeset: d7c4baff3f96 Author: lana Date: 2010-01-28 18:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d7c4baff3f96 Merge - make/java/redist/FILES.gmk ! make/sun/awt/Makefile - make/sun/nio/FILES_java.gmk - src/share/classes/sun/dyn/util/BytecodeSignature.java - src/solaris/classes/sun/nio/ch/SctpSocketDispatcher.java Changeset: 66c193082586 Author: yan Date: 2010-02-08 17:02 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/66c193082586 6882912: Strange behaviours when typing @ or ' Summary: Eliminate stray lines without a proper unicode->regularKeyID pair (e.g. as there is no "arrow left" unicode, should be no pair) Reviewed-by: rupashka ! src/share/classes/sun/awt/ExtendedKeyCodes.java Changeset: b51982678191 Author: lana Date: 2010-02-09 00:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b51982678191 Merge Changeset: de7807599a9b Author: peytoia Date: 2009-12-15 14:50 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/de7807599a9b 5047314: [Col] Collator.compare() runs indefinitely for a certain set of Thai strings Reviewed-by: okutsu ! src/share/classes/java/text/CollationElementIterator.java + test/java/text/Collator/Bug5047314.java Changeset: 3efbbc00ac5f Author: lana Date: 2009-12-16 16:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3efbbc00ac5f Merge - make/tools/CharsetMapping/DoubleByte-X.java - make/tools/CharsetMapping/SingleByte-X.java - src/share/classes/sun/awt/ComponentAccessor.java - src/share/classes/sun/awt/WindowAccessor.java - src/share/classes/sun/security/provider/IdentityDatabase.java - src/share/classes/sun/security/provider/SystemIdentity.java - src/share/classes/sun/security/provider/SystemSigner.java - src/share/classes/sun/security/x509/X500Signer.java - src/share/classes/sun/security/x509/X509Cert.java - src/share/classes/sun/tools/jar/JarVerifierStream.java - src/share/classes/sun/util/CoreResourceBundleControl-XLocales.java - src/share/classes/sun/util/LocaleDataMetaInfo-XLocales.java - test/java/util/Formatter/Basic-X.java - test/sun/tools/native2ascii/test2 - test/tools/launcher/SolarisDataModel.sh - test/tools/launcher/SolarisRunpath.sh - test/tools/launcher/libraryCaller.c - test/tools/launcher/libraryCaller.h - test/tools/launcher/libraryCaller.java Changeset: e2f7e92c30f1 Author: peterz Date: 2009-12-21 19:26 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e2f7e92c30f1 6860433: [Nimbus] Code to set a single slider's thumb background doesn't work as specified Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template ! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java + test/javax/swing/plaf/nimbus/ColorCustomizationTest.java Changeset: fffd21bc5657 Author: peterz Date: 2009-12-25 17:47 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/fffd21bc5657 6860438: [Nimbus] Code to globally set slider's thumb background doesn't work as specified Reviewed-by: rupashka ! src/share/classes/javax/swing/MultiUIDefaults.java + test/javax/swing/MultiUIDefaults/4300666/bug4300666.html + test/javax/swing/MultiUIDefaults/4300666/bug4300666.java + test/javax/swing/MultiUIDefaults/4331767/bug4331767.java + test/javax/swing/MultiUIDefaults/Test6860438.java Changeset: e9ccd1dd6923 Author: andrew Date: 2010-01-08 12:51 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e9ccd1dd6923 6584033: (tz) wrong buffer length in TimeZone_md.c Summary: Add testcase for this bug Reviewed-by: darcy, okutsu + test/java/util/TimeZone/TimeZoneDatePermissionCheck.java + test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh Changeset: b129d0f7be40 Author: peytoia Date: 2010-01-13 15:40 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b129d0f7be40 6868503: RuleBasedBreakIterator is inefficient Reviewed-by: okutsu ! src/share/classes/java/text/RuleBasedBreakIterator.java Changeset: 9c5a24050392 Author: malenkov Date: 2010-01-21 21:45 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9c5a24050392 4922835: DOC: Statement javadoc should indicate that target and methodName cannot be null Reviewed-by: peterz ! src/share/classes/java/beans/Expression.java ! src/share/classes/java/beans/Statement.java Changeset: eba0ff97a252 Author: malenkov Date: 2010-01-21 21:53 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/eba0ff97a252 4968536: DOC: Javadoc for java.beans.Encoder.getPersistenceDelegate is incomplete Reviewed-by: peterz ! src/share/classes/java/beans/Encoder.java Changeset: 3c61edecf44f Author: okutsu Date: 2010-01-26 15:42 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3c61edecf44f 6912866: (date) java.util.Date.before / after may be expensive Reviewed-by: peytoia ! src/share/classes/java/util/Date.java Changeset: e7127f3fa2f4 Author: peterz Date: 2010-01-28 17:06 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e7127f3fa2f4 6912118: Incosistency in several SynthUI classes between inherited specs ofupdate() and paint() methods Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/synth/SynthButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthColorChooserUI.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopIconUI.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthEditorPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameUI.java ! src/share/classes/javax/swing/plaf/synth/SynthLabelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthListUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuItemUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthOptionPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPanelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPopupMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthProgressBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthRootPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthScrollBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthScrollPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSeparatorUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSpinnerUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTableHeaderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTableUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextAreaUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToolBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToolTipUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java ! src/share/classes/javax/swing/plaf/synth/SynthViewportUI.java Changeset: 4eb3a8c95c24 Author: malenkov Date: 2010-01-28 20:49 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4eb3a8c95c24 6412286: DOC: LTP: Unspecified NPE in java.beans.DefaultPersistenceDelegate.instantiate method Reviewed-by: peterz ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/PersistenceDelegate.java Changeset: 3283bb8c1bcb Author: lana Date: 2010-01-28 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3283bb8c1bcb Merge - make/java/redist/FILES.gmk - make/sun/nio/FILES_java.gmk - src/share/classes/sun/dyn/util/BytecodeSignature.java - src/solaris/classes/sun/nio/ch/SctpSocketDispatcher.java Changeset: 3913691b3021 Author: malenkov Date: 2010-02-05 10:36 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3913691b3021 6921057: REGRESSION: persistence delegate issue on Windows and Linux against 5.u23b03/6u17b11 Reviewed-by: peterz, art ! src/share/classes/java/beans/Introspector.java ! test/java/beans/Introspector/6380849/TestBeanInfo.java ! test/java/beans/Introspector/Test5102804.java ! test/java/beans/XMLEncoder/Test4646747.java Changeset: 5c0c2882eed2 Author: lana Date: 2010-02-09 00:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5c0c2882eed2 Merge Changeset: 7cb9388bb1a1 Author: lana Date: 2010-02-14 23:38 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7cb9388bb1a1 Merge Changeset: a9b4fde406d4 Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a9b4fde406d4 Added tag jdk7-b84 for changeset 7cb9388bb1a1 ! .hgtags From john.coomes at sun.com Fri Feb 19 07:17:33 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 19 Feb 2010 15:17:33 +0000 Subject: hg: jdk7/hotspot/langtools: 16 new changesets Message-ID: <20100219151822.D4F5742819@hg.openjdk.java.net> Changeset: f23b985beb78 Author: jjg Date: 2010-01-19 14:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/f23b985beb78 6917067: refactor type annotations code from TransTypes into new TypeAnnotations class Reviewed-by: jjg, darcy Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu + src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java Changeset: 0eaf89e08564 Author: jjg Date: 2010-01-20 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/0eaf89e08564 6918127: improve handling of TypeAnnotationPosition fields Reviewed-by: jjg, darcy Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java Changeset: da0e3e2dd3ef Author: jjg Date: 2010-01-26 11:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/da0e3e2dd3ef 6919944: incorrect position given for duplicate annotation value error Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.out Changeset: 59167312ed4e Author: jjg Date: 2010-01-26 11:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/59167312ed4e 6917130: should test that annotations that have been optimized away are not emitted to classfile Reviewed-by: jjg, darcy Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu + test/tools/javac/typeAnnotations/classfile/DeadCode.java Changeset: ff7a01f9eff3 Author: lana Date: 2010-01-27 14:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/ff7a01f9eff3 Merge Changeset: 699ecefbdd4e Author: jjg Date: 2010-01-29 16:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/699ecefbdd4e 6919889: assorted position errors in compiler syntax trees Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java + test/tools/javac/T6654037.java ! test/tools/javac/generics/diamond/neg/Neg01.out ! test/tools/javac/generics/diamond/neg/Neg02.out ! test/tools/javac/generics/diamond/neg/Neg03.out ! test/tools/javac/generics/diamond/neg/Neg04.out + test/tools/javac/treepostests/TreePosTest.java Changeset: 8e638442522a Author: jjg Date: 2010-01-29 16:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/8e638442522a 6499119: Created package-info class file modeled improperly 6920317: package-info.java file has to be specified on the javac cmdline, else it will not be avail. Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/6499119/ClassProcessor.java + test/tools/javac/processing/6499119/package-info.java + test/tools/javac/processing/T6920317.java Changeset: 732510cc3538 Author: jjg Date: 2010-02-01 17:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/732510cc3538 6919986: [308] change size of type_index (of CLASS_EXTENDS and THROWS) from byte to short Reviewed-by: darcy, jjg Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java Changeset: b0a68258360a Author: jjg Date: 2010-02-02 10:56 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/b0a68258360a 6918625: handle annotations on array class literals Reviewed-by: jjg, darcy Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java + test/tools/javap/typeAnnotations/ArrayClassLiterals2.java Changeset: 41ed86f86585 Author: jjg Date: 2010-02-03 11:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/41ed86f86585 6922429: extend tree position test waiver Reviewed-by: darcy ! test/tools/javac/treepostests/TreePosTest.java Changeset: f65d652cb6af Author: jjg Date: 2010-02-03 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/f65d652cb6af 6922300: [308] populate the reference_info for type annotations targeting primitive class literals Reviewed-by: darcy, jjg Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/classes/com/sun/tools/javac/jvm/Gen.java Changeset: 4c844e609d81 Author: jjg Date: 2010-02-03 16:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/4c844e609d81 6921979: add test program to verify annotations are attached to nodes as expected Reviewed-by: darcy + test/tools/javac/treeannotests/AnnoTreeTests.java + test/tools/javac/treeannotests/DA.java + test/tools/javac/treeannotests/TA.java + test/tools/javac/treeannotests/Test.java + test/tools/javac/treeannotests/TestProcessor.java Changeset: 4b4e282a3146 Author: jjg Date: 2010-02-04 10:14 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/4b4e282a3146 6923080: TreeScanner.visitNewClass should scan tree.typeargs Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java + test/tools/javac/tree/T6923080.java + test/tools/javac/tree/TreeScannerTest.java Changeset: 56a46d079264 Author: lana Date: 2010-02-08 23:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/56a46d079264 Merge Changeset: d9cd5b8286e4 Author: lana Date: 2010-02-14 23:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/d9cd5b8286e4 Merge Changeset: 75d5bd12eb86 Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/75d5bd12eb86 Added tag jdk7-b84 for changeset d9cd5b8286e4 ! .hgtags From daniel.daugherty at sun.com Sun Feb 21 13:59:55 2010 From: daniel.daugherty at sun.com (daniel.daugherty at sun.com) Date: Sun, 21 Feb 2010 21:59:55 +0000 Subject: hg: hsx/hsx16/baseline: 3 new changesets Message-ID: <20100221220006.343D142B9B@hg.openjdk.java.net> Changeset: 9127aa69352e Author: dcubed Date: 2009-12-14 09:51 -0700 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/9127aa69352e 6648438: 4/4 src/share/vm/prims/jvmtiEnv.cpp:457 assert(phase == JVMTI_PHASE_LIVE,"sanity check") Summary: Return error on invalid JVMTI_PHASE instead of asserting. Reviewed-by: dholmes, ohair ! src/share/vm/prims/jvmtiEnv.cpp Changeset: 98cd9901c161 Author: dcubed Date: 2009-12-14 10:05 -0700 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/98cd9901c161 6849968: 3/2 JVMTI tests fails on jdk5.0 with hs14 Summary: If a JVMTI agent asks for version 1.0, then it should get version 1.0 semantics. Reviewed-by: dholmes, ohair ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiHpp.xsl Changeset: c9740f5ed5b4 Author: dcubed Date: 2010-02-19 11:18 -0700 URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4 Merge ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiExport.cpp From gnu_andrew at member.fsf.org Sun Feb 21 14:46:28 2010 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Sun, 21 Feb 2010 22:46:28 +0000 Subject: hg: hsx/hsx16/baseline: 3 new changesets In-Reply-To: <20100221220006.343D142B9B@hg.openjdk.java.net> References: <20100221220006.343D142B9B@hg.openjdk.java.net> Message-ID: <17c6771e1002211446o23fcdb87l530ef8578ec2bfcb@mail.gmail.com> On 21 February 2010 21:59, wrote: > Changeset: 9127aa69352e > Author: ? ?dcubed > Date: ? ? ?2009-12-14 09:51 -0700 > URL: ? ? ? http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/9127aa69352e > > 6648438: 4/4 src/share/vm/prims/jvmtiEnv.cpp:457 assert(phase == JVMTI_PHASE_LIVE,"sanity check") > Summary: Return error on invalid JVMTI_PHASE instead of asserting. > Reviewed-by: dholmes, ohair > > ! src/share/vm/prims/jvmtiEnv.cpp > > Changeset: 98cd9901c161 > Author: ? ?dcubed > Date: ? ? ?2009-12-14 10:05 -0700 > URL: ? ? ? http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/98cd9901c161 > > 6849968: 3/2 JVMTI tests fails on jdk5.0 with hs14 > Summary: If a JVMTI agent asks for version 1.0, then it should get version 1.0 semantics. > Reviewed-by: dholmes, ohair > > ! src/share/vm/prims/jvmtiEnv.cpp > ! src/share/vm/prims/jvmtiEnvBase.cpp > ! src/share/vm/prims/jvmtiEnvBase.hpp > ! src/share/vm/prims/jvmtiExport.cpp > ! src/share/vm/prims/jvmtiExport.hpp > ! src/share/vm/prims/jvmtiHpp.xsl > > Changeset: c9740f5ed5b4 > Author: ? ?dcubed > Date: ? ? ?2010-02-19 11:18 -0700 > URL: ? ? ? http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4 > > Merge > > ! src/share/vm/prims/jvmtiEnv.cpp > ! src/share/vm/prims/jvmtiEnvBase.cpp > ! src/share/vm/prims/jvmtiEnvBase.hpp > ! src/share/vm/prims/jvmtiExport.cpp > > Thanks. What's the migration process for these to master? -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From gnu_andrew at member.fsf.org Sun Feb 21 14:47:39 2010 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Sun, 21 Feb 2010 22:47:39 +0000 Subject: hg: hsx/hsx16/baseline: 3 new changesets In-Reply-To: <17c6771e1002211446o23fcdb87l530ef8578ec2bfcb@mail.gmail.com> References: <20100221220006.343D142B9B@hg.openjdk.java.net> <17c6771e1002211446o23fcdb87l530ef8578ec2bfcb@mail.gmail.com> Message-ID: <17c6771e1002211447tdc5e72dv8bdbd0dbdc6b01df@mail.gmail.com> On 21 February 2010 22:46, Andrew John Hughes wrote: > On 21 February 2010 21:59, ? wrote: >> Changeset: 9127aa69352e >> Author: ? ?dcubed >> Date: ? ? ?2009-12-14 09:51 -0700 >> URL: ? ? ? http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/9127aa69352e >> >> 6648438: 4/4 src/share/vm/prims/jvmtiEnv.cpp:457 assert(phase == JVMTI_PHASE_LIVE,"sanity check") >> Summary: Return error on invalid JVMTI_PHASE instead of asserting. >> Reviewed-by: dholmes, ohair >> >> ! src/share/vm/prims/jvmtiEnv.cpp >> >> Changeset: 98cd9901c161 >> Author: ? ?dcubed >> Date: ? ? ?2009-12-14 10:05 -0700 >> URL: ? ? ? http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/98cd9901c161 >> >> 6849968: 3/2 JVMTI tests fails on jdk5.0 with hs14 >> Summary: If a JVMTI agent asks for version 1.0, then it should get version 1.0 semantics. >> Reviewed-by: dholmes, ohair >> >> ! src/share/vm/prims/jvmtiEnv.cpp >> ! src/share/vm/prims/jvmtiEnvBase.cpp >> ! src/share/vm/prims/jvmtiEnvBase.hpp >> ! src/share/vm/prims/jvmtiExport.cpp >> ! src/share/vm/prims/jvmtiExport.hpp >> ! src/share/vm/prims/jvmtiHpp.xsl >> >> Changeset: c9740f5ed5b4 >> Author: ? ?dcubed >> Date: ? ? ?2010-02-19 11:18 -0700 >> URL: ? ? ? http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4 >> >> Merge >> >> ! src/share/vm/prims/jvmtiEnv.cpp >> ! src/share/vm/prims/jvmtiEnvBase.cpp >> ! src/share/vm/prims/jvmtiEnvBase.hpp >> ! src/share/vm/prims/jvmtiExport.cpp >> >> > > Thanks. ?What's the migration process for these to master? > -- > Andrew :-) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and the OpenJDK > http://www.gnu.org/software/classpath > http://openjdk.java.net > > PGP Key: 94EFD9D8 (http://subkeys.pgp.net) > Fingerprint: F8EF F1EA 401E 2E60 15FA ?7927 142C 2591 94EF D9D8 > I think http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4 may be the missing piece of the puzzle that's causing the build failure as it seems to synchronize the cpp file with the header. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Erik.Trimble at Sun.COM Mon Feb 22 10:44:08 2010 From: Erik.Trimble at Sun.COM (Erik Trimble) Date: Mon, 22 Feb 2010 10:44:08 -0800 Subject: hg: hsx/hsx16/baseline: 3 new changesets In-Reply-To: <17c6771e1002211447tdc5e72dv8bdbd0dbdc6b01df@mail.gmail.com> References: <20100221220006.343D142B9B@hg.openjdk.java.net> <17c6771e1002211446o23fcdb87l530ef8578ec2bfcb@mail.gmail.com> <17c6771e1002211447tdc5e72dv8bdbd0dbdc6b01df@mail.gmail.com> Message-ID: <4B82D078.5060905@sun.com> Andrew John Hughes wrote: > On 21 February 2010 22:46, Andrew John Hughes wrote: > >> On 21 February 2010 21:59, wrote: >> >>> Changeset: 9127aa69352e >>> Author: dcubed >>> Date: 2009-12-14 09:51 -0700 >>> URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/9127aa69352e >>> >>> 6648438: 4/4 src/share/vm/prims/jvmtiEnv.cpp:457 assert(phase == JVMTI_PHASE_LIVE,"sanity check") >>> Summary: Return error on invalid JVMTI_PHASE instead of asserting. >>> Reviewed-by: dholmes, ohair >>> >>> ! src/share/vm/prims/jvmtiEnv.cpp >>> >>> Changeset: 98cd9901c161 >>> Author: dcubed >>> Date: 2009-12-14 10:05 -0700 >>> URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/98cd9901c161 >>> >>> 6849968: 3/2 JVMTI tests fails on jdk5.0 with hs14 >>> Summary: If a JVMTI agent asks for version 1.0, then it should get version 1.0 semantics. >>> Reviewed-by: dholmes, ohair >>> >>> ! src/share/vm/prims/jvmtiEnv.cpp >>> ! src/share/vm/prims/jvmtiEnvBase.cpp >>> ! src/share/vm/prims/jvmtiEnvBase.hpp >>> ! src/share/vm/prims/jvmtiExport.cpp >>> ! src/share/vm/prims/jvmtiExport.hpp >>> ! src/share/vm/prims/jvmtiHpp.xsl >>> >>> Changeset: c9740f5ed5b4 >>> Author: dcubed >>> Date: 2010-02-19 11:18 -0700 >>> URL: http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4 >>> >>> Merge >>> >>> ! src/share/vm/prims/jvmtiEnv.cpp >>> ! src/share/vm/prims/jvmtiEnvBase.cpp >>> ! src/share/vm/prims/jvmtiEnvBase.hpp >>> ! src/share/vm/prims/jvmtiExport.cpp >>> >>> >>> >> Thanks. What's the migration process for these to master? >> -- >> Andrew :-) >> >> Free Java Software Engineer >> Red Hat, Inc. (http://www.redhat.com) >> >> Support Free Java! >> Contribute to GNU Classpath and the OpenJDK >> http://www.gnu.org/software/classpath >> http://openjdk.java.net >> >> PGP Key: 94EFD9D8 (http://subkeys.pgp.net) >> Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 >> >> > > I think http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4 > may be the missing piece of the puzzle that's causing the build > failure as it seems to synchronize the cpp file with the header. > I can do a rebuild and push from baseline to master whenever we think that a new build is appropriate. I'd bump the build number and then push to master (after a PIT cycle). -- Erik Trimble Java System Support Mailstop: usca22-123 Phone: x17195 Santa Clara, CA From gnu_andrew at member.fsf.org Mon Feb 22 12:02:25 2010 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Mon, 22 Feb 2010 20:02:25 +0000 Subject: hg: hsx/hsx16/baseline: 3 new changesets In-Reply-To: <4B82D078.5060905@sun.com> References: <20100221220006.343D142B9B@hg.openjdk.java.net> <17c6771e1002211446o23fcdb87l530ef8578ec2bfcb@mail.gmail.com> <17c6771e1002211447tdc5e72dv8bdbd0dbdc6b01df@mail.gmail.com> <4B82D078.5060905@sun.com> Message-ID: <17c6771e1002221202v956fe95s475cf23ab8323316@mail.gmail.com> On 22 February 2010 18:44, Erik Trimble wrote: > Andrew John Hughes wrote: >> >> On 21 February 2010 22:46, Andrew John Hughes >> wrote: >> >>> >>> On 21 February 2010 21:59, ? wrote: >>> >>>> >>>> Changeset: 9127aa69352e >>>> Author: ? ?dcubed >>>> Date: ? ? ?2009-12-14 09:51 -0700 >>>> URL: >>>> http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/9127aa69352e >>>> >>>> 6648438: 4/4 src/share/vm/prims/jvmtiEnv.cpp:457 assert(phase == >>>> JVMTI_PHASE_LIVE,"sanity check") >>>> Summary: Return error on invalid JVMTI_PHASE instead of asserting. >>>> Reviewed-by: dholmes, ohair >>>> >>>> ! src/share/vm/prims/jvmtiEnv.cpp >>>> >>>> Changeset: 98cd9901c161 >>>> Author: ? ?dcubed >>>> Date: ? ? ?2009-12-14 10:05 -0700 >>>> URL: >>>> http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/98cd9901c161 >>>> >>>> 6849968: 3/2 JVMTI tests fails on jdk5.0 with hs14 >>>> Summary: If a JVMTI agent asks for version 1.0, then it should get >>>> version 1.0 semantics. >>>> Reviewed-by: dholmes, ohair >>>> >>>> ! src/share/vm/prims/jvmtiEnv.cpp >>>> ! src/share/vm/prims/jvmtiEnvBase.cpp >>>> ! src/share/vm/prims/jvmtiEnvBase.hpp >>>> ! src/share/vm/prims/jvmtiExport.cpp >>>> ! src/share/vm/prims/jvmtiExport.hpp >>>> ! src/share/vm/prims/jvmtiHpp.xsl >>>> >>>> Changeset: c9740f5ed5b4 >>>> Author: ? ?dcubed >>>> Date: ? ? ?2010-02-19 11:18 -0700 >>>> URL: >>>> http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4 >>>> >>>> Merge >>>> >>>> ! src/share/vm/prims/jvmtiEnv.cpp >>>> ! src/share/vm/prims/jvmtiEnvBase.cpp >>>> ! src/share/vm/prims/jvmtiEnvBase.hpp >>>> ! src/share/vm/prims/jvmtiExport.cpp >>>> >>>> >>>> >>> >>> Thanks. ?What's the migration process for these to master? >>> -- >>> Andrew :-) >>> >>> Free Java Software Engineer >>> Red Hat, Inc. (http://www.redhat.com) >>> >>> Support Free Java! >>> Contribute to GNU Classpath and the OpenJDK >>> http://www.gnu.org/software/classpath >>> http://openjdk.java.net >>> >>> PGP Key: 94EFD9D8 (http://subkeys.pgp.net) >>> Fingerprint: F8EF F1EA 401E 2E60 15FA ?7927 142C 2591 94EF D9D8 >>> >>> >> >> I think http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4 >> may be the missing piece of the puzzle that's causing the build >> failure as it seems to synchronize the cpp file with the header. >> > > I can do a rebuild and push from baseline to master whenever we think that a > new build is appropriate. ?I'd bump the build number and then push to master > (after a PIT cycle). > > > > > > -- > Erik Trimble > Java System Support > Mailstop: ?usca22-123 > Phone: ?x17195 > Santa Clara, CA > > Well now would seem appropriate so that we can have a known build integrated into OpenJDK6. If I bring in: searching for changes changeset: 1126:c9740f5ed5b4 tag: tip parent: 1124:b9408ac1b596 parent: 629:98cd9901c161 user: dcubed date: Fri Feb 19 11:18:38 2010 -0700 summary: Merge from baseline, in addition to the changesets I merged from master, this provides the fix: diff -r 0d4f291060f7 src/share/vm/prims/jvmtiEnvBase.cpp --- a/src/share/vm/prims/jvmtiEnvBase.cpp Mon Feb 22 17:32:37 2010 +0000 +++ b/src/share/vm/prims/jvmtiEnvBase.cpp Mon Feb 22 19:53:27 2010 +0000 @@ -123,7 +123,26 @@ } -JvmtiEnvBase::JvmtiEnvBase() : _env_event_enable() { +bool +JvmtiEnvBase::use_version_1_0_semantics() { + int major, minor, micro; + + JvmtiExport::decode_version_values(_version, &major, &minor, µ); + return major == 1 && minor == 0; // micro version doesn't matter here +} + + +bool +JvmtiEnvBase::use_version_1_1_semantics() { + int major, minor, micro; + + JvmtiExport::decode_version_values(_version, &major, &minor, µ); + return major == 1 && minor == 1; // micro version doesn't matter here +} + + +JvmtiEnvBase::JvmtiEnvBase(jint version) : _env_event_enable() { + _version = version; _env_local_storage = NULL; _tag_map = NULL; _native_method_prefix_count = 0; which makes the build get further. If I also revert the erroneous change made in: changeset: 734:dbbe28fc66b5 user: twisti date: Fri Feb 27 03:35:40 2009 -0800 summary: 6778669: Patch from Red Hat -- fixes compilation errors diff -r ed6404fac86b -r dbbe28fc66b5 src/share/vm/utilities/vmError.cpp --- a/src/share/vm/utilities/vmError.cpp Thu Feb 26 16:57:21 2009 -0800 +++ b/src/share/vm/utilities/vmError.cpp Fri Feb 27 03:35:40 2009 -0800 @@ -1,5 +1,5 @@ /* - * Copyright 2003-2008 Sun Microsystems, Inc. All Rights Reserved. + * Copyright 2003-2009 Sun Microsystems, Inc. All Rights Reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -306,7 +306,7 @@ strncpy(buf, file, buflen); if (len + 10 < buflen) { - sprintf(buf + len, ":" SIZE_FORMAT, _lineno); + sprintf(buf + len, ":%d", _lineno); the build completes: $ /mnt/builder/jdk6/j2sdk-image/bin/java -version openjdk version "1.6.0-internal" OpenJDK Runtime Environment (build 1.6.0-internal-andrew_22_feb_2010_19_12-b00) OpenJDK 64-Bit Server VM (build 16.0-b13, mixed mode) -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From aph at redhat.com Tue Feb 23 08:16:09 2010 From: aph at redhat.com (Andrew Haley) Date: Tue, 23 Feb 2010 16:16:09 +0000 Subject: Stack guard pages Message-ID: <4B83FF49.6060004@redhat.com> I've been working on a bug in OpenOffice where using Java causes a later crash. https://bugzilla.novell.com/show_bug.cgi?id=578802 It's a very strange bug: Java is called, does something, and then the thread is detached from the Java VM. Long after, a segfault occurs. The reason for this crash is the way that stack guard pages work. When DetachCurrentThread() calls JavaThread::remove_stack_guard_pages(), the guard pages are not removed. So, if at some point later in the process the stack grows beyond the point where the guard pages were mapped, the Linux kernel cannot expand the stack any further because the guard pages are in the way, and a segfault occurs. I've attached a reproducer for this bug to the end of this message. It crashes on many of the Linux systems I've tried. The right way to fix this is for remove_stack_guard_pages() to munmap() the guard pages. However, it's essential not to split the stack region, so if the stack has already grown beyond the guard pages, we have to unmap() it. Like so: bool os::create_stack_guard_pages(char* addr, size_t size) { uintptr_t stack_extent, stack_base; // get_stack_bounds() returns the memory extent mapped for the stack // by the kernel. if (get_stack_bounds(&stack_extent, &stack_base)) { if (stack_extent < (uintptr_t)addr) ::munmap((void*)stack_extent, (uintptr_t)addr - stack_extent); } return os::commit_memory(addr, size); } bool os::remove_stack_guard_pages(char* addr, size_t size) { return ::munmap(addr, size) == 0; } This fixes the bug. Unfortunately, there is no os:: interface for create_stack_guard_pages() and remove_stack_guard_pages(), so this solution doesn't fit well with the current organization of the VM. I can't see any way of making this work only by touching os_linux.?pp . I could simply patch OpenJDK locally for the Linux distros, but I think we should have this discussion first. Andrew. -------------- next part -------------- A non-text attachment was scrubbed... Name: invoke.c Type: text/x-csrc Size: 1214 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20100223/30bbc56a/attachment.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: T.java Type: text/x-java Size: 90 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20100223/30bbc56a/attachment-0001.bin From gnu_andrew at member.fsf.org Tue Feb 23 11:15:11 2010 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Tue, 23 Feb 2010 19:15:11 +0000 Subject: Stack guard pages In-Reply-To: <4B83FF49.6060004@redhat.com> References: <4B83FF49.6060004@redhat.com> Message-ID: <17c6771e1002231115h28d0f281p5abff855ab1406c@mail.gmail.com> On 23 February 2010 16:16, Andrew Haley wrote: > I've been working on a bug in OpenOffice where using Java causes a > later crash. ?https://bugzilla.novell.com/show_bug.cgi?id=578802 > > It's a very strange bug: Java is called, does something, and then the > thread is detached from the Java VM. ?Long after, a segfault occurs. > > The reason for this crash is the way that stack guard pages work. > When DetachCurrentThread() calls > JavaThread::remove_stack_guard_pages(), the guard pages are not > removed. ?So, if at some point later in the process the stack grows > beyond the point where the guard pages were mapped, the Linux kernel > cannot expand the stack any further because the guard pages are in the > way, and a segfault occurs. > > I've attached a reproducer for this bug to the end of this message. > It crashes on many of the Linux systems I've tried. > > The right way to fix this is for remove_stack_guard_pages() to > munmap() the guard pages. ?However, it's essential not to split the > stack region, so if the stack has already grown beyond the guard > pages, we have to unmap() it. ?Like so: > > bool os::create_stack_guard_pages(char* addr, size_t size) { > ?uintptr_t stack_extent, stack_base; > ?// get_stack_bounds() returns the memory extent mapped for the stack > ?// by the kernel. > ?if (get_stack_bounds(&stack_extent, &stack_base)) { > ? ?if (stack_extent < (uintptr_t)addr) > ? ? ?::munmap((void*)stack_extent, (uintptr_t)addr - stack_extent); > ?} > > ?return os::commit_memory(addr, size); > } > > bool os::remove_stack_guard_pages(char* addr, size_t size) { > ?return ::munmap(addr, size) == 0; > } > > This fixes the bug. ?Unfortunately, there is no os:: interface for > create_stack_guard_pages() and remove_stack_guard_pages(), so this > solution doesn't fit well with the current organization of the VM. ?I > can't see any way of making this work only by touching os_linux.?pp . > > I could simply patch OpenJDK locally for the Linux distros, but I > think we should have this discussion first. > > Andrew. > Segfaults here with the latest OpenJDK7 b84: $ /mnt/builder/jdk7/j2sdk-image/bin/java -version openjdk version "1.7.0-internal" OpenJDK Runtime Environment (build 1.7.0-internal-andrew_2010_02_23_18_45-b00) OpenJDK 64-Bit Server VM (build 17.0-b09, mixed mode) $ LD_LIBRARY_PATH=/mnt/builder/jdk7/j2sdk-image/jre/lib/amd64/server ./invoke Hello Segmentation fault I think it would it would be clearer what the suggested fix entails if you posted a diff or webrev of the suggested change. Cheers, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From aph at redhat.com Tue Feb 23 11:50:15 2010 From: aph at redhat.com (Andrew Haley) Date: Tue, 23 Feb 2010 19:50:15 +0000 Subject: Stack guard pages In-Reply-To: <17c6771e1002231115h28d0f281p5abff855ab1406c@mail.gmail.com> References: <4B83FF49.6060004@redhat.com> <17c6771e1002231115h28d0f281p5abff855ab1406c@mail.gmail.com> Message-ID: <4B843177.2030500@redhat.com> On 02/23/2010 07:15 PM, Andrew John Hughes wrote: > On 23 February 2010 16:16, Andrew Haley wrote: >> I've been working on a bug in OpenOffice where using Java causes a >> later crash. https://bugzilla.novell.com/show_bug.cgi?id=578802 >> >> It's a very strange bug: Java is called, does something, and then the >> thread is detached from the Java VM. Long after, a segfault occurs. >> >> The reason for this crash is the way that stack guard pages work. >> When DetachCurrentThread() calls >> JavaThread::remove_stack_guard_pages(), the guard pages are not >> removed. So, if at some point later in the process the stack grows >> beyond the point where the guard pages were mapped, the Linux kernel >> cannot expand the stack any further because the guard pages are in the >> way, and a segfault occurs. >> >> I've attached a reproducer for this bug to the end of this message. >> It crashes on many of the Linux systems I've tried. >> >> The right way to fix this is for remove_stack_guard_pages() to >> munmap() the guard pages. However, it's essential not to split the >> stack region, so if the stack has already grown beyond the guard >> pages, we have to unmap() it. Like so: >> >> bool os::create_stack_guard_pages(char* addr, size_t size) { >> uintptr_t stack_extent, stack_base; >> // get_stack_bounds() returns the memory extent mapped for the stack >> // by the kernel. >> if (get_stack_bounds(&stack_extent, &stack_base)) { >> if (stack_extent < (uintptr_t)addr) >> ::munmap((void*)stack_extent, (uintptr_t)addr - stack_extent); >> } >> >> return os::commit_memory(addr, size); >> } >> >> bool os::remove_stack_guard_pages(char* addr, size_t size) { >> return ::munmap(addr, size) == 0; >> } >> >> This fixes the bug. Unfortunately, there is no os:: interface for >> create_stack_guard_pages() and remove_stack_guard_pages(), so this >> solution doesn't fit well with the current organization of the VM. I >> can't see any way of making this work only by touching os_linux.?pp . >> >> I could simply patch OpenJDK locally for the Linux distros, but I >> think we should have this discussion first. > > Segfaults here with the latest OpenJDK7 b84: > > $ /mnt/builder/jdk7/j2sdk-image/bin/java -version > openjdk version "1.7.0-internal" > OpenJDK Runtime Environment (build 1.7.0-internal-andrew_2010_02_23_18_45-b00) > OpenJDK 64-Bit Server VM (build 17.0-b09, mixed mode) > > $ LD_LIBRARY_PATH=/mnt/builder/jdk7/j2sdk-image/jre/lib/amd64/server ./invoke > Hello > Segmentation fault > > I think it would it would be clearer what the suggested fix entails if > you posted a diff or webrev of the suggested change. Maybe, but I don't ATM have a suggested change. Everything I've tried is rather intrusive, and potentially affects other targets. However, here's what I've been testing, for information only. Andrew. --- ./src/share/vm/runtime/thread.cpp~ 2008-07-10 21:04:36.000000000 +0100 +++ ./src/share/vm/runtime/thread.cpp 2010-02-23 14:43:20.452135932 +0000 @@ -2075,7 +2075,7 @@ int allocate = os::allocate_stack_guard_pages(); // warning("Guarding at " PTR_FORMAT " for len " SIZE_FORMAT "\n", low_addr, len); - if (allocate && !os::commit_memory((char *) low_addr, len)) { + if (allocate && !os::create_stack_guard_pages((char *) low_addr, len)) { warning("Attempt to allocate stack guard pages failed."); return; } @@ -2096,7 +2096,7 @@ size_t len = (StackYellowPages + StackRedPages) * os::vm_page_size(); if (os::allocate_stack_guard_pages()) { - if (os::uncommit_memory((char *) low_addr, len)) { + if (os::remove_stack_guard_pages((char *) low_addr, len)) { _stack_guard_state = stack_guard_unused; } else { warning("Attempt to deallocate stack guard pages failed."); --- ./src/share/vm/runtime/os.hpp~ 2008-07-10 21:04:36.000000000 +0100 +++ ./src/share/vm/runtime/os.hpp 2010-02-23 14:49:27.512732036 +0000 @@ -168,6 +168,9 @@ static bool protect_memory(char* addr, size_t bytes); static bool guard_memory(char* addr, size_t bytes); static bool unguard_memory(char* addr, size_t bytes); + static bool create_stack_guard_pages(char* addr, size_t bytes); + static bool remove_stack_guard_pages(char* addr, size_t bytes); + static char* map_memory(int fd, const char* file_name, size_t file_offset, char *addr, size_t bytes, bool read_only = false, bool allow_exec = false); --- ./src/os/linux/vm/os_linux.cpp~ 2010-02-23 11:42:40.005073691 +0000 +++ ./src/os/linux/vm/os_linux.cpp 2010-02-23 15:44:47.112387815 +0000 @@ -57,6 +57,10 @@ # include # include +#include +#include +#include + #define MAX_PATH (2 * K) // for timer info max values which include all bits @@ -2292,6 +2296,53 @@ != MAP_FAILED; } +static bool +get_stack_bounds(uintptr_t *bottom, uintptr_t *top) +{ + using namespace std; + + ostringstream oss; + oss << "/proc/" << syscall(SYS_gettid) << "/maps"; + ifstream cin(oss.str().c_str()); + while (!cin.eof()) + { + string str; + getline(cin,str); + const string stack_str = "[stack]"; + if (str.length() > stack_str.length() + && (str.compare(str.length() - stack_str.length(), + stack_str.length(), stack_str) + == 0)) + { + istringstream iss(str); + iss.flags(ios::hex); + iss >> *bottom; + char c; + iss >> c; + iss >> *top; + uintptr_t sp = (intptr_t)__builtin_frame_address(0); + if (sp >= *bottom && sp <= *top) + return true; + } + } + + return false; +} + +bool os::create_stack_guard_pages(char* addr, size_t size) { + uintptr_t stack_extent, stack_base; + if (get_stack_bounds(&stack_extent, &stack_base)) { + if (stack_extent < (uintptr_t)addr) + ::munmap((void*)stack_extent, (uintptr_t)addr - stack_extent); + } + + return os::commit_memory(addr, size); +} + +bool os::remove_stack_guard_pages(char* addr, size_t size) { + return ::munmap(addr, size) == 0; +} + static address _highest_vm_reserved_address = NULL; // If 'fixed' is true, anon_mmap() will attempt to reserve anonymous memory From gnu_andrew at member.fsf.org Tue Feb 23 12:36:51 2010 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Tue, 23 Feb 2010 20:36:51 +0000 Subject: Stack guard pages In-Reply-To: <4B843177.2030500@redhat.com> References: <4B83FF49.6060004@redhat.com> <17c6771e1002231115h28d0f281p5abff855ab1406c@mail.gmail.com> <4B843177.2030500@redhat.com> Message-ID: <17c6771e1002231236r517e57dp7fde6ff0b9110a31@mail.gmail.com> On 23 February 2010 19:50, Andrew Haley wrote: > On 02/23/2010 07:15 PM, Andrew John Hughes wrote: >> On 23 February 2010 16:16, Andrew Haley wrote: >>> I've been working on a bug in OpenOffice where using Java causes a >>> later crash. ?https://bugzilla.novell.com/show_bug.cgi?id=578802 >>> >>> It's a very strange bug: Java is called, does something, and then the >>> thread is detached from the Java VM. ?Long after, a segfault occurs. >>> >>> The reason for this crash is the way that stack guard pages work. >>> When DetachCurrentThread() calls >>> JavaThread::remove_stack_guard_pages(), the guard pages are not >>> removed. ?So, if at some point later in the process the stack grows >>> beyond the point where the guard pages were mapped, the Linux kernel >>> cannot expand the stack any further because the guard pages are in the >>> way, and a segfault occurs. >>> >>> I've attached a reproducer for this bug to the end of this message. >>> It crashes on many of the Linux systems I've tried. >>> >>> The right way to fix this is for remove_stack_guard_pages() to >>> munmap() the guard pages. ?However, it's essential not to split the >>> stack region, so if the stack has already grown beyond the guard >>> pages, we have to unmap() it. ?Like so: >>> >>> bool os::create_stack_guard_pages(char* addr, size_t size) { >>> ?uintptr_t stack_extent, stack_base; >>> ?// get_stack_bounds() returns the memory extent mapped for the stack >>> ?// by the kernel. >>> ?if (get_stack_bounds(&stack_extent, &stack_base)) { >>> ? ?if (stack_extent < (uintptr_t)addr) >>> ? ? ?::munmap((void*)stack_extent, (uintptr_t)addr - stack_extent); >>> ?} >>> >>> ?return os::commit_memory(addr, size); >>> } >>> >>> bool os::remove_stack_guard_pages(char* addr, size_t size) { >>> ?return ::munmap(addr, size) == 0; >>> } >>> >>> This fixes the bug. ?Unfortunately, there is no os:: interface for >>> create_stack_guard_pages() and remove_stack_guard_pages(), so this >>> solution doesn't fit well with the current organization of the VM. ?I >>> can't see any way of making this work only by touching os_linux.?pp . >>> >>> I could simply patch OpenJDK locally for the Linux distros, but I >>> think we should have this discussion first. >> >> Segfaults here with the latest OpenJDK7 b84: >> >> $ /mnt/builder/jdk7/j2sdk-image/bin/java -version >> openjdk version "1.7.0-internal" >> OpenJDK Runtime Environment (build 1.7.0-internal-andrew_2010_02_23_18_45-b00) >> OpenJDK 64-Bit Server VM (build 17.0-b09, mixed mode) >> >> $ LD_LIBRARY_PATH=/mnt/builder/jdk7/j2sdk-image/jre/lib/amd64/server ./invoke >> Hello >> Segmentation fault >> >> I think it would it would be clearer what the suggested fix entails if >> you posted a diff or webrev of the suggested change. > > Maybe, but I don't ATM have a suggested change. ?Everything I've tried is > rather intrusive, and potentially affects other targets. > > However, here's what I've been testing, for information only. > Thanks. That helps a lot. I was confusing the functions you introduce with the ones of the same name in src/share/vm/runtime/thread.{c,h}pp For the other platforms, would it not be sufficient for them to just have simple implementations that call os::commti_memory and os::uncommit_memory as before? The HotSpot developers can run the change through JPRT to test it on all platforms. > Andrew. > > > --- ./src/share/vm/runtime/thread.cpp~ ?2008-07-10 21:04:36.000000000 +0100 > +++ ./src/share/vm/runtime/thread.cpp ? 2010-02-23 14:43:20.452135932 +0000 > @@ -2075,7 +2075,7 @@ > ? int allocate = os::allocate_stack_guard_pages(); > ? // warning("Guarding at " PTR_FORMAT " for len " SIZE_FORMAT "\n", low_addr, len); > > - ?if (allocate && !os::commit_memory((char *) low_addr, len)) { > + ?if (allocate && !os::create_stack_guard_pages((char *) low_addr, len)) { > ? ? warning("Attempt to allocate stack guard pages failed."); > ? ? return; > ? } > @@ -2096,7 +2096,7 @@ > ? size_t len = (StackYellowPages + StackRedPages) * os::vm_page_size(); > > ? if (os::allocate_stack_guard_pages()) { > - ? ?if (os::uncommit_memory((char *) low_addr, len)) { > + ? ?if (os::remove_stack_guard_pages((char *) low_addr, len)) { > ? ? ? _stack_guard_state = stack_guard_unused; > ? ? } else { > ? ? ? warning("Attempt to deallocate stack guard pages failed."); > --- ./src/share/vm/runtime/os.hpp~ ? ? ?2008-07-10 21:04:36.000000000 +0100 > +++ ./src/share/vm/runtime/os.hpp ? ? ? 2010-02-23 14:49:27.512732036 +0000 > @@ -168,6 +168,9 @@ > ? static bool ? protect_memory(char* addr, size_t bytes); > ? static bool ? guard_memory(char* addr, size_t bytes); > ? static bool ? unguard_memory(char* addr, size_t bytes); > + ?static bool ? create_stack_guard_pages(char* addr, size_t bytes); > + ?static bool ? remove_stack_guard_pages(char* addr, size_t bytes); > + > ? static char* ?map_memory(int fd, const char* file_name, size_t file_offset, > ? ? ? ? ? ? ? ? ? ? ? ? ? ?char *addr, size_t bytes, bool read_only = false, > ? ? ? ? ? ? ? ? ? ? ? ? ? ?bool allow_exec = false); > --- ./src/os/linux/vm/os_linux.cpp~ ? ? 2010-02-23 11:42:40.005073691 +0000 > +++ ./src/os/linux/vm/os_linux.cpp ? ? ?2010-02-23 15:44:47.112387815 +0000 > @@ -57,6 +57,10 @@ > ?# include > ?# include > > +#include > +#include > +#include > + > ?#define MAX_PATH ? ?(2 * K) > > ?// for timer info max values which include all bits > @@ -2292,6 +2296,53 @@ > ? ? != MAP_FAILED; > ?} > > +static bool > +get_stack_bounds(uintptr_t *bottom, uintptr_t *top) > +{ > + ?using namespace std; > + > + ?ostringstream oss; > + ?oss << "/proc/" << syscall(SYS_gettid) << "/maps"; > + ?ifstream cin(oss.str().c_str()); > + ?while (!cin.eof()) > + ?{ > + ? ?string str; > + ? ?getline(cin,str); > + ? ?const string stack_str = "[stack]"; > + ? ?if (str.length() > stack_str.length() > + ? ? ? && (str.compare(str.length() - stack_str.length(), > + ? ? ? ? ? ? ? ? ? ? ?stack_str.length(), stack_str) > + ? ? ? ? ? == 0)) > + ? ? ?{ > + ? ? ? istringstream iss(str); > + ? ? ? iss.flags(ios::hex); > + ? ? ? iss >> *bottom; > + ? ? ? char c; > + ? ? ? iss >> c; > + ? ? ? iss >> *top; > + ? ? ? uintptr_t sp = (intptr_t)__builtin_frame_address(0); > + ? ? ? if (sp >= *bottom && sp <= *top) > + ? ? ? ? return true; > + ? ? ?} > + ?} > + > + ?return false; > +} > + > +bool os::create_stack_guard_pages(char* addr, size_t size) { > + ?uintptr_t stack_extent, stack_base; > + ?if (get_stack_bounds(&stack_extent, &stack_base)) { > + ? ?if (stack_extent < (uintptr_t)addr) > + ? ? ?::munmap((void*)stack_extent, (uintptr_t)addr - stack_extent); > + ?} > + > + ?return os::commit_memory(addr, size); > +} > + > +bool os::remove_stack_guard_pages(char* addr, size_t size) { > + ?return ::munmap(addr, size) == 0; > +} > + > ?static address _highest_vm_reserved_address = NULL; > > ?// If 'fixed' is true, anon_mmap() will attempt to reserve anonymous memory > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From gnu_andrew at member.fsf.org Tue Feb 23 13:05:48 2010 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Tue, 23 Feb 2010 21:05:48 +0000 Subject: HotSpot 16 and OpenJDK6 In-Reply-To: <4B843620.8030804@sun.com> References: <17c6771e1002230137h55cacd71r75c0b40ae109dcd8@mail.gmail.com> <4B843620.8030804@sun.com> Message-ID: <17c6771e1002231305u2ea8766jcc9eff5e6a5492de@mail.gmail.com> On 23 February 2010 20:10, Joseph D. Darcy wrote: > Hello. > > Andrew John Hughes wrote: >> >> Here's the merge: >> >> http://cr.openjdk.java.net/~andrew/jdk6-hs16-merge/webrev.01/ >> >> which now builds, thanks to this additional changeset from Daniel >> Daugherty in baseline: >> http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4 >> > > Good. > >> It also includes an additional fix, also listed separately at: >> >> http://cr.openjdk.java.net/~andrew/jdk6-hs16-merge/webrev.02/ >> >> which reverts an erroneous change from SIZE_FORMAT to %d in >> >> changeset: ? 734:dbbe28fc66b5 >> user: ? ? ? ?twisti >> date: ? ? ? ?Fri Feb 27 03:35:40 2009 -0800 >> summary: ? ? 6778669: Patch from Red Hat -- fixes compilation errors >> >> fixing the build on x86_64. ?We'll need a bug ID for this reversion. >> > > The webrev generally looks good, but I have a few questions and comments > before this goes back. > > Do you know why webrev shows so many files with zero changes? ?I assume this > is an artifact of the merge. > No, you're right that does seem strange. All I did was a pull from hs16 and then a merge. Perhaps this is some webrev oddity? If you look at http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-February/001230.html I included a diff of the merged OpenJDK6 against the hs16 master (which includes Daniel's patch that is currently only in baseline). It actually makes the other questions below a bit clearer. > In hotspot_version, what are the semantics of JDK_PREVIOUS_VERSION? > I'm not sure. It doesn't seem to do much. Its only use is to set a default BOOTDIR AFAICS: # Find JDK used for javac compiles BOOTDIR=$(SLASH_JAVA)/re/j2se/$(PREVIOUS_JDK_VERSION)/latest/binaries/$(PLATFORM) (from hotspot/make/defs.make) We actually differ from hs16 by still using 1.5.0 rather than 1.6.0. 1.5.0 implicitly seems to make more sense to me, because 1.6.0 is the version being built. But in practice, it doesn't seem to matter unless you're relying on the contents of a /java tree. > In terms of fixing the %d vs SIZE_FORMAT in vmError.cpp, I've filed 6929005 > "Fix format specifier in vmError.cpp." ?However, I notice that the JDK 7 > master still has %d in this location. ?I'll approve going back from %d -> > SIZE_FORMAT in OpenJDK 6 conditional on the review and approval of a HotSpot > engineer. > Interesting; I didn't check OpenJDK7 and indeed you're right. Looking again at the diff, it seems that we don't apply part of the same changeset: --- ../hs16/src/share/vm/utilities/vmError.hpp 2010-01-13 14:35:26.651211783 +0000 +++ hotspot/src/share/vm/utilities/vmError.hpp 2010-02-17 11:07:40.899854566 +0000 @@ -50,7 +50,7 @@ // additional info for VM internal errors const char * _filename; - int _lineno; + size_t _lineno; // used by fatal error handler int _current_step; keeping the size_t rather than using int. So I'll change the fix to be making vmError.hpp match hs16 and OpenJDK7, rather than changing vmError.cpp. The remaining diffs are typos and license fixups from the previous merge which need to go back to the main HotSpot tree. > Thanks, > > -Joe > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Vladimir.Kozlov at Sun.COM Tue Feb 23 14:29:17 2010 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Tue, 23 Feb 2010 14:29:17 -0800 Subject: Stack guard pages In-Reply-To: <17c6771e1002231236r517e57dp7fde6ff0b9110a31@mail.gmail.com> References: <4B83FF49.6060004@redhat.com> <17c6771e1002231115h28d0f281p5abff855ab1406c@mail.gmail.com> <4B843177.2030500@redhat.com> <17c6771e1002231236r517e57dp7fde6ff0b9110a31@mail.gmail.com> Message-ID: <4B8456BD.1000101@sun.com> I filed bug 6929067: Stack guard pages should be removed when thread is detached Vladimir Andrew John Hughes wrote: > On 23 February 2010 19:50, Andrew Haley wrote: >> On 02/23/2010 07:15 PM, Andrew John Hughes wrote: >>> On 23 February 2010 16:16, Andrew Haley wrote: >>>> I've been working on a bug in OpenOffice where using Java causes a >>>> later crash. https://bugzilla.novell.com/show_bug.cgi?id=578802 >>>> >>>> It's a very strange bug: Java is called, does something, and then the >>>> thread is detached from the Java VM. Long after, a segfault occurs. >>>> >>>> The reason for this crash is the way that stack guard pages work. >>>> When DetachCurrentThread() calls >>>> JavaThread::remove_stack_guard_pages(), the guard pages are not >>>> removed. So, if at some point later in the process the stack grows >>>> beyond the point where the guard pages were mapped, the Linux kernel >>>> cannot expand the stack any further because the guard pages are in the >>>> way, and a segfault occurs. >>>> >>>> I've attached a reproducer for this bug to the end of this message. >>>> It crashes on many of the Linux systems I've tried. >>>> >>>> The right way to fix this is for remove_stack_guard_pages() to >>>> munmap() the guard pages. However, it's essential not to split the >>>> stack region, so if the stack has already grown beyond the guard >>>> pages, we have to unmap() it. Like so: >>>> >>>> bool os::create_stack_guard_pages(char* addr, size_t size) { >>>> uintptr_t stack_extent, stack_base; >>>> // get_stack_bounds() returns the memory extent mapped for the stack >>>> // by the kernel. >>>> if (get_stack_bounds(&stack_extent, &stack_base)) { >>>> if (stack_extent < (uintptr_t)addr) >>>> ::munmap((void*)stack_extent, (uintptr_t)addr - stack_extent); >>>> } >>>> >>>> return os::commit_memory(addr, size); >>>> } >>>> >>>> bool os::remove_stack_guard_pages(char* addr, size_t size) { >>>> return ::munmap(addr, size) == 0; >>>> } >>>> >>>> This fixes the bug. Unfortunately, there is no os:: interface for >>>> create_stack_guard_pages() and remove_stack_guard_pages(), so this >>>> solution doesn't fit well with the current organization of the VM. I >>>> can't see any way of making this work only by touching os_linux.?pp . >>>> >>>> I could simply patch OpenJDK locally for the Linux distros, but I >>>> think we should have this discussion first. >>> Segfaults here with the latest OpenJDK7 b84: >>> >>> $ /mnt/builder/jdk7/j2sdk-image/bin/java -version >>> openjdk version "1.7.0-internal" >>> OpenJDK Runtime Environment (build 1.7.0-internal-andrew_2010_02_23_18_45-b00) >>> OpenJDK 64-Bit Server VM (build 17.0-b09, mixed mode) >>> >>> $ LD_LIBRARY_PATH=/mnt/builder/jdk7/j2sdk-image/jre/lib/amd64/server ./invoke >>> Hello >>> Segmentation fault >>> >>> I think it would it would be clearer what the suggested fix entails if >>> you posted a diff or webrev of the suggested change. >> Maybe, but I don't ATM have a suggested change. Everything I've tried is >> rather intrusive, and potentially affects other targets. >> >> However, here's what I've been testing, for information only. >> > > Thanks. That helps a lot. I was confusing the functions you > introduce with the ones of the same name in > src/share/vm/runtime/thread.{c,h}pp > > For the other platforms, would it not be sufficient for them to just > have simple implementations that call os::commti_memory and > os::uncommit_memory as before? The HotSpot developers can run the > change through JPRT to test it on all platforms. > >> Andrew. >> >> >> --- ./src/share/vm/runtime/thread.cpp~ 2008-07-10 21:04:36.000000000 +0100 >> +++ ./src/share/vm/runtime/thread.cpp 2010-02-23 14:43:20.452135932 +0000 >> @@ -2075,7 +2075,7 @@ >> int allocate = os::allocate_stack_guard_pages(); >> // warning("Guarding at " PTR_FORMAT " for len " SIZE_FORMAT "\n", low_addr, len); >> >> - if (allocate && !os::commit_memory((char *) low_addr, len)) { >> + if (allocate && !os::create_stack_guard_pages((char *) low_addr, len)) { >> warning("Attempt to allocate stack guard pages failed."); >> return; >> } >> @@ -2096,7 +2096,7 @@ >> size_t len = (StackYellowPages + StackRedPages) * os::vm_page_size(); >> >> if (os::allocate_stack_guard_pages()) { >> - if (os::uncommit_memory((char *) low_addr, len)) { >> + if (os::remove_stack_guard_pages((char *) low_addr, len)) { >> _stack_guard_state = stack_guard_unused; >> } else { >> warning("Attempt to deallocate stack guard pages failed."); >> --- ./src/share/vm/runtime/os.hpp~ 2008-07-10 21:04:36.000000000 +0100 >> +++ ./src/share/vm/runtime/os.hpp 2010-02-23 14:49:27.512732036 +0000 >> @@ -168,6 +168,9 @@ >> static bool protect_memory(char* addr, size_t bytes); >> static bool guard_memory(char* addr, size_t bytes); >> static bool unguard_memory(char* addr, size_t bytes); >> + static bool create_stack_guard_pages(char* addr, size_t bytes); >> + static bool remove_stack_guard_pages(char* addr, size_t bytes); >> + >> static char* map_memory(int fd, const char* file_name, size_t file_offset, >> char *addr, size_t bytes, bool read_only = false, >> bool allow_exec = false); >> --- ./src/os/linux/vm/os_linux.cpp~ 2010-02-23 11:42:40.005073691 +0000 >> +++ ./src/os/linux/vm/os_linux.cpp 2010-02-23 15:44:47.112387815 +0000 >> @@ -57,6 +57,10 @@ >> # include >> # include >> >> +#include >> +#include >> +#include >> + >> #define MAX_PATH (2 * K) >> >> // for timer info max values which include all bits >> @@ -2292,6 +2296,53 @@ >> != MAP_FAILED; >> } >> >> +static bool >> +get_stack_bounds(uintptr_t *bottom, uintptr_t *top) >> +{ >> + using namespace std; >> + >> + ostringstream oss; >> + oss << "/proc/" << syscall(SYS_gettid) << "/maps"; >> + ifstream cin(oss.str().c_str()); >> + while (!cin.eof()) >> + { >> + string str; >> + getline(cin,str); >> + const string stack_str = "[stack]"; >> + if (str.length() > stack_str.length() >> + && (str.compare(str.length() - stack_str.length(), >> + stack_str.length(), stack_str) >> + == 0)) >> + { >> + istringstream iss(str); >> + iss.flags(ios::hex); >> + iss >> *bottom; >> + char c; >> + iss >> c; >> + iss >> *top; >> + uintptr_t sp = (intptr_t)__builtin_frame_address(0); >> + if (sp >= *bottom && sp <= *top) >> + return true; >> + } >> + } >> + >> + return false; >> +} >> + >> +bool os::create_stack_guard_pages(char* addr, size_t size) { >> + uintptr_t stack_extent, stack_base; >> + if (get_stack_bounds(&stack_extent, &stack_base)) { >> + if (stack_extent < (uintptr_t)addr) >> + ::munmap((void*)stack_extent, (uintptr_t)addr - stack_extent); >> + } >> + >> + return os::commit_memory(addr, size); >> +} >> + >> +bool os::remove_stack_guard_pages(char* addr, size_t size) { >> + return ::munmap(addr, size) == 0; >> +} >> + >> static address _highest_vm_reserved_address = NULL; >> >> // If 'fixed' is true, anon_mmap() will attempt to reserve anonymous memory >> > > > From Joe.Darcy at Sun.COM Tue Feb 23 16:28:57 2010 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Tue, 23 Feb 2010 16:28:57 -0800 Subject: HotSpot 16 and OpenJDK6 In-Reply-To: <17c6771e1002231305u2ea8766jcc9eff5e6a5492de@mail.gmail.com> References: <17c6771e1002230137h55cacd71r75c0b40ae109dcd8@mail.gmail.com> <4B843620.8030804@sun.com> <17c6771e1002231305u2ea8766jcc9eff5e6a5492de@mail.gmail.com> Message-ID: <4B8472C9.4090507@sun.com> Andrew John Hughes wrote: > On 23 February 2010 20:10, Joseph D. Darcy wrote: > >> Hello. >> >> Andrew John Hughes wrote: >> >>> Here's the merge: >>> >>> http://cr.openjdk.java.net/~andrew/jdk6-hs16-merge/webrev.01/ >>> >>> which now builds, thanks to this additional changeset from Daniel >>> Daugherty in baseline: >>> http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4 >>> >>> >> Good. >> >> >>> It also includes an additional fix, also listed separately at: >>> >>> http://cr.openjdk.java.net/~andrew/jdk6-hs16-merge/webrev.02/ >>> >>> which reverts an erroneous change from SIZE_FORMAT to %d in >>> >>> changeset: 734:dbbe28fc66b5 >>> user: twisti >>> date: Fri Feb 27 03:35:40 2009 -0800 >>> summary: 6778669: Patch from Red Hat -- fixes compilation errors >>> >>> fixing the build on x86_64. We'll need a bug ID for this reversion. >>> >>> >> The webrev generally looks good, but I have a few questions and comments >> before this goes back. >> >> Do you know why webrev shows so many files with zero changes? I assume this >> is an artifact of the merge. >> >> > > No, you're right that does seem strange. All I did was a pull from > hs16 and then a merge. Perhaps this is some webrev oddity? > > If you look at http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-February/001230.html > I included a diff of the merged OpenJDK6 against the hs16 master > (which includes Daniel's patch that is currently only in baseline). > It actually makes the other questions below a bit clearer. > Yes, that patch size is more manageable! > >> In hotspot_version, what are the semantics of JDK_PREVIOUS_VERSION? >> >> > > I'm not sure. It doesn't seem to do much. Its only use is to set a > default BOOTDIR AFAICS: > > # Find JDK used for javac compiles > BOOTDIR=$(SLASH_JAVA)/re/j2se/$(PREVIOUS_JDK_VERSION)/latest/binaries/$(PLATFORM) > > (from hotspot/make/defs.make) > > We actually differ from hs16 by still using 1.5.0 rather than 1.6.0. > 1.5.0 implicitly seems to make more sense to me, because 1.6.0 is the > version being built. But in practice, it doesn't seem to matter > unless you're relying on the contents of a /java tree. > I have a vague recollection of there being a particular reason why this was upgraded to 1.6.0 so I'd prefer to see this kept as 1.6.0. >> In terms of fixing the %d vs SIZE_FORMAT in vmError.cpp, I've filed 6929005 >> "Fix format specifier in vmError.cpp." However, I notice that the JDK 7 >> master still has %d in this location. I'll approve going back from %d -> >> SIZE_FORMAT in OpenJDK 6 conditional on the review and approval of a HotSpot >> engineer. >> >> > > Interesting; I didn't check OpenJDK7 and indeed you're right. Looking > again at the diff, it seems that we don't apply part of the same > changeset: > > --- ../hs16/src/share/vm/utilities/vmError.hpp 2010-01-13 > 14:35:26.651211783 +0000 > +++ hotspot/src/share/vm/utilities/vmError.hpp 2010-02-17 > 11:07:40.899854566 +0000 > @@ -50,7 +50,7 @@ > > // additional info for VM internal errors > const char * _filename; > - int _lineno; > + size_t _lineno; > > // used by fatal error handler > int _current_step; > > keeping the size_t rather than using int. So I'll change the fix to > be making vmError.hpp match hs16 and OpenJDK7, rather than changing > vmError.cpp. > > The remaining diffs are typos and license fixups from the previous > merge which need to go back to the main HotSpot tree. > > If vmError.hpp matches what is in JDK 7 and HS 16, I approve your merge of HS 16 + Dan's fixes into OpenJDK 6. Thanks, -Joe From Erik.Trimble at Sun.COM Tue Feb 23 16:53:16 2010 From: Erik.Trimble at Sun.COM (Erik Trimble) Date: Tue, 23 Feb 2010 16:53:16 -0800 Subject: HotSpot 16 and OpenJDK6 In-Reply-To: <4B8472C9.4090507@sun.com> References: <17c6771e1002230137h55cacd71r75c0b40ae109dcd8@mail.gmail.com> <4B843620.8030804@sun.com> <17c6771e1002231305u2ea8766jcc9eff5e6a5492de@mail.gmail.com> <4B8472C9.4090507@sun.com> Message-ID: <4B84787C.1020606@sun.com> Joe Darcy wrote: > Andrew John Hughes wrote: >> On 23 February 2010 20:10, Joseph D. Darcy wrote: >> >>> Hello. >>> >>> Andrew John Hughes wrote: >>> >>>> Here's the merge: >>>> >>>> http://cr.openjdk.java.net/~andrew/jdk6-hs16-merge/webrev.01/ >>>> >>>> which now builds, thanks to this additional changeset from Daniel >>>> Daugherty in baseline: >>>> http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4 >>>> >>>> >>> Good. >>> >>> >>>> It also includes an additional fix, also listed separately at: >>>> >>>> http://cr.openjdk.java.net/~andrew/jdk6-hs16-merge/webrev.02/ >>>> >>>> which reverts an erroneous change from SIZE_FORMAT to %d in >>>> >>>> changeset: 734:dbbe28fc66b5 >>>> user: twisti >>>> date: Fri Feb 27 03:35:40 2009 -0800 >>>> summary: 6778669: Patch from Red Hat -- fixes compilation errors >>>> >>>> fixing the build on x86_64. We'll need a bug ID for this reversion. >>>> >>>> >>> The webrev generally looks good, but I have a few questions and >>> comments >>> before this goes back. >>> >>> Do you know why webrev shows so many files with zero changes? I >>> assume this >>> is an artifact of the merge. >>> >>> >> >> No, you're right that does seem strange. All I did was a pull from >> hs16 and then a merge. Perhaps this is some webrev oddity? >> >> If you look at >> http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-February/001230.html >> >> I included a diff of the merged OpenJDK6 against the hs16 master >> (which includes Daniel's patch that is currently only in baseline). >> It actually makes the other questions below a bit clearer. >> > > Yes, that patch size is more manageable! > >> >>> In hotspot_version, what are the semantics of JDK_PREVIOUS_VERSION? >>> >>> >> >> I'm not sure. It doesn't seem to do much. Its only use is to set a >> default BOOTDIR AFAICS: >> >> # Find JDK used for javac compiles >> BOOTDIR=$(SLASH_JAVA)/re/j2se/$(PREVIOUS_JDK_VERSION)/latest/binaries/$(PLATFORM) >> >> >> (from hotspot/make/defs.make) >> >> We actually differ from hs16 by still using 1.5.0 rather than 1.6.0. >> 1.5.0 implicitly seems to make more sense to me, because 1.6.0 is the >> version being built. But in practice, it doesn't seem to matter >> unless you're relying on the contents of a /java tree. >> > > I have a vague recollection of there being a particular reason why > this was upgraded to 1.6.0 so I'd prefer to see this kept as 1.6.0. > I'll have to go back and check, but there were some changes around 6u14 which required that the build JDK for Hotspot be at least 1.6-something. -- Erik Trimble Java System Support Mailstop: usca22-123 Phone: x17195 Santa Clara, CA From gnu_andrew at member.fsf.org Tue Feb 23 17:09:28 2010 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Wed, 24 Feb 2010 01:09:28 +0000 Subject: HotSpot 16 and OpenJDK6 In-Reply-To: <4B8472C9.4090507@sun.com> References: <17c6771e1002230137h55cacd71r75c0b40ae109dcd8@mail.gmail.com> <4B843620.8030804@sun.com> <17c6771e1002231305u2ea8766jcc9eff5e6a5492de@mail.gmail.com> <4B8472C9.4090507@sun.com> Message-ID: <17c6771e1002231709q143eb0d9r871253554375e69@mail.gmail.com> On 24 February 2010 00:28, Joe Darcy wrote: > Andrew John Hughes wrote: >> >> On 23 February 2010 20:10, Joseph D. Darcy wrote: >> >>> >>> Hello. >>> >>> Andrew John Hughes wrote: >>> >>>> >>>> Here's the merge: >>>> >>>> http://cr.openjdk.java.net/~andrew/jdk6-hs16-merge/webrev.01/ >>>> >>>> which now builds, thanks to this additional changeset from Daniel >>>> Daugherty in baseline: >>>> http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4 >>>> >>>> >>> >>> Good. >>> >>> >>>> >>>> It also includes an additional fix, also listed separately at: >>>> >>>> http://cr.openjdk.java.net/~andrew/jdk6-hs16-merge/webrev.02/ >>>> >>>> which reverts an erroneous change from SIZE_FORMAT to %d in >>>> >>>> changeset: ? 734:dbbe28fc66b5 >>>> user: ? ? ? ?twisti >>>> date: ? ? ? ?Fri Feb 27 03:35:40 2009 -0800 >>>> summary: ? ? 6778669: Patch from Red Hat -- fixes compilation errors >>>> >>>> fixing the build on x86_64. ?We'll need a bug ID for this reversion. >>>> >>>> >>> >>> The webrev generally looks good, but I have a few questions and comments >>> before this goes back. >>> >>> Do you know why webrev shows so many files with zero changes? ?I assume >>> this >>> is an artifact of the merge. >>> >>> >> >> No, you're right that does seem strange. ?All I did was a pull from >> hs16 and then a merge. ?Perhaps this is some webrev oddity? >> >> If you look at >> http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-February/001230.html >> I included a diff of the merged OpenJDK6 against the hs16 master >> (which includes Daniel's patch that is currently only in baseline). >> It actually makes the other questions below a bit clearer. >> > > Yes, that patch size is more manageable! > >> >>> >>> In hotspot_version, what are the semantics of JDK_PREVIOUS_VERSION? >>> >>> >> >> I'm not sure. ?It doesn't seem to do much. ?Its only use is to set a >> default BOOTDIR AFAICS: >> >> # Find JDK used for javac compiles >> >> BOOTDIR=$(SLASH_JAVA)/re/j2se/$(PREVIOUS_JDK_VERSION)/latest/binaries/$(PLATFORM) >> >> (from hotspot/make/defs.make) >> >> We actually differ from hs16 by still using 1.5.0 rather than 1.6.0. >> 1.5.0 implicitly seems to make more sense to me, because 1.6.0 is the >> version being built. ?But in practice, it doesn't seem to matter >> unless you're relying on the contents of a /java tree. >> > > I have a vague recollection of there being a particular reason why this was > upgraded to 1.6.0 so I'd prefer to see this kept as 1.6.0. > >>> In terms of fixing the %d vs SIZE_FORMAT in vmError.cpp, I've filed >>> 6929005 >>> "Fix format specifier in vmError.cpp." ?However, I notice that the JDK 7 >>> master still has %d in this location. ?I'll approve going back from %d -> >>> SIZE_FORMAT in OpenJDK 6 conditional on the review and approval of a >>> HotSpot >>> engineer. >>> >>> >> >> Interesting; I didn't check OpenJDK7 and indeed you're right. ?Looking >> again at the diff, it seems that we don't apply part of the same >> changeset: >> >> --- ../hs16/src/share/vm/utilities/vmError.hpp ?2010-01-13 >> 14:35:26.651211783 +0000 >> +++ hotspot/src/share/vm/utilities/vmError.hpp ?2010-02-17 >> 11:07:40.899854566 +0000 >> @@ -50,7 +50,7 @@ >> >> ? // additional info for VM internal errors >> ? const char * _filename; >> - ?int ? ? ? ? ?_lineno; >> + ?size_t ? ? ? _lineno; >> >> ? // used by fatal error handler >> ? int ? ? ? ? ?_current_step; >> >> keeping the size_t rather than using int. ?So I'll change the fix to >> be making vmError.hpp match hs16 and OpenJDK7, rather than changing >> vmError.cpp. >> >> The remaining diffs are typos and license fixups from the previous >> merge which need to go back to the main HotSpot tree. >> >> > > If vmError.hpp matches what is in JDK 7 and HS 16, I approve your merge of > HS 16 + Dan's fixes into OpenJDK 6. > Pushed. I reused 6929005 as Fix HS16 merge issues in OpenJDK 6 to make vmError.hpp and JDK_PREVIOUS_VERSION match hs16. You should probably update the bug itself to match :-) > Thanks, > > -Joe > Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From aph at redhat.com Wed Feb 24 01:24:23 2010 From: aph at redhat.com (Andrew Haley) Date: Wed, 24 Feb 2010 09:24:23 +0000 Subject: Stack guard pages In-Reply-To: <17c6771e1002231236r517e57dp7fde6ff0b9110a31@mail.gmail.com> References: <4B83FF49.6060004@redhat.com> <17c6771e1002231115h28d0f281p5abff855ab1406c@mail.gmail.com> <4B843177.2030500@redhat.com> <17c6771e1002231236r517e57dp7fde6ff0b9110a31@mail.gmail.com> Message-ID: <4B84F047.3060502@redhat.com> On 02/23/2010 08:36 PM, Andrew John Hughes wrote: > For the other platforms, would it not be sufficient for them to just > have simple implementations that call os::commti_memory and > os::uncommit_memory as before? The HotSpot developers can run the > change through JPRT to test it on all platforms. Sure. If hotspot developers like that I'll do it. Andrew. From ivo.anjo at ist.utl.pt Thu Feb 25 08:52:31 2010 From: ivo.anjo at ist.utl.pt (Ivo Anjo) Date: Thu, 25 Feb 2010 16:52:31 +0000 Subject: CC_INTERP broken in jdk7 hotspot on x86_64 Message-ID: <557ea2711002250852tbc3388dlb7110a6313979a5d@mail.gmail.com> I was looking into prototyping some changes using the C++ interpreter with the latest (tested with builds 81 and 84) openjdk. I edited hotspot/make/linux/platform_amd64 adding -DCC_INTERP, but am getting multiple compile errors, possibly due to the fact that this combination is not used by default, and the methods referenced are inside #ifndef CC_INTERP blocks. jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp: In member function 'unsigned char* InterpreterGenerator::generate_abstract_entry()': jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:282: error: 'class InterpreterMacroAssembler' has no member named 'empty_expression_stack' jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:284: error: 'class InterpreterMacroAssembler' has no member named 'restore_locals' jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static member function 'static unsigned char* MethodHandles::generate_method_handle_interpreter_entry(MacroAssembler*)': jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:95: error: 'throw_WrongMethodType_entry' is not a member of 'Interpreter' jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static member function 'static void MethodHandles::generate_method_handle_stub(MacroAssembler*, MethodHandles::EntryKind)': jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:404: error: 'throw_WrongMethodType_entry' is not a member of 'Interpreter' and finally Linking launcher... jdk7-b84/build/linux-amd64/hotspot/outputdir/linux_amd64_compiler2/product/libjvm.so: undefined reference to `AbstractInterpreter::can_be_compiled(methodHandle)' collect2: ld returned 1 exit status As I am new to hotspot development, may I ask if CC_INTERP is supposed to be working for x86_64, or is it just considered "dead code" that is kept around for historical reasons and there are no plans to fix it? Thanks, Ivo Anjo From imdupeng at gmail.com Thu Feb 25 09:10:26 2010 From: imdupeng at gmail.com (Peng Du) Date: Thu, 25 Feb 2010 11:10:26 -0600 Subject: CC_INTERP broken in jdk7 hotspot on x86_64 In-Reply-To: <557ea2711002250852tbc3388dlb7110a6313979a5d@mail.gmail.com> References: <557ea2711002250852tbc3388dlb7110a6313979a5d@mail.gmail.com> Message-ID: <1267117826.2661.1.camel@ubuntu61> Hi, Ivo I had a similar issue before. See this thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2010-January/002598.html Try building Zero. It works like a charm for me. Peng Du On Thu, 2010-02-25 at 16:52 +0000, Ivo Anjo wrote: > I was looking into prototyping some changes using the C++ interpreter > with the latest (tested with builds 81 and 84) openjdk. > I edited hotspot/make/linux/platform_amd64 adding -DCC_INTERP, but am > getting multiple compile errors, possibly due to the fact that this > combination is not used by default, and the methods referenced are > inside #ifndef CC_INTERP blocks. > > jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp: In member > function 'unsigned char* > InterpreterGenerator::generate_abstract_entry()': > jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:282: error: > 'class InterpreterMacroAssembler' has no member named > 'empty_expression_stack' > jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:284: error: > 'class InterpreterMacroAssembler' has no member named 'restore_locals' > > jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static > member function 'static unsigned char* > MethodHandles::generate_method_handle_interpreter_entry(MacroAssembler*)': > jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:95: error: > 'throw_WrongMethodType_entry' is not a member of 'Interpreter' > > jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static > member function 'static void > MethodHandles::generate_method_handle_stub(MacroAssembler*, > MethodHandles::EntryKind)': > jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:404: error: > 'throw_WrongMethodType_entry' is not a member of 'Interpreter' > > and finally > > Linking launcher... > jdk7-b84/build/linux-amd64/hotspot/outputdir/linux_amd64_compiler2/product/libjvm.so: > undefined reference to > `AbstractInterpreter::can_be_compiled(methodHandle)' > collect2: ld returned 1 exit status > > As I am new to hotspot development, may I ask if CC_INTERP is supposed > to be working for x86_64, or is it just considered "dead code" that is > kept around for historical reasons and there are no plans to fix it? > > Thanks, > Ivo Anjo From gbenson at redhat.com Thu Feb 25 09:15:23 2010 From: gbenson at redhat.com (Gary Benson) Date: Thu, 25 Feb 2010 17:15:23 +0000 Subject: CC_INTERP broken in jdk7 hotspot on x86_64 In-Reply-To: <557ea2711002250852tbc3388dlb7110a6313979a5d@mail.gmail.com> References: <557ea2711002250852tbc3388dlb7110a6313979a5d@mail.gmail.com> Message-ID: <20100225171523.GB4394@redhat.com> Hi Ivo, I don't believe the C++ interpreter ever worked on x86_64, only on SPARC and on 32-bit x86. I don't know of anybody at Sun who builds using the C++ interpreter, but we use it for Zero[1] and it definitely works there. That doesn't touch anything under hotspot/src/cpu/x86 though. Cheers, Gary [1] http://icedtea.classpath.org/wiki/ZeroSharkFaq Ivo Anjo wrote: > I was looking into prototyping some changes using the C++ > interpreter with the latest (tested with builds 81 and 84) openjdk. > I edited hotspot/make/linux/platform_amd64 adding -DCC_INTERP, but > am getting multiple compile errors, possibly due to the fact that > this combination is not used by default, and the methods referenced > are inside #ifndef CC_INTERP blocks. > > jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp: In member > function 'unsigned char* > InterpreterGenerator::generate_abstract_entry()': > jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:282: error: > 'class InterpreterMacroAssembler' has no member named > 'empty_expression_stack' > jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:284: error: > 'class InterpreterMacroAssembler' has no member named 'restore_locals' > > jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static > member function 'static unsigned char* > MethodHandles::generate_method_handle_interpreter_entry(MacroAssembler*)': > jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:95: error: > 'throw_WrongMethodType_entry' is not a member of 'Interpreter' > > jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static > member function 'static void > MethodHandles::generate_method_handle_stub(MacroAssembler*, > MethodHandles::EntryKind)': > jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:404: error: > 'throw_WrongMethodType_entry' is not a member of 'Interpreter' > > and finally > > Linking launcher... > jdk7-b84/build/linux-amd64/hotspot/outputdir/linux_amd64_compiler2/product/libjvm.so: > undefined reference to > `AbstractInterpreter::can_be_compiled(methodHandle)' > collect2: ld returned 1 exit status > > As I am new to hotspot development, may I ask if CC_INTERP is > supposed to be working for x86_64, or is it just considered "dead > code" that is kept around for historical reasons and there are no > plans to fix it? > > Thanks, > Ivo Anjo -- http://gbenson.net/ From Thomas.Rodriguez at Sun.COM Thu Feb 25 10:54:15 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Thu, 25 Feb 2010 10:54:15 -0800 Subject: CC_INTERP broken in jdk7 hotspot on x86_64 In-Reply-To: <557ea2711002250852tbc3388dlb7110a6313979a5d@mail.gmail.com> References: <557ea2711002250852tbc3388dlb7110a6313979a5d@mail.gmail.com> Message-ID: <60BFDDD1-96D0-4B84-AFEA-FBB996AF58C4@sun.com> It's not actively maintained by the hotspot team but we will accept fixes. There were customers who wanted the C++ interpreter so we've included it but none of our standard configurations use it. It worked for several configuration when it was first introduced but things have diverged a bit since then. tom On Feb 25, 2010, at 8:52 AM, Ivo Anjo wrote: > I was looking into prototyping some changes using the C++ interpreter > with the latest (tested with builds 81 and 84) openjdk. > I edited hotspot/make/linux/platform_amd64 adding -DCC_INTERP, but am > getting multiple compile errors, possibly due to the fact that this > combination is not used by default, and the methods referenced are > inside #ifndef CC_INTERP blocks. > > jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp: In member > function 'unsigned char* > InterpreterGenerator::generate_abstract_entry()': > jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:282: error: > 'class InterpreterMacroAssembler' has no member named > 'empty_expression_stack' > jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:284: error: > 'class InterpreterMacroAssembler' has no member named 'restore_locals' > > jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static > member function 'static unsigned char* > MethodHandles::generate_method_handle_interpreter_entry(MacroAssembler*)': > jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:95: error: > 'throw_WrongMethodType_entry' is not a member of 'Interpreter' > > jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static > member function 'static void > MethodHandles::generate_method_handle_stub(MacroAssembler*, > MethodHandles::EntryKind)': > jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:404: error: > 'throw_WrongMethodType_entry' is not a member of 'Interpreter' > > and finally > > Linking launcher... > jdk7-b84/build/linux-amd64/hotspot/outputdir/linux_amd64_compiler2/product/libjvm.so: > undefined reference to > `AbstractInterpreter::can_be_compiled(methodHandle)' > collect2: ld returned 1 exit status > > As I am new to hotspot development, may I ask if CC_INTERP is supposed > to be working for x86_64, or is it just considered "dead code" that is > kept around for historical reasons and there are no plans to fix it? > > Thanks, > Ivo Anjo From ivo.anjo at ist.utl.pt Thu Feb 25 13:49:35 2010 From: ivo.anjo at ist.utl.pt (Ivo Anjo) Date: Thu, 25 Feb 2010 21:49:35 +0000 Subject: CC_INTERP broken in jdk7 hotspot on x86_64 In-Reply-To: <60BFDDD1-96D0-4B84-AFEA-FBB996AF58C4@sun.com> References: <557ea2711002250852tbc3388dlb7110a6313979a5d@mail.gmail.com> <60BFDDD1-96D0-4B84-AFEA-FBB996AF58C4@sun.com> Message-ID: <557ea2711002251349o20f1d51dj983cde1b9f2d3eba@mail.gmail.com> Thanks for all the quick answers, and sorry for missing the older thread that couldn't be more obvious: "C++ Interpreter on 64-bit Linux". The usage of the C++ interpreter would be interesting because it would allow me to run it in tandem with the JIT stuff, but maybe I was aiming too high anyway, so Zero is probably the best way to start. Again, thanks for all the feedback Ivo Anjo On Thu, Feb 25, 2010 at 6:54 PM, Tom Rodriguez wrote: > It's not actively maintained by the hotspot team but we will accept fixes. ?There were customers who wanted the C++ interpreter so we've included it but none of our standard configurations use it. ?It worked for several configuration when it was first introduced but things have diverged a bit since then. > > tom > > On Feb 25, 2010, at 8:52 AM, Ivo Anjo wrote: > >> I was looking into prototyping some changes using the C++ interpreter >> with the latest (tested with builds 81 and 84) openjdk. >> I edited hotspot/make/linux/platform_amd64 adding -DCC_INTERP, but am >> getting multiple compile errors, possibly due to the fact that this >> combination is not used by default, and the methods referenced are >> inside #ifndef CC_INTERP blocks. >> >> jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp: In member >> function 'unsigned char* >> InterpreterGenerator::generate_abstract_entry()': >> jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:282: error: >> 'class InterpreterMacroAssembler' has no member named >> 'empty_expression_stack' >> jdk7-b84/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:284: error: >> 'class InterpreterMacroAssembler' has no member named 'restore_locals' >> >> jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static >> member function 'static unsigned char* >> MethodHandles::generate_method_handle_interpreter_entry(MacroAssembler*)': >> jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:95: error: >> 'throw_WrongMethodType_entry' is not a member of 'Interpreter' >> >> jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static >> member function 'static void >> MethodHandles::generate_method_handle_stub(MacroAssembler*, >> MethodHandles::EntryKind)': >> jdk7-b84/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:404: error: >> 'throw_WrongMethodType_entry' is not a member of 'Interpreter' >> >> and finally >> >> Linking launcher... >> jdk7-b84/build/linux-amd64/hotspot/outputdir/linux_amd64_compiler2/product/libjvm.so: >> undefined reference to >> `AbstractInterpreter::can_be_compiled(methodHandle)' >> collect2: ld returned 1 exit status >> >> As I am new to hotspot development, may I ask if CC_INTERP is supposed >> to be working for x86_64, or is it just considered "dead code" that is >> kept around for historical reasons and there are no plans to fix it? >> >> Thanks, >> Ivo Anjo > >