From Christian.Thalinger at Sun.COM Mon Jan 4 03:28:07 2010 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Mon, 04 Jan 2010 12:28:07 +0100 Subject: Review Request: Zero fix In-Reply-To: <20091222133204.GC3312@redhat.com> References: <20091222133204.GC3312@redhat.com> Message-ID: <1262604487.8926.22.camel@macbook> On Tue, 2009-12-22 at 13:32 +0000, Gary Benson wrote: > Hi all, > > Zero currently won't build on zSeries or PowerPC machines with > assertions turned on. This webrev fixes: > > http://cr.openjdk.java.net/~gbenson/zero-signedness-fix/ > > I haven't filed a bug for this one, it'll only get bounced by > the triage people if I file it. I created: 6913869: Zero assert fix The changes look good and I will push them right away. -- Christian From gbenson at redhat.com Mon Jan 4 03:49:37 2010 From: gbenson at redhat.com (Gary Benson) Date: Mon, 4 Jan 2010 11:49:37 +0000 Subject: Review Request: Zero fix In-Reply-To: <1262604487.8926.22.camel@macbook> References: <20091222133204.GC3312@redhat.com> <1262604487.8926.22.camel@macbook> Message-ID: <20100104114937.GD3350@redhat.com> Christian Thalinger wrote: > On Tue, 2009-12-22 at 13:32 +0000, Gary Benson wrote: > > Hi all, > > > > Zero currently won't build on zSeries or PowerPC machines with > > assertions turned on. This webrev fixes: > > > > http://cr.openjdk.java.net/~gbenson/zero-signedness-fix/ > > > > I haven't filed a bug for this one, it'll only get bounced by > > the triage people if I file it. > > I created: > > 6913869: Zero assert fix > > The changes look good and I will push them right away. Thank you :) Cheers, Gary -- http://gbenson.net/ From gbenson at redhat.com Tue Jan 5 02:42:17 2010 From: gbenson at redhat.com (Gary Benson) Date: Tue, 5 Jan 2010 10:42:17 +0000 Subject: PING: 6908267: Zero fails to unlock synchronized native methods on exception Message-ID: <20100105104217.GA3321@redhat.com> Hi all, If a synchronized native method throws an exception, Zero does not unlock it. This leaves the receiver (or mirror) "locked" to a "monitor" which is basically junk on the stack, and the VM will crash at the next safepoint if not before. http://cr.openjdk.java.net/~gbenson/zero-fix-6908267/ fixes this issue. It's been hanging around for a month or so now. Could somebody please look at it for me? Cheers, Gary -- http://gbenson.net/ From gbenson at redhat.com Tue Jan 5 02:45:47 2010 From: gbenson at redhat.com (Gary Benson) Date: Tue, 5 Jan 2010 10:45:47 +0000 Subject: PING: Make -Xprintflags always available In-Reply-To: <20091218084201.GC3317@redhat.com> References: <20091209171339.GF3409@redhat.com> <20091218084201.GC3317@redhat.com> Message-ID: <20100105104547.GB3321@redhat.com> Hi all, I mailed this webrev to the list a month ago, and not one person has commented. Can somebody please look at this for me? Cheers, Gary Gary Benson wrote: > Hi, > > Did anyone have any thoughts on this? It would be really helpful > for IcedTea if OpenJDK did this generally. > > Cheers, > Gary > > Gary Benson wrote: > > Hi all, > > > > I've been working on a script to test HotSpot with non-standard > > options. The idea is to start the VM with -XX option and check > > it doesn't crash or anything. > > > > One thing that's proving problematic is getting a list of all > > the options. We want to test product builds, but -Xprintflags > > is only available on debug builds. > > > > Would it be possible to have -Xprintflags always available? > > Something like this: > > > > http://cr.openjdk.java.net/~gbenson/printflags-product/ > > > > Cheers, > > Gary > > > > -- > > http://gbenson.net/ From Christian.Thalinger at Sun.COM Tue Jan 5 02:57:14 2010 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Tue, 05 Jan 2010 11:57:14 +0100 Subject: PING: Make -Xprintflags always available In-Reply-To: <20100105104547.GB3321@redhat.com> References: <20091209171339.GF3409@redhat.com> <20091218084201.GC3317@redhat.com> <20100105104547.GB3321@redhat.com> Message-ID: <1262689035.1668.1.camel@macbook> On Tue, 2010-01-05 at 10:45 +0000, Gary Benson wrote: > Hi all, > > I mailed this webrev to the list a month ago, and not one person > has commented. Can somebody please look at this for me? > > Cheers, > Gary > > Gary Benson wrote: > > Hi, > > > > Did anyone have any thoughts on this? It would be really helpful > > for IcedTea if OpenJDK did this generally. > > > > Cheers, > > Gary > > > > Gary Benson wrote: > > > Hi all, > > > > > > I've been working on a script to test HotSpot with non-standard > > > options. The idea is to start the VM with -XX option and check > > > it doesn't crash or anything. > > > > > > One thing that's proving problematic is getting a list of all > > > the options. We want to test product builds, but -Xprintflags > > > is only available on debug builds. > > > > > > Would it be possible to have -Xprintflags always available? > > > Something like this: > > > > > > http://cr.openjdk.java.net/~gbenson/printflags-product/ I think this would be nice to have, but maybe there is a history behind that that I don't know. Someone else has to jump in here. -- Christian From Thomas.Rodriguez at Sun.COM Tue Jan 5 10:13:17 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 05 Jan 2010 10:13:17 -0800 Subject: State of openjdk on hppa In-Reply-To: <4B1D338C.703@ubuntu.com> References: <4B1D338C.703@ubuntu.com> Message-ID: <87D52094-A310-44C9-945E-7FF3E39592BB@sun.com> > openjdk builds on hppa, but doesn't run (yet). Andrew Haley once debugged it and found out at least one things which would need to be fixed: the assumption in the C++ interpreter that the stack always grows downwards, and not upwards as on hppa. > > please could one of the hotspot developers sched some light on this, how easy this might to be fix, and if there are other assumptions? Could you give more detail on where exactly the direction of growth is being assumed? I know there's an accessor in frame that's supposed to describe the direction of growth of the expression stack which is used a few places in the code: // expression stack (may go up or down, direction == 1 or -1) public: intptr_t* interpreter_frame_expression_stack() const; static jint interpreter_frame_expression_stack_direction(); I would think this has to be set correctly for HPPA to work. Is it? It's possible that the C++ interpreter would also need to consult this when pushing values for it to work correctly. tom > > thanks, Matthias From Thomas.Rodriguez at Sun.COM Tue Jan 5 10:21:19 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 05 Jan 2010 10:21:19 -0800 Subject: PING: 6908267: Zero fails to unlock synchronized native methods on exception In-Reply-To: <20100105104217.GA3321@redhat.com> References: <20100105104217.GA3321@redhat.com> Message-ID: Yes this looks fine. Would you like me to push it? tom On Jan 5, 2010, at 2:42 AM, Gary Benson wrote: > Hi all, > > If a synchronized native method throws an exception, Zero does > not unlock it. This leaves the receiver (or mirror) "locked" > to a "monitor" which is basically junk on the stack, and the > VM will crash at the next safepoint if not before. > > http://cr.openjdk.java.net/~gbenson/zero-fix-6908267/ fixes > this issue. It's been hanging around for a month or so now. > Could somebody please look at it for me? > > Cheers, > Gary > > -- > http://gbenson.net/ From gbenson at redhat.com Tue Jan 5 10:23:18 2010 From: gbenson at redhat.com (Gary Benson) Date: Tue, 5 Jan 2010 18:23:18 +0000 Subject: PING: 6908267: Zero fails to unlock synchronized native methods on exception In-Reply-To: References: <20100105104217.GA3321@redhat.com> Message-ID: <20100105182318.GD3321@redhat.com> Yes please :) Cheers, Gary Tom Rodriguez wrote: > Yes this looks fine. Would you like me to push it? > > tom > > On Jan 5, 2010, at 2:42 AM, Gary Benson wrote: > > > Hi all, > > > > If a synchronized native method throws an exception, Zero does > > not unlock it. This leaves the receiver (or mirror) "locked" > > to a "monitor" which is basically junk on the stack, and the > > VM will crash at the next safepoint if not before. > > > > http://cr.openjdk.java.net/~gbenson/zero-fix-6908267/ fixes > > this issue. It's been hanging around for a month or so now. > > Could somebody please look at it for me? > > > > Cheers, > > Gary > > > > -- > > http://gbenson.net/ From Vladimir.Kozlov at Sun.COM Tue Jan 5 10:23:36 2010 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Tue, 05 Jan 2010 10:23:36 -0800 Subject: PING: Make -Xprintflags always available In-Reply-To: <1262689035.1668.1.camel@macbook> References: <20091209171339.GF3409@redhat.com> <20091218084201.GC3317@redhat.com> <20100105104547.GB3321@redhat.com> <1262689035.1668.1.camel@macbook> Message-ID: <4B4383A8.2070807@sun.com> I looked through the flag's changes history and I don't see anything which prevents it from work in product VM. Gary, do you want PrintFlagsFinal also be a product flag? Note: -Xprintflags prints default values and flags setting specified on command line before it, after printing VM exit. -XX:+PrintFlagsFinal prints final state of all flags which could be different from default due to ergonomic and platform specific settings, after printing VM continue execution. Thanks, Vladimir Christian Thalinger wrote: > On Tue, 2010-01-05 at 10:45 +0000, Gary Benson wrote: >> Hi all, >> >> I mailed this webrev to the list a month ago, and not one person >> has commented. Can somebody please look at this for me? >> >> Cheers, >> Gary >> >> Gary Benson wrote: >>> Hi, >>> >>> Did anyone have any thoughts on this? It would be really helpful >>> for IcedTea if OpenJDK did this generally. >>> >>> Cheers, >>> Gary >>> >>> Gary Benson wrote: >>>> Hi all, >>>> >>>> I've been working on a script to test HotSpot with non-standard >>>> options. The idea is to start the VM with -XX option and check >>>> it doesn't crash or anything. >>>> >>>> One thing that's proving problematic is getting a list of all >>>> the options. We want to test product builds, but -Xprintflags >>>> is only available on debug builds. >>>> >>>> Would it be possible to have -Xprintflags always available? >>>> Something like this: >>>> >>>> http://cr.openjdk.java.net/~gbenson/printflags-product/ > > I think this would be nice to have, but maybe there is a history behind > that that I don't know. Someone else has to jump in here. > > -- Christian > From Thomas.Rodriguez at Sun.COM Tue Jan 5 11:32:46 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 05 Jan 2010 11:32:46 -0800 Subject: PING: 6908267: Zero fails to unlock synchronized native methods on exception In-Reply-To: <20100105182318.GD3321@redhat.com> References: <20100105104217.GA3321@redhat.com> <20100105182318.GD3321@redhat.com> Message-ID: <75BF3107-8D60-400E-BAF5-E5161FE8B304@Sun.COM> It's in the queue. tom On Jan 5, 2010, at 10:23 AM, Gary Benson wrote: > Yes please :) > > Cheers, > Gary > > Tom Rodriguez wrote: >> Yes this looks fine. Would you like me to push it? >> >> tom >> >> On Jan 5, 2010, at 2:42 AM, Gary Benson wrote: >> >>> Hi all, >>> >>> If a synchronized native method throws an exception, Zero does >>> not unlock it. This leaves the receiver (or mirror) "locked" >>> to a "monitor" which is basically junk on the stack, and the >>> VM will crash at the next safepoint if not before. >>> >>> http://cr.openjdk.java.net/~gbenson/zero-fix-6908267/ fixes >>> this issue. It's been hanging around for a month or so now. >>> Could somebody please look at it for me? >>> >>> Cheers, >>> Gary >>> >>> -- >>> http://gbenson.net/ From gbenson at redhat.com Wed Jan 6 02:07:20 2010 From: gbenson at redhat.com (Gary Benson) Date: Wed, 6 Jan 2010 10:07:20 +0000 Subject: PING: 6908267: Zero fails to unlock synchronized native methods on exception In-Reply-To: <75BF3107-8D60-400E-BAF5-E5161FE8B304@Sun.COM> References: <20100105104217.GA3321@redhat.com> <20100105182318.GD3321@redhat.com> <75BF3107-8D60-400E-BAF5-E5161FE8B304@Sun.COM> Message-ID: <20100106100720.GC3312@redhat.com> Thank you. Cheers, Gary Tom Rodriguez wrote: > It's in the queue. > > tom > > On Jan 5, 2010, at 10:23 AM, Gary Benson wrote: > > > Yes please :) > > > > Cheers, > > Gary > > > > Tom Rodriguez wrote: > > > Yes this looks fine. Would you like me to push it? > > > > > > tom > > > > > > On Jan 5, 2010, at 2:42 AM, Gary Benson wrote: > > > > Hi all, > > > > > > > > If a synchronized native method throws an exception, Zero does > > > > not unlock it. This leaves the receiver (or mirror) "locked" > > > > to a "monitor" which is basically junk on the stack, and the > > > > VM will crash at the next safepoint if not before. > > > > > > > > http://cr.openjdk.java.net/~gbenson/zero-fix-6908267/ fixes > > > > this issue. It's been hanging around for a month or so now. > > > > Could somebody please look at it for me? > > > > > > > > Cheers, > > > > Gary > > > > > > > > -- > > > > http://gbenson.net/ From gbenson at redhat.com Wed Jan 6 02:12:10 2010 From: gbenson at redhat.com (Gary Benson) Date: Wed, 6 Jan 2010 10:12:10 +0000 Subject: PING: Make -Xprintflags always available In-Reply-To: <4B4383A8.2070807@sun.com> References: <20091209171339.GF3409@redhat.com> <20091218084201.GC3317@redhat.com> <20100105104547.GB3321@redhat.com> <1262689035.1668.1.camel@macbook> <4B4383A8.2070807@sun.com> Message-ID: <20100106101210.GD3312@redhat.com> Hi Vladimir, PrintFlagsFinal looks like it would be useful to have, if that's ok with you. Thanks for looking into this for me. Cheers, Gary Vladimir Kozlov wrote: > I looked through the flag's changes history and I don't see anything > which prevents it from work in product VM. > > Gary, do you want PrintFlagsFinal also be a product flag? > > Note: > -Xprintflags prints default values and flags setting specified > on command line before it, after printing VM exit. > -XX:+PrintFlagsFinal prints final state of all flags which could be > different from default due to ergonomic and platform specific settings, > after printing VM continue execution. > > Thanks, > Vladimir > > Christian Thalinger wrote: > > On Tue, 2010-01-05 at 10:45 +0000, Gary Benson wrote: > > > Hi all, > > > > > > I mailed this webrev to the list a month ago, and not one person > > > has commented. Can somebody please look at this for me? > > > > > > Cheers, > > > Gary > > > > > > Gary Benson wrote: > > > > Hi, > > > > > > > > Did anyone have any thoughts on this? It would be really > > > > helpful for IcedTea if OpenJDK did this generally. > > > > > > > > Cheers, > > > > Gary > > > > > > > > Gary Benson wrote: > > > > > Hi all, > > > > > > > > > > I've been working on a script to test HotSpot with > > > > > non-standard options. The idea is to start the VM with -XX > > > > > option and check it doesn't crash or anything. > > > > > > > > > > One thing that's proving problematic is getting a list of > > > > > all the options. We want to test product builds, but > > > > > -Xprintflags is only available on debug builds. > > > > > > > > > > Would it be possible to have -Xprintflags always available? > > > > > Something like this: > > > > > > > > > > http://cr.openjdk.java.net/~gbenson/printflags-product/ > > > > I think this would be nice to have, but maybe there is a history > > behind that that I don't know. Someone else has to jump in here. > > > > -- Christian -- http://gbenson.net/ From doko at ubuntu.com Wed Jan 6 07:16:34 2010 From: doko at ubuntu.com (Matthias Klose) Date: Wed, 06 Jan 2010 16:16:34 +0100 Subject: State of openjdk on hppa In-Reply-To: <87D52094-A310-44C9-945E-7FF3E39592BB@sun.com> References: <4B1D338C.703@ubuntu.com> <87D52094-A310-44C9-945E-7FF3E39592BB@sun.com> Message-ID: <4B44A952.4080807@ubuntu.com> On 05.01.2010 19:13, Tom Rodriguez wrote: >> openjdk builds on hppa, but doesn't run (yet). Andrew Haley once debugged it and found out at least one things which would need to be fixed: the assumption in the C++ interpreter that the stack always grows downwards, and not upwards as on hppa. >> >> please could one of the hotspot developers sched some light on this, how easy this might to be fix, and if there are other assumptions? > > Could you give more detail on where exactly the direction of growth is being assumed? I know there's an accessor in frame that's supposed to describe the direction of growth of the expression stack which is used a few places in the code: > > // expression stack (may go up or down, direction == 1 or -1) > public: > intptr_t* interpreter_frame_expression_stack() const; > static jint interpreter_frame_expression_stack_direction(); > > I would think this has to be set correctly for HPPA to work. Is it? It's possible that the C++ interpreter would also need to consult this when pushing values for it to work correctly. thanks for the pointer. zero sets this independently of the architecture. now checking the obvious fix. Matthias From gbenson at redhat.com Wed Jan 6 08:08:13 2010 From: gbenson at redhat.com (Gary Benson) Date: Wed, 6 Jan 2010 16:08:13 +0000 Subject: State of openjdk on hppa In-Reply-To: <87D52094-A310-44C9-945E-7FF3E39592BB@sun.com> References: <4B1D338C.703@ubuntu.com> <87D52094-A310-44C9-945E-7FF3E39592BB@sun.com> Message-ID: <20100106160813.GE3312@redhat.com> Tom Rodriguez wrote: > Someone wrote: > > openjdk builds on hppa, but doesn't run (yet). Andrew Haley once > > debugged it and found out at least one things which would need to > > be fixed: the assumption in the C++ interpreter that the stack > > always grows downwards, and not upwards as on hppa. > > > > please could one of the hotspot developers sched some light on > > this, how easy this might to be fix, and if there are other > > assumptions? > > Could you give more detail on where exactly the direction of growth > is being assumed? I know there's an accessor in frame that's > supposed to describe the direction of growth of the expression stack > which is used a few places in the code: > > // expression stack (may go up or down, direction == 1 or -1) > public: > intptr_t* interpreter_frame_expression_stack() const; > static jint interpreter_frame_expression_stack_direction(); > > I would think this has to be set correctly for HPPA to work. Is it? > It's possible that the C++ interpreter would also need to consult > this when pushing values for it to work correctly. I'm not 100% sure what the correct value of this would be for HPPA. The ABI stack grows upwards, but the stack Zero maintains still grows downwards. If interpreter_frame_expression_stack_direction is used for both of these stacks then something will need changing (either a separate accessor, or Zero's stack direction changing to match the ABI stack.) Cheers, Gary -- http://gbenson.net/ From Thomas.Rodriguez at Sun.COM Wed Jan 6 08:47:27 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 06 Jan 2010 08:47:27 -0800 Subject: State of openjdk on hppa In-Reply-To: <20100106160813.GE3312@redhat.com> References: <4B1D338C.703@ubuntu.com> <87D52094-A310-44C9-945E-7FF3E39592BB@sun.com> <20100106160813.GE3312@redhat.com> Message-ID: <7D583646-E851-4241-9688-CDF14FBC59C1@Sun.COM> > I'm not 100% sure what the correct value of this would be for HPPA. > The ABI stack grows upwards, but the stack Zero maintains still grows > downwards. If interpreter_frame_expression_stack_direction is used > for both of these stacks then something will need changing (either a > separate accessor, or Zero's stack direction changing to match the > ABI stack.) I don't really think hotspot cares which direction the ABI stack grows. It only cares what direction the expression stack grows and that's only for frame code that it was walking over the contents of the expression stack.. I was assuming that the expression stack would follow the ABI but I guess there's no reason it must. It's just the responsibility of the C++ intepreter to deal with that properly. It would be nice to know what exact problem led to the initial conclusion that direction of stack growth was the problem. tom > > Cheers, > Gary > > -- > http://gbenson.net/ From carlos at systemhalted.org Wed Jan 6 06:59:44 2010 From: carlos at systemhalted.org (Carlos O'Donell) Date: Wed, 6 Jan 2010 09:59:44 -0500 Subject: State of openjdk on hppa In-Reply-To: <87D52094-A310-44C9-945E-7FF3E39592BB@sun.com> References: <4B1D338C.703@ubuntu.com> <87D52094-A310-44C9-945E-7FF3E39592BB@sun.com> Message-ID: <119aab441001060659k7c58f2bam4ca0c661ec2deb@mail.gmail.com> On Tue, Jan 5, 2010 at 1:13 PM, Tom Rodriguez wrote: >> please could one of the hotspot developers sched some light on this, how easy this might to be fix, and if there are other assumptions? > > Could you give more detail on where exactly the direction of growth is being assumed? ?I know there's an accessor in frame that's supposed to describe the direction of growth of the expression stack which is used a few places in the code: The usual problem faced by HPPA is that it is one of the few stack-grows-up targets, therefore it is the *missing* calls to interpreter_frame_expression_stack_direction() that a porter has to determine. There is no easy way to know this other than debugging a failed application and determining that a section of code is assuming stack-grows-down and should instead call the appropriate accessor function to determine stack growth. I don't know if there are any such instances in the hotspot code. > ?// expression stack (may go up or down, direction == 1 or -1) > ?public: > ?intptr_t* interpreter_frame_expression_stack() const; > ?static ?jint ?interpreter_frame_expression_stack_direction(); > > I would think this has to be set correctly for HPPA to work. ?Is it? ?It's possible that the C++ interpreter would also need to consult this when pushing values for it to work correctly. Given that HPPA is a stack-grows-up target, is the value of this constant 1? All interpreters that manually manipulate the stack must know the direction of stack growth (and alignment of stack). Cheers, Carlos. From Thomas.Rodriguez at Sun.COM Wed Jan 6 09:26:00 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 06 Jan 2010 09:26:00 -0800 Subject: State of openjdk on hppa In-Reply-To: <4B44C01E.3030105@redhat.com> References: <4B1D338C.703@ubuntu.com> <87D52094-A310-44C9-945E-7FF3E39592BB@sun.com> <20100106160813.GE3312@redhat.com> <7D583646-E851-4241-9688-CDF14FBC59C1@Sun.COM> <4B44C01E.3030105@redhat.com> Message-ID: <9C8C32DC-CEAD-473D-ACB3-63CC52D4F75C@Sun.COM> No I didn't see it. If it was only on the icedtea list then I wouldn't have seen it as hotspot-dev is the only one of these aliases that I'm on. By the way, I restored the other aliases to my reply so they would get it too. So the computation of the location of the guard pages is wrong because of the direction of growth? For instance this line obviously won't work right: address low_addr = stack_base() - stack_size(); There's also some code in os_linux_zero.cpp that does math on the stack that would need to take into account the real ABI direction. I think we probably need something like "int os::stack_direction()" to deal with this in shared code. All the guard logic in Thread needs to check it as does is_in_stack and is_lock_owned. There might be some logic in frame that needs to check it too but hopefully that will all be platform dependent logic. tom On Jan 6, 2010, at 8:53 AM, Andrew Haley wrote: > On 01/06/2010 04:47 PM, Tom Rodriguez wrote: >>> I'm not 100% sure what the correct value of this would be for HPPA. >>> The ABI stack grows upwards, but the stack Zero maintains still grows >>> downwards. If interpreter_frame_expression_stack_direction is used >>> for both of these stacks then something will need changing (either a >>> separate accessor, or Zero's stack direction changing to match the >>> ABI stack.) >> >> I don't really think hotspot cares which direction the ABI stack >> grows. It only cares what direction the expression stack grows and >> that's only for frame code that it was walking over the contents of >> the expression stack.. I was assuming that the expression stack >> would follow the ABI but I guess there's no reason it must. It's >> just the responsibility of the C++ intepreter to deal with that >> properly. It would be nice to know what exact problem led to the >> initial conclusion that direction of stack growth was the problem. > > Did you not see my reply? The runtime write protects the guard pages > of the stack, and this immediately causes a segfault since the stack > being used is now unwritable, > > Andrew. From aph at redhat.com Wed Jan 6 09:29:52 2010 From: aph at redhat.com (Andrew Haley) Date: Wed, 06 Jan 2010 17:29:52 +0000 Subject: State of openjdk on hppa In-Reply-To: <9C8C32DC-CEAD-473D-ACB3-63CC52D4F75C@Sun.COM> References: <4B1D338C.703@ubuntu.com> <87D52094-A310-44C9-945E-7FF3E39592BB@sun.com> <20100106160813.GE3312@redhat.com> <7D583646-E851-4241-9688-CDF14FBC59C1@Sun.COM> <4B44C01E.3030105@redhat.com> <9C8C32DC-CEAD-473D-ACB3-63CC52D4F75C@Sun.COM> Message-ID: <4B44C890.2060507@redhat.com> On 01/06/2010 05:26 PM, Tom Rodriguez wrote: > No I didn't see it. If it was only on the icedtea list then I > wouldn't have seen it as hotspot-dev is the only one of these > aliases that I'm on. Oh darn, my mistake. The shiny new Reply List button on Thunderbird 3 didn't quite do what I expected... > By the way, I restored the other aliases to my reply so they would > get it too. So the computation of the location of the guard pages > is wrong because of the direction of growth? For instance this line > obviously won't work right: > > address low_addr = stack_base() - stack_size(); Right, that's it. > There's also some code in os_linux_zero.cpp that does math on the > stack that would need to take into account the real ABI direction. > I think we probably need something like "int os::stack_direction()" > to deal with this in shared code. All the guard logic in Thread > needs to check it as does is_in_stack and is_lock_owned. There > might be some logic in frame that needs to check it too but > hopefully that will all be platform dependent logic. Andrew. From Thomas.Rodriguez at Sun.COM Wed Jan 6 10:03:23 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 06 Jan 2010 10:03:23 -0800 Subject: review (M) for 6914300: ciEnv should export all well known classes Message-ID: http://cr.openjdk.java.net/~never/6914300 From Christian.Thalinger at Sun.COM Wed Jan 6 10:18:20 2010 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Wed, 06 Jan 2010 19:18:20 +0100 Subject: review (M) for 6914300: ciEnv should export all well known classes In-Reply-To: References: Message-ID: <1262801900.901.5.camel@macbook> On Wed, 2010-01-06 at 10:03 -0800, Tom Rodriguez wrote: > http://cr.openjdk.java.net/~never/6914300 Looks good. Thanks for doing the rename, it helps a lot. -- Christian From Vladimir.Kozlov at Sun.COM Wed Jan 6 11:22:04 2010 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 06 Jan 2010 11:22:04 -0800 Subject: review (M) for 6914300: ciEnv should export all well known classes In-Reply-To: References: Message-ID: <4B44E2DC.2010103@sun.com> Tom, In ciEnv.cpp and ciEnv.hpp names will contain sufix _klass now. You replaced ci accessors for ArrayStoreException, ClassCastException, OutOfMemoryError with macro generated accessors but names of fields left unchanged (without _klass). And adjust spacing in vmStructs.cpp. Vladimir Tom Rodriguez wrote: > http://cr.openjdk.java.net/~never/6914300 From Thomas.Rodriguez at Sun.COM Wed Jan 6 12:15:11 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 06 Jan 2010 12:15:11 -0800 Subject: review (M) for 6914300: ciEnv should export all well known classes In-Reply-To: <4B44E2DC.2010103@sun.com> References: <4B44E2DC.2010103@sun.com> Message-ID: <5D079E87-476B-4932-8AAA-730064391484@Sun.COM> On Jan 6, 2010, at 11:22 AM, Vladimir Kozlov wrote: > Tom, > > In ciEnv.cpp and ciEnv.hpp names will contain sufix _klass now. > You replaced ci accessors for ArrayStoreException, ClassCastException, > OutOfMemoryError with macro generated accessors but names of fields > left unchanged (without _klass). Actually those fields should have been deleted since they are covered by the macro. > > And adjust spacing in vmStructs.cpp. Fixed. tom > > Vladimir > > Tom Rodriguez wrote: >> http://cr.openjdk.java.net/~never/6914300 From John.Rose at Sun.COM Wed Jan 6 12:23:13 2010 From: John.Rose at Sun.COM (John Rose) Date: Wed, 06 Jan 2010 12:23:13 -0800 Subject: review (M) for 6914300: ciEnv should export all well known classes In-Reply-To: <1262801900.901.5.camel@macbook> References: <1262801900.901.5.camel@macbook> Message-ID: Yes, the JSR 292 work often bumps into the need to refer to a well-known class at compile time, and working with the previous ciEnv design was awkward. Thanks! -- John On Jan 6, 2010, at 10:18 AM, Christian Thalinger wrote: > On Wed, 2010-01-06 at 10:03 -0800, Tom Rodriguez wrote: >> http://cr.openjdk.java.net/~never/6914300 > > Looks good. Thanks for doing the rename, it helps a lot. -- Christian From Vladimir.Kozlov at Sun.COM Wed Jan 6 13:49:03 2010 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 06 Jan 2010 13:49:03 -0800 Subject: review (M) for 6914300: ciEnv should export all well known classes In-Reply-To: <5D079E87-476B-4932-8AAA-730064391484@Sun.COM> References: <4B44E2DC.2010103@sun.com> <5D079E87-476B-4932-8AAA-730064391484@Sun.COM> Message-ID: <4B45054F.7030504@sun.com> Looks good. Vladimir Tom Rodriguez wrote: > On Jan 6, 2010, at 11:22 AM, Vladimir Kozlov wrote: > >> Tom, >> >> In ciEnv.cpp and ciEnv.hpp names will contain sufix _klass now. >> You replaced ci accessors for ArrayStoreException, ClassCastException, >> OutOfMemoryError with macro generated accessors but names of fields >> left unchanged (without _klass). > > Actually those fields should have been deleted since they are covered by the macro. > >> And adjust spacing in vmStructs.cpp. > > Fixed. > > tom > >> Vladimir >> >> Tom Rodriguez wrote: >>> http://cr.openjdk.java.net/~never/6914300 > From igor.veresov at sun.com Thu Jan 7 15:22:49 2010 From: igor.veresov at sun.com (igor.veresov at sun.com) Date: Thu, 07 Jan 2010 23:22:49 +0000 Subject: hg: jdk7/hotspot/hotspot: 14 new changesets Message-ID: <20100107232321.E15F142740@hg.openjdk.java.net> Changeset: 40e7c1d24e4a Author: twisti Date: 2010-01-04 00:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/40e7c1d24e4a 6909153: Fix broken options on Zero Summary: Smaller fixes to ensure that Zero still works with non-standard options. Reviewed-by: twisti Contributed-by: Gary Benson ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 896da934748c Author: twisti Date: 2010-01-04 03:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/896da934748c 6913869: Zero assert fix Summary: Zero currently won't build on zSeries or PowerPC machines with assertions turned on. Reviewed-by: twisti Contributed-by: Gary Benson ! src/share/vm/prims/jni.cpp Changeset: aa62b9388fce Author: twisti Date: 2010-01-04 15:52 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/aa62b9388fce 6894206: JVM needs a way to traverse method handle structures Summary: We need a way to walk chained method handles in the JVM to call the right methods and to generate required bytecode adapters for the compilers. Reviewed-by: kvn ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/includeDB_core + src/share/vm/prims/methodHandleWalk.cpp + src/share/vm/prims/methodHandleWalk.hpp Changeset: 0910903272e5 Author: twisti Date: 2010-01-04 07:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/0910903272e5 Merge Changeset: e66fd840cb6b Author: twisti Date: 2010-01-04 18:38 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/e66fd840cb6b 6893081: method handle & invokedynamic code needs additional cleanup (post 6815692, 6858164) Summary: During the work for 6829187 we have fixed a number of basic bugs which are logically grouped with 6815692 and 6858164 but which must be reviewed and pushed separately. Reviewed-by: kvn, never ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/runtime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/c1/c1_IR.hpp ! src/share/vm/ci/ciStreams.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/code/codeBlob.hpp ! src/share/vm/code/debugInfoRec.cpp ! src/share/vm/code/debugInfoRec.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/code/pcDesc.hpp ! src/share/vm/compiler/methodLiveness.cpp ! src/share/vm/interpreter/bytecode.cpp ! src/share/vm/interpreter/bytecode.hpp ! src/share/vm/interpreter/bytecodes.cpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 4b84186a8248 Author: kvn Date: 2010-01-04 15:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/4b84186a8248 6913075: EA identifies escape state incorrectly after 6895383 fix Summary: EA incorrectly identifies escape state of an allocation passed as call argument. Reviewed-by: never ! src/share/vm/opto/escape.cpp Changeset: 97125851f396 Author: twisti Date: 2010-01-05 13:05 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/97125851f396 6829187: compiler optimizations required for JSR 292 Summary: C2 implementation for invokedynamic support. Reviewed-by: kvn, never ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad + src/share/vm/ci/ciCPCache.cpp + src/share/vm/ci/ciCPCache.hpp ! src/share/vm/ci/ciClassList.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciObject.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciStreams.cpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/ci/ciTypeFlow.cpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/includeDB_core ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/machnode.hpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/type.cpp Changeset: dd57230ba8fe Author: twisti Date: 2010-01-05 15:21 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/dd57230ba8fe 6893268: additional dynamic language related optimizations in C2 Summary: C2 needs some additional optimizations to be able to handle MethodHandle invokes and invokedynamic instructions at the best performance. Reviewed-by: kvn, never ! src/share/vm/ci/ciCPCache.cpp + src/share/vm/ci/ciCallSite.cpp + src/share/vm/ci/ciCallSite.hpp ! src/share/vm/ci/ciClassList.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciExceptionHandler.cpp ! src/share/vm/ci/ciField.cpp ! src/share/vm/ci/ciField.hpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/ci/ciKlass.cpp ! src/share/vm/ci/ciKlass.hpp ! src/share/vm/ci/ciMethod.hpp + src/share/vm/ci/ciMethodHandle.cpp + src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/ci/ciObject.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciStreams.cpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/ci/ciSymbol.cpp ! src/share/vm/ci/ciSymbol.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/includeDB_core ! src/share/vm/interpreter/bytecode.hpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/constMethodOop.hpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/generateOopMap.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/oops/symbolOop.cpp ! src/share/vm/oops/symbolOop.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/utilities/constantTag.hpp Changeset: b6f06e395428 Author: never Date: 2010-01-05 11:14 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/b6f06e395428 6908267: Zero fails to unlock synchronized native methods on exception Reviewed-by: never Contributed-by: Gary Benson ! src/cpu/zero/vm/cppInterpreter_zero.cpp Changeset: 1f6d42899c3a Author: never Date: 2010-01-05 11:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/1f6d42899c3a Merge Changeset: b1f619d38249 Author: never Date: 2010-01-05 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/b1f619d38249 6914002: unsigned compare problem after 5057818 Reviewed-by: kvn, twisti ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp Changeset: 4ce7240d622c Author: never Date: 2010-01-06 14:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/4ce7240d622c 6914300: ciEnv should export all well known classes Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciField.cpp ! src/share/vm/ci/ciInstance.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciType.cpp ! src/share/vm/ci/ciUtilities.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/javaAssertions.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/memory/classify.cpp ! src/share/vm/memory/dump.cpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/arrayKlass.hpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlassKlass.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiEnter.xsl ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/jniHandles.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/reflectionUtils.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/statSampler.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/lowMemoryDetector.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/serviceUtil.hpp ! src/share/vm/services/threadService.cpp ! src/share/vm/utilities/exceptions.cpp Changeset: aad340e07bc4 Author: never Date: 2010-01-06 14:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/aad340e07bc4 Merge Changeset: 9b9c1ee9b3f6 Author: iveresov Date: 2010-01-06 22:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/9b9c1ee9b3f6 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp From igor.veresov at sun.com Thu Jan 7 16:26:06 2010 From: igor.veresov at sun.com (igor.veresov at sun.com) Date: Fri, 08 Jan 2010 00:26:06 +0000 Subject: hg: jdk7/hotspot/jdk: 3 new changesets Message-ID: <20100108002702.DC1A442752@hg.openjdk.java.net> Changeset: 9c352f7ed4a3 Author: jrose Date: 2009-10-21 23:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9c352f7ed4a3 6891770: JSR 292 API needs initial unit tests Summary: backport working mlvm regression test to M3 implementation of JSR 292; requires jtreg 4.1 Reviewed-by: twisti + test/java/dyn/MethodHandlesTest.java Changeset: fc3d21b50545 Author: jrose Date: 2010-01-06 16:50 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/fc3d21b50545 Merge Changeset: dbcf6cafa65c Author: jrose Date: 2010-01-07 16:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/dbcf6cafa65c 6914665: update jdk code for JSR 292 (post 6858164) Summary: Fill in missing API implementations, fix numerous bugs, adjust APIs towards EG design. Reviewed-by: twisti ! src/share/classes/java/dyn/CallSite.java ! src/share/classes/java/dyn/InvokeDynamic.java ! src/share/classes/java/dyn/InvokeDynamicBootstrapError.java ! src/share/classes/java/dyn/JavaMethodHandle.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/LinkagePermission.java ! src/share/classes/java/dyn/MethodHandle.java ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/MethodType.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/BoundMethodHandle.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/FilterGeneric.java ! src/share/classes/sun/dyn/FilterOneArgument.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MemberName.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/MethodHandleNatives.java ! src/share/classes/sun/dyn/MethodTypeImpl.java + src/share/classes/sun/dyn/SpreadGeneric.java ! src/share/classes/sun/dyn/ToGeneric.java ! src/share/classes/sun/dyn/empty/Empty.java + src/share/classes/sun/dyn/util/BytecodeDescriptor.java ! src/share/classes/sun/dyn/util/BytecodeName.java - src/share/classes/sun/dyn/util/BytecodeSignature.java ! src/share/classes/sun/dyn/util/ValueConversions.java ! src/share/classes/sun/dyn/util/VerifyAccess.java ! src/share/classes/sun/dyn/util/VerifyType.java ! src/share/classes/sun/dyn/util/Wrapper.java ! test/java/dyn/MethodHandlesTest.java From aph at redhat.com Fri Jan 8 10:48:37 2010 From: aph at redhat.com (Andrew Haley) Date: Fri, 08 Jan 2010 18:48:37 +0000 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <4B1FC407.6010405@redhat.com> References: <4B1FC407.6010405@redhat.com> Message-ID: <4B477E05.5050207@redhat.com> On 12/09/2009 03:36 PM, Andrew Haley wrote: > This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 > The symptom is that jmap doesn't work because target libraries are stripped. > The fix is to allow the symtab reader to use the separate debuginfo files > that are available for all (AFAIK) GNU/Linux distributions. This is now also https://bugs.openjdk.java.net/show_bug.cgi?id=100126 Webrev at http://cr.openjdk.java.net/~aph/100126-hotspot-webrev/ I have now checked several Linux distros, old and new, and although they keep their debuginfo files in different places, this patch works on all of them. Is this OK? And, if so, which repos should I push the patch to? Thanks. Andrew. From gnu_andrew at member.fsf.org Fri Jan 8 11:11:53 2010 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Fri, 8 Jan 2010 19:11:53 +0000 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <4B477E05.5050207@redhat.com> References: <4B1FC407.6010405@redhat.com> <4B477E05.5050207@redhat.com> Message-ID: <17c6771e1001081111y398c3899xfd60771d134907a9@mail.gmail.com> 2010/1/8 Andrew Haley : > On 12/09/2009 03:36 PM, Andrew Haley wrote: >> This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 >> The symptom is that jmap doesn't work because target libraries are stripped. >> The fix is to allow the symtab reader to use the separate debuginfo files >> that are available for all (AFAIK) GNU/Linux distributions. > > This is now also https://bugs.openjdk.java.net/show_bug.cgi?id=100126 > > Webrev at http://cr.openjdk.java.net/~aph/100126-hotspot-webrev/ > > I have now checked several Linux distros, old and new, and although > they keep their debuginfo files in different places, this patch works > on all of them. > > Is this OK? ?And, if so, which repos should I push the patch to? > > Thanks. > Andrew. > It also needs a Sun bug ID to push, so could the reviewer please allocate one :-) -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From gnu_andrew at member.fsf.org Fri Jan 8 11:27:55 2010 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Fri, 8 Jan 2010 19:27:55 +0000 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <4B4785A1.8030604@sun.com> References: <4B1FC407.6010405@redhat.com> <4B477EED.2080806@redhat.com> <4B4785A1.8030604@sun.com> Message-ID: <17c6771e1001081127r11984f04n28848a4bdee644f6@mail.gmail.com> 2010/1/8 Kelly O'Hair : > > > Andrew Haley wrote: >> >> On 12/09/2009 03:36 PM, Andrew Haley wrote: >>> >>> This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 >>> The symptom is that jmap doesn't work because target libraries are >>> stripped. >>> The fix is to allow the symtab reader to use the separate debuginfo files >>> that are available for all (AFAIK) GNU/Linux distributions. >> >> This is now also https://bugs.openjdk.java.net/show_bug.cgi?id=100126 >> >> Webrev at http://cr.openjdk.java.net/~aph/100126-hotspot-webrev/ >> >> I have now checked several Linux distros, old and new, and although >> they keep their debuginfo files in different places, this patch works >> on all of them. >> >> Is this OK? ?And, if so, which repos should I push the patch to? >> > > I'm a little concerned about the impact this might have on hotspot > as it will eventually get delivered into a jdk6 release (I assume). > And jdk6 does builds on really old Linux systems, e.g. > "Red Hat Enterprise Advanced Server 2.1 update 2". > Can you think of anything that might be a problem with that? > Either at compile time or runtime? > aph will be able to respond to this in more detail, but my understanding of the patch is that it only tries separate debug files if it doesn't find debuginfo in the binary itself. If the builds om RHEL AS 2.1 use non-stripped binaries, it won't even get that far AFAICS. And if they don't and /usr/lib/debug also doesn't exist, then it will just fail as it always did. So the only issue would be that the code relies on building against something newer than it did previously. > I still am a bit uncomfortable with that 1K block of bytes we are adding, > but I'll resign from that debate, if this is the official way to do it. > How many of these 1K blocks are floating around the system? :^( > > The change probably needs to go through one of the hotspot forests, maybe > hotspot-rt? > I would have assumed hotspot-svc as it's serviceability-related. > In the meantime, I will take this patch and apply it, and make sure > hotspot still builds with the jdk6 and jdk7 Linux systems we have. > Thanks. HotSpot patches go through JPRT so that should also give it some build testing. > -kto > >> Thanks. >> Andrew. > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Kelly.Ohair at Sun.COM Fri Jan 8 11:46:23 2010 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Fri, 08 Jan 2010 11:46:23 -0800 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <17c6771e1001081127r11984f04n28848a4bdee644f6@mail.gmail.com> References: <4B1FC407.6010405@redhat.com> <4B477EED.2080806@redhat.com> <4B4785A1.8030604@sun.com> <17c6771e1001081127r11984f04n28848a4bdee644f6@mail.gmail.com> Message-ID: <4B478B8F.7050702@sun.com> Andrew John Hughes wrote: > 2010/1/8 Kelly O'Hair : >> >> Andrew Haley wrote: >>> On 12/09/2009 03:36 PM, Andrew Haley wrote: >>>> This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 >>>> The symptom is that jmap doesn't work because target libraries are >>>> stripped. >>>> The fix is to allow the symtab reader to use the separate debuginfo files >>>> that are available for all (AFAIK) GNU/Linux distributions. >>> This is now also https://bugs.openjdk.java.net/show_bug.cgi?id=100126 >>> >>> Webrev at http://cr.openjdk.java.net/~aph/100126-hotspot-webrev/ >>> >>> I have now checked several Linux distros, old and new, and although >>> they keep their debuginfo files in different places, this patch works >>> on all of them. >>> >>> Is this OK? And, if so, which repos should I push the patch to? >>> >> I'm a little concerned about the impact this might have on hotspot >> as it will eventually get delivered into a jdk6 release (I assume). >> And jdk6 does builds on really old Linux systems, e.g. >> "Red Hat Enterprise Advanced Server 2.1 update 2". >> Can you think of anything that might be a problem with that? >> Either at compile time or runtime? >> > > aph will be able to respond to this in more detail, but my > understanding of the patch is that it only tries separate debug files > if it doesn't find debuginfo in the binary itself. If the builds om > RHEL AS 2.1 use non-stripped binaries, it won't even get that far > AFAICS. And if they don't and /usr/lib/debug also doesn't exist, then > it will just fail as it always did. > > So the only issue would be that the code relies on building against > something newer than it did previously. > >> I still am a bit uncomfortable with that 1K block of bytes we are adding, >> but I'll resign from that debate, if this is the official way to do it. >> How many of these 1K blocks are floating around the system? :^( >> >> The change probably needs to go through one of the hotspot forests, maybe >> hotspot-rt? >> > > I would have assumed hotspot-svc as it's serviceability-related. The hotspot-svc forest has been abandoned in favor of hotspot-rt, or hotspot-rt has consumed it, depends on your point of view. Strange, I remember an email on this back in Nov 2008, but it appears to never have been sent out to the serviceability-dev at openjdk.java.net alias. The primary issue was resources in doing testing and integration of a 4th developer forest, the 3 (gc, comp, rt) seemed to be consuming all our testing resources. > >> In the meantime, I will take this patch and apply it, and make sure >> hotspot still builds with the jdk6 and jdk7 Linux systems we have. >> > > Thanks. HotSpot patches go through JPRT so that should also give it > some build testing. I fired off two JPRT jobs, one for jdk6 and one for jdk7, with this patch applied. Builds and testing. I'll let you know what I find out. Testing this particular functionality is another story of course, never easy to test features that require something to go wrong... ;^) -kto > > >> -kto >> >>> Thanks. >>> Andrew. > > > From Thomas.Rodriguez at Sun.COM Fri Jan 8 11:54:46 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Fri, 08 Jan 2010 11:54:46 -0800 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <4B477E05.5050207@redhat.com> References: <4B1FC407.6010405@redhat.com> <4B477E05.5050207@redhat.com> Message-ID: I think a better fix is to add the required gHotSpot* symbols to the mapfile so that they are always exported. This way jmap would work even if the debug symbols for libjvm.so weren't installed on the machine. I actually thought we already did this because we explicitly export a few vtbls for use by the SA but apparently we don't. I must have been thinking of windows where you have to explicitly export them or they won't show up at all. Anyway, adding this to the mapfiles will allow it work as is: # SA symbols gHotSpotVMIntConstantEntryArrayStride; gHotSpotVMIntConstantEntryNameOffset; gHotSpotVMIntConstantEntryValueOffset; gHotSpotVMIntConstants; gHotSpotVMLongConstantEntryArrayStride; gHotSpotVMLongConstantEntryNameOffset; gHotSpotVMLongConstantEntryValueOffset; gHotSpotVMLongConstants; gHotSpotVMStructEntryAddressOffset; gHotSpotVMStructEntryArrayStride; gHotSpotVMStructEntryFieldNameOffset; gHotSpotVMStructEntryIsStaticOffset; gHotSpotVMStructEntryOffsetOffset; gHotSpotVMStructEntryTypeNameOffset; gHotSpotVMStructEntryTypeStringOffset; gHotSpotVMStructs; gHotSpotVMTypeEntryArrayStride; gHotSpotVMTypeEntryIsIntegerTypeOffset; gHotSpotVMTypeEntryIsOopTypeOffset; gHotSpotVMTypeEntryIsUnsignedOffset; gHotSpotVMTypeEntrySizeOffset; gHotSpotVMTypeEntrySuperclassNameOffset; gHotSpotVMTypeEntryTypeNameOffset; gHotSpotVMTypes; Would this be acceptable? tom On Jan 8, 2010, at 10:48 AM, Andrew Haley wrote: > On 12/09/2009 03:36 PM, Andrew Haley wrote: >> This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 >> The symptom is that jmap doesn't work because target libraries are stripped. >> The fix is to allow the symtab reader to use the separate debuginfo files >> that are available for all (AFAIK) GNU/Linux distributions. > > This is now also https://bugs.openjdk.java.net/show_bug.cgi?id=100126 > > Webrev at http://cr.openjdk.java.net/~aph/100126-hotspot-webrev/ > > I have now checked several Linux distros, old and new, and although > they keep their debuginfo files in different places, this patch works > on all of them. > > Is this OK? And, if so, which repos should I push the patch to? > > Thanks. > Andrew. From gnu_andrew at member.fsf.org Fri Jan 8 12:03:35 2010 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Fri, 8 Jan 2010 20:03:35 +0000 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <4B478B8F.7050702@sun.com> References: <4B1FC407.6010405@redhat.com> <4B477EED.2080806@redhat.com> <4B4785A1.8030604@sun.com> <17c6771e1001081127r11984f04n28848a4bdee644f6@mail.gmail.com> <4B478B8F.7050702@sun.com> Message-ID: <17c6771e1001081203t3bef9e8j36f0d8ef886775e8@mail.gmail.com> 2010/1/8 Kelly O'Hair : > > > Andrew John Hughes wrote: >> >> 2010/1/8 Kelly O'Hair : >>> >>> Andrew Haley wrote: >>>> >>>> On 12/09/2009 03:36 PM, Andrew Haley wrote: >>>>> >>>>> This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 >>>>> The symptom is that jmap doesn't work because target libraries are >>>>> stripped. >>>>> The fix is to allow the symtab reader to use the separate debuginfo >>>>> files >>>>> that are available for all (AFAIK) GNU/Linux distributions. >>>> >>>> This is now also https://bugs.openjdk.java.net/show_bug.cgi?id=100126 >>>> >>>> Webrev at http://cr.openjdk.java.net/~aph/100126-hotspot-webrev/ >>>> >>>> I have now checked several Linux distros, old and new, and although >>>> they keep their debuginfo files in different places, this patch works >>>> on all of them. >>>> >>>> Is this OK? ?And, if so, which repos should I push the patch to? >>>> >>> I'm a little concerned about the impact this might have on hotspot >>> as it will eventually get delivered into a jdk6 release (I assume). >>> And jdk6 does builds on really old Linux systems, e.g. >>> "Red Hat Enterprise Advanced Server 2.1 update 2". >>> Can you think of anything that might be a problem with that? >>> Either at compile time or runtime? >>> >> >> aph will be able to respond to this in more detail, but my >> understanding of the patch is that it only tries separate debug files >> if it doesn't find debuginfo in the binary itself. ?If the builds om >> RHEL AS 2.1 use non-stripped binaries, it won't even get that far >> AFAICS. ?And if they don't and /usr/lib/debug also doesn't exist, then >> it will just fail as it always did. >> >> So the only issue would be that the code relies on building against >> something newer than it did previously. >> >>> I still am a bit uncomfortable with that 1K block of bytes we are adding, >>> but I'll resign from that debate, if this is the official way to do it. >>> How many of these 1K blocks are floating around the system? :^( >>> >>> The change probably needs to go through one of the hotspot forests, maybe >>> hotspot-rt? >>> >> >> I would have assumed hotspot-svc as it's serviceability-related. > > The hotspot-svc forest has been abandoned in favor of hotspot-rt, > or hotspot-rt has consumed it, depends on your point of view. > > Strange, I remember an email on this back in Nov 2008, but it appears > to never have been sent out to the serviceability-dev at openjdk.java.net > alias. The primary issue was resources in doing testing and integration > of a 4th developer forest, the 3 (gc, comp, rt) seemed to be consuming > all our testing resources. > Ah ok, that makes sense with the separate serviceability tree going too. I only checked hg.openjdk.java.net. Maybe it's time to nuke some of these dead trees? :) >> >>> In the meantime, I will take this patch and apply it, and make sure >>> hotspot still builds with the jdk6 and jdk7 Linux systems we have. >>> >> >> Thanks. ?HotSpot patches go through JPRT so that should also give it >> some build testing. > > I fired off two JPRT jobs, one for jdk6 and one for jdk7, with this patch > applied. Builds and testing. I'll let you know what I find out. > > Testing this particular functionality is another story of course, never > easy to test features that require something to go wrong... ;^) > > -kto > >> >> >>> -kto >>> >>>> Thanks. >>>> Andrew. >> >> >> > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Kelly.Ohair at Sun.COM Fri Jan 8 15:10:50 2010 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Fri, 08 Jan 2010 15:10:50 -0800 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <17c6771e1001081203t3bef9e8j36f0d8ef886775e8@mail.gmail.com> References: <4B1FC407.6010405@redhat.com> <4B477EED.2080806@redhat.com> <4B4785A1.8030604@sun.com> <17c6771e1001081127r11984f04n28848a4bdee644f6@mail.gmail.com> <4B478B8F.7050702@sun.com> <17c6771e1001081203t3bef9e8j36f0d8ef886775e8@mail.gmail.com> Message-ID: <4B47BB7A.3000509@sun.com> Andrew John Hughes wrote: > 2010/1/8 Kelly O'Hair : >> >> Andrew John Hughes wrote: >>> 2010/1/8 Kelly O'Hair : >>>> Andrew Haley wrote: >>>>> On 12/09/2009 03:36 PM, Andrew Haley wrote: >>>>>> This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 >>>>>> The symptom is that jmap doesn't work because target libraries are >>>>>> stripped. >>>>>> The fix is to allow the symtab reader to use the separate debuginfo >>>>>> files >>>>>> that are available for all (AFAIK) GNU/Linux distributions. >>>>> This is now also https://bugs.openjdk.java.net/show_bug.cgi?id=100126 >>>>> >>>>> Webrev at http://cr.openjdk.java.net/~aph/100126-hotspot-webrev/ >>>>> >>>>> I have now checked several Linux distros, old and new, and although >>>>> they keep their debuginfo files in different places, this patch works >>>>> on all of them. >>>>> >>>>> Is this OK? And, if so, which repos should I push the patch to? >>>>> >>>> I'm a little concerned about the impact this might have on hotspot >>>> as it will eventually get delivered into a jdk6 release (I assume). >>>> And jdk6 does builds on really old Linux systems, e.g. >>>> "Red Hat Enterprise Advanced Server 2.1 update 2". >>>> Can you think of anything that might be a problem with that? >>>> Either at compile time or runtime? >>>> >>> aph will be able to respond to this in more detail, but my >>> understanding of the patch is that it only tries separate debug files >>> if it doesn't find debuginfo in the binary itself. If the builds om >>> RHEL AS 2.1 use non-stripped binaries, it won't even get that far >>> AFAICS. And if they don't and /usr/lib/debug also doesn't exist, then >>> it will just fail as it always did. >>> >>> So the only issue would be that the code relies on building against >>> something newer than it did previously. >>> >>>> I still am a bit uncomfortable with that 1K block of bytes we are adding, >>>> but I'll resign from that debate, if this is the official way to do it. >>>> How many of these 1K blocks are floating around the system? :^( >>>> >>>> The change probably needs to go through one of the hotspot forests, maybe >>>> hotspot-rt? >>>> >>> I would have assumed hotspot-svc as it's serviceability-related. >> The hotspot-svc forest has been abandoned in favor of hotspot-rt, >> or hotspot-rt has consumed it, depends on your point of view. >> >> Strange, I remember an email on this back in Nov 2008, but it appears >> to never have been sent out to the serviceability-dev at openjdk.java.net >> alias. The primary issue was resources in doing testing and integration >> of a 4th developer forest, the 3 (gc, comp, rt) seemed to be consuming >> all our testing resources. >> > > Ah ok, that makes sense with the separate serviceability tree going too. > I only checked hg.openjdk.java.net. Maybe it's time to nuke some of > these dead trees? :) I've pinged Dan on this. We will ask MarkR to purge these hotspot-svc repositories. > >>>> In the meantime, I will take this patch and apply it, and make sure >>>> hotspot still builds with the jdk6 and jdk7 Linux systems we have. >>>> >>> Thanks. HotSpot patches go through JPRT so that should also give it >>> some build testing. >> I fired off two JPRT jobs, one for jdk6 and one for jdk7, with this patch >> applied. Builds and testing. I'll let you know what I find out. >> Both JPRT jobs came back fine. -kto >> Testing this particular functionality is another story of course, never >> easy to test features that require something to go wrong... ;^) >> >> -kto >> >>> >>>> -kto >>>> >>>>> Thanks. >>>>> Andrew. >>> >>> > > > From aph at redhat.com Sat Jan 9 02:57:21 2010 From: aph at redhat.com (Andrew Haley) Date: Sat, 09 Jan 2010 10:57:21 +0000 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <4B478B8F.7050702@sun.com> References: <4B1FC407.6010405@redhat.com> <4B477EED.2080806@redhat.com> <4B4785A1.8030604@sun.com> <17c6771e1001081127r11984f04n28848a4bdee644f6@mail.gmail.com> <4B478B8F.7050702@sun.com> Message-ID: <4B486111.50206@redhat.com> On 01/08/2010 07:46 PM, Kelly O'Hair wrote: > > > Andrew John Hughes wrote: >> 2010/1/8 Kelly O'Hair : >>> >>> Andrew Haley wrote: >>>> On 12/09/2009 03:36 PM, Andrew Haley wrote: >>>>> This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 >>>>> The symptom is that jmap doesn't work because target libraries are >>>>> stripped. >>>>> The fix is to allow the symtab reader to use the separate debuginfo files >>>>> that are available for all (AFAIK) GNU/Linux distributions. >>>> This is now also https://bugs.openjdk.java.net/show_bug.cgi?id=100126 >>>> >>>> Webrev at http://cr.openjdk.java.net/~aph/100126-hotspot-webrev/ >>>> >>>> I have now checked several Linux distros, old and new, and although >>>> they keep their debuginfo files in different places, this patch works >>>> on all of them. >>>> >>>> Is this OK? And, if so, which repos should I push the patch to? >>>> >>> I'm a little concerned about the impact this might have on hotspot >>> as it will eventually get delivered into a jdk6 release (I assume). >>> And jdk6 does builds on really old Linux systems, e.g. >>> "Red Hat Enterprise Advanced Server 2.1 update 2". >>> Can you think of anything that might be a problem with that? >>> Either at compile time or runtime? >>> >> >> aph will be able to respond to this in more detail, but my >> understanding of the patch is that it only tries separate debug files >> if it doesn't find debuginfo in the binary itself. If the builds om >> RHEL AS 2.1 use non-stripped binaries, it won't even get that far >> AFAICS. And if they don't and /usr/lib/debug also doesn't exist, then >> it will just fail as it always did. >> >> So the only issue would be that the code relies on building against >> something newer than it did previously. >> >>> I still am a bit uncomfortable with that 1K block of bytes we are adding, >>> but I'll resign from that debate, if this is the official way to do it. >>> How many of these 1K blocks are floating around the system? :^( >>> >>> The change probably needs to go through one of the hotspot forests, maybe >>> hotspot-rt? >>> >> >> I would have assumed hotspot-svc as it's serviceability-related. > > The hotspot-svc forest has been abandoned in favor of hotspot-rt, > or hotspot-rt has consumed it, depends on your point of view. > > Strange, I remember an email on this back in Nov 2008, but it appears > to never have been sent out to the serviceability-dev at openjdk.java.net > alias. The primary issue was resources in doing testing and integration > of a 4th developer forest, the 3 (gc, comp, rt) seemed to be consuming > all our testing resources. > >> >>> In the meantime, I will take this patch and apply it, and make sure >>> hotspot still builds with the jdk6 and jdk7 Linux systems we have. >>> >> >> Thanks. HotSpot patches go through JPRT so that should also give it >> some build testing. > > I fired off two JPRT jobs, one for jdk6 and one for jdk7, with this patch > applied. Builds and testing. I'll let you know what I find out. > > Testing this particular functionality is another story of course, never > easy to test features that require something to go wrong... ;^) I have a nice test for this, of course! for foo in do eu-strip $foo -f $foo.dbg done Then see if jprt and its friends still work. Andrew. From aph at redhat.com Sat Jan 9 03:03:20 2010 From: aph at redhat.com (Andrew Haley) Date: Sat, 09 Jan 2010 11:03:20 +0000 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: References: <4B1FC407.6010405@redhat.com> <4B477E05.5050207@redhat.com> Message-ID: <4B486278.9040005@redhat.com> On 01/08/2010 07:54 PM, Tom Rodriguez wrote: > I think a better fix is to add the required gHotSpot* symbols to the > mapfile so that they are always exported. I'm not sure this will work on all GNU/Linux distros, since symtabs are routinely removed in their entirety from DSOs. Is there some logic in the symtab handling to do a look-aside into the dynamic symtab instead of the symtab? Also, are these the only symbols that are ever looked up by this symtab reader? > This way jmap would work even if the debug symbols for libjvm.so > weren't installed on the machine. I actually thought we already did > this because we explicitly export a few vtbls for use by the SA but > apparently we don't. I must have been thinking of windows where you > have to explicitly export them or they won't show up at all. > Anyway, adding this to the mapfiles will allow it work as is: > > # SA symbols > gHotSpotVMIntConstantEntryArrayStride; > gHotSpotVMIntConstantEntryNameOffset; > gHotSpotVMIntConstantEntryValueOffset; > gHotSpotVMIntConstants; > gHotSpotVMLongConstantEntryArrayStride; > gHotSpotVMLongConstantEntryNameOffset; > gHotSpotVMLongConstantEntryValueOffset; > gHotSpotVMLongConstants; > gHotSpotVMStructEntryAddressOffset; > gHotSpotVMStructEntryArrayStride; > gHotSpotVMStructEntryFieldNameOffset; > gHotSpotVMStructEntryIsStaticOffset; > gHotSpotVMStructEntryOffsetOffset; > gHotSpotVMStructEntryTypeNameOffset; > gHotSpotVMStructEntryTypeStringOffset; > gHotSpotVMStructs; > gHotSpotVMTypeEntryArrayStride; > gHotSpotVMTypeEntryIsIntegerTypeOffset; > gHotSpotVMTypeEntryIsOopTypeOffset; > gHotSpotVMTypeEntryIsUnsignedOffset; > gHotSpotVMTypeEntrySizeOffset; > gHotSpotVMTypeEntrySuperclassNameOffset; > gHotSpotVMTypeEntryTypeNameOffset; > gHotSpotVMTypes; > > Would this be acceptable? I'll try it and report back. It seems a bit fragile, in that it depends on having a few magic names and it won't get tested in the standard build. I considered this option but rejected it in favour of fixing the root cause of the problem, which was that the symtab reader wasn't looking in the right place. Having said that, it's nice not to require the debuginfo files. Andrew. From y.s.ramakrishna at sun.com Sat Jan 9 11:11:28 2010 From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com) Date: Sat, 09 Jan 2010 19:11:28 +0000 Subject: hg: jdk7/hotspot/hotspot: 5 new changesets Message-ID: <20100109191141.735C042A1B@hg.openjdk.java.net> Changeset: e018e6884bd8 Author: ysr Date: 2009-12-23 09:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/e018e6884bd8 6631166: CMS: better heuristics when combatting fragmentation Summary: Autonomic per-worker free block cache sizing, tunable coalition policies, fixes to per-size block statistics, retuned gain and bandwidth of some feedback loop filters to allow quicker reactivity to abrupt changes in ambient demand, and other heuristics to reduce fragmentation of the CMS old gen. Also tightened some assertions, including those related to locking. Reviewed-by: jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsLockVerifier.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsLockVerifier.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp ! src/share/vm/gc_implementation/includeDB_gc_concurrentMarkSweep ! src/share/vm/gc_implementation/includeDB_gc_serial ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/gc_implementation/shared/gcUtil.cpp ! src/share/vm/gc_implementation/shared/gcUtil.hpp ! src/share/vm/includeDB_gc_parallel ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/generation.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/services/classLoadingService.cpp Changeset: 504830073409 Author: jmasa Date: 2010-01-04 07:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/504830073409 Merge ! src/share/vm/runtime/globals.hpp Changeset: 75bd253e25dd Author: ysr Date: 2010-01-04 14:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/75bd253e25dd 6637203: Classunloading messages go to stdout rather than Xloggc file, causing hangs when stdout is closed Summary: Decoupled TraceClassUnloading from verbose:gc, JVMTI_VERBOSE_GC and PrintGC[Details], making it settable in a manner identical to TraceClassLoading. Reverted an inadvertent change of TraceClassUnloading output in a previous changeset from gclog back to tty. Reviewed-by: coleenp, dholmes, jmasa, poonam ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/services/classLoadingService.cpp Changeset: 05b775309e59 Author: jmasa Date: 2010-01-07 08:14 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/05b775309e59 6912018: CMS: guarantee(head() != 0,"The head of the list cannot be NULL") Summary: Block too small to split was not correctly putback to free lists. Reviewed-by: ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp Changeset: 0579c695832f Author: ysr Date: 2010-01-09 09:01 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/0579c695832f Merge ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/runtime/arguments.cpp From Thomas.Rodriguez at Sun.COM Mon Jan 11 12:36:17 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Mon, 11 Jan 2010 12:36:17 -0800 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <4B486278.9040005@redhat.com> References: <4B1FC407.6010405@redhat.com> <4B477E05.5050207@redhat.com> <4B486278.9040005@redhat.com> Message-ID: <448B68EA-1FE2-430C-A534-A8598652C046@Sun.COM> On Jan 9, 2010, at 3:03 AM, Andrew Haley wrote: > On 01/08/2010 07:54 PM, Tom Rodriguez wrote: > >> I think a better fix is to add the required gHotSpot* symbols to the >> mapfile so that they are always exported. > > I'm not sure this will work on all GNU/Linux distros, since symtabs > are routinely removed in their entirety from DSOs. Is there some > logic in the symtab handling to do a look-aside into the dynamic > symtab instead of the symtab? The solaris libproc does this and I assumed that the linux code we wrote would also do this but it looks to me like it doesn't. I don't think it would be hard to add support for parsing the dynsym table in build_symtab and it would allow these tools to work if the libraries are commonly stripped. The code could either be modified to look for SHT_DYNSYM if SHT_SYMTAB doesn't exist or it could always parse both of them. Something limited like this works ok: diff -r f24201449cac agent/src/os/linux/symtab.c --- a/agent/src/os/linux/symtab.c Sat Jan 09 00:59:35 2010 -0800 +++ b/agent/src/os/linux/symtab.c Mon Jan 11 12:34:56 2010 -0800 @@ -66,6 +66,7 @@ struct symtab* build_symtab(int fd) { ELF_SHDR* cursct = NULL; ELF_PHDR* phbuf = NULL; ELF_PHDR* phdr = NULL; + int sym_section = SHT_DYNSYM; uintptr_t baseaddr = (uintptr_t)-1; @@ -90,9 +91,13 @@ struct symtab* build_symtab(int fd) { for (cursct = shbuf, cnt = 0; cnt < ehdr.e_shnum; cnt++) { scn_cache[cnt].c_shdr = cursct; - if (cursct->sh_type == SHT_SYMTAB || cursct->sh_type == SHT_STRTAB) { + if (cursct->sh_type == SHT_SYMTAB || cursct->sh_type == SHT_STRTAB || cursct->sh_type == SHT_DYNSYM) { if ( (scn_cache[cnt].c_data = read_section_data(fd, &ehdr, cursct)) == NULL) { goto quit; + } + if (cursct->sh_type == SHT_SYMTAB) { + // Full symbol table available so use that + sym_section = cursct->sh_type; } } cursct++; @@ -101,7 +106,7 @@ struct symtab* build_symtab(int fd) { for (cnt = 1; cnt < ehdr.e_shnum; cnt++) { ELF_SHDR *shdr = scn_cache[cnt].c_shdr; - if (shdr->sh_type == SHT_SYMTAB) { + if (shdr->sh_type == sym_section) { ELF_SYM *syms; int j, n, rslt; size_t size; > > Also, are these the only symbols that are ever looked up by this > symtab reader? Those are the only ones needed by the core SA functionality. The only thing other symbols are used for is the jstack -m mode that dumps mixed Java and native frames ala pstack and adding the external debug info reader to support this seems reasonable. tom > >> This way jmap would work even if the debug symbols for libjvm.so >> weren't installed on the machine. I actually thought we already did >> this because we explicitly export a few vtbls for use by the SA but >> apparently we don't. I must have been thinking of windows where you >> have to explicitly export them or they won't show up at all. >> Anyway, adding this to the mapfiles will allow it work as is: >> >> # SA symbols >> gHotSpotVMIntConstantEntryArrayStride; >> gHotSpotVMIntConstantEntryNameOffset; >> gHotSpotVMIntConstantEntryValueOffset; >> gHotSpotVMIntConstants; >> gHotSpotVMLongConstantEntryArrayStride; >> gHotSpotVMLongConstantEntryNameOffset; >> gHotSpotVMLongConstantEntryValueOffset; >> gHotSpotVMLongConstants; >> gHotSpotVMStructEntryAddressOffset; >> gHotSpotVMStructEntryArrayStride; >> gHotSpotVMStructEntryFieldNameOffset; >> gHotSpotVMStructEntryIsStaticOffset; >> gHotSpotVMStructEntryOffsetOffset; >> gHotSpotVMStructEntryTypeNameOffset; >> gHotSpotVMStructEntryTypeStringOffset; >> gHotSpotVMStructs; >> gHotSpotVMTypeEntryArrayStride; >> gHotSpotVMTypeEntryIsIntegerTypeOffset; >> gHotSpotVMTypeEntryIsOopTypeOffset; >> gHotSpotVMTypeEntryIsUnsignedOffset; >> gHotSpotVMTypeEntrySizeOffset; >> gHotSpotVMTypeEntrySuperclassNameOffset; >> gHotSpotVMTypeEntryTypeNameOffset; >> gHotSpotVMTypes; >> >> Would this be acceptable? > > I'll try it and report back. > > It seems a bit fragile, in that it depends on having a few magic names > and it won't get tested in the standard build. I considered this > option but rejected it in favour of fixing the root cause of the > problem, which was that the symtab reader wasn't looking in the right > place. > > Having said that, it's nice not to require the debuginfo files. > > Andrew. From aph at redhat.com Tue Jan 12 01:49:21 2010 From: aph at redhat.com (Andrew Haley) Date: Tue, 12 Jan 2010 09:49:21 +0000 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <448B68EA-1FE2-430C-A534-A8598652C046@Sun.COM> References: <4B1FC407.6010405@redhat.com> <4B477E05.5050207@redhat.com> <4B486278.9040005@redhat.com> <448B68EA-1FE2-430C-A534-A8598652C046@Sun.COM> Message-ID: <4B4C45A1.1010806@redhat.com> On 01/11/2010 08:36 PM, Tom Rodriguez wrote: > > On Jan 9, 2010, at 3:03 AM, Andrew Haley wrote: > >> On 01/08/2010 07:54 PM, Tom Rodriguez wrote: >> >>> I think a better fix is to add the required gHotSpot* symbols to the >>> mapfile so that they are always exported. >> >> I'm not sure this will work on all GNU/Linux distros, since symtabs >> are routinely removed in their entirety from DSOs. Is there some >> logic in the symtab handling to do a look-aside into the dynamic >> symtab instead of the symtab? > > The solaris libproc does this and I assumed that the linux code we > wrote would also do this but it looks to me like it doesn't. I > don't think it would be hard to add support for parsing the dynsym > table in build_symtab and it would allow these tools to work if the > libraries are commonly stripped. The code could either be modified > to look for SHT_DYNSYM if SHT_SYMTAB doesn't exist or it could > always parse both of them. Something limited like this works ok: > > ... > >> Also, are these the only symbols that are ever looked up by this >> symtab reader? > > Those are the only ones needed by the core SA functionality. The > only thing other symbols are used for is the jstack -m mode that > dumps mixed Java and native frames ala pstack and adding the > external debug info reader to support this seems reasonable. OK, right. I'll make a new webrev that includes my patch for external debug info and your patch for reading the dynsym table. I'll test with and without debuginfo and make sure that jmap works in both cases. Andrew. From igor.veresov at sun.com Wed Jan 13 00:08:15 2010 From: igor.veresov at sun.com (igor.veresov at sun.com) Date: Wed, 13 Jan 2010 08:08:15 +0000 Subject: hg: jdk7/hotspot/hotspot: 12 new changesets Message-ID: <20100113080849.3D5EA42F7E@hg.openjdk.java.net> Changeset: f62a22282a47 Author: kvn Date: 2010-01-07 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f62a22282a47 6914622: Print values of all flags for product VM Summary: Change the flag -XX:+PrintFlagsFinal to product and add new product flag -XX:+PrintFlagsInitial. Reviewed-by: phh, ysr Contributed-by: gbenson at redhat.com ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp Changeset: 1271af4ec18c Author: kvn Date: 2010-01-07 16:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/1271af4ec18c 6912517: JIT bug compiles out (and stops running) code that needs to be run. Causes NPE. Summary: Add missing check that value is used in memory expression in instructions with embedded load. Reviewed-by: never, jrose ! src/share/vm/opto/lcm.cpp + test/compiler/6912517/Test.java Changeset: cd37471eaecc Author: twisti Date: 2010-01-08 11:09 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/cd37471eaecc 6914206: change way of permission checking for generated MethodHandle adapters Summary: Put generated MH adapter in InvokeDynamic/MethodHandle classes to be able to indentify them easily in the compiler. Reviewed-by: kvn, never, jrose ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/includeDB_core ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/vframe.cpp Changeset: bea7a22a6f79 Author: kvn Date: 2010-01-08 09:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/bea7a22a6f79 6915110: IfNode::up_one_dom moves beyond RootNode bug in src/share/vm/opto/ifnode.cpp Summary: Check RootNode before check Loop in IfNode::up_one_dom(). Reviewed-by: never Contributed-by: kevin.brown at sun.com ! src/share/vm/opto/ifnode.cpp Changeset: 174ade00803b Author: kvn Date: 2010-01-08 09:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/174ade00803b 6910484: incorrect integer optimization (loosing and op-r in a given example) Summary: Remove AND operation only if mask is equal to shift. Reviewed-by: never ! src/share/vm/opto/divnode.cpp + test/compiler/6910484/Test.java Changeset: 4e6abf09f540 Author: jrose Date: 2010-01-08 13:47 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/4e6abf09f540 6912062: disassembler plugin needs to produce symbolic information in product mode Summary: More informative disassembly in product mode. Also, a more consistent CompileCommand syntax. Reviewed-by: never ! src/share/vm/code/codeBlob.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/includeDB_core ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/oops/arrayKlassKlass.cpp ! src/share/vm/oops/arrayKlassKlass.hpp ! src/share/vm/oops/compiledICHolderKlass.cpp ! src/share/vm/oops/compiledICHolderKlass.hpp ! src/share/vm/oops/constMethodKlass.cpp ! src/share/vm/oops/constMethodKlass.hpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolKlass.hpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/oops/cpCacheKlass.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceKlassKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/klassKlass.cpp ! src/share/vm/oops/klassKlass.hpp ! src/share/vm/oops/methodDataKlass.cpp ! src/share/vm/oops/methodDataKlass.hpp ! src/share/vm/oops/methodKlass.cpp ! src/share/vm/oops/methodKlass.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/oops/objArrayKlassKlass.cpp ! src/share/vm/oops/objArrayKlassKlass.hpp ! src/share/vm/oops/oop.cpp ! src/share/vm/oops/symbolKlass.cpp ! src/share/vm/oops/symbolKlass.hpp ! src/share/vm/oops/typeArrayKlassKlass.cpp ! src/share/vm/oops/typeArrayKlassKlass.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 136ac23d6ded Author: jrose Date: 2010-01-08 15:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/136ac23d6ded Merge Changeset: c3b315a0d58a Author: jrose Date: 2010-01-08 13:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM Summary: Put all inline-related switches into product mode, to allow tuning by dynamic language implementors. Reviewed-by: twisti, kvn ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/runtime/globals.hpp Changeset: f2e64cfc2020 Author: jrose Date: 2010-01-08 18:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f2e64cfc2020 Merge Changeset: 5b06c5db3e89 Author: jrose Date: 2010-01-08 22:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/5b06c5db3e89 Merge Changeset: f24201449cac Author: never Date: 2010-01-09 00:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f24201449cac 6909839: missing unsigned compare cases for some cmoves in sparc.ad Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/sparc.ad + test/compiler/6909839/Test6909839.java Changeset: 1fc01a2425ce Author: iveresov Date: 2010-01-12 13:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/1fc01a2425ce Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp From john.coomes at sun.com Thu Jan 14 20:33:24 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 15 Jan 2010 04:33:24 +0000 Subject: hg: jdk7/hotspot: Added tag jdk7-b79 for changeset 20aeeb517139 Message-ID: <20100115043324.C56D541633@hg.openjdk.java.net> Changeset: b1952d19290d Author: katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/b1952d19290d Added tag jdk7-b79 for changeset 20aeeb517139 ! .hgtags From john.coomes at sun.com Thu Jan 14 20:33:29 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 15 Jan 2010 04:33:29 +0000 Subject: hg: jdk7/hotspot/corba: Added tag jdk7-b79 for changeset ec0421b5703b Message-ID: <20100115043332.7A7C241634@hg.openjdk.java.net> Changeset: fdbc85b2d15c Author: katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/fdbc85b2d15c Added tag jdk7-b79 for changeset ec0421b5703b ! .hgtags From john.coomes at sun.com Thu Jan 14 20:36:12 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 15 Jan 2010 04:36:12 +0000 Subject: hg: jdk7/hotspot/jaxp: Added tag jdk7-b79 for changeset b1005c504358 Message-ID: <20100115043612.74A5F41636@hg.openjdk.java.net> Changeset: 9219574db593 Author: katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/9219574db593 Added tag jdk7-b79 for changeset b1005c504358 ! .hgtags From john.coomes at sun.com Thu Jan 14 20:36:17 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 15 Jan 2010 04:36:17 +0000 Subject: hg: jdk7/hotspot/jaxws: Added tag jdk7-b79 for changeset c08894f5b6e5 Message-ID: <20100115043617.ED15241637@hg.openjdk.java.net> Changeset: 447767dee56a Author: katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/447767dee56a Added tag jdk7-b79 for changeset c08894f5b6e5 ! .hgtags From john.coomes at sun.com Thu Jan 14 20:36:50 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 15 Jan 2010 04:36:50 +0000 Subject: hg: jdk7/hotspot/jdk: 35 new changesets Message-ID: <20100115044806.7A6754163A@hg.openjdk.java.net> Changeset: a0f6963b1618 Author: martin Date: 2009-12-08 12:41 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a0f6963b1618 6903754: (bf) Improve floating-point buffer comparison Summary: Describe the exact behavior of {Double,Float}Buffer.{equals,compareTo}; fix non-anti-symmetric behavior of compareTo Reviewed-by: alanb Contributed-by: jessewilson at google.com ! make/java/nio/genBuffer.sh ! src/share/classes/java/nio/X-Buffer.java.template ! test/java/nio/Buffer/Basic-X.java.template ! test/java/nio/Buffer/BasicByte.java ! test/java/nio/Buffer/BasicChar.java ! test/java/nio/Buffer/BasicDouble.java ! test/java/nio/Buffer/BasicFloat.java ! test/java/nio/Buffer/BasicInt.java ! test/java/nio/Buffer/BasicLong.java ! test/java/nio/Buffer/BasicShort.java ! test/java/nio/Buffer/genBasic.sh Changeset: db5c77621c6b Author: weijun Date: 2009-12-09 11:15 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/db5c77621c6b 6908628: ObjectIdentifier s11n test fails Reviewed-by: xuelei ! test/sun/security/util/Oid/S11N.sh Changeset: c2f83e13bbe5 Author: darcy Date: 2009-12-09 17:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c2f83e13bbe5 6909057: @see Arrays#hashCode missing particular method specification in j.u.Objects.hash Reviewed-by: ksrini ! src/share/classes/java/util/Objects.java Changeset: 0f8f624ddcb4 Author: mchung Date: 2009-12-09 21:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0f8f624ddcb4 6909082: Docs warning from java.util.logging.PlatformLoggingMXBean Summary: Fix incorrect tag @See with @see. Reviewed-by: darcy ! src/share/classes/java/util/logging/PlatformLoggingMXBean.java Changeset: 7c9be6c9385a Author: mullan Date: 2009-12-10 11:31 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7c9be6c9385a 6867348: Digest Value of References inside Manifest - calculation order problem Reviewed-by: xuelei ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java ! test/javax/xml/crypto/dsig/GenerationTests.java Changeset: 421e652f00c7 Author: mullan Date: 2009-12-10 11:34 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/421e652f00c7 Merge Changeset: ae944611249f Author: chegar Date: 2009-12-10 15:52 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ae944611249f 6909089: Memory leak occurs by lack of free for read buffer in SocketInputStream#read() Reviewed-by: alanb, jccollet ! src/windows/native/java/net/SocketInputStream.c Changeset: 59221d9e0c1c Author: chegar Date: 2009-12-10 09:08 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/59221d9e0c1c Merge Changeset: f9c9c2b726a0 Author: darcy Date: 2009-12-10 13:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f9c9c2b726a0 6909070: Missing package statements in java.text.Bidi @see links Reviewed-by: anthony ! src/share/classes/java/text/Bidi.java Changeset: aa0d374b40a5 Author: darcy Date: 2009-12-10 13:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/aa0d374b40a5 4891262: API spec, javax/accessibility: few invalid javadoc tags Reviewed-by: jjg ! src/share/classes/javax/accessibility/AccessibleContext.java ! src/share/classes/javax/accessibility/AccessibleExtendedText.java ! src/share/classes/javax/accessibility/AccessibleKeyBinding.java Changeset: 3267ca7afe95 Author: darcy Date: 2009-12-11 10:40 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3267ca7afe95 6909563: Javadoc build warnings in rmi, security, management Reviewed-by: mchung, mullan ! src/share/classes/java/lang/management/PlatformManagedObject.java ! src/share/classes/java/rmi/activation/Activatable.java ! src/share/classes/java/rmi/registry/LocateRegistry.java ! src/share/classes/java/rmi/server/RemoteObjectInvocationHandler.java ! src/share/classes/java/security/cert/CertPathValidatorException.java Changeset: 5434b2585a08 Author: andrew Date: 2009-12-11 23:47 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5434b2585a08 6909442: Fix comments in test/sun/tools/jhat/HatRun.java Summary: Update the comments in this test to match the changes in 6902325 Reviewed-by: ohair ! test/sun/tools/jhat/HatRun.java Changeset: 2d53da2c4764 Author: ohair Date: 2009-12-09 09:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/2d53da2c4764 6906210: Fix another minor typo in test/Makefile Reviewed-by: tbell, dcubed ! test/Makefile ! test/ProblemList.txt ! test/com/sun/jdi/NoLaunchOptionTest.java ! test/com/sun/jdi/OptionTest.java ! test/sun/tools/jhat/HatRun.java Changeset: a5ee97f72245 Author: ohair Date: 2009-12-09 09:50 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a5ee97f72245 Merge Changeset: 8d42b2bd25fe Author: ohair Date: 2009-12-10 16:57 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/8d42b2bd25fe Merge Changeset: c84d8b9be5c6 Author: ohair Date: 2009-12-11 15:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c84d8b9be5c6 6909373: Add -ea to the testing done by jdk/test/Makefile Reviewed-by: darcy ! test/Makefile ! test/ProblemList.txt Changeset: 623c22f00e49 Author: ohair Date: 2009-12-11 15:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/623c22f00e49 Merge Changeset: 15568b6998f4 Author: ohair Date: 2009-12-11 17:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/15568b6998f4 Merge ! test/sun/tools/jhat/HatRun.java Changeset: ad1e30930c6c Author: darcy Date: 2009-12-15 13:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ad1e30930c6c 6908131: Pure Java implementations of StrictMath.floor(double) & StrictMath.ceil(double) Reviewed-by: alanb ! make/java/java/mapfile-vers ! make/java/java/reorder-i586 ! make/java/java/reorder-sparc ! make/java/java/reorder-sparcv9 ! src/share/classes/java/lang/StrictMath.java ! src/share/native/java/lang/StrictMath.c + test/java/lang/Math/CeilAndFloorTests.java Changeset: c6d3ca281660 Author: ohair Date: 2009-12-16 12:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c6d3ca281660 6558110: tmp/java/jli/obj_g/static is not deleted automatically Reviewed-by: ksrini ! make/java/jli/Makefile Changeset: a368ebcfeeb6 Author: mchung Date: 2009-12-17 08:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/a368ebcfeeb6 6898747: Allow JNDI cosnaming provider to be used when java.applet is not present Summary: Check if java.applet.Applet is present before accessing the type Reviewed-by: alanb, vinnie ! src/share/classes/com/sun/jndi/toolkit/corba/CorbaUtils.java Changeset: de776cd139aa Author: mchung Date: 2009-12-18 07:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/de776cd139aa Merge Changeset: da43f2e977ac Author: mchung Date: 2009-12-18 11:36 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/da43f2e977ac 6909572: Add a new target for building modules Summary: Add a new "modules" build target that builds jdk and jre module image Reviewed-by: alanb, ohair ! make/Makefile + make/common/Modules.gmk + make/modules/Makefile + make/modules/bootmodule.roots + make/modules/jdk7.depconfig + make/modules/modules.config + make/modules/modules.group + make/modules/optional.depconfig + make/modules/tools/Makefile + make/modules/tools/build.xml + make/modules/tools/nbproject/project.properties + make/modules/tools/nbproject/project.xml + make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java + make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java + make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java + make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java + make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java + make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java + make/modules/tools/src/com/sun/classanalyzer/ClassPath.java + make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java + make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java + make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java + make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java + make/modules/tools/src/com/sun/classanalyzer/Klass.java + make/modules/tools/src/com/sun/classanalyzer/Module.java + make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java + make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java + make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java + make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java Changeset: b8d1e718ea6d Author: mchung Date: 2009-12-18 11:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b8d1e718ea6d 6909573: Temporary launcher support to add modules in the bootclasspath Summary: Add the list of modules to the bootclasspath if lib/rt.jar and classes don't exist Reviewed-by: alanb, ohair, ksrini ! src/share/bin/java.c Changeset: 3b896fcc7806 Author: tbell Date: 2009-12-19 10:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3b896fcc7806 Merge Changeset: f7e4cda33734 Author: darcy Date: 2009-12-22 21:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f7e4cda33734 6908541: Bad resource management in java/math/BigInteger/BigIntegerTest.java Reviewed-by: alanb ! test/ProblemList.txt ! test/java/math/BigInteger/BigIntegerTest.java Changeset: 94feb5bd31bd Author: ptisnovs Date: 2009-12-23 11:18 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/94feb5bd31bd 6912628: test/java/util/jar/JarFile/TurkCert.java cannot be run in samevm mode Summary: Added tag to run this test in othervm Reviewed-by: chegar ! test/java/util/jar/JarFile/TurkCert.java Changeset: 4a062158d2c5 Author: andrew Date: 2009-12-23 17:17 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4a062158d2c5 6912893: (build) make/java/nio/FILES_java.gmk doesn't list sun.nio.cs.Unicode Summary: Add missing Java source file Reviewed-by: alanb ! make/java/nio/FILES_java.gmk Changeset: 49bc2b443eca Author: dl Date: 2009-12-23 15:57 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/49bc2b443eca 6908348: java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java get OOME for unbounded queues Reviewed-by: martin, dholmes ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java Changeset: 6a80c535f02e Author: weijun Date: 2009-12-24 13:56 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6a80c535f02e 6843127: krb5 should not try to access unavailable kdc too often Reviewed-by: valeriep, mullan ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/KrbKdcReq.java ! src/share/lib/security/java.security + test/sun/security/krb5/auto/BadKdc.java + test/sun/security/krb5/auto/BadKdc1.java + test/sun/security/krb5/auto/BadKdc2.java + test/sun/security/krb5/auto/BadKdc3.java + test/sun/security/krb5/auto/BadKdc4.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/OneKDC.java Changeset: 91c3cabb3d32 Author: weijun Date: 2009-12-24 13:56 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/91c3cabb3d32 6907425: JCK Kerberos tests fail since b77 Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/EncryptionKey.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/MoreKvno.java Changeset: ef9774dc4f5a Author: weijun Date: 2010-01-05 10:40 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ef9774dc4f5a 6895424: RFC 5653 Reviewed-by: valeriep ! src/share/classes/org/ietf/jgss/GSSName.java ! src/share/classes/sun/security/jgss/GSSManagerImpl.java ! src/share/classes/sun/security/jgss/GSSNameImpl.java ! src/share/classes/sun/security/jgss/GSSUtil.java ! src/share/classes/sun/security/jgss/wrapper/GSSNameElement.java + test/sun/security/krb5/auto/Test5653.java Changeset: c028d78fa438 Author: weijun Date: 2010-01-05 10:40 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/c028d78fa438 6913636: kvno check in JSSE Reviewed-by: valeriep ! src/share/classes/sun/security/ssl/krb5/KerberosClientKeyExchangeImpl.java ! test/sun/security/krb5/auto/SSL.java Changeset: 918920710d65 Author: jcoomes Date: 2010-01-13 15:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/918920710d65 Merge - src/share/classes/sun/dyn/util/BytecodeSignature.java Changeset: 756ab2266ffb Author: katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/756ab2266ffb Added tag jdk7-b79 for changeset 918920710d65 ! .hgtags From john.coomes at sun.com Thu Jan 14 20:52:29 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 15 Jan 2010 04:52:29 +0000 Subject: hg: jdk7/hotspot/langtools: 7 new changesets Message-ID: <20100115045251.B164E4163C@hg.openjdk.java.net> Changeset: ff823a039e16 Author: darcy Date: 2009-12-10 20:35 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/ff823a039e16 6909538: Clarify meaning of "element" in javax.lang.model.element API Reviewed-by: ahe ! src/share/classes/javax/lang/model/element/package-info.java Changeset: 4011f49b4af8 Author: jjg Date: 2009-12-11 14:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/4011f49b4af8 6906175: bridge JSR199 and JSR 203 APIs Reviewed-by: darcy, alanb ! make/build.properties ! make/build.xml ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java - src/share/classes/com/sun/tools/javac/file/CloseableURLClassLoader.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java + src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java + src/share/classes/com/sun/tools/javac/nio/PathFileManager.java + src/share/classes/com/sun/tools/javac/nio/PathFileObject.java + src/share/classes/com/sun/tools/javac/util/BaseFileManager.java + src/share/classes/com/sun/tools/javac/util/CloseableURLClassLoader.java ! src/share/classes/javax/tools/StandardJavaFileManager.java + test/tools/javac/nio/compileTest/CompileTest.java + test/tools/javac/nio/compileTest/HelloPathWorld.java Changeset: fbeb560f39e7 Author: jjg Date: 2009-12-12 09:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/fbeb560f39e7 6907575: [classfile] add support for classfile dependency analysis Reviewed-by: ksrini + src/share/classes/com/sun/tools/classfile/Dependencies.java + src/share/classes/com/sun/tools/classfile/Dependency.java + test/tools/javap/classfile/deps/GetDeps.java + test/tools/javap/classfile/deps/T6907575.java + test/tools/javap/classfile/deps/T6907575.out + test/tools/javap/classfile/deps/p/C1.java Changeset: 0666a8f87661 Author: jjg Date: 2009-12-15 13:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/0666a8f87661 6910317: [classfile] typo and other issues in Dependency classes Reviewed-by: ksrini ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/classfile/Dependency.java ! test/tools/javap/classfile/deps/GetDeps.java Changeset: 96c71cbc544b Author: darcy Date: 2009-12-18 11:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/96c71cbc544b 6911854: Update TestElementsAnnotatedWith.java to use @compile/proc Reviewed-by: jjg ! test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java Changeset: ac5b4c5644ce Author: tbell Date: 2009-12-19 10:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/ac5b4c5644ce Merge - src/share/classes/com/sun/tools/javac/file/CloseableURLClassLoader.java Changeset: f0074aa48d4e Author: katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/f0074aa48d4e Added tag jdk7-b79 for changeset ac5b4c5644ce ! .hgtags From y.s.ramakrishna at sun.com Sun Jan 17 04:24:40 2010 From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com) Date: Sun, 17 Jan 2010 12:24:40 +0000 Subject: hg: jdk7/hotspot/hotspot: 6 new changesets Message-ID: <20100117122500.5B1E0419FD@hg.openjdk.java.net> Changeset: 2dd52dea6d28 Author: johnc Date: 2010-01-12 14:56 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/2dd52dea6d28 6902115: G1:assert(ignore_max_completed||thread->is_Java_thread()||SafepointSynchronize::is_at_safepoint()) Summary: Remove invalid assert and mangle filler objects in TLABs that are being retired. Reviewed-by: ysr, jmasa ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/threadLocalAllocBuffer.inline.hpp Changeset: 7b0e9cba0307 Author: ysr Date: 2010-01-13 15:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/7b0e9cba0307 6896647: card marks can be deferred too long Summary: Deferred card marks are now flushed during the gc prologue. Parallel[Scavege,OldGC] and SerialGC no longer defer card marks generated by COMPILER2 as a result of ReduceInitialCardMarks. For these cases, introduced a diagnostic option to defer the card marks, only for the purposes of testing and diagnostics. CMS and G1 continue to defer card marks. Potential performance concern related to single-threaded flushing of deferred card marks in the gc prologue will be addressed in the future. Reviewed-by: never, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 0c1bf505f7a2 Author: tonyp Date: 2010-01-13 15:46 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/0c1bf505f7a2 6916652: G1: remove +UseG1GC from under experimental options Summary: What the title says. Reviewed-by: ysr, jmasa ! src/share/vm/runtime/globals.hpp Changeset: 22e27cceb7d8 Author: tonyp Date: 2010-01-14 09:20 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/22e27cceb7d8 Merge ! src/share/vm/runtime/globals.hpp Changeset: 09646c4656ca Author: johnc Date: 2010-01-13 15:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001 Summary: When enqueuing a completed PtrQueue buffer, cache a local pointer to the buffer and clear the field in the PtrQueue prior to unlocking the mutex referenced by the _lock field and pass the cached local value to the enqueuing routine. This will prevent the same completed buffer being enqueued multiple times, which causes the hang. Reviewed-by: ysr ! src/share/vm/gc_implementation/g1/ptrQueue.cpp - src/share/vm/gc_implementation/g1/ptrQueue.inline.hpp Changeset: c4d722788ed6 Author: ysr Date: 2010-01-16 23:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c4d722788ed6 Merge - src/share/vm/gc_implementation/g1/ptrQueue.inline.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/runtime/globals.hpp From aph at redhat.com Tue Jan 19 08:10:37 2010 From: aph at redhat.com (Andrew Haley) Date: Tue, 19 Jan 2010 16:10:37 +0000 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <448B68EA-1FE2-430C-A534-A8598652C046@Sun.COM> References: <4B1FC407.6010405@redhat.com> <4B477E05.5050207@redhat.com> <4B486278.9040005@redhat.com> <448B68EA-1FE2-430C-A534-A8598652C046@Sun.COM> Message-ID: <4B55D97D.4020001@redhat.com> On 01/11/2010 08:36 PM, Tom Rodriguez wrote: > > On Jan 9, 2010, at 3:03 AM, Andrew Haley wrote: > >> On 01/08/2010 07:54 PM, Tom Rodriguez wrote: >> >>> I think a better fix is to add the required gHotSpot* symbols to the >>> mapfile so that they are always exported. >> >> I'm not sure this will work on all GNU/Linux distros, since symtabs >> are routinely removed in their entirety from DSOs. Is there some >> logic in the symtab handling to do a look-aside into the dynamic >> symtab instead of the symtab? > The solaris libproc does this and I assumed that the linux code we > wrote would also do this but it looks to me like it doesn't. I > don't think it would be hard to add support for parsing the dynsym > table in build_symtab and it would allow these tools to work if the > libraries are commonly stripped. The code could either be modified > to look for SHT_DYNSYM if SHT_SYMTAB doesn't exist or it could > always parse both of them. Something limited like this works ok: OK, I added that. I also had to add these + _ZTV20ParallelScavengeHeap; + _ZTV16GenCollectedHeap; to the list of exported symbols. Without this jmap doesn't work. >> Also, are these the only symbols that are ever looked up by this >> symtab reader? > Those are the only ones needed by the core SA functionality. The > only thing other symbols are used for is the jstack -m mode that > dumps mixed Java and native frames ala pstack and adding the > external debug info reader to support this seems reasonable. OK. I guess this will work, but on my x86_64 Linux box ptrace_getregs is disabled, so jstack -m fails. There's a new webrev at http://cr.openjdk.java.net/~aph/100028-jdk6-webrev-2/ I can confirm that jmap -heap works with and without debuginfo, whether or not the libraries are stripped. Andrew. From Thomas.Rodriguez at Sun.COM Tue Jan 19 11:43:09 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Tue, 19 Jan 2010 11:43:09 -0800 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <4B55D97D.4020001@redhat.com> References: <4B1FC407.6010405@redhat.com> <4B477E05.5050207@redhat.com> <4B486278.9040005@redhat.com> <448B68EA-1FE2-430C-A534-A8598652C046@Sun.COM> <4B55D97D.4020001@redhat.com> Message-ID: <5D1BE1E0-B1D9-465F-A29F-A46802BD7F43@Sun.COM> > OK, I added that. > > I also had to add these > > + _ZTV20ParallelScavengeHeap; > + _ZTV16GenCollectedHeap; > > to the list of exported symbols. Without this jmap doesn't work. The SA does use vtables to dynamically identify the type of some objects and these are needed for that. Looking at the way this works on Windows, it has a build script, make/windows/build_vm_def.sh, that exports all vtables globally so that this is guaranteed to work on a product binary without having to explicitly enumerate the needed vtables. On solaris we never strip libjvm.so so we haven't worried about explicitly exporting everything, though we do explicitly export a few things in make/solaris/makefiles/mapfiles-vers-COMPILER[12] but I believe that is for dtrace. If you'd like the SA tools to work reliably even when stripped you might need to add something to the build process that adds all of the vtables like windows does. We don't have a good way to enumerate all the ones that are needed. I'd really prefer it if we didn't need to rely on the symbol table at all for the vtables. I think it might be possible to build the vtable lookup logic into vmStructs.cpp but that's a bigger change and I'm not totally sure how it would work. One thing to keep in mind with your testing is that some of the tools use JVMTI for live processes instead of going through the SA. For instance, I believe jstack will use JVMTI unless you use the -F option, though the -m option requires using the SA code. So do you want to pursue making the SA work with a stripped libjvm.so or is requiring debug info to be installed acceptable? Sorry if I made this more complicated than you wanted. I think your original change is fine, but if the norm is being stripped then making these tools work in that situation would be good. tom > >>> Also, are these the only symbols that are ever looked up by this >>> symtab reader? > >> Those are the only ones needed by the core SA functionality. The >> only thing other symbols are used for is the jstack -m mode that >> dumps mixed Java and native frames ala pstack and adding the >> external debug info reader to support this seems reasonable. > > OK. I guess this will work, but on my x86_64 Linux box ptrace_getregs > is disabled, so jstack -m fails. > > There's a new webrev at > http://cr.openjdk.java.net/~aph/100028-jdk6-webrev-2/ > > I can confirm that jmap -heap works with and without debuginfo, > whether or not the libraries are stripped. > > Andrew. From erik.trimble at sun.com Tue Jan 19 14:23:46 2010 From: erik.trimble at sun.com (erik.trimble at sun.com) Date: Tue, 19 Jan 2010 22:23:46 +0000 Subject: hg: jdk7/hotspot/hotspot: 4 new changesets Message-ID: <20100119222359.6F95341DB4@hg.openjdk.java.net> Changeset: 1bc68593a110 Author: katleman Date: 2010-01-14 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/1bc68593a110 Added tag jdk7-b79 for changeset a5a6adfca6ec ! .hgtags Changeset: d749b1813f40 Author: trims Date: 2010-01-15 14:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/d749b1813f40 Merge Changeset: 3003ddd1d433 Author: trims Date: 2010-01-15 14:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/3003ddd1d433 6917463: Bump the HS17 build number to 07 Summary: Update the HS17 build number to 07 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 5b00c9feb9ea Author: trims Date: 2010-01-19 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/5b00c9feb9ea Merge - src/share/vm/gc_implementation/g1/ptrQueue.inline.hpp From aph at redhat.com Wed Jan 20 02:16:00 2010 From: aph at redhat.com (Andrew Haley) Date: Wed, 20 Jan 2010 10:16:00 +0000 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <5D1BE1E0-B1D9-465F-A29F-A46802BD7F43@Sun.COM> References: <4B1FC407.6010405@redhat.com> <4B477E05.5050207@redhat.com> <4B486278.9040005@redhat.com> <448B68EA-1FE2-430C-A534-A8598652C046@Sun.COM> <4B55D97D.4020001@redhat.com> <5D1BE1E0-B1D9-465F-A29F-A46802BD7F43@Sun.COM> Message-ID: <4B56D7E0.6020702@redhat.com> On 01/19/2010 07:43 PM, Tom Rodriguez wrote: > So do you want to pursue making the SA work with a stripped > libjvm.so or is requiring debug info to be installed acceptable? > Sorry if I made this more complicated than you wanted. I think your > original change is fine, but if the norm is being stripped then > making these tools work in that situation would be good. Clearly it would be. Java programmers on Linux systems aren't used to installing debuginfo, so it would be better all round if these tools were to work without it. (And besides, the idea that the Windows port might be better in any way irks me!) I'll have a look. Andrew. From Thomas.Rodriguez at Sun.COM Wed Jan 20 09:35:34 2010 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Wed, 20 Jan 2010 09:35:34 -0800 Subject: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files In-Reply-To: <4B56D7E0.6020702@redhat.com> References: <4B1FC407.6010405@redhat.com> <4B477E05.5050207@redhat.com> <4B486278.9040005@redhat.com> <448B68EA-1FE2-430C-A534-A8598652C046@Sun.COM> <4B55D97D.4020001@redhat.com> <5D1BE1E0-B1D9-465F-A29F-A46802BD7F43@Sun.COM> <4B56D7E0.6020702@redhat.com> Message-ID: <401A9C44-0A14-49AB-A771-A049BC04AE12@Sun.COM> On Jan 20, 2010, at 2:16 AM, Andrew Haley wrote: > On 01/19/2010 07:43 PM, Tom Rodriguez wrote: > >> So do you want to pursue making the SA work with a stripped >> libjvm.so or is requiring debug info to be installed acceptable? >> Sorry if I made this more complicated than you wanted. I think your >> original change is fine, but if the norm is being stripped then >> making these tools work in that situation would be good. > > Clearly it would be. Java programmers on Linux systems aren't used to > installing debuginfo, so it would be better all round if these tools > were to work without it. (And besides, the idea that the Windows port > might be better in any way irks me!) I'll have a look. So the brute force approach is to make all vtables visible in the dynamic symbol table. A more limited approach would be to make only the vtables of types mentioned in vmStructs.cpp available. A script that looked for declare_toplevel_type and declare_type could select interesting types but not all of those would have vtables so comparison with the real symbol table would be needed. That would complicate the build a though. The list would be slowly changing so we could check it in and only verify that it's still valid after the link. It's kind of complicated so maybe just exporting them all is easier. tom > > Andrew. From igor.veresov at sun.com Wed Jan 20 15:07:42 2010 From: igor.veresov at sun.com (igor.veresov at sun.com) Date: Wed, 20 Jan 2010 23:07:42 +0000 Subject: hg: jdk7/hotspot/hotspot: 8 new changesets Message-ID: <20100120230808.A9AF741F4E@hg.openjdk.java.net> Changeset: b2b6a9bf6238 Author: cfang Date: 2010-01-12 14:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2 Summary: Loop predication implementation Reviewed-by: never, kvn ! src/share/vm/includeDB_compiler2 ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp Changeset: 73b22f919c34 Author: jrose Date: 2010-01-13 23:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/73b22f919c34 6912065: final fields in objects need to support inlining optimizations for JSR 292 Reviewed-by: twisti, kvn ! src/share/vm/ci/ciField.cpp ! src/share/vm/runtime/globals.hpp Changeset: ddb7834449d0 Author: never Date: 2010-01-15 11:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/ddb7834449d0 6849984: Value methods for platform dependent math functions constant fold incorrectly Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/interpreter_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: 614b7e3a9f48 Author: never Date: 2010-01-15 16:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/614b7e3a9f48 6879943: CTW failure jdk6_18/hotspot/src/share/vm/c1/c1_LIR.hpp:2029 Reviewed-by: kvn, cfang ! src/share/vm/c1/c1_LIR.hpp Changeset: d11ce1551e8d Author: twisti Date: 2010-01-18 05:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/d11ce1551e8d 6917698: os::is_allocatable Zero fix for 32-bit platforms Summary: Recent changes call os::is_allocatable which was not implemented in Zero. Reviewed-by: twisti Contributed-by: Edward Nevill ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp Changeset: acebf2655d3a Author: kvn Date: 2010-01-19 10:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/acebf2655d3a 6917931: compiler/6895383/Test.java don't compile due missed imports Summary: Add missing imports. Reviewed-by: never, twisti ! test/compiler/6895383/Test.java Changeset: 648fe315b257 Author: kvn Date: 2010-01-19 15:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/648fe315b257 6893701: compiler/6877254/Test.java fails because it combines -XX:+UseConcMarkSweepGC with other GC Summary: Remove explicit GC flags in regression tests Reviewed-by: never, ysr ! test/compiler/6877254/Test.java ! test/compiler/6896727/Test.java Changeset: 3d6016e040d6 Author: iveresov Date: 2010-01-20 12:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/3d6016e040d6 Merge ! src/share/vm/runtime/globals.hpp From jandam at crcdata.cz Wed Jan 20 23:45:11 2010 From: jandam at crcdata.cz (Janda Martin) Date: Thu, 21 Jan 2010 08:45:11 +0100 (CET) Subject: SIGSEGV on GCTaskThread in jdk 6u18 In-Reply-To: <2835755.271264059889328.JavaMail.root@zs.crcpraha> Message-ID: <19970429.291264059911094.JavaMail.root@zs.crcpraha> Please can you help me. I experienced several crashes on GCTaskThread in latest Java6u18 when running IntelliJ IDEA (not only). 64bit linux, 32bit jvm, 4 core processor I create new bug report with Review ID: 1699960. Is there any -XX options to help diagnose this problem. It looks like regression from 6u17 (maybe) or 6u16 (sure). hs_err log files are attached. Thank you. Martin -------------- next part -------------- A non-text attachment was scrubbed... Name: hs_err_logs_2010-01-21.zip Type: application/zip Size: 33620 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20100121/0f8fc14a/attachment-0001.zip From andreas.kohn at fredhopper.com Thu Jan 21 00:24:25 2010 From: andreas.kohn at fredhopper.com (Andreas Kohn) Date: Thu, 21 Jan 2010 09:24:25 +0100 Subject: SIGSEGV on GCTaskThread in jdk 6u18 In-Reply-To: <19970429.291264059911094.JavaMail.root@zs.crcpraha> References: <19970429.291264059911094.JavaMail.root@zs.crcpraha> Message-ID: <1264062265.2371.29.camel@tiamaria.ams.fredhopper.com> On Thu, 2010-01-21 at 08:45 +0100, Janda Martin wrote: > Please can you help me. I experienced several crashes on GCTaskThread in latest Java6u18 when running IntelliJ IDEA (not only). 64bit linux, 32bit jvm, 4 core processor > I create new bug report with Review ID: 1699960. > > Is there any -XX options to help diagnose this problem. It looks like regression from 6u17 (maybe) or 6u16 (sure). We observed a very similar 6u18 crash (once so far), 64bit linux, 64bit jvm. I have attached our hs_err log as well. Regards, -- Andreas -- Never attribute to malice that which can be adequately explained by stupidity. -- Hanlon's Razor -------------- next part -------------- A non-text attachment was scrubbed... Name: hs_err_pid23845.log Type: text/x-log Size: 54587 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20100121/da0852a8/attachment-0002.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part Url : http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20100121/da0852a8/attachment-0003.bin From Vladimir.Kozlov at Sun.COM Thu Jan 21 01:03:01 2010 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Thu, 21 Jan 2010 01:03:01 -0800 Subject: SIGSEGV on GCTaskThread in jdk 6u18 In-Reply-To: <1264062265.2371.29.camel@tiamaria.ams.fredhopper.com> References: <19970429.291264059911094.JavaMail.root@zs.crcpraha> <1264062265.2371.29.camel@tiamaria.ams.fredhopper.com> Message-ID: <4B581845.8020507@sun.com> Try -XX:-ReduceInitialCardMarks Please, read release notes for 6u18. Vladimir On 1/21/10 12:24 AM, Andreas Kohn wrote: > On Thu, 2010-01-21 at 08:45 +0100, Janda Martin wrote: >> Please can you help me. I experienced several crashes on GCTaskThread in latest Java6u18 when running IntelliJ IDEA (not only). 64bit linux, 32bit jvm, 4 core processor >> I create new bug report with Review ID: 1699960. >> >> Is there any -XX options to help diagnose this problem. It looks like regression from 6u17 (maybe) or 6u16 (sure). > > We observed a very similar 6u18 crash (once so far), 64bit linux, 64bit > jvm. > > I have attached our hs_err log as well. > > Regards, > -- > Andreas > From jandam at crcdata.cz Thu Jan 21 01:16:28 2010 From: jandam at crcdata.cz (Janda Martin) Date: Thu, 21 Jan 2010 10:16:28 +0100 (CET) Subject: SIGSEGV on GCTaskThread in jdk 6u18 In-Reply-To: <4B581845.8020507@sun.com> Message-ID: <9555002.581264065388011.JavaMail.root@zs.crcpraha> Thank you for fast response. I supposed that I use Serial GC so this problem is different. I will try ReduceInitialCardMarks Martin ----- Original Message ----- From: "Vladimir Kozlov" To: hotspot-dev at openjdk.java.net Sent: Thursday, January 21, 2010 10:03:01 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: SIGSEGV on GCTaskThread in jdk 6u18 Try -XX:-ReduceInitialCardMarks Please, read release notes for 6u18. Vladimir On 1/21/10 12:24 AM, Andreas Kohn wrote: > On Thu, 2010-01-21 at 08:45 +0100, Janda Martin wrote: >> Please can you help me. I experienced several crashes on GCTaskThread in latest Java6u18 when running IntelliJ IDEA (not only). 64bit linux, 32bit jvm, 4 core processor >> I create new bug report with Review ID: 1699960. >> >> Is there any -XX options to help diagnose this problem. It looks like regression from 6u17 (maybe) or 6u16 (sure). > > We observed a very similar 6u18 crash (once so far), 64bit linux, 64bit > jvm. > > I have attached our hs_err log as well. > > Regards, > -- > Andreas > From Y.S.Ramakrishna at Sun.COM Thu Jan 21 07:53:50 2010 From: Y.S.Ramakrishna at Sun.COM (Y. Srinivas Ramakrishna) Date: Thu, 21 Jan 2010 07:53:50 -0800 Subject: SIGSEGV on GCTaskThread in jdk 6u18 In-Reply-To: <9555002.581264065388011.JavaMail.root@zs.crcpraha> References: <9555002.581264065388011.JavaMail.root@zs.crcpraha> Message-ID: <4B58788E.2060403@sun.com> Janda Martin wrote: > Thank you for fast response. I supposed that I use Serial GC so this problem is different. Unless you specify it explicitly via -XX:+UseSerialGC, the GC ergonomics might pick a different collector, and in this case it picked parallel gc because yr machine was considered a "server class" machine (or some such) because you had 8 cores on yr box. > > I will try ReduceInitialCardMarks Yes either that, or explicitly specify serial gc. In your case, since you have 8 cores, you should use -ReduceInitialCardMarks and continue using the parallel collector you are getting by default. Indeed you might want to specify -XX:+UseParallelOldGC which i think you aren't getting by default (i wonder why; i thought that was the parallel collector default now, but haven't checked recently). -- ramki > > Martin > > ----- Original Message ----- > From: "Vladimir Kozlov" > To: hotspot-dev at openjdk.java.net > Sent: Thursday, January 21, 2010 10:03:01 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: SIGSEGV on GCTaskThread in jdk 6u18 > > Try -XX:-ReduceInitialCardMarks > > Please, read release notes for 6u18. > > Vladimir > > On 1/21/10 12:24 AM, Andreas Kohn wrote: >> On Thu, 2010-01-21 at 08:45 +0100, Janda Martin wrote: >>> Please can you help me. I experienced several crashes on GCTaskThread in latest Java6u18 when running IntelliJ IDEA (not only). 64bit linux, 32bit jvm, 4 core processor >>> I create new bug report with Review ID: 1699960. >>> >>> Is there any -XX options to help diagnose this problem. It looks like regression from 6u17 (maybe) or 6u16 (sure). >> We observed a very similar 6u18 crash (once so far), 64bit linux, 64bit >> jvm. >> >> I have attached our hs_err log as well. >> >> Regards, >> -- >> Andreas >> From john.coomes at sun.com Thu Jan 21 20:33:31 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 22 Jan 2010 04:33:31 +0000 Subject: hg: jdk7/hotspot: 3 new changesets Message-ID: <20100122043332.168B5414DF@hg.openjdk.java.net> Changeset: 432cbbdc44bc Author: andrew Date: 2010-01-07 23:17 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/432cbbdc44bc 6914986: Make sure openjdk doc generation not turned off with JDK_UPDATE_VERSION Summary: Only turn off documentation for updates when not building OpenJDK Reviewed-by: ohair ! make/Defs-internal.gmk Changeset: a3242906c774 Author: mikejwre Date: 2010-01-20 17:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/a3242906c774 Merge Changeset: 8403096d1fe7 Author: mikejwre Date: 2010-01-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/8403096d1fe7 Added tag jdk7-b80 for changeset a3242906c774 ! .hgtags From john.coomes at sun.com Thu Jan 21 20:33:41 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 22 Jan 2010 04:33:41 +0000 Subject: hg: jdk7/hotspot/corba: 3 new changesets Message-ID: <20100122043347.07812414E0@hg.openjdk.java.net> Changeset: d4c077d44a64 Author: andrew Date: 2010-01-16 01:04 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/d4c077d44a64 6917485: Corba doc warnings Summary: Fix warnings generated by javadoc Reviewed-by: darcy ! src/share/classes/com/sun/tools/corba/se/idl/constExpr/Expression.java ! src/share/classes/javax/rmi/PortableRemoteObject.java ! src/share/classes/org/omg/CORBA/SetOverrideType.java ! src/share/classes/org/omg/CORBA/TCKind.java ! src/share/classes/org/omg/CORBA/UnknownUserException.java ! src/share/classes/org/omg/CORBA/portable/ServantObject.java ! src/share/classes/org/omg/CosNaming/nameservice.idl ! src/share/classes/org/omg/PortableInterceptor/Interceptors.idl Changeset: 0336e70ca0ae Author: mikejwre Date: 2010-01-20 17:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/0336e70ca0ae Merge Changeset: e08a42a2a94d Author: mikejwre Date: 2010-01-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/e08a42a2a94d Added tag jdk7-b80 for changeset 0336e70ca0ae ! .hgtags From john.coomes at sun.com Thu Jan 21 20:37:13 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 22 Jan 2010 04:37:13 +0000 Subject: hg: jdk7/hotspot/jaxp: Added tag jdk7-b80 for changeset 9219574db593 Message-ID: <20100122043713.4586A414E2@hg.openjdk.java.net> Changeset: 204e59d488cd Author: mikejwre Date: 2010-01-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/204e59d488cd Added tag jdk7-b80 for changeset 9219574db593 ! .hgtags From john.coomes at sun.com Thu Jan 21 20:37:18 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 22 Jan 2010 04:37:18 +0000 Subject: hg: jdk7/hotspot/jaxws: Added tag jdk7-b80 for changeset 447767dee56a Message-ID: <20100122043719.358B7414E3@hg.openjdk.java.net> Changeset: f051045fe94a Author: mikejwre Date: 2010-01-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/f051045fe94a Added tag jdk7-b80 for changeset 447767dee56a ! .hgtags From john.coomes at sun.com Thu Jan 21 20:38:43 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 22 Jan 2010 04:38:43 +0000 Subject: hg: jdk7/hotspot/jdk: 27 new changesets Message-ID: <20100122044740.1B631414E6@hg.openjdk.java.net> Changeset: b428c8f80209 Author: jgodinez Date: 2010-01-15 09:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b428c8f80209 6915906: tests in closed/javax/print/ should not be calling System.exit() Reviewed-by: igor, prr ! test/ProblemList.txt + test/javax/print/DialogMargins.java + test/javax/print/StreamPrintingOrientation.java + test/javax/print/attribute/AttributeTest.java + test/javax/print/attribute/ServiceDialogTest.java ! test/javax/print/attribute/SidesPageRangesTest.java Changeset: 9956e8d71e06 Author: tbell Date: 2009-12-18 09:40 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9956e8d71e06 6899737: JDK build fails in make/java/jli because of _vsnprintf macro redefinition Summary: Use stdio.h instead when building with Visual Studio 2008 or later Reviewed-by: art, ohair ! src/share/native/java/util/zip/zlib-1.2.3/zutil.h Changeset: 39b9564ff01c Author: ohair Date: 2010-01-05 15:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/39b9564ff01c Merge Changeset: 447c9e535234 Author: ohair Date: 2010-01-13 15:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/447c9e535234 Merge Changeset: e0905e36766a Author: yhuang Date: 2009-12-06 22:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e0905e36766a 6868106: Ukrainian currency has wrong format Reviewed-by: yhuang, peytoia ! src/share/classes/sun/text/resources/FormatData_uk.java ! src/share/classes/sun/util/resources/CurrencyNames_uk_UA.properties ! test/sun/text/resources/LocaleData Changeset: d9080b33ba74 Author: yhuang Date: 2009-12-08 21:14 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d9080b33ba74 6610748: Dateformat - AM-PM indicator in Finnish appears to be from English Reviewed-by: yhuang, peytoia ! src/share/classes/sun/text/resources/FormatData_fi.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: ac9e284db030 Author: yhuang Date: 2009-12-08 21:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ac9e284db030 6645271: Wrong date format for Croatian (hr) locale Reviewed-by: yhuang, peytoia ! src/share/classes/sun/text/resources/FormatData_hr_HR.java Changeset: 3ab178316aa0 Author: yhuang Date: 2009-12-08 21:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3ab178316aa0 6609737: DateFormat incorrect for German locale Reviewed-by: yhuang, peytoia ! src/share/classes/sun/text/resources/FormatData_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java Changeset: 4910b580a725 Author: yhuang Date: 2009-12-08 21:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/4910b580a725 6507067: TimeZone country/area message error Reviewed-by: peytoia ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java Changeset: 06df47459ecf Author: yhuang Date: 2009-12-10 17:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/06df47459ecf 6873931: New Turkish currency since 2009 Reviewed-by: yhuang, peytoia ! src/share/classes/sun/util/resources/CurrencyNames_tr_TR.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: ddc4a80f25f4 Author: yhuang Date: 2009-12-17 02:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ddc4a80f25f4 6450945: The week day for Saturday and the first week day in Romania locale are incorrect Reviewed-by: yhuang, peytoia ! src/share/classes/sun/text/resources/FormatData_ro.java ! src/share/classes/sun/util/resources/CalendarData_ro.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: cd5d46887546 Author: yhuang Date: 2009-12-17 02:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/cd5d46887546 6645268: Country/language names with locale fi_FI are incorrect for FRANCE/FRENCH Reviewed-by: yhuang, peytoia ! src/share/classes/sun/util/resources/LocaleNames_fi.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java ! test/sun/util/resources/Locale/Bug4429024.java Changeset: 946a0a09a477 Author: yhuang Date: 2009-12-17 02:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/946a0a09a477 6646611: Incorrect spelling of month name in locale for Belarusian language ("be", "BY") Reviewed-by: yhuang, peytoia ! src/share/classes/sun/text/resources/FormatData_be.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: e8fa2b2cb1e8 Author: yhuang Date: 2009-12-17 22:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e8fa2b2cb1e8 6650730: Lithuanian locale date and number formats mismatch. Reviewed-by: yhuang, peytoia ! src/share/classes/sun/text/resources/FormatData_lt.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: e9b09f76d281 Author: yhuang Date: 2009-12-17 22:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e9b09f76d281 6645405: Errors in Hungarian local-specific formatting. (L10N part of 6609703) Reviewed-by: yhuang, peytoia ! src/share/classes/sun/text/resources/FormatData_hu_HU.java Changeset: 3b78f3769688 Author: yhuang Date: 2009-12-20 19:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/3b78f3769688 6910489: Slovenia Locale, wrong firstDayOfWeek number Reviewed-by: yhuang, peytoia ! src/share/classes/sun/util/resources/CalendarData_sl.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: b09e582d09bd Author: yhuang Date: 2009-12-20 19:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b09e582d09bd 6573250: Java.util.Currency.getSymbol(Locale) returns wrong value when locale is not US. Reviewed-by: yhuang, peytoia ! src/share/classes/sun/util/resources/CurrencyNames_en_CA.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 7bf839e2e9ce Author: yhuang Date: 2009-12-24 15:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7bf839e2e9ce 6870908: reopen bug 4244752: month names in Estonian should be lowercase Reviewed-by: yhuang, peytoia ! src/share/classes/sun/text/resources/FormatData_et.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 1397ae8dc558 Author: yhuang Date: 2009-12-24 16:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1397ae8dc558 6541350: TimeZone display names localization Reviewed-by: yhuang, peytoia ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java Changeset: 2886607f8bc3 Author: yhuang Date: 2009-12-28 14:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/2886607f8bc3 6585666: Spanish language names not compliant with CLDR Reviewed-by: yhuang, peytoia ! src/share/classes/sun/util/resources/LocaleNames_es.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 5ec5337c0298 Author: yhuang Date: 2010-01-05 18:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/5ec5337c0298 6716626: Integrate contributed language and country names for NL Reviewed-by: yhuang, peytoia ! src/share/classes/sun/util/resources/LocaleNames_nl.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 8bf6b2173e9f Author: yhuang Date: 2010-01-06 17:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/8bf6b2173e9f 6914413: abbreviation name for November is not correct in be_BY Reviewed-by: yhuang, peytoia ! src/share/classes/sun/text/resources/FormatData_be.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: eea1cc096889 Author: yhuang Date: 2010-01-06 19:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/eea1cc096889 6821191: Timezone display name localization Reviewed-by: yhuang, ogino ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java Changeset: eff93f451501 Author: yhuang Date: 2010-01-11 23:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/eff93f451501 Merge - make/tools/CharsetMapping/DoubleByte-X.java - make/tools/CharsetMapping/SingleByte-X.java - src/share/classes/javax/swing/plaf/synth/DefaultMenuLayout.java - src/share/classes/sun/awt/ComponentAccessor.java - src/share/classes/sun/awt/WindowAccessor.java - src/share/classes/sun/security/provider/IdentityDatabase.java - src/share/classes/sun/security/provider/SystemIdentity.java - src/share/classes/sun/security/provider/SystemSigner.java - src/share/classes/sun/security/x509/X500Signer.java - src/share/classes/sun/security/x509/X509Cert.java - src/share/classes/sun/swing/plaf/synth/SynthUI.java - src/share/classes/sun/tools/jar/JarVerifierStream.java - src/share/classes/sun/util/CoreResourceBundleControl-XLocales.java - src/share/classes/sun/util/LocaleDataMetaInfo-XLocales.java - test/java/util/Formatter/Basic-X.java - test/sun/tools/native2ascii/test2 - test/tools/launcher/SolarisDataModel.sh - test/tools/launcher/SolarisRunpath.sh - test/tools/launcher/libraryCaller.c - test/tools/launcher/libraryCaller.h - test/tools/launcher/libraryCaller.java Changeset: d91c6bdcc852 Author: yhuang Date: 2010-01-17 18:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d91c6bdcc852 Merge Changeset: 049cfaaa9a73 Author: mikejwre Date: 2010-01-20 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/049cfaaa9a73 Merge Changeset: 15815a54d930 Author: mikejwre Date: 2010-01-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/15815a54d930 Added tag jdk7-b80 for changeset 049cfaaa9a73 ! .hgtags From john.coomes at sun.com Thu Jan 21 20:54:13 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 22 Jan 2010 04:54:13 +0000 Subject: hg: jdk7/hotspot/langtools: Added tag jdk7-b80 for changeset f0074aa48d4e Message-ID: <20100122045421.3760C414EA@hg.openjdk.java.net> Changeset: 250a580ab046 Author: mikejwre Date: 2010-01-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/250a580ab046 Added tag jdk7-b80 for changeset f0074aa48d4e ! .hgtags From coleen.phillimore at sun.com Fri Jan 22 20:01:37 2010 From: coleen.phillimore at sun.com (coleen.phillimore at sun.com) Date: Sat, 23 Jan 2010 04:01:37 +0000 Subject: hg: jdk7/hotspot/hotspot: 3 new changesets Message-ID: <20100123040147.36FCC416C9@hg.openjdk.java.net> Changeset: 7fbf850d87b7 Author: dcubed Date: 2010-01-13 09:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/7fbf850d87b7 6580131: 3/4 CompiledMethodLoad events don't produce the expected extra notifications to describe inlining Summary: Add support for additional implementation specific info to the JVM/TI CompiledMethodLoad event via the compile_info parameter. Reviewed-by: never, ohair, tbell, tdeneau Contributed-by: Vasanth Venkatachalam ! make/Makefile ! make/defs.make + src/share/vm/code/jvmticmlr.h ! src/share/vm/includeDB_core ! src/share/vm/prims/jvmtiExport.cpp Changeset: 3908ad124838 Author: dcubed Date: 2010-01-20 11:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/3908ad124838 Merge ! make/Makefile ! make/defs.make ! src/share/vm/includeDB_core ! src/share/vm/prims/jvmtiExport.cpp Changeset: 2718ec34c699 Author: coleenp Date: 2010-01-22 15:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/2718ec34c699 Merge - src/share/vm/gc_implementation/g1/ptrQueue.inline.hpp From igor.veresov at sun.com Wed Jan 27 21:58:31 2010 From: igor.veresov at sun.com (igor.veresov at sun.com) Date: Thu, 28 Jan 2010 05:58:31 +0000 Subject: hg: jdk7/hotspot/hotspot: 3 new changesets Message-ID: <20100128055841.4689B41E9D@hg.openjdk.java.net> Changeset: cf0685d550f1 Author: never Date: 2010-01-20 22:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/cf0685d550f1 6911204: generated adapters with large signatures can fill up the code cache Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/share/vm/includeDB_core ! src/share/vm/oops/methodOop.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 99af867dfa05 Author: kvn Date: 2010-01-26 08:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/99af867dfa05 6919886: Sweep CodeCache more aggressively to reduce its usage for CompileTheWorld Summary: Add safepoint after CompileTheWorldSafepointInterval (100) compilations and do full sweep of CodeCache each time. Reviewed-by: never Contributed-by: eric.caspole at amd.com ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 89ca5ab4fa60 Author: iveresov Date: 2010-01-27 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/89ca5ab4fa60 Merge ! src/share/vm/includeDB_core From imdupeng at gmail.com Thu Jan 28 10:25:42 2010 From: imdupeng at gmail.com (Peng Du) Date: Thu, 28 Jan 2010 12:25:42 -0600 Subject: C++ Interpreter on 64-bit Linux Message-ID: Hello, Is HotSpot w/ C++ Interpreter currently working on 64-bit Linux (x86_64)? I tried building HotSpot with CC_INTERP=true but encountered this error: /openjdk/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp: In member function 'unsigned char* InterpreterGenerator::generate_abstract_entry()': /openjdk/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:282: error: 'class InterpreterMacroAssembler' has no member named 'empty_expression_stack' /openjdk/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:284: error: 'class InterpreterMacroAssembler' has no member named 'restore_locals' make[6]: *** [interpreter_x86_64.o] Error 1 make[6]: *** Waiting for unfinished jobs.... /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static member function 'static unsigned char* MethodHandles::generate_method_handle_interpreter_entry(MacroAssembler*)': /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:95: error: 'throw_WrongMethodType_entry' is not a member of 'Interpreter' /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static member function 'static void MethodHandles::generate_method_handle_stub(MacroAssembler*, MethodHandles::EntryKind)': /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:404: error: 'throw_WrongMethodType_entry' is not a member of 'Interpreter' make[6]: *** [methodHandles_x86.o] Error 1 make[6]: Leaving directory `/jdk-dist-64-cpp/hotspot/outputdir/linux_amd64_compiler2/product' make[5]: *** [the_vm] Error 2 make[5]: Leaving directory `/jdk-dist-64-cpp/hotspot/outputdir/linux_amd64_compiler2/product' make[4]: *** [product] Error 2 make[4]: Leaving directory `/jdk-dist-64-cpp/hotspot/outputdir' make[3]: *** [generic_build2] Error 2 make[3]: Leaving directory `/openjdk/hotspot/make' make[2]: *** [product] Error 2 make[2]: Leaving directory `/openjdk/hotspot/make' make[1]: *** [hotspot-build] Error 2 make[1]: Leaving directory `/openjdk' make: *** [build_product_image] Error 2 Is there any patch to fix it? Thanks -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20100128/588acd8a/attachment.html From y.s.ramakrishna at sun.com Thu Jan 28 13:47:37 2010 From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com) Date: Thu, 28 Jan 2010 21:47:37 +0000 Subject: hg: jdk7/hotspot/hotspot: 7 new changesets Message-ID: <20100128214806.6638141FA3@hg.openjdk.java.net> Changeset: 4788266644c1 Author: jmasa Date: 2010-01-21 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/4788266644c1 6895236: CMS: cmsOopClosures.inline.hpp:43 assert(..., "Should remember klasses in this context") Summary: Adjust assertion checking for ExplicitGCInvokesConcurrentAndUnloadsClasses as a reason for class unloading Reviewed-by: ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp Changeset: fed17682aea5 Author: ysr Date: 2010-01-21 14:47 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/fed17682aea5 Merge Changeset: 776fb94f33cc Author: apetrusenko Date: 2010-01-21 18:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/776fb94f33cc 6918006: G1: spill space must be reserved on the stack for barrier calls on Windows x64 Summary: Stub code generated to call G1 barriers does not allocate spill space on the stack as required by Windows x64 ABI. The fix is to use more ABI-friendly call_VM_leaf(). Reviewed-by: iveresov, never, kvn ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: c81fa70144aa Author: tonyp Date: 2010-01-25 18:03 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/c81fa70144aa 6919980: G1: remove +UseG1GC from under experimental options (second attempt) Summary: Trying this again, as the original change was lost. Reviewed-by: ysr, jmasa ! src/share/vm/runtime/globals.hpp Changeset: 34fb2662f6c2 Author: ysr Date: 2010-01-26 16:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/34fb2662f6c2 6920090: G1: Disable ReduceInitialCardMarks at least until 6920109 is fixed Summary: G1 now answers "no" to the query can_elide_initializing_store_barrier() in the product build. A debug flag allows alternate behaviour in debug builds. Reviewed-by: iveresov, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_interface/collectedHeap.cpp Changeset: 291c9b3b64fc Author: ysr Date: 2010-01-26 23:36 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/291c9b3b64fc Merge Changeset: f3345b7b01b4 Author: ysr Date: 2010-01-27 22:38 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/hotspot/rev/f3345b7b01b4 Merge ! src/share/vm/runtime/globals.hpp From john.coomes at sun.com Thu Jan 28 20:36:34 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 29 Jan 2010 04:36:34 +0000 Subject: hg: jdk7/hotspot: Added tag jdk7-b81 for changeset 8403096d1fe7 Message-ID: <20100129043634.976C3412EC@hg.openjdk.java.net> Changeset: e1176f86805f Author: mikejwre Date: 2010-01-28 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/rev/e1176f86805f Added tag jdk7-b81 for changeset 8403096d1fe7 ! .hgtags From john.coomes at sun.com Thu Jan 28 20:36:40 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 29 Jan 2010 04:36:40 +0000 Subject: hg: jdk7/hotspot/corba: Added tag jdk7-b81 for changeset e08a42a2a94d Message-ID: <20100129043643.8059A412ED@hg.openjdk.java.net> Changeset: 1e8c1bfad1ab Author: mikejwre Date: 2010-01-28 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/corba/rev/1e8c1bfad1ab Added tag jdk7-b81 for changeset e08a42a2a94d ! .hgtags From john.coomes at sun.com Thu Jan 28 20:40:45 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 29 Jan 2010 04:40:45 +0000 Subject: hg: jdk7/hotspot/jaxp: Added tag jdk7-b81 for changeset 204e59d488cd Message-ID: <20100129044047.94D70412F0@hg.openjdk.java.net> Changeset: c876ad22e4bf Author: mikejwre Date: 2010-01-28 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxp/rev/c876ad22e4bf Added tag jdk7-b81 for changeset 204e59d488cd ! .hgtags From john.coomes at sun.com Thu Jan 28 20:40:53 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 29 Jan 2010 04:40:53 +0000 Subject: hg: jdk7/hotspot/jaxws: Added tag jdk7-b81 for changeset f051045fe94a Message-ID: <20100129044054.34378412F1@hg.openjdk.java.net> Changeset: 31573ae8eed1 Author: mikejwre Date: 2010-01-28 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jaxws/rev/31573ae8eed1 Added tag jdk7-b81 for changeset f051045fe94a ! .hgtags From john.coomes at sun.com Thu Jan 28 20:41:37 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 29 Jan 2010 04:41:37 +0000 Subject: hg: jdk7/hotspot/jdk: 30 new changesets Message-ID: <20100129045125.EB928412F4@hg.openjdk.java.net> Changeset: 7e116fd3a724 Author: ohair Date: 2010-01-04 15:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7e116fd3a724 6910834: TEST: java/io/File/Basic.java fails on Windows CYGWIN environment Reviewed-by: tbell, alanb ! test/java/io/File/Basic.java ! test/java/io/File/basic.sh Changeset: ad19f61a0fa6 Author: ohair Date: 2010-01-04 15:33 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ad19f61a0fa6 6910835: TESTS: 3 java/io run.sh tests fail when run on Windows XP CYGWIN Reviewed-by: tbell, alanb ! test/java/io/Serializable/evolution/RenamePackage/run.sh ! test/java/io/Serializable/serialver/classpath/run.sh ! test/java/io/Serializable/serialver/nested/run.sh Changeset: f9aa7e58974d Author: ohair Date: 2010-01-04 15:36 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f9aa7e58974d 6911113: These tests do not work with CYGWIN: java/nio Reviewed-by: tbell, alanb ! test/java/nio/channels/Selector/lots_of_updates.sh ! test/java/nio/channels/spi/AsynchronousChannelProvider/custom_provider.sh ! test/java/nio/file/Files/walk_file_tree.sh ! test/java/nio/file/Path/delete_on_close.sh Changeset: 7595c6a198d3 Author: ohair Date: 2010-01-04 15:38 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7595c6a198d3 6911117: These tests do not work with CYGWIN: com/sun/jdi Reviewed-by: tbell, alanb ! test/com/sun/jdi/ProcessAttachTest.sh ! test/com/sun/jdi/connect/spi/JdiLoadedByCustomLoader.sh Changeset: caf27afcae8d Author: ohair Date: 2010-01-04 15:41 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/caf27afcae8d 6911131: Test does not work with CYGWIN: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.sh Reviewed-by: tbell, alanb ! test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh Changeset: f86db0646421 Author: ohair Date: 2010-01-04 15:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/f86db0646421 6911112: Tests do not work with CYGWIN: javax/imageio/, javax/script/, and sun/misc/ Reviewed-by: tbell, alanb ! test/javax/imageio/stream/StreamCloserLeak/run_test.sh ! test/javax/script/CommonSetup.sh ! test/javax/script/ProviderTest.sh ! test/sun/misc/URLClassPath/ClassnameCharTest.sh Changeset: 07fdd926aaea Author: ohair Date: 2010-01-04 15:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/07fdd926aaea 6911129: These tests do not work with CYGWIN: java/lang Reviewed-by: tbell, alanb ! test/java/beans/Introspector/Test5102804.java ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh ! test/java/lang/StringCoding/CheckEncodings.sh ! test/java/lang/System/finalization/FinExit.sh ! test/java/lang/annotation/loaderLeak/LoaderLeak.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CommonSetup.sh Changeset: 1d6f315e42f1 Author: ohair Date: 2010-01-04 15:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/1d6f315e42f1 6911108: These tests do not work with CYGWIN: java/util Reviewed-by: tbell, alanb ! test/java/util/Currency/PropertiesTest.sh ! test/java/util/PluggableLocale/ExecTest.sh ! test/java/util/ResourceBundle/Bug6299235Test.sh ! test/java/util/ResourceBundle/Control/ExpirationTest.sh ! test/java/util/ServiceLoader/basic.sh Changeset: 6f2a5912f5be Author: ohair Date: 2010-01-04 15:56 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/6f2a5912f5be 6911104: Tests do not work with CYGWIN: tools, sun/tools, and com/sun/tools Reviewed-by: tbell, alanb ! test/com/sun/tools/attach/ApplicationSetup.sh ! test/com/sun/tools/attach/BasicTests.sh ! test/com/sun/tools/attach/CommonSetup.sh ! test/com/sun/tools/attach/PermissionTests.sh ! test/com/sun/tools/attach/ProviderTests.sh ! test/sun/jvmstat/testlibrary/utils.sh ! test/sun/tools/common/ApplicationSetup.sh ! test/sun/tools/common/CommonSetup.sh ! test/sun/tools/jps/jps-help.sh ! test/sun/tools/jstat/jstatHelp.sh ! test/sun/tools/jstat/jstatOptions1.sh ! test/sun/tools/jstatd/jstatdUsage1.sh ! test/sun/tools/native2ascii/Native2AsciiTests.sh ! test/tools/launcher/ChangeDataModel.sh ! test/tools/launcher/ClassPathWildCard.sh ! test/tools/launcher/DefaultLocaleTest.sh ! test/tools/launcher/UnicodeTest.sh Changeset: b7cf91e43c67 Author: ohair Date: 2010-01-05 13:44 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b7cf91e43c67 Merge Changeset: d30f2e22fffd Author: mchung Date: 2010-01-07 08:14 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d30f2e22fffd 6911737: Module build: generate modules with native libraries and any other files not in jar Summary: create modules under OUTPUTDIR/modules directory containing resources, native libraries Reviewed-by: alanb, ohair ! make/com/sun/crypto/provider/Makefile ! make/com/sun/java/pack/Makefile ! make/com/sun/java/pack/prop/Makefile ! make/com/sun/jndi/cosnaming/Makefile ! make/com/sun/jndi/dns/Makefile ! make/com/sun/jndi/ldap/Makefile ! make/com/sun/jndi/rmi/registry/Makefile ! make/com/sun/nio/sctp/Makefile ! make/com/sun/org/apache/xml/Makefile ! make/com/sun/rowset/Makefile ! make/com/sun/script/Makefile ! make/com/sun/security/auth/module/Makefile ! make/com/sun/servicetag/Makefile ! make/com/sun/tools/attach/Makefile ! make/common/Defs.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Modules.gmk ! make/common/Program.gmk ! make/common/internal/BinaryPlugs.gmk ! make/common/internal/Resources.gmk ! make/common/shared/Sanity.gmk ! make/java/awt/Makefile ! make/java/fdlibm/Makefile ! make/java/hpi/native/Makefile ! make/java/hpi/windows/Makefile ! make/java/instrument/Makefile ! make/java/java/Makefile ! make/java/java_crw_demo/Makefile ! make/java/java_hprof_demo/Makefile ! make/java/jli/Makefile ! make/java/jvm/Makefile ! make/java/logging/Makefile ! make/java/main/java/Makefile ! make/java/main/javaw/Makefile ! make/java/management/Makefile ! make/java/net/Makefile ! make/java/nio/Makefile ! make/java/npt/Makefile - make/java/redist/FILES.gmk ! make/java/redist/Makefile + make/java/redist/fonts/Makefile + make/java/redist/sajdi/Makefile ! make/java/security/Makefile ! make/java/sql/Makefile ! make/java/text/Makefile ! make/java/verify/Makefile ! make/java/zip/Makefile ! make/javax/crypto/Makefile ! make/javax/imageio/Makefile ! make/javax/print/Makefile ! make/javax/sound/Makefile ! make/javax/sound/jsoundalsa/Makefile ! make/javax/sound/jsoundds/Makefile ! make/javax/sql/Makefile ! make/javax/swing/Makefile ! make/javax/swing/plaf/Makefile ! make/jpda/back/Makefile ! make/jpda/transport/Makefile ! make/jpda/transport/shmem/Makefile ! make/jpda/transport/socket/Makefile ! make/jpda/tty/Makefile ! make/launchers/Makefile ! make/mkdemo/jvmti/Makefile ! make/mkdemo/management/Makefile ! make/mksample/dtrace/Makefile ! make/mksample/jmx/jmx-scandir/Makefile ! make/mksample/nbproject/Makefile ! make/mksample/nio/file/Makefile ! make/mksample/nio/multicast/Makefile ! make/mksample/nio/server/Makefile ! make/mksample/scripting/scriptpad/Makefile ! make/mksample/webservices/EbayClient/Makefile ! make/mksample/webservices/EbayServer/Makefile ! make/modules/Makefile ! make/modules/modules.config ! make/modules/tools/nbproject/project.xml ! make/modules/tools/src/com/sun/classanalyzer/Module.java ! make/sun/applet/Makefile ! make/sun/awt/Makefile ! make/sun/cmm/Makefile ! make/sun/cmm/kcms/Makefile ! make/sun/cmm/lcms/Makefile ! make/sun/dcpr/Makefile ! make/sun/font/Makefile ! make/sun/font/t2k/Makefile ! make/sun/headless/Makefile ! make/sun/image/generic/Makefile ! make/sun/image/vis/Makefile ! make/sun/jar/Makefile ! make/sun/javazic/Makefile ! make/sun/jawt/Makefile ! make/sun/jconsole/Makefile ! make/sun/jdbc/Makefile ! make/sun/jdga/Makefile ! make/sun/jkernel/Makefile ! make/sun/jpeg/Makefile ! make/sun/launcher/Makefile ! make/sun/management/Makefile ! make/sun/native2ascii/Makefile ! make/sun/net/others/Makefile ! make/sun/net/spi/nameservice/dns/Makefile - make/sun/nio/FILES_java.gmk ! make/sun/nio/Makefile + make/sun/nio/cs/FILES_java.gmk + make/sun/nio/cs/Makefile ! make/sun/org/mozilla/javascript/Makefile ! make/sun/pisces/Makefile ! make/sun/rmi/cgi/Makefile ! make/sun/rmi/oldtools/Makefile ! make/sun/rmi/registry/Makefile ! make/sun/rmi/rmi/Makefile ! make/sun/rmi/rmic/Makefile ! make/sun/rmi/rmid/Makefile ! make/sun/security/ec/Makefile ! make/sun/security/jgss/wrapper/Makefile ! make/sun/security/krb5/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile ! make/sun/security/smartcardio/Makefile ! make/sun/security/tools/Makefile ! make/sun/serialver/Makefile ! make/sun/splashscreen/Makefile ! make/sun/text/Makefile ! make/sun/tools/Makefile ! make/sun/tracing/dtrace/Makefile ! make/sun/xawt/Makefile Changeset: d36fa10de3cb Author: darcy Date: 2010-01-07 19:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/d36fa10de3cb 6915171: Clarify checked/unchecked status of Throwable and its subclasses Reviewed-by: dholmes ! src/share/classes/java/lang/Error.java ! src/share/classes/java/lang/Exception.java ! src/share/classes/java/lang/RuntimeException.java ! src/share/classes/java/lang/Throwable.java Changeset: 755dd6bdccca Author: alanb Date: 2010-01-09 19:32 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/755dd6bdccca 6907760: (file) OVERFLOW event should cause pending events to be purged Reviewed-by: chegar ! src/share/classes/sun/nio/fs/AbstractWatchKey.java + test/java/nio/file/WatchService/OverflowEventIsLoner.java Changeset: 0f0aee89e282 Author: alanb Date: 2010-01-10 12:29 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/0f0aee89e282 6913877: (fs) AsynchronousFileChannel.write can return wrong result under load [win] Reviewed-by: chegar ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! src/windows/native/sun/nio/ch/WindowsAsynchronousFileChannelImpl.c + test/java/nio/channels/AsynchronousFileChannel/LotsOfWrites.java Changeset: fc5578368a0c Author: chegar Date: 2010-01-11 16:04 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/fc5578368a0c 6915313: Reorganize implementation to make it more feasible to port to JDK6 Summary: This makes the SCTP implementation easier to run with Suns JDK6. Reviewed-by: alanb ! make/com/sun/nio/sctp/FILES_java.gmk ! make/com/sun/nio/sctp/mapfile-vers ! src/solaris/classes/sun/nio/ch/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpNet.java ! src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpSocketDispatcher.java ! src/solaris/native/sun/nio/ch/SctpNet.c Changeset: 9d38ab65acff Author: darcy Date: 2010-01-11 15:35 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/9d38ab65acff 6828204: NavigableSet.subSet() documentation refers to nonexistent parameters Reviewed-by: martin ! src/share/classes/java/util/NavigableMap.java ! src/share/classes/java/util/NavigableSet.java Changeset: ba74184a952c Author: mchung Date: 2010-01-12 15:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/ba74184a952c 6915502: Legal notice repairs needed in jdk/make/modules/tools Summary: Fix the legal notice in jdk/make/modules/tools Reviewed-by: tbell ! make/modules/tools/build.xml ! make/modules/tools/nbproject/project.properties ! make/modules/tools/nbproject/project.xml Changeset: fa0cb25202d8 Author: darcy Date: 2010-01-14 20:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/fa0cb25202d8 6908218: java.lang.Deprecated should have explicit @Target meta-annotation. Reviewed-by: mernst ! src/share/classes/java/lang/Deprecated.java ! src/share/classes/java/lang/SuppressWarnings.java Changeset: 51d62db10c93 Author: mullan Date: 2010-01-15 09:48 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/51d62db10c93 6915939: Exception should be thrown if OCSP SingleResponses contain unresolved critical extensions Reviewed-by: xuelei ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java Changeset: 074f79397dda Author: mullan Date: 2010-01-15 09:58 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/074f79397dda Merge Changeset: b019cdae32dd Author: chegar Date: 2010-01-15 16:31 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/b019cdae32dd 6916922: (sctp) SO_RCVBUF & SO_SNDBUF returns twice the value set Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/SctpNet.c ! test/com/sun/nio/sctp/SctpChannel/SocketOptionTests.java Changeset: 64f7b789aecc Author: lana Date: 2010-01-15 15:36 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/64f7b789aecc Merge - src/share/classes/sun/dyn/util/BytecodeSignature.java Changeset: 680d7d312a30 Author: chegar Date: 2010-01-18 14:01 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/680d7d312a30 6916890: (sctp) SctpChannel.send may cause IAE if given a heap buffer with an offset Reviewed-by: alanb ! src/solaris/classes/sun/nio/ch/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java ! test/com/sun/nio/sctp/SctpChannel/Send.java ! test/com/sun/nio/sctp/SctpMultiChannel/Send.java Changeset: e0870a19b09e Author: chegar Date: 2010-01-18 14:56 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/e0870a19b09e 6917317: (sctp) Remove dependency on handleSocketError Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/SctpNet.c ! test/com/sun/nio/sctp/SctpChannel/Connect.java Changeset: 42894ae6671c Author: alanb Date: 2010-01-18 15:21 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/42894ae6671c 6917021: (file) copyTo/moveTo can overrwrite existing file when target associated with custom provider Reviewed-by: chegar ! src/share/classes/sun/nio/fs/AbstractPath.java ! test/java/nio/file/Path/CopyAndMove.java + test/java/nio/file/Path/PassThroughFileSystem.java ! test/java/nio/file/TestUtil.java Changeset: 7f2b99bd5123 Author: ptisnovs Date: 2010-01-18 17:53 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/7f2b99bd5123 6917663: test/java/security/Provider/Turkish.java not samevm friendly Summary: Added othervm flag to ensure that this test will run in isolation. Reviewed-by: alanb ! test/java/security/Provider/Turkish.java Changeset: 056d88d0f4d4 Author: mchung Date: 2010-01-18 15:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/056d88d0f4d4 6916217: make/modules/Makefile requires ALT_JDK_IMPORT_PATH Summary: build modules not depending on ALT_JDK_IMPORT_PATH being set Reviewed-by: alanb ! make/common/Defs.gmk ! make/common/Modules.gmk ! make/modules/Makefile ! make/modules/optional.depconfig ! make/modules/tools/Makefile Changeset: 8339fd49bf6b Author: weijun Date: 2010-01-19 11:43 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/8339fd49bf6b 6917791: KeyTabEntry, when the byte value smaller then 16, the string drop '0' Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/internal/ktab/KeyTabEntry.java + test/sun/security/krb5/ktab/KeyString.java Changeset: 10b993d417fc Author: lana Date: 2010-01-22 09:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/10b993d417fc Merge - make/java/redist/FILES.gmk - make/sun/nio/FILES_java.gmk - src/solaris/classes/sun/nio/ch/SctpSocketDispatcher.java Changeset: 31ed4132f345 Author: mikejwre Date: 2010-01-28 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/jdk/rev/31ed4132f345 Added tag jdk7-b81 for changeset 10b993d417fc ! .hgtags From john.coomes at sun.com Thu Jan 28 20:57:38 2010 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 29 Jan 2010 04:57:38 +0000 Subject: hg: jdk7/hotspot/langtools: 18 new changesets Message-ID: <20100129045831.47AC3412F8@hg.openjdk.java.net> Changeset: 0220a3ab1a40 Author: jjg Date: 2010-01-06 13:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/0220a3ab1a40 6307206: missing lint control for pkg-info Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/resources/compiler.properties Changeset: d4e0ae9b4ecb Author: jjg Date: 2010-01-06 13:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/d4e0ae9b4ecb 6855236: Compiler Tree API TreePath class generates NullPointerException from Iterator Reviewed-by: darcy + test/tools/javac/T6855236.java Changeset: c315df443ff2 Author: jjg Date: 2010-01-08 11:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/c315df443ff2 6878147: Keywords.log is declared and initialized but unused Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/parser/Keywords.java Changeset: 2d15bf467aea Author: jjg Date: 2010-01-08 11:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/2d15bf467aea 6878146: incorrect unused value should be deleted Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/util/LayoutCharacters.java Changeset: 0e75f9f6d1d4 Author: jjg Date: 2010-01-08 11:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/0e75f9f6d1d4 6665791: com.sun.source.tree.MethodTree.toString() does not output default values Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/tree/Pretty.java + test/tools/javac/T6665791.java Changeset: aa06467be3a2 Author: jjg Date: 2010-01-08 11:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/aa06467be3a2 6915078: ALT_JDK_IMPORT_PATH typo in langtools/make/Makefile Reviewed-by: tbell ! make/Makefile Changeset: 96c56220dcc2 Author: jjg Date: 2010-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/96c56220dcc2 6915152: langtools build failures with import.jdk on Windows Reviewed-by: ohair ! make/build.xml Changeset: d02e99d31cc0 Author: jjg Date: 2010-01-11 14:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/d02e99d31cc0 6326754: Compiler will fail to handle -Xmaxerrs with -ve numbers Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/T6326754.java + test/tools/javac/T6326754.out Changeset: f983c1dca202 Author: jjg Date: 2010-01-11 14:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/f983c1dca202 6764569: [PATCH] Fix unused imports in list resource bundles Reviewed-by: ksrini Contributed-by: jesse.glick at sun.com ! make/tools/CompileProperties/CompileProperties.java ! make/tools/CompileProperties/CompilePropertiesTask.java Changeset: ca6bc36b2305 Author: jjg Date: 2010-01-11 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/ca6bc36b2305 6915476: java.util.regex.PatternSyntaxException in com.sun.tools.javac.nio.PathFileObject Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/nio/PathFileObject.java ! test/tools/javac/nio/compileTest/CompileTest.java Changeset: 14a4c45ef734 Author: jjg Date: 2010-01-11 14:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/14a4c45ef734 6915497: test test/tools/javac/nio/compileTest/CompileTest.java fails under Hudson Reviewed-by: darcy ! test/tools/javac/nio/compileTest/CompileTest.java Changeset: 51011e02c02f Author: jjg Date: 2010-01-11 16:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/51011e02c02f 6909470: langtools stub generator should prune unnecessary imports Reviewed-by: darcy ! make/tools/GenStubs/GenStubs.java Changeset: ccd51af119b4 Author: jjg Date: 2010-01-13 17:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/ccd51af119b4 6472751: SourcePositions.getStartPos returns incorrect value for enum constants 6567414: javac compiler reports no source file or line on enum constant declaration error Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/T6472751.java + test/tools/javac/T6567414.java + test/tools/javac/T6567414.out Changeset: b96ad32c004a Author: jjg Date: 2010-01-14 17:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/b96ad32c004a 6917122: provide utility method to find the inner most type of a type tree Reviewed-by: darcy, jjg Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java Changeset: 2d0f4e7b44b2 Author: jjg Date: 2010-01-14 17:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/2d0f4e7b44b2 6916986: handle spaces in langtools launcher path Reviewed-by: darcy, jjg Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/bin/launcher.sh-template Changeset: a84062774f0e Author: lana Date: 2010-01-15 15:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/a84062774f0e Merge Changeset: cfabfcf9f110 Author: lana Date: 2010-01-22 09:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/cfabfcf9f110 Merge Changeset: 47003a3622f6 Author: mikejwre Date: 2010-01-28 11:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot/langtools/rev/47003a3622f6 Added tag jdk7-b81 for changeset cfabfcf9f110 ! .hgtags From imdupeng at gmail.com Fri Jan 29 15:49:39 2010 From: imdupeng at gmail.com (Peng Du) Date: Fri, 29 Jan 2010 17:49:39 -0600 Subject: C++ Interpreter on 64-bit Linux In-Reply-To: References: Message-ID: <1264808979.22676.9.camel@witty-114b.unl.edu> Hi, Same error with 32-bit Linux and Intel Core2. Does that mean the code of C++ Interpreter on Linux is currently broken? Anyone knows a solution to get the C++ Interpreter working on Linux? BTW, I am using openjdk-7-b80. Thanks On Thu, 2010-01-28 at 12:25 -0600, Peng Du wrote: > Hello, > > Is HotSpot w/ C++ Interpreter currently working on 64-bit Linux > (x86_64)? I tried building HotSpot > with CC_INTERP=true but encountered this error: > > /openjdk/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp: In member > function 'unsigned char* > InterpreterGenerator::generate_abstract_entry()': > /openjdk/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:282: error: > 'class InterpreterMacroAssembler' has no member named > 'empty_expression_stack' > /openjdk/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:284: error: > 'class InterpreterMacroAssembler' has no member named 'restore_locals' > make[6]: *** [interpreter_x86_64.o] Error 1 > make[6]: *** Waiting for unfinished jobs.... > /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static > member function 'static unsigned char* > MethodHandles::generate_method_handle_interpreter_entry(MacroAssembler*)': > /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:95: error: > 'throw_WrongMethodType_entry' is not a member of 'Interpreter' > /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static > member function 'static void > MethodHandles::generate_method_handle_stub(MacroAssembler*, > MethodHandles::EntryKind)': > /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:404: error: > 'throw_WrongMethodType_entry' is not a member of 'Interpreter' > make[6]: *** [methodHandles_x86.o] Error 1 > make[6]: Leaving directory > `/jdk-dist-64-cpp/hotspot/outputdir/linux_amd64_compiler2/product' > make[5]: *** [the_vm] Error 2 > make[5]: Leaving directory > `/jdk-dist-64-cpp/hotspot/outputdir/linux_amd64_compiler2/product' > make[4]: *** [product] Error 2 > make[4]: Leaving directory `/jdk-dist-64-cpp/hotspot/outputdir' > make[3]: *** [generic_build2] Error 2 > make[3]: Leaving directory `/openjdk/hotspot/make' > make[2]: *** [product] Error 2 > make[2]: Leaving directory `/openjdk/hotspot/make' > make[1]: *** [hotspot-build] Error 2 > make[1]: Leaving directory `/openjdk' > make: *** [build_product_image] Error 2 > > > Is there any patch to fix it? > > > Thanks > > > > > > > From nagy.mostafa at gmail.com Fri Jan 29 19:19:40 2010 From: nagy.mostafa at gmail.com (Nagy Mostafa) Date: Fri, 29 Jan 2010 19:19:40 -0800 Subject: C++ Interpreter on 64-bit Linux In-Reply-To: <1264808979.22676.9.camel@witty-114b.unl.edu> References: <1264808979.22676.9.camel@witty-114b.unl.edu> Message-ID: Hi Peng, I had the same problem with the CPP interpreter. The alternative is to use the Gary Benson's hotspot Zero port which is interpreter-only hotspot. The way I do it is as follows: ./configure --enable-zero make icedtea-against-ecj This will build the bootstrap VM only. Now you can edit the code in "openjdk-ecj" and rebuild like this: make hotspot To do a clean: rm -Rf openjdk-ecj/build/*/hotspot then do "make hotspot" again It has been a while since I tried all this, so things might have changed. I hope this works for you though. More under: http://markmail.org/search/?q=Nagy+Mostafa#query:Nagy%20Mostafa+page:1+mid:gqklt4gpv3izoqae+state:results Thanks, - nagy On Fri, Jan 29, 2010 at 3:49 PM, Peng Du wrote: > Hi, > > Same error with 32-bit Linux and Intel Core2. Does that mean the code of > C++ Interpreter on Linux is currently broken? Anyone knows a solution to > get the C++ Interpreter working on Linux? > > BTW, I am using openjdk-7-b80. > > Thanks > > > > On Thu, 2010-01-28 at 12:25 -0600, Peng Du wrote: > > Hello, > > > > Is HotSpot w/ C++ Interpreter currently working on 64-bit Linux > > (x86_64)? I tried building HotSpot > > with CC_INTERP=true but encountered this error: > > > > /openjdk/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp: In member > > function 'unsigned char* > > InterpreterGenerator::generate_abstract_entry()': > > /openjdk/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:282: error: > > 'class InterpreterMacroAssembler' has no member named > > 'empty_expression_stack' > > /openjdk/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:284: error: > > 'class InterpreterMacroAssembler' has no member named 'restore_locals' > > make[6]: *** [interpreter_x86_64.o] Error 1 > > make[6]: *** Waiting for unfinished jobs.... > > /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static > > member function 'static unsigned char* > > > MethodHandles::generate_method_handle_interpreter_entry(MacroAssembler*)': > > /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:95: error: > > 'throw_WrongMethodType_entry' is not a member of 'Interpreter' > > /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In static > > member function 'static void > > MethodHandles::generate_method_handle_stub(MacroAssembler*, > > MethodHandles::EntryKind)': > > /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:404: error: > > 'throw_WrongMethodType_entry' is not a member of 'Interpreter' > > make[6]: *** [methodHandles_x86.o] Error 1 > > make[6]: Leaving directory > > `/jdk-dist-64-cpp/hotspot/outputdir/linux_amd64_compiler2/product' > > make[5]: *** [the_vm] Error 2 > > make[5]: Leaving directory > > `/jdk-dist-64-cpp/hotspot/outputdir/linux_amd64_compiler2/product' > > make[4]: *** [product] Error 2 > > make[4]: Leaving directory `/jdk-dist-64-cpp/hotspot/outputdir' > > make[3]: *** [generic_build2] Error 2 > > make[3]: Leaving directory `/openjdk/hotspot/make' > > make[2]: *** [product] Error 2 > > make[2]: Leaving directory `/openjdk/hotspot/make' > > make[1]: *** [hotspot-build] Error 2 > > make[1]: Leaving directory `/openjdk' > > make: *** [build_product_image] Error 2 > > > > > > Is there any patch to fix it? > > > > > > Thanks > > > > > > > > > > > > > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20100129/a5a61116/attachment.html From imdupeng at gmail.com Fri Jan 29 21:08:06 2010 From: imdupeng at gmail.com (Peng Du) Date: Fri, 29 Jan 2010 23:08:06 -0600 Subject: C++ Interpreter on 64-bit Linux In-Reply-To: References: <1264808979.22676.9.camel@witty-114b.unl.edu> Message-ID: <1264828086.2777.4.camel@ubuntu61> Thanks, Nagy I will give the Zero port a spin. I have read Gary's blog some while ago but have never tried zero before. Was curious about the status of the interpreters in Hotspot. Anyway, thank you for the nice walk-through. It helps a lot. Peng On Fri, 2010-01-29 at 19:19 -0800, Nagy Mostafa wrote: > Hi Peng, > I had the same problem with the CPP interpreter. The alternative is to > use the Gary Benson's hotspot Zero port which is interpreter-only > hotspot. > > > The way I do it is as follows: > > > ./configure --enable-zero make icedtea-against-ecj > > > This will build the bootstrap VM only. Now you can edit the code in > "openjdk-ecj" and rebuild like this: > > > make hotspot > > > To do a clean: > > rm -Rf openjdk-ecj/build/*/hotspot > > > then do "make hotspot" again > > > It has been a while since I tried all this, so things might have > changed. I hope this works for you though. More under: > > http://markmail.org/search/?q=Nagy+Mostafa#query:Nagy%20Mostafa+page:1 > +mid:gqklt4gpv3izoqae+state:results > > > Thanks, > > - nagy > > > > > > On Fri, Jan 29, 2010 at 3:49 PM, Peng Du wrote: > Hi, > > Same error with 32-bit Linux and Intel Core2. Does that mean > the code of > C++ Interpreter on Linux is currently broken? Anyone knows a > solution to > get the C++ Interpreter working on Linux? > > BTW, I am using openjdk-7-b80. > > Thanks > > > > > On Thu, 2010-01-28 at 12:25 -0600, Peng Du wrote: > > Hello, > > > > Is HotSpot w/ C++ Interpreter currently working on 64-bit > Linux > > (x86_64)? I tried building HotSpot > > with CC_INTERP=true but encountered this error: > > > > /openjdk/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp: In > member > > function 'unsigned char* > > InterpreterGenerator::generate_abstract_entry()': > > /openjdk/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:282: > error: > > 'class InterpreterMacroAssembler' has no member named > > 'empty_expression_stack' > > /openjdk/hotspot/src/cpu/x86/vm/interpreter_x86_64.cpp:284: > error: > > 'class InterpreterMacroAssembler' has no member named > 'restore_locals' > > make[6]: *** [interpreter_x86_64.o] Error 1 > > make[6]: *** Waiting for unfinished jobs.... > > /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In > static > > member function 'static unsigned char* > > > MethodHandles::generate_method_handle_interpreter_entry(MacroAssembler*)': > > /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:95: > error: > > 'throw_WrongMethodType_entry' is not a member of > 'Interpreter' > > /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp: In > static > > member function 'static void > > MethodHandles::generate_method_handle_stub(MacroAssembler*, > > MethodHandles::EntryKind)': > > /openjdk/hotspot/src/cpu/x86/vm/methodHandles_x86.cpp:404: > error: > > 'throw_WrongMethodType_entry' is not a member of > 'Interpreter' > > make[6]: *** [methodHandles_x86.o] Error 1 > > make[6]: Leaving directory > > > `/jdk-dist-64-cpp/hotspot/outputdir/linux_amd64_compiler2/product' > > make[5]: *** [the_vm] Error 2 > > make[5]: Leaving directory > > > `/jdk-dist-64-cpp/hotspot/outputdir/linux_amd64_compiler2/product' > > make[4]: *** [product] Error 2 > > make[4]: Leaving directory > `/jdk-dist-64-cpp/hotspot/outputdir' > > make[3]: *** [generic_build2] Error 2 > > make[3]: Leaving directory `/openjdk/hotspot/make' > > make[2]: *** [product] Error 2 > > make[2]: Leaving directory `/openjdk/hotspot/make' > > make[1]: *** [hotspot-build] Error 2 > > make[1]: Leaving directory `/openjdk' > > make: *** [build_product_image] Error 2 > > > > > > Is there any patch to fix it? > > > > > > Thanks > > > > > > > > > > > > > > > > > > >