review (M) for 6914300: ciEnv should export all well known classes

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Wed Jan 6 13:49:03 PST 2010


Looks good.

Vladimir

Tom Rodriguez wrote:
> On Jan 6, 2010, at 11:22 AM, Vladimir Kozlov wrote:
> 
>> Tom,
>>
>> In ciEnv.cpp and ciEnv.hpp names will contain sufix _klass now.
>> You replaced ci accessors for ArrayStoreException, ClassCastException,
>> OutOfMemoryError with macro generated accessors but names of fields
>> left unchanged (without _klass).
> 
> Actually those fields should have been deleted since they are covered by the macro.
> 
>> And adjust spacing in vmStructs.cpp.
> 
> Fixed.
> 
> tom
> 
>> Vladimir
>>
>> Tom Rodriguez wrote:
>>> http://cr.openjdk.java.net/~never/6914300
> 


More information about the hotspot-dev mailing list